@foray1010/eslint-config 12.4.0 → 13.0.1

package/CHANGELOG.md

@@ -3,6 +3,28 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.0.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@13.0.0...@foray1010/eslint-config@13.0.1) (2024-08-27)
+
+### Bug Fixes
+
+- **eslint-config:** fix errors when uses with eslint v9 ([9e2bc51](https://github.com/foray1010/common-presets/commit/9e2bc512f84b91963955e0558b7346bb27ba1365))
+
+## [13.0.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@12.4.0...@foray1010/eslint-config@13.0.0) (2024-08-27)
+
+### ⚠ BREAKING CHANGES
+
+- **eslint-config:** require node `^18.18.0 || >=20.9.0`
+
+### Features
+
+- **eslint-config:** require eslint v9 ([198866f](https://github.com/foray1010/common-presets/commit/198866f67ec6f9d534d71878c4a72e8af517d1f0))
+
+### Bug Fixes
+
+- **deps:** update dependency eslint-plugin-functional to v7 ([3762aa6](https://github.com/foray1010/common-presets/commit/3762aa6819c8efe24b6426b75d385c1991b0e8c4))
+- **deps:** update dependency eslint-plugin-import-x to v4 ([8e5d140](https://github.com/foray1010/common-presets/commit/8e5d140f6e7b8541f17d25a6f47ea75070ffbdd5))
+- **eslint-config:** replace eslint-plugin-deprecation by typescript-eslint ([7b1e637](https://github.com/foray1010/common-presets/commit/7b1e637d55f54f5996451025112257327a6905cf))
+
 ## [12.4.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@12.3.1...@foray1010/eslint-config@12.4.0) (2024-08-20)
 
 ### Features

package/bases/base.mjs

@@ -23,8 +23,7 @@ async function generateTypeScriptConfig() {
 
   // eslint-disable-next-line import-x/no-unresolved
   const tseslint = (await import('typescript-eslint')).default
-  const eslintPluginDeprecation = (await import('eslint-plugin-deprecation'))
-    .default
+  // eslint-disable-next-line import-x/no-unresolved
   const eslintPluginFunctional = (await import('eslint-plugin-functional'))
     .default
 
@@ -52,7 +51,6 @@ async function generateTypeScriptConfig() {
         },
       },
       plugins: {
-        deprecation: eslintPluginDeprecation,
         functional: eslintPluginFunctional,
       },
       rules: {
@@ -91,6 +89,8 @@ async function generateTypeScriptConfig() {
         ],
         // sometimes auto detect can provide a better and narrower type
         '@typescript-eslint/explicit-module-boundary-types': 'off',
+        // do not allow usage of deprecated code
+        '@typescript-eslint/no-deprecated': 'error',
         // disallow duplicated value in enum as it is error-prone
         '@typescript-eslint/no-duplicate-enum-values': 'error',
         // need empty function for react context default value
@@ -150,8 +150,6 @@ async function generateTypeScriptConfig() {
         '@typescript-eslint/switch-exhaustiveness-check': 'error',
         // ignore static function as those are not supposed to use `this`
         '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }],
-        // do not allow usage of deprecated code
-        'deprecation/deprecation': 'error',
         // use with functional/type-declaration-immutability
         'functional/prefer-immutable-types': [
           'error',
@@ -256,48 +254,13 @@ const baseConfig = [
   js.configs.recommended,
   eslintPluginRegexp.configs['flat/recommended'],
   {
-    languageOptions: {
-      ecmaVersion: 2023,
-      globals: {
-        ...globals.es2023,
-        /* Not using `node` to explicitly import node.js only built-in modules, e.g.
-         * import { Buffer } from 'node:buffer'
-         * import process from 'node:process'
-         */
-        ...globals['shared-node-browser'],
-      },
-    },
-    plugins: {
-      '@eslint-community/eslint-comments': eslintPluginEslintComments,
-      // @ts-expect-error Type is not compact with flat config
-      'import-x': eslintPluginImportX,
-      unicorn: eslintPluginUnicorn,
-    },
+    ...eslintPluginImportX.flatConfigs.recommended,
     rules: {
-      ...eslintPluginEslintComments.configs['recommended']?.rules,
-      ...eslintPluginImportX.configs['recommended']?.rules,
-      ...Object.fromEntries(
-        Object.entries(
-          eslintPluginUnicorn.configs['flat/recommended']?.rules ?? {},
-        ).filter(([ruleName]) => {
-          // only use a subset of recommended rules as other rules are too strict
-          return (
-            ruleName.startsWith('unicorn/no-useless-') ||
-            ruleName.startsWith('unicorn/prefer-')
-          )
-        }),
-      ),
-      // allow disable eslint rules for whole file without re-enable it in the end of the file
-      '@eslint-community/eslint-comments/disable-enable-pair': [
-        'error',
-        { allowWholeFile: true },
-      ],
-      // make sure every eslint-disable comments are in use
-      '@eslint-community/eslint-comments/no-unused-disable': 'error',
-      // always use named function for easier to debug via stack trace
-      'func-names': ['error', 'as-needed'],
+      ...eslintPluginImportX.flatConfigs.recommended.rules,
       // this rule doesn't support commonjs, some dependencies are using commonjs
       'import-x/default': 'off',
+      // Does not work after upgrading to eslint-plugin-import-x v4, got this error message: `sourceType 'module' is not supported when ecmaVersion < 2015. Consider adding `{ ecmaVersion: 2015 }` to the parser options. (undefined:undefined)`
+      'import-x/export': 'off',
       // enforce extensions for both cjs and esm
       'import-x/extensions': [
         'error',
@@ -365,6 +328,46 @@ const baseConfig = [
       'import-x/namespace': 'off',
       'import-x/no-named-as-default': 'off',
       'import-x/no-named-as-default-member': 'off',
+    },
+  },
+  {
+    languageOptions: {
+      ecmaVersion: 2023,
+      globals: {
+        ...globals.es2023,
+        /* Not using `node` to explicitly import node.js only built-in modules, e.g.
+         * import { Buffer } from 'node:buffer'
+         * import process from 'node:process'
+         */
+        ...globals['shared-node-browser'],
+      },
+    },
+    plugins: {
+      '@eslint-community/eslint-comments': eslintPluginEslintComments,
+      unicorn: eslintPluginUnicorn,
+    },
+    rules: {
+      ...eslintPluginEslintComments.configs['recommended']?.rules,
+      ...Object.fromEntries(
+        Object.entries(
+          eslintPluginUnicorn.configs['flat/recommended']?.rules ?? {},
+        ).filter(([ruleName]) => {
+          // only use a subset of recommended rules as other rules are too strict
+          return (
+            ruleName.startsWith('unicorn/no-useless-') ||
+            ruleName.startsWith('unicorn/prefer-')
+          )
+        }),
+      ),
+      // allow disable eslint rules for whole file without re-enable it in the end of the file
+      '@eslint-community/eslint-comments/disable-enable-pair': [
+        'error',
+        { allowWholeFile: true },
+      ],
+      // make sure every eslint-disable comments are in use
+      '@eslint-community/eslint-comments/no-unused-disable': 'error',
+      // always use named function for easier to debug via stack trace
+      'func-names': ['error', 'as-needed'],
       // prefer explicitly convert type for readability
       'no-implicit-coercion': 'error',
       // make sure private class members are in-use

package/bases/browser.mjs

@@ -1,7 +1,7 @@
+import { fixupPluginRules } from '@eslint/compat'
 import { hasDep } from '@foray1010/common-presets-utils'
 import restrictedGlobals from 'confusing-browser-globals'
 import eslintPluginCompat from 'eslint-plugin-compat'
-import eslintPluginImportX from 'eslint-plugin-import-x'
 import eslintPluginTestingLibrary from 'eslint-plugin-testing-library'
 import globals from 'globals'
 
@@ -37,8 +37,6 @@ const browserConfig = [
     },
     plugins: {
       compat: eslintPluginCompat,
-      // @ts-expect-error Type is not compact with flat config
-      'import-x': eslintPluginImportX,
     },
     rules: {
       'compat/compat': 'error',
@@ -50,7 +48,12 @@ const browserConfig = [
   ...(await generateJestDomConfig()),
   {
     files: testFileGlobs,
-    ...eslintPluginTestingLibrary.configs['flat/dom'],
+    plugins: {
+      'testing-library': fixupPluginRules(eslintPluginTestingLibrary),
+    },
+    rules: {
+      ...eslintPluginTestingLibrary.configs['flat/dom']?.rules,
+    },
   },
   {
     files: testFileGlobs,

package/bases/react.mjs

@@ -61,7 +61,10 @@ const reactConfig = [
   },
   {
     files: testFileGlobs,
-    ...eslintPluginTestingLibrary.configs['flat/react'],
+    rules: {
+      // Do not use flat config directly as eslint v9 does not support duplicated plugins (already defined in browser.mjs)
+      ...eslintPluginTestingLibrary.configs['flat/react']?.rules,
+    },
   },
   {
     files: testFileGlobs,

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "12.4.0",
+  "version": "13.0.1",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -20,37 +20,37 @@
     "type:check": "tsc"
   },
   "dependencies": {
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.1.0",
-    "@eslint/js": "^8.53.0",
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.4.0",
+    "@eslint/compat": "^1.1.1",
+    "@eslint/js": "^9.9.1",
     "@foray1010/common-presets-utils": "^8.0.0",
     "confusing-browser-globals": "^1.0.11",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
+    "eslint-import-resolver-typescript": "^3.6.3",
     "eslint-plugin-compat": "^6.0.0",
-    "eslint-plugin-deprecation": "^3.0.0",
-    "eslint-plugin-functional": "^6.0.0",
-    "eslint-plugin-import-x": "^3.0.1",
-    "eslint-plugin-jest": "^28.6.0",
+    "eslint-plugin-functional": "^7.0.2",
+    "eslint-plugin-import-x": "^4.1.0",
+    "eslint-plugin-jest": "^28.8.0",
     "eslint-plugin-jest-dom": "^5.4.0",
-    "eslint-plugin-n": "^17.0.0",
+    "eslint-plugin-n": "^17.10.2",
     "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-react": "^7.35.0",
-    "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-react-hooks": "^4.6.2",
     "eslint-plugin-regexp": "^2.6.0",
-    "eslint-plugin-simple-import-sort": "^12.0.0",
+    "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-testing-library": "^6.3.0",
     "eslint-plugin-unicorn": "^55.0.0",
-    "globals": "^15.4.0",
-    "typescript-eslint": "^8.0.0"
+    "globals": "^15.9.0",
+    "typescript-eslint": "^8.3.0"
   },
   "devDependencies": {
     "@types/confusing-browser-globals": "1.0.3",
-    "@types/eslint": "8.56.11",
+    "@types/eslint": "9.6.1",
     "@types/eslint__js": "8.42.3"
   },
   "peerDependencies": {
     "@testing-library/dom": "^10.0.0",
-    "eslint": "^8.52.0",
+    "eslint": "^9.0.0",
     "prettier": "^3.0.0",
     "typescript": "^5.0.2"
   },
@@ -63,10 +63,10 @@
     }
   },
   "engines": {
-    "node": "^18.12.0 || >=20.9.0"
+    "node": "^18.18.0 || >=20.9.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "fae1085ef22d08177b22034905e40dd23a80b95a"
+  "gitHead": "96a15140fa887ba923ba9706b55e1cf1c3af48d9"
 }