@foray1010/eslint-config 10.2.1 → 10.4.0

package/CHANGELOG.md

@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [10.4.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@10.3.0...@foray1010/eslint-config@10.4.0) (2023-03-30)
+
+### Features
+
+- **eslint-config:** enable recommended `no-useless-` rules from unicorn plugin ([671581b](https://github.com/foray1010/common-presets/commit/671581b466aa788f2f9e82e6bbf8e324ba57b415))
+
+### Bug Fixes
+
+- **eslint-config:** disable unicorn/prefer-spread ([004f937](https://github.com/foray1010/common-presets/commit/004f9377777a58ebc7ddfd579075b713fa3a468e))
+
+## [10.3.0](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@10.2.1...@foray1010/eslint-config@10.3.0) (2023-03-30)
+
+### Features
+
+- **eslint-config:** enable more `prefer-` rules from unicorn plugin ([2c0b411](https://github.com/foray1010/common-presets/commit/2c0b411a1ab5585db01f321e000239cf13758a94))
+
 ## [10.2.1](https://github.com/foray1010/common-presets/compare/@foray1010/eslint-config@10.2.0...@foray1010/eslint-config@10.2.1) (2023-03-29)
 
 ### Bug Fixes

package/bases/base.mjs

@@ -280,6 +280,17 @@ const baseConfig = [
     rules: {
       ...eslintPluginEslintComments.configs['recommended']?.rules,
       ...eslintPluginImport.configs['recommended']?.rules,
+      ...Object.fromEntries(
+        Object.entries(
+          eslintPluginUnicorn.configs['recommended']?.rules ?? {},
+        ).filter(([ruleName]) => {
+          // only use a subset of recommended rules as other rules are too strict
+          return (
+            ruleName.startsWith('unicorn/no-useless-') ||
+            ruleName.startsWith('unicorn/prefer-')
+          )
+        }),
+      ),
       // allow disable eslint rules for whole file without re-enable it in the end of the file
       '@eslint-community/eslint-comments/disable-enable-pair': [
         'error',
@@ -374,10 +385,16 @@ const baseConfig = [
       // use with `unicorn/throw-new-error`
       // disallow builtins to be created without `new` operator, to be consistent with es6 class syntax
       'unicorn/new-for-builtins': 'error',
-      // prefer `import from 'node:xxx'`
-      'unicorn/prefer-node-protocol': 'error',
-      // prefer Number static properties over global ones
-      'unicorn/prefer-number-properties': 'error',
+      // `at()` is simpler to use in array and string
+      'unicorn/prefer-at': 'error',
+      // EventTarget works on both node.js and browsers, but EventEmitter only works on node.js
+      'unicorn/prefer-event-target': 'error',
+      // some legacy projects still use commonjs
+      'unicorn/prefer-module': 'off',
+      // `Array.from(iterable)` is more readable than `[...iterable]`
+      'unicorn/prefer-spread': 'off',
+      // it is cleaner than `.replace(//g)`
+      'unicorn/prefer-string-replace-all': 'error',
       // use with `unicorn/new-for-builtins`
       'unicorn/throw-new-error': 'error',
     },

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package",
   "name": "@foray1010/eslint-config",
-  "version": "10.2.1",
+  "version": "10.4.0",
   "homepage": "https://github.com/foray1010/common-presets/tree/master/packages/eslint-config#readme",
   "bugs": "https://github.com/foray1010/common-presets/issues",
   "repository": {
@@ -64,5 +64,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "60e70bc680f7b1b43f4f45e4a7760306d1edc5ca"
+  "gitHead": "77efc0ef501281193755a7a4ff7991ae15c9fd6f"
 }