@fonoster/voice 0.22.4 → 0.22.10

package/dist/createSession.js

@@ -40,7 +40,20 @@ function createSession(handler) {
             if (request) {
                 mediaSessionRef = request.mediaSessionRef;
                 const response = new VoiceResponse_1.VoiceResponse(request, voice);
-                yield handler(request, response);
+                // EventEmitter ignores the promise this callback returns, so an error
+                // escaping the handler becomes an unhandled rejection and, under Node's
+                // default policy, takes the whole voice server down with it. Verbs now
+                // reject when the session ends mid-call, which makes reaching here an
+                // ordinary occurrence rather than a defect in the application.
+                try {
+                    yield handler(request, response);
+                }
+                catch (e) {
+                    logger.warn("voice handler did not complete", {
+                        mediaSessionRef,
+                        error: e instanceof Error ? e.message : e
+                    });
+                }
                 resolve();
             }
         }));

package/dist/verbs/Verb.js

@@ -46,26 +46,54 @@ class Verb {
                 mediaSessionRef
             });
             return new Promise((resolve, reject) => {
+                // Every exit path must remove all three listeners. A verb shares the session
+                // stream with every other verb in the call, so anything left attached
+                // accumulates for the lifetime of the session.
+                const cleanup = () => {
+                    voice.removeListener(common_1.StreamEvent.DATA, dataListener);
+                    voice.removeListener(common_1.StreamEvent.END, endListener);
+                    voice.removeListener(common_1.StreamEvent.ERROR, errorListener);
+                };
+                const dataListener = (result) => {
+                    const expectedContent = (0, getExpectedContent_1.getExpectedContent)(this.constructor.name);
+                    if (expectedContent !== result.content) {
+                        return;
+                    }
+                    logger.verbose(`received ${this.constructor.name} response`, {
+                        mediaSessionRef
+                    });
+                    cleanup();
+                    resolve(result);
+                };
+                // Without these the promise has exactly one exit: a matching response. When the
+                // session dies first — the caller hangs up mid-verb, or the transport fails —
+                // it is left pending forever, neither resolved nor rejected. The application
+                // then awaits a verb that can never complete and the call is stranded rather
+                // than failed.
+                const endListener = () => {
+                    cleanup();
+                    reject(new Error(`voice session ended before the ${this.constructor.name} verb completed`));
+                };
+                const errorListener = (error) => {
+                    cleanup();
+                    reject(error instanceof Error
+                        ? error
+                        : new Error(`voice session failed during the ${this.constructor.name} verb: ${error}`));
+                };
                 try {
                     const fullRequest = Object.assign(Object.assign({}, params), { mediaSessionRef });
                     (0, validateRequest_1.validateRequest)(this.getValidationSchema(), fullRequest);
+                    // Listen before writing: a response cannot be delivered to a listener that
+                    // does not exist yet.
+                    voice.on(common_1.StreamEvent.DATA, dataListener);
+                    voice.on(common_1.StreamEvent.END, endListener);
+                    voice.on(common_1.StreamEvent.ERROR, errorListener);
                     voice.write({
                         [`${(0, common_1.toCamelCase)(this.constructor.name)}Request`]: fullRequest
                     });
-                    const dataListener = (result) => {
-                        const expectedContent = (0, getExpectedContent_1.getExpectedContent)(this.constructor.name);
-                        if (expectedContent !== result.content) {
-                            return;
-                        }
-                        logger.verbose(`received ${this.constructor.name} response`, {
-                            mediaSessionRef
-                        });
-                        resolve(result);
-                        voice.removeListener(common_1.StreamEvent.DATA, dataListener);
-                    };
-                    voice.on(common_1.StreamEvent.DATA, dataListener);
                 }
                 catch (e) {
+                    cleanup();
                     reject(e);
                 }
             });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fonoster/voice",
-  "version": "0.22.4",
+  "version": "0.22.10",
   "description": "Voice Server for Fonoster",
   "author": "Pedro Sanders <psanders@fonoster.com>",
   "homepage": "https://github.com/fonoster/fonoster#readme",
@@ -23,7 +23,7 @@
   },
   "dependencies": {
     "@fonoster/common": "^0.22.3",
-    "@fonoster/identity": "^0.22.4",
+    "@fonoster/identity": "^0.22.7",
     "@fonoster/logger": "^0.22.0",
     "@grpc/grpc-js": "~1.10.6",
     "deepmerge": "^4.3.1",
@@ -45,5 +45,5 @@
   "bugs": {
     "url": "https://github.com/fonoster/fonoster/issues"
   },
-  "gitHead": "1af8d903b578b1e85180bf811f645dd0ff00bf20"
+  "gitHead": "a222992b88756fcfe60c2e05bf2bc9a19f65f19d"
 }