@fonderie/customers 6.1.3 → 6.1.5

package/dist/index.d.cts

@@ -196,7 +196,8 @@ declare class CustomerAddressModel {
     }): Promise<ICustomerAddress>;
     updateLabel(addrId: string, customerId: string, labelId: string): Promise<ICustomerAddress>;
     setPrimary(addrId: string, customerId: string): Promise<void>;
-    remove(addrId: string, customerId: string): Promise<void>;
+    /** Returns false when the address is not linked to THIS customer (no-op). */
+    remove(addrId: string, customerId: string): Promise<boolean>;
 }
 
 declare class CustomerEmailModel {

package/dist/index.d.ts

@@ -196,7 +196,8 @@ declare class CustomerAddressModel {
     }): Promise<ICustomerAddress>;
     updateLabel(addrId: string, customerId: string, labelId: string): Promise<ICustomerAddress>;
     setPrimary(addrId: string, customerId: string): Promise<void>;
-    remove(addrId: string, customerId: string): Promise<void>;
+    /** Returns false when the address is not linked to THIS customer (no-op). */
+    remove(addrId: string, customerId: string): Promise<boolean>;
 }
 
 declare class CustomerEmailModel {

package/dist/index.js

@@ -908,16 +908,18 @@ var CustomerAddressModel = class {
       );
     });
   }
+  /** Returns false when the address is not linked to THIS customer (no-op). */
   async remove(addrId, customerId) {
-    await this.store.transaction(async (tx) => {
+    return this.store.transaction(async (tx) => {
       const [deleted] = await tx.query(
         `DELETE FROM fonderie_customer_addresses
 				 WHERE addr_id = $1 AND customer_id = $2
 				 RETURNING is_primary AS "isPrimary"`,
         [addrId, customerId]
       );
+      if (!deleted) return false;
       await tx.query(`DELETE FROM fonderie_addresses WHERE id = $1`, [addrId]);
-      if (deleted?.isPrimary) {
+      if (deleted.isPrimary) {
         await tx.query(
           `UPDATE fonderie_customer_addresses
 					 SET is_primary = true
@@ -930,6 +932,7 @@ var CustomerAddressModel = class {
           [customerId]
         );
       }
+      return true;
     });
   }
 };
@@ -1039,11 +1042,23 @@ var CustomerLabelModel = class {
       [type]
     );
   }
-  remove(id) {
-    return this.store.query(
-      `DELETE FROM fonderie_customer_labels WHERE id = $1`,
+  /**
+   * Returns false when the label is still referenced. Labels are a SHARED
+   * table (no workspace column), so an unconditional delete would let one
+   * tenant destroy a label other tenants' emails/phones/addresses point at.
+   * Until labels are workspace-scoped, only an unreferenced label may go.
+   */
+  async remove(id) {
+    const rows = await this.store.query(
+      `DELETE FROM fonderie_customer_labels l
+			 WHERE l.id = $1
+			   AND NOT EXISTS (SELECT 1 FROM fonderie_customer_emails    WHERE label_id = l.id)
+			   AND NOT EXISTS (SELECT 1 FROM fonderie_customer_phones    WHERE label_id = l.id)
+			   AND NOT EXISTS (SELECT 1 FROM fonderie_customer_addresses WHERE label_id = l.id)
+			 RETURNING l.id`,
       [id]
-    ).then(() => void 0);
+    );
+    return rows.length > 0;
   }
   async findOrCreate(type, raw) {
     const value = raw.trim().toLowerCase();
@@ -1733,7 +1748,10 @@ function customerAddressController(store) {
       if (!isUuid(addrId)) {
         return setApiResponse2(HTTP2.UNPROCESSABLE, "INVALID_PARAMETER", "addrId must be a valid UUID");
       }
-      await addresses.remove(addrId, r.customer.id);
+      const removed = await addresses.remove(addrId, r.customer.id);
+      if (!removed) {
+        return setApiResponse2(HTTP2.NOT_FOUND, "NOT_FOUND", "Address not found");
+      }
       return setApiResponse2(HTTP2.OK, "ADDRESS_REMOVED", "Address removed successfully.");
     }
   };
@@ -2153,7 +2171,14 @@ function customerLabelController(store) {
       if (!isUuid(labelId)) {
         return setApiResponse7(HTTP7.UNPROCESSABLE, "INVALID_PARAMETER", "labelId must be a valid UUID");
       }
-      await labels.remove(labelId);
+      const removed = await labels.remove(labelId);
+      if (!removed) {
+        return setApiResponse7(
+          HTTP7.CONFLICT,
+          "LABEL_IN_USE",
+          "Label is still referenced by customer records and cannot be deleted."
+        );
+      }
       return setApiResponse7(HTTP7.OK, "LABEL_DELETED", "Label deleted successfully.");
     }
   };