@foldspace_npm/harness 0.1.33 → 0.1.34

package/src/lint/index.mjs

@@ -1,7 +1,14 @@
 import fs from "node:fs";
 import path from "node:path";
 import { listSourceFiles, parseFile, shouldSkipActionFile } from "./ast.mjs";
-import { lintActionFile, lintViewsFile, ruleNoTestModeInBundle, ruleRegistryIntegrity } from "./rules.mjs";
+import {
+  lintActionFile,
+  lintViewsFile,
+  ruleNoTestModeInBundle,
+  ruleRegistryIntegrity,
+  ruleStartersLimit,
+} from "./rules.mjs";
+import { lintSafetyFile, readProjectFacts, ruleNoSecrets } from "./safety.mjs";
 
 export { bundleTurnsOnTestMode } from "./rules.mjs";
 
@@ -47,12 +54,25 @@ export function lintProject(projectDir) {
   }
 
   // Any file under agent/ can end up in the bundle, including code that runs
-  // as soon as the bundle loads, so this rule reads all of it - not only
+  // as soon as the bundle loads, so these rules read all of it - not only
   // actions and views.
   for (const filePath of listSourceFiles(path.join(projectDir, "agent"))) {
-    ruleNoTestModeInBundle(parseFile(filePath), path.relative(projectDir, filePath), findings);
+    const sourceFile = parseFile(filePath);
+    const relative = path.relative(projectDir, filePath);
+    ruleNoTestModeInBundle(sourceFile, relative, findings);
+    ruleStartersLimit(sourceFile, relative, findings);
   }
 
+  // Safety: every file under agent/ the project owns - not agent/runtime/,
+  // which is the harness's own copy - and, for secrets, the whole project.
+  const facts = readProjectFacts(projectDir);
+  for (const filePath of listSourceFiles(path.join(projectDir, "agent"))) {
+    const relative = path.relative(projectDir, filePath);
+    if (relative.split(path.sep)[1] === "runtime") continue;
+    lintSafetyFile(filePath, relative, findings, facts);
+  }
+  ruleNoSecrets(projectDir, findings);
+
   ruleRegistryIntegrity({
     indexFile: entry,
     indexSource: parseFile(entry),

package/src/lint/rules.mjs

@@ -22,9 +22,11 @@ import {
 import { ts } from "./ts.mjs";
 
 /*
+  Safety rules (one customer's address, the user's token, secrets, known
+  hosts) live in ./safety.mjs.
+
   Backlog, not this slice:
-  - no-hardcoded-secrets
-  - no-unsafe-return (stack / cookies / Authorization / ApiResult.detail)
+  - no-unsafe-return (stack / ApiResult.detail)
   - snake_case action keys
   - credentials: "include" on every fetch
   - _gen2 vs _v2 taskKey
@@ -804,6 +806,48 @@ export function ruleNoTestModeInBundle(sourceFile, relative, findings) {
   walk(sourceFile, undefined);
 }
 
+// The most starters one page (or the agent-wide default) shows, both groups
+// together. `setConversationStarters` also sets the panel's opening screen,
+// and a long list there buries the one that matters (a customer default had 7).
+export const MAX_STARTERS = 3;
+
+// Any object with a KNOWLEDGE or ACTION list - a setConversationStarters
+// call, a page's entry in the bottom bar's list, conversationStartersSettings
+// - is counted. Only lists written out in the file are counted: a list built
+// at run time (`.map`, a spread) is left alone.
+export function ruleStartersLimit(sourceFile, relative, findings) {
+  const bindings = collectModuleBindings(sourceFile);
+  const visit = (node) => {
+    if (ts.isObjectLiteralExpression(node)) {
+      let count = 0;
+      let counted = false;
+      for (const prop of objectProperties(node)) {
+        const name = propertyName(prop);
+        if (name !== "KNOWLEDGE" && name !== "ACTION") continue;
+        const list = resolveNode(propertyValue(prop), bindings);
+        if (!list || !ts.isArrayLiteralExpression(list)) continue;
+        counted = true;
+        count += list.elements.filter((element) => !ts.isSpreadElement(element)).length;
+      }
+      if (counted && count > MAX_STARTERS) {
+        findings.push(
+          finding({
+            rule: "starters-limit",
+            severity: "error",
+            sourceFile,
+            node,
+            file: relative,
+            message: `${count} conversation starters in one set; at most ${MAX_STARTERS}, KNOWLEDGE and ACTION together. The same list is the agent panel's opening screen.`,
+            fix: `Keep the ${MAX_STARTERS} that matter most on this page - each one something the agent can answer today.`,
+          }),
+        );
+      }
+    }
+    ts.forEachChild(node, visit);
+  };
+  visit(sourceFile);
+}
+
 // What the build checks in the bundle it wrote: minify keeps property names,
 // so a bundle that can turn test mode on still says `setTestMode`. Calls with
 // `false` (`!1` once minified) are allowed; any other mention is not - the