@foldspace_npm/harness 0.1.28 → 0.1.29

package/README.md

@@ -225,7 +225,7 @@ v1 flags:
 - **error** `no-static-agent-prompt` - `execute`, a card's `callback` or its `readyState` handing the agent instructions (`directive`, “tell the user”, …)
 - **error** `no-runtask-prompt` — `runTask({ data: { prompt } })` and the same keys; a customer API field named `prompt` is allowed
 - **error** `card-contract` - `awaitUserInput: true` on a view card (its `render` uses no `callback`, `cancel` or `readyState`): the chat panel ignores it, but in headless mode the agent waits for a callback that never comes
-- **error** `no-test-mode-in-bundle` - `armAllInstances(...)`, or `setTestMode(...)` with anything but a literal `false`, anywhere in `agent/`
+- **error** `no-test-mode-in-bundle` - `armAllInstances` used anywhere in `agent/` (called, or handed on to be called later), or `setTestMode(...)` with anything but a literal `false`. A code project's own copy of the runtime in `agent/runtime/` is not refused for the `setTestMode` inside its `armAllInstances`
 - **warning** `card-contract` - any other `awaitUserInput` on a view card, `awaitUserInput` on an input card (not needed), or a `render` that declares `callback`, `cancel` or `readyState` and uses none of them (the SDK treats it as a view card)
 - **warning** `no-emoji` — emoji in handler or `agent/views` string literals
 - **warning** `registry-integrity` — duplicate keys, `{ execute }` not registered, registry value missing `execute`

package/bin/build.ts

@@ -2,7 +2,7 @@ import * as esbuild from "esbuild";
 import * as fs from "fs";
 import * as path from "path";
 import { fileURLToPath } from "url";
-import { lintProject, printLint } from "../src/lint/index.mjs";
+import { bundleTurnsOnTestMode, lintProject, printLint } from "../src/lint/index.mjs";
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const projectDir = process.env.FOLDSPACE_PROJECT_DIR || process.cwd();
@@ -19,6 +19,21 @@ function gateLint(): void {
   }
 }
 
+const TEST_MODE_IN_BUNDLE =
+  "foldspace build: the bundle can turn test mode on - it uses `setTestMode` with something other than `false`. " +
+  "Any bundle can ship to production, where test mode would stop real users' conversations being tracked. " +
+  "Remove it: test mode is only `npx foldspace attach --test-mode`, which never touches the bundle. dist/index.js was not kept.";
+
+// The net under lint's no-test-mode-in-bundle: read what was actually built.
+function bundleIsSafe(): boolean {
+  const outfile = path.join(distDir, "index.js");
+  if (!fs.existsSync(outfile)) return true;
+  if (!bundleTurnsOnTestMode(fs.readFileSync(outfile, "utf8"))) return true;
+  fs.rmSync(outfile, { force: true });
+  console.error(TEST_MODE_IN_BUNDLE);
+  return false;
+}
+
 function buildOptions(): esbuild.BuildOptions {
   return {
     entryPoints: [agentActionsEntry],
@@ -45,11 +60,8 @@ function rebuildPlugin(): esbuild.Plugin {
       });
       build.onEnd((result) => {
         const time = new Date().toLocaleTimeString();
-        if (result.errors.length === 0) {
-          console.log(`[${time}] Rebuilt: dist/index.js`);
-        } else {
-          console.log(`[${time}] Error: dist/index.js`);
-        }
+        const built = result.errors.length === 0 && bundleIsSafe();
+        console.log(`[${time}] ${built ? "Rebuilt" : "Error"}: dist/index.js`);
       });
     },
   };
@@ -90,6 +102,7 @@ async function build() {
       });
     } else {
       await esbuild.build(buildOptions());
+      if (!bundleIsSafe()) process.exit(1);
       console.log("Built: dist/index.js");
       console.log("\nBuild complete!");
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@foldspace_npm/harness",
-  "version": "0.1.28",
+  "version": "0.1.29",
   "description": "Build and verify portable Foldspace action artifacts against a live app.",
   "type": "module",
   "bin": {

package/src/lint/index.mjs

@@ -3,6 +3,8 @@ import path from "node:path";
 import { listSourceFiles, parseFile, shouldSkipActionFile } from "./ast.mjs";
 import { lintActionFile, lintViewsFile, ruleNoTestModeInBundle, ruleRegistryIntegrity } from "./rules.mjs";
 
+export { bundleTurnsOnTestMode } from "./rules.mjs";
+
 export const LINT_SCHEMA_VERSION = 1;
 
 export function lintProject(projectDir) {

package/src/lint/rules.mjs

@@ -644,34 +644,173 @@ export function ruleCardContract(sourceFile, relative, findings) {
 
 // Test mode belongs to `attach --test-mode`, which never touches the bundle.
 // A call in agent code that turns it on can ship to production and mark real
-// users' conversations as test traffic. A call to `setTestMode` by name is
-// refused unless its first argument is the literal `false`. A call to
-// `armAllInstances` by name is always refused: even with `false` it sends a
-// partial `setConfiguration` to every instance.
+// users' conversations as test traffic.
+//
+// `setTestMode` is refused unless it is called with the literal `false` - and
+// also when it is reached any other way (handed on, `.call`, `.bind`).
+// `armAllInstances` is refused however it is used, whatever its argument:
+// called (by name, under the name it was imported as, by element access),
+// handed on (a timer, a listener, an object, a default value) or exported
+// under another name. Even with `false` it sends a partial `setConfiguration`
+// to every instance. Importing it, re-exporting it under its own name and
+// types are not uses. Names are matched within the file, not by binding, so
+// the rule errs on the side of refusing.
+//
+// One call is not refused. A code project carries its own copy of the runtime,
+// and that copy's `agent/runtime/agent.ts` defines `function
+// armAllInstances(testMode)`, which calls `setTestMode(testMode)`. That call -
+// with the helper's own first parameter, in that function, in that file - runs
+// only when something uses `armAllInstances`, and every use is refused. The
+// build also checks the bundle itself (`bundleTurnsOnTestMode`), which catches
+// what reading the source cannot.
 export function ruleNoTestModeInBundle(sourceFile, relative, findings) {
-  const walk = (node) => {
-    if (ts.isCallExpression(node)) {
-      const callee = node.expression;
-      const name = ts.isPropertyAccessExpression(callee) ? callee.name.text : ts.isIdentifier(callee) ? callee.text : "";
-      const first = node.arguments[0];
-      const setTestModeOff = name === "setTestMode" && first && first.kind === ts.SyntaxKind.FalseKeyword;
-      if ((name === "setTestMode" || name === "armAllInstances") && !setTestModeOff) {
-        findings.push(
-          finding({
-            rule: "no-test-mode-in-bundle",
-            severity: "error",
-            sourceFile,
-            node,
-            file: relative,
-            message: `\`${name}\` does not belong in agent code: any file in \`agent/\` can ship to production, where test mode would stop real users' conversations being tracked.`,
-            fix: "Remove it. Test mode is only for an agent that already has real users, and only through `npx foldspace attach --test-mode`, which never touches the bundle. For an agent with no real users yet, leave test mode off.",
-          }),
-        );
-      }
+  // path.sep, so a POSIX file whose name holds a backslash is not read as a folder.
+  const inRuntimeHelperFile = relative.split(path.sep).join("/") === "agent/runtime/agent.ts";
+
+  const ARM = "armAllInstances";
+  const armNames = new Set([ARM]);
+  const keyText = (key) => {
+    if (!key) return undefined;
+    if (ts.isIdentifier(key) || ts.isStringLiteralLike(key)) return key.text;
+    if (ts.isComputedPropertyName(key) && ts.isStringLiteralLike(key.expression)) return key.expression.text;
+    return undefined;
+  };
+  const collectImportedNames = (node) => {
+    if (ts.isImportSpecifier(node) && keyText(node.propertyName ?? node.name) === ARM) armNames.add(node.name.text);
+    if (ts.isBindingElement(node) && ts.isIdentifier(node.name) && keyText(node.propertyName ?? node.name) === ARM) {
+      armNames.add(node.name.text);
     }
-    ts.forEachChild(node, walk);
+    ts.forEachChild(node, collectImportedNames);
   };
-  walk(sourceFile);
+  collectImportedNames(sourceFile);
+
+  const memberName = (node) => {
+    if (ts.isPropertyAccessExpression(node)) return node.name.text;
+    if (ts.isElementAccessExpression(node) && ts.isStringLiteralLike(node.argumentExpression)) {
+      return node.argumentExpression.text;
+    }
+    return "";
+  };
+  const unwrap = (node) => {
+    while (
+      node &&
+      (ts.isParenthesizedExpression(node) ||
+        ts.isNonNullExpression(node) ||
+        ts.isAsExpression(node) ||
+        ts.isSatisfiesExpression(node) ||
+        ts.isTypeAssertionExpression(node))
+    ) {
+      node = node.expression;
+    }
+    return node;
+  };
+  const isArm = (node) => (ts.isIdentifier(node) && armNames.has(node.text)) || memberName(node) === ARM;
+  const isSetTestMode = (node) =>
+    (ts.isIdentifier(node) && node.text === "setTestMode") || memberName(node) === "setTestMode";
+  const isCallee = (node) => {
+    let parent = node.parent;
+    while (parent && (ts.isParenthesizedExpression(parent) || ts.isNonNullExpression(parent) || ts.isAsExpression(parent))) {
+      parent = parent.parent;
+    }
+    return parent !== undefined && ts.isCallExpression(parent) && unwrap(parent.expression) === node;
+  };
+
+  const inImportEquals = (node) => {
+    let n = node;
+    while (n.parent && ts.isQualifiedName(n.parent)) n = n.parent;
+    return n.parent !== undefined && ts.isImportEqualsDeclaration(n.parent);
+  };
+  // Positions where the name is declared, imported, a key or a type - not a
+  // value that can be called later.
+  const isNamedNotUsed = (node) => {
+    const parent = node.parent;
+    if (!parent) return true;
+    if (ts.isPropertyAccessExpression(parent) && parent.name === node) return true;
+    if (ts.isQualifiedName(parent)) return !inImportEquals(node);
+    if (ts.isExportSpecifier(parent)) return true; // the export itself is judged below, once
+    if (ts.isBindingElement(parent)) return parent.name === node || parent.propertyName === node;
+    if (
+      ts.isImportSpecifier(parent) ||
+      ts.isImportClause(parent) ||
+      ts.isNamespaceImport(parent) ||
+      ts.isTypeQueryNode(parent) ||
+      ts.isImportTypeNode(parent)
+    ) {
+      return true;
+    }
+    if (ts.isFunctionDeclaration(parent) && parent.name === node) {
+      return !parent.modifiers?.some((m) => m.kind === ts.SyntaxKind.DefaultKeyword);
+    }
+    return (
+      (ts.isFunctionExpression(parent) ||
+        ts.isVariableDeclaration(parent) ||
+        ts.isParameter(parent) ||
+        ts.isPropertyAssignment(parent) ||
+        ts.isMethodDeclaration(parent) ||
+        ts.isMethodSignature(parent) ||
+        ts.isGetAccessorDeclaration(parent) ||
+        ts.isSetAccessorDeclaration(parent) ||
+        ts.isPropertyDeclaration(parent) ||
+        ts.isPropertySignature(parent) ||
+        ts.isEnumMember(parent)) &&
+      parent.name === node
+    );
+  };
+
+  // The helper's first parameter, when node is the runtime copy's own
+  // `function armAllInstances(testMode)` in agent/runtime/agent.ts.
+  const helperParam = (node) => {
+    if (!inRuntimeHelperFile || !ts.isFunctionDeclaration(node) || node.name?.text !== ARM) return undefined;
+    if (node.modifiers?.some((m) => m.kind === ts.SyntaxKind.DefaultKeyword)) return undefined;
+    const first = node.parameters[0];
+    return first && ts.isIdentifier(first.name) ? first.name.text : undefined;
+  };
+
+  const refuse = (node, name) => {
+    findings.push(
+      finding({
+        rule: "no-test-mode-in-bundle",
+        severity: "error",
+        sourceFile,
+        node,
+        file: relative,
+        message: `\`${name}\` does not belong in agent code: any file in \`agent/\` can ship to production, where test mode would stop real users' conversations being tracked.`,
+        fix: "Remove it. Test mode is only for an agent that already has real users, and only through `npx foldspace attach --test-mode`, which never touches the bundle. For an agent with no real users yet, leave test mode off.",
+      }),
+    );
+  };
+
+  const walk = (node, exemptParam) => {
+    if (ts.isCallExpression(node) && isSetTestMode(unwrap(node.expression))) {
+      const [first] = node.arguments;
+      const off = first !== undefined && first.kind === ts.SyntaxKind.FalseKeyword;
+      const helperOwnCall =
+        exemptParam !== undefined && node.arguments.length === 1 && ts.isIdentifier(first) && first.text === exemptParam;
+      if (!off && !helperOwnCall) refuse(node, "setTestMode");
+    } else if (isSetTestMode(node) && !isCallee(node) && !(ts.isIdentifier(node) && isNamedNotUsed(node))) {
+      refuse(node, "setTestMode");
+    }
+    if (ts.isCallExpression(node) && isArm(unwrap(node.expression))) {
+      refuse(node, ARM);
+    } else if (isArm(node)) {
+      if (!isCallee(node) && !(ts.isIdentifier(node) && isNamedNotUsed(node))) refuse(node, ARM);
+    } else if (ts.isExportSpecifier(node)) {
+      const local = keyText(node.propertyName ?? node.name);
+      if (local !== undefined && armNames.has(local) && keyText(node.name) !== ARM) refuse(node, ARM);
+    }
+    const param = exemptParam ?? helperParam(node);
+    ts.forEachChild(node, (child) => walk(child, param));
+  };
+  walk(sourceFile, undefined);
+}
+
+// What the build checks in the bundle it wrote: minify keeps property names,
+// so a bundle that can turn test mode on still says `setTestMode`. Calls with
+// `false` (`!1` once minified) are allowed; any other mention is not - the
+// net under the lint rule above, for code it cannot read (a computed name, a
+// file lint does not walk).
+export function bundleTurnsOnTestMode(js) {
+  return /setTestMode/.test(js.replace(/\??\.setTestMode(\?\.)?\(\s*(!1|false)\s*\)/g, ""));
 }
 
 export function lintActionFile(filePath, relative, findings) {