@foldspace_npm/harness 0.1.26 → 0.1.28

package/src/init.mjs

@@ -137,7 +137,7 @@ function validateIdentifier(value, label) {
 function validateProductId(value) {
   const productId = validateIdentifier(value, "Product ID");
   if (/^EU-/i.test(productId)) {
-    throw new Error("Product ID must be the bare product ID, not an EU-… SDK key.");
+    throw new Error("Use the bare product ID, not the SDK key (the one that starts with EU-, in every region).");
   }
   return productId;
 }
@@ -504,9 +504,11 @@ export async function runInit(argv, options = {}) {
   if (!installed) {
     log("  npm install --ignore-scripts");
   }
+  log("  # before the first build, CLAUDE.md step 5: a code project's agent/ replaces the scaffold's");
   log("  npm run build");
-  log("  npm run inject");
-  log("  npm run attach");
+  log("  npm run inject   # the human signs in in that window");
+  log("  npx foldspace observe wait-login");
+  log("  npx foldspace attach --daemon");
 
   return { ...result, installed };
 }

package/src/keep-focus.mjs

@@ -3,18 +3,19 @@
 // then types into their live product (seen 2026-09-22). Nothing in CDP stops
 // that; on macOS the fix is to hand focus straight back to whatever app the
 // human was using. Elsewhere this is a no-op.
+//
+// Done with Launch Services (`lsappinfo`, `open -b`), not AppleScript: asking
+// "System Events" which app is in front makes macOS show the customer a
+// permission dialog - "claude wants access to control System Events" - in
+// the middle of their first session (seen 2026-09-30). Launch Services
+// answers the same question, and brings an app forward, with no dialog.
 
 import { execFile } from "node:child_process";
 
-const FRONT_APP_SCRIPT =
-  'tell application "System Events" to get bundle identifier of first application process whose frontmost is true';
-
-function osascript(script) {
+function run(command, args, timeout = 4000) {
   return new Promise((resolve) => {
-    // 4s, not less: the first call wakes System Events, which alone can take
-    // over a second, and a timeout here silently leaves focus on Chrome.
-    execFile("osascript", ["-e", script], { timeout: 4000 }, (error, stdout) => {
-      resolve(error ? null : String(stdout).trim());
+    execFile(command, args, { timeout }, (error, stdout) => {
+      resolve(error ? null : String(stdout));
     });
   });
 }
@@ -22,7 +23,11 @@ function osascript(script) {
 /** Bundle id of the app in front right now, or null (not macOS, or unknown). */
 export async function frontApp() {
   if (process.platform !== "darwin") return null;
-  return osascript(FRONT_APP_SCRIPT);
+  const asn = (await run("lsappinfo", ["front"]))?.trim();
+  if (!asn) return null;
+  const info = await run("lsappinfo", ["info", "-only", "bundleid", asn]);
+  const match = /"CFBundleIdentifier"="([^"]+)"/.exec(info || "");
+  return match ? match[1] : null;
 }
 
 /**
@@ -39,11 +44,10 @@ export async function withoutStealingFocus(action, { front = frontApp, restore =
 }
 
 export async function restoreFront(bundleId) {
-  if (process.platform !== "darwin" || !bundleId) return;
+  if (process.platform !== "darwin" || !bundleId || !/^[\w.-]+$/.test(bundleId)) return;
   // Twice, a beat apart: Chrome's activation lands after the navigation
   // settles, so one immediate restore can be overtaken.
-  const script = `tell application id "${bundleId.replace(/"/g, "")}" to activate`;
-  await osascript(script);
+  await run("open", ["-b", bundleId]);
   await new Promise((resolve) => setTimeout(resolve, 400));
-  await osascript(script);
+  await run("open", ["-b", bundleId]);
 }

package/src/lint/index.mjs

@@ -1,7 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
 import { listSourceFiles, parseFile, shouldSkipActionFile } from "./ast.mjs";
-import { lintActionFile, lintViewsFile, ruleRegistryIntegrity } from "./rules.mjs";
+import { lintActionFile, lintViewsFile, ruleNoTestModeInBundle, ruleRegistryIntegrity } from "./rules.mjs";
 
 export const LINT_SCHEMA_VERSION = 1;
 
@@ -44,6 +44,13 @@ export function lintProject(projectDir) {
     }
   }
 
+  // Any file under agent/ can end up in the bundle, including code that runs
+  // as soon as the bundle loads, so this rule reads all of it - not only
+  // actions and views.
+  for (const filePath of listSourceFiles(path.join(projectDir, "agent"))) {
+    ruleNoTestModeInBundle(parseFile(filePath), path.relative(projectDir, filePath), findings);
+  }
+
   ruleRegistryIntegrity({
     indexFile: entry,
     indexSource: parseFile(entry),

package/src/lint/rules.mjs

@@ -57,7 +57,7 @@ const IMPERATIVE_PATTERNS = [
 const EMOJI_PATTERN = /\p{Extended_Pictographic}/u;
 
 const PROMPT_FIX =
-  "Put the wording in the action or agent instructions via MCP or Agent Studio; return data only.";
+  "Put the wording in the action's instructions (with the Foldspace tools or in Agent Studio) or in the agent's instructions (Agent Studio only); return data only.";
 
 function mergeBindings(fn, sourceFile) {
   return new Map([
@@ -98,7 +98,7 @@ function inspectReturnedObject(obj, bindings, sourceFile, relative, findings, or
           sourceFile,
           node: at,
           file: relative,
-          message: `${origin} sends the copilot operating instructions ('${text.slice(0, 80)}').`,
+          message: `${origin} sends the agent operating instructions ('${text.slice(0, 80)}').`,
           fix: PROMPT_FIX,
         }),
       );
@@ -128,19 +128,29 @@ export function ruleNoStaticAgentPrompt(sourceFile, relative, findings) {
     }
 
     if (name === "render") {
-      const cbName = callbackParamName(fn);
-      forEachCallNamed(fn, cbName, (call) => {
-        const arg = call.arguments[0];
-        if (!arg) return;
-        inspectReturnedObject(
-          resolveNode(arg, bindings),
-          bindings,
-          sourceFile,
-          relative,
-          findings,
-          "callback",
-        );
-      });
+      // What a card hands to callback, and to readyState (render's 6th
+      // parameter), reaches the agent as the card's result - check both.
+      const params = fn.parameters || [];
+      const readyName =
+        params.length >= 6 && ts.isIdentifier(params[5].name) ? params[5].name.text : null;
+      for (const [paramName, origin] of [
+        [callbackParamName(fn), "callback"],
+        [readyName, "readyState"],
+      ]) {
+        if (!paramName) continue;
+        forEachCallNamed(fn, paramName, (call) => {
+          const arg = call.arguments[0];
+          if (!arg) return;
+          inspectReturnedObject(
+            resolveNode(arg, bindings),
+            bindings,
+            sourceFile,
+            relative,
+            findings,
+            origin,
+          );
+        });
+      }
     }
   });
 }
@@ -208,8 +218,8 @@ function reportEmoji(node, sourceFile, relative, findings) {
       sourceFile,
       node,
       file: relative,
-      message: "Emoji in handler or widget copy reads as off-brand in a product UI that has none.",
-      fix: "Strip the glyph from handler/render copy. Put “no emoji” in the agent's Behavior instructions; the MCP cannot write that field, so each new action's Studio instructions must carry the line too.",
+      message: "Emoji in handler or card copy reads as off-brand in a product UI that has none.",
+      fix: "Strip the glyph from handler/render copy. Put “no emoji” in the agent's Behavior instructions; the Foldspace tools cannot write that field, so each new action's Studio instructions must carry the line too.",
     }),
   );
 }
@@ -450,30 +460,218 @@ export function ruleRegistryIntegrity({ indexFile, indexSource, actionFiles, pro
   }
 }
 
-// The panel saves every rendered card to the conversation history as an image
-// drawn with html2canvas, which cannot parse modern colour functions: one such
-// value and the saved card is blank ("data:," where the card was - seen on a
-// CRM, 2026-09-22). Hex and rgba survive.
-const UNSNAPSHOTTABLE_COLOR = /\b(oklch|oklab|lch|lab|color-mix|light-dark)\s*\(/i;
-
-export function ruleNoUnsnapshottableColor(sourceFile, relative, findings) {
-  forEachStringLiteral(sourceFile, (node) => {
-    if (ts.isImportDeclaration(node.parent) || ts.isExportDeclaration(node.parent)) return;
-    const text = node.getText(sourceFile);
-    const match = UNSNAPSHOTTABLE_COLOR.exec(text);
-    if (!match) return;
-    findings.push(
-      finding({
-        rule: "no-unsnapshottable-color",
-        severity: "error",
-        sourceFile,
-        node,
-        file: relative,
-        message: `${match[1]}() in a card: the panel saves cards to history as an image drawn with html2canvas, which cannot read it - the saved card comes out blank.`,
-        fix: "Use plain hex or rgba. Do not read the app's CSS variables either: on modern apps they resolve to oklch.",
-      }),
-    );
-  });
+// The card contract of the page SDK. A card is a view card or an input card.
+// An input card's render uses one of its 4th to 6th parameters - callback,
+// cancel, readyState - and the agent waits until callback or cancel runs, or
+// until readyState reports. A view card uses none of them: as soon as render
+// returns, the agent is told it was shown, with everything execute returned.
+// awaitUserInput is never needed. The chat panel ignores it; in headless mode
+// awaitUserInput: true forces the wait, so on a view card the agent waits for
+// a callback that never comes.
+//
+// "Uses" is read the way the SDK reads render in the built bundle, where
+// parameters are renamed and types are erased: the parameter's name anywhere
+// in the body, nested functions included, but not as a property name
+// (`host.callback`, `{ callback: 1 }`) and not inside a type. A destructured
+// parameter, a `...rest` parameter or `arguments` count as used. A TypeScript
+// `this` parameter is erased, so it takes no position.
+const CARD_PARAMS = ["callback", "cancel", "readyState"];
+
+function mentions(fn, test) {
+  let found = false;
+  function walk(node) {
+    if (found) return;
+    if (ts.isIdentifier(node) && test(node.text)) {
+      const parent = node.parent;
+      const isName =
+        parent &&
+        (ts.isPropertyAccessExpression(parent) ||
+          ts.isPropertyAssignment(parent) ||
+          ts.isMethodDeclaration(parent) ||
+          ts.isPropertyDeclaration(parent) ||
+          ts.isGetAccessorDeclaration(parent) ||
+          ts.isSetAccessorDeclaration(parent)) &&
+        parent.name === node;
+      const isKey = parent && ts.isBindingElement(parent) && parent.propertyName === node;
+      let inType = false;
+      for (let up = parent; up && up !== fn; up = up.parent) {
+        if (ts.isTypeNode(up) && !ts.isExpressionWithTypeArguments(up)) {
+          inType = true;
+          break;
+        }
+      }
+      if (!isName && !isKey && !inType) {
+        found = true;
+        return;
+      }
+    }
+    ts.forEachChild(node, walk);
+  }
+  if (fn.body) walk(fn.body);
+  return found;
+}
+
+/** What the SDK concludes about a render function: does the agent wait, and which card parameters are declared but unused. */
+function readRender(fn) {
+  const params = fn.parameters.filter((param) => !(ts.isIdentifier(param.name) && param.name.text === "this"));
+  const cardParams = params.slice(3, 3 + CARD_PARAMS.length);
+  const restOrArguments = params.some((param) => param.dotDotDotToken) || mentions(fn, (name) => name === "arguments");
+  const destructured = cardParams.some((param) => !ts.isIdentifier(param.name));
+  const names = cardParams.filter((param) => ts.isIdentifier(param.name)).map((param) => param.name.text);
+  const used = names.filter((name) => mentions(fn, (text) => text === name));
+  const waits = restOrArguments || destructured || used.length > 0;
+  return { waits, declaredUnused: !waits && names.length > 0 ? names : [] };
+}
+
+// The function `render` names: inline, a method, or - for `render` and
+// `render: renderCard` - a `function` or `const` of that name in the same file.
+function declaredFunction(sourceFile, name) {
+  let found = null;
+  function walk(node) {
+    if (found) return;
+    if (ts.isFunctionDeclaration(node) && node.name?.text === name) {
+      found = node;
+      return;
+    }
+    if (ts.isVariableDeclaration(node) && ts.isIdentifier(node.name) && node.name.text === name && isFunctionLike(node.initializer)) {
+      found = node.initializer;
+      return;
+    }
+    ts.forEachChild(node, walk);
+  }
+  walk(sourceFile);
+  return found;
+}
+
+function renderFunction(sourceFile, member) {
+  if (ts.isMethodDeclaration(member)) return member;
+  if (ts.isShorthandPropertyAssignment(member)) return declaredFunction(sourceFile, member.name.text);
+  let value = member.initializer;
+  while (
+    value &&
+    (ts.isParenthesizedExpression(value) ||
+      ts.isAsExpression(value) ||
+      ts.isSatisfiesExpression(value) ||
+      ts.isNonNullExpression(value) ||
+      ts.isTypeAssertionExpression(value))
+  )
+    value = value.expression;
+  if (isFunctionLike(value)) return value;
+  if (value && ts.isIdentifier(value)) return declaredFunction(sourceFile, value.text);
+  return null;
+}
+
+export function ruleCardContract(sourceFile, relative, findings) {
+  function walk(node) {
+    if (ts.isObjectLiteralExpression(node)) {
+      const members = node.properties;
+      const render = members.find(
+        (member) =>
+          propertyName(member) === "render" &&
+          (ts.isPropertyAssignment(member) || ts.isMethodDeclaration(member) || ts.isShorthandPropertyAssignment(member)),
+      );
+      const fn = render ? renderFunction(sourceFile, render) : null;
+      if (fn) {
+        const { waits, declaredUnused } = readRender(fn);
+        const flag = members.find((member) => propertyName(member) === "awaitUserInput");
+        const flagTrue = flag && ts.isPropertyAssignment(flag) && flag.initializer.kind === ts.SyntaxKind.TrueKeyword;
+        if (flagTrue && !waits) {
+          findings.push(
+            finding({
+              rule: "card-contract",
+              severity: "error",
+              sourceFile,
+              node: flag.name,
+              file: relative,
+              message:
+                "A view card (render uses neither callback nor cancel) sets awaitUserInput: true. The chat panel ignores it, but in headless mode the agent then waits for a callback that never comes.",
+              fix: "Remove awaitUserInput. A view card is reported to the agent as shown, with what execute returned.",
+            }),
+          );
+        }
+        if (flag && !waits && !flagTrue) {
+          findings.push(
+            finding({
+              rule: "card-contract",
+              severity: "warning",
+              sourceFile,
+              node: flag.name,
+              file: relative,
+              message:
+                "A view card does not need awaitUserInput: render uses neither callback nor cancel, so the agent is told the card was shown, with what execute returned.",
+              fix: "Remove awaitUserInput.",
+            }),
+          );
+        }
+        if (flag && waits) {
+          findings.push(
+            finding({
+              rule: "card-contract",
+              severity: "warning",
+              sourceFile,
+              node: flag.name,
+              file: relative,
+              message:
+                "An input card does not need awaitUserInput: render uses callback, cancel or readyState, and that is what makes the agent wait.",
+              fix: 'Remove awaitUserInput. Then check that every path calls callback or cancel - choosing, "none of these", closing the card, failing. When the conversation should go on while the user decides, call readyState(value) once the card is drawn.',
+            }),
+          );
+        }
+        if (declaredUnused.length > 0) {
+          const list =
+            declaredUnused.length === 1
+              ? declaredUnused[0]
+              : `${declaredUnused.slice(0, -1).join(", ")} and ${declaredUnused.at(-1)}`;
+          const unused = declaredUnused.length === 1 ? "never uses it" : "uses none of them";
+          findings.push(
+            finding({
+              rule: "card-contract",
+              severity: "warning",
+              sourceFile,
+              node: render.name,
+              file: relative,
+              message: `render declares ${list} but ${unused} - the SDK treats the card as a view card: the agent is told it was shown, with what execute returned.`,
+              fix: `For a view card, remove ${list} from render. For an input card, call callback or cancel on every path, or readyState(value) once the card is drawn.`,
+            }),
+          );
+        }
+      }
+    }
+    ts.forEachChild(node, walk);
+  }
+  walk(sourceFile);
+}
+
+// Test mode belongs to `attach --test-mode`, which never touches the bundle.
+// A call in agent code that turns it on can ship to production and mark real
+// users' conversations as test traffic. A call to `setTestMode` by name is
+// refused unless its first argument is the literal `false`. A call to
+// `armAllInstances` by name is always refused: even with `false` it sends a
+// partial `setConfiguration` to every instance.
+export function ruleNoTestModeInBundle(sourceFile, relative, findings) {
+  const walk = (node) => {
+    if (ts.isCallExpression(node)) {
+      const callee = node.expression;
+      const name = ts.isPropertyAccessExpression(callee) ? callee.name.text : ts.isIdentifier(callee) ? callee.text : "";
+      const first = node.arguments[0];
+      const setTestModeOff = name === "setTestMode" && first && first.kind === ts.SyntaxKind.FalseKeyword;
+      if ((name === "setTestMode" || name === "armAllInstances") && !setTestModeOff) {
+        findings.push(
+          finding({
+            rule: "no-test-mode-in-bundle",
+            severity: "error",
+            sourceFile,
+            node,
+            file: relative,
+            message: `\`${name}\` does not belong in agent code: any file in \`agent/\` can ship to production, where test mode would stop real users' conversations being tracked.`,
+            fix: "Remove it. Test mode is only for an agent that already has real users, and only through `npx foldspace attach --test-mode`, which never touches the bundle. For an agent with no real users yet, leave test mode off.",
+          }),
+        );
+      }
+    }
+    ts.forEachChild(node, walk);
+  };
+  walk(sourceFile);
 }
 
 export function lintActionFile(filePath, relative, findings) {
@@ -482,11 +680,10 @@ export function lintActionFile(filePath, relative, findings) {
   ruleNoStaticAgentPrompt(sourceFile, relative, findings);
   ruleNoRunTaskPrompt(sourceFile, relative, findings);
   ruleNoEmoji(sourceFile, relative, findings);
-  ruleNoUnsnapshottableColor(sourceFile, relative, findings);
+  ruleCardContract(sourceFile, relative, findings);
 }
 
 export function lintViewsFile(filePath, relative, findings) {
   const sourceFile = parseFile(filePath);
   ruleNoEmoji(sourceFile, relative, findings, { wholeFile: true });
-  ruleNoUnsnapshottableColor(sourceFile, relative, findings);
 }