@foldkit/oxlint-plugin 0.7.0-canary.9869cf777983 → 0.7.0-canary.c49937d15e79

package/all.json

@@ -19,6 +19,7 @@
     "foldkit/no-disabling-dev-guardrails": "error",
     "foldkit/no-duplicate-onmount-per-element": "error",
     "foldkit/no-empty-children-array": "error",
+    "foldkit/no-empty-commands-array": "error",
     "foldkit/no-empty-object-tagged-call": "error",
     "foldkit/no-hand-rolled-command-struct": "error",
     "foldkit/no-hardcoded-route-strings": "error",
@@ -72,6 +73,7 @@
         "foldkit/no-disabling-dev-guardrails": "off",
         "foldkit/no-duplicate-onmount-per-element": "off",
         "foldkit/no-empty-children-array": "off",
+        "foldkit/no-empty-commands-array": "off",
         "foldkit/no-empty-object-tagged-call": "off",
         "foldkit/no-hand-rolled-command-struct": "off",
         "foldkit/no-hardcoded-route-strings": "off",

package/dist/index.js

@@ -11687,6 +11687,80 @@ var noEmptyChildrenArray = Rule_exports.define({
   }
 });
 
+// src/rules/no-empty-commands-array.ts
+var COMMANDS_PROPERTY = "commands";
+var isObjectProperty = (node) => typeof node === "object" && node !== null && "type" in node && node.type === "Property";
+var staticPropertyName2 = (property) => {
+  if (!property.computed && isIdentifier(property.key)) {
+    return Option_exports.some(property.key.name);
+  }
+  return staticStringValue(property.key);
+};
+var isEmptyCommandsProperty = (property) => Option_exports.contains(staticPropertyName2(property), COMMANDS_PROPERTY) && isArrayExpression(property.value) && Array_exports.isReadonlyArrayEmpty(property.value.elements);
+var removalRange = (object, property, index) => {
+  const maybePrevious = Array_exports.get(object.properties, index - 1);
+  if (Option_exports.isSome(maybePrevious)) {
+    return [maybePrevious.value.end, property.end];
+  }
+  const maybeNext = Array_exports.get(object.properties, index + 1);
+  if (Option_exports.isSome(maybeNext)) {
+    return [property.start, maybeNext.value.start];
+  }
+  return property.range;
+};
+var emptyCommandsMessage = "Return { model } instead of the literal { model, commands: [] }. Return a computed Commands collection directly, even when it may be empty.";
+var noEmptyCommandsArray = Rule_exports.define({
+  name: "no-empty-commands-array",
+  meta: Rule_exports.meta({
+    type: "suggestion",
+    description: "Omit a literal empty commands property from an update result.",
+    fixable: "code"
+  }),
+  create: function* () {
+    const ctx = yield* RuleContext;
+    return {
+      ObjectExpression: (node) => {
+        if (!isObjectExpression(node)) {
+          return Effect_exports.void;
+        }
+        const hasSpread = Array_exports.some(
+          node.properties,
+          (property) => property.type === "SpreadElement"
+        );
+        const commandProperties = Array_exports.filter(
+          node.properties,
+          (property) => isObjectProperty(property) && Option_exports.contains(staticPropertyName2(property), COMMANDS_PROPERTY)
+        );
+        const hasComments = Array_exports.isReadonlyArrayNonEmpty(
+          ctx.sourceCode.getCommentsInside(node)
+        );
+        return Effect_exports.forEach(
+          node.properties.entries(),
+          ([index, property]) => {
+            if (!isObjectProperty(property) || !isEmptyCommandsProperty(property)) {
+              return Effect_exports.void;
+            }
+            const diagnostic = Diagnostic_exports.make({
+              node: property,
+              message: emptyCommandsMessage
+            });
+            if (hasSpread || hasComments || Array_exports.isReadonlyArrayNonEmpty(Array_exports.drop(commandProperties, 1))) {
+              return ctx.report(diagnostic);
+            }
+            return ctx.report(
+              Diagnostic_exports.withFix(
+                diagnostic,
+                (fixer) => fixer.removeRange(removalRange(node, property, index))
+              )
+            );
+          },
+          { discard: true }
+        );
+      }
+    };
+  }
+});
+
 // src/rules/no-empty-object-tagged-call.ts
 var constructorName = (callee) => {
   if (isIdentifier(callee) && /^[A-Z][A-Za-z0-9]*$/.test(callee.name)) {
@@ -11944,7 +12018,7 @@ var staticMemberName = (node) => {
   }
   return void 0;
 };
-var staticPropertyName2 = (property) => {
+var staticPropertyName3 = (property) => {
   if (property.key.type === "Identifier") {
     return property.key.name;
   }
@@ -12022,7 +12096,7 @@ var noNonportableServerGlobals = Rule_exports.define({
           if (property.type !== "Property") {
             return [];
           }
-          const name = staticPropertyName2(property);
+          const name = staticPropertyName3(property);
           return name !== void 0 && restrictedGlobalNames.has(name) ? [{ name, property }] : [];
         });
         return isUnshadowedGlobalReference(references, source) ? Effect_exports.forEach(
@@ -12762,6 +12836,7 @@ var basePlugin = Plugin_exports.define({
     "no-disabling-dev-guardrails": noDisablingDevGuardrails,
     "no-duplicate-onmount-per-element": noDuplicateOnmountPerElement,
     "no-empty-children-array": noEmptyChildrenArray,
+    "no-empty-commands-array": noEmptyCommandsArray,
     "no-empty-object-tagged-call": noEmptyObjectTaggedCall,
     "no-hand-rolled-command-struct": noHandRolledCommandStruct,
     "no-hardcoded-route-strings": noHardcodedRouteStrings,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@foldkit/oxlint-plugin",
-  "version": "0.7.0-canary.9869cf777983",
+  "version": "0.7.0-canary.c49937d15e79",
   "description": "Oxlint rules for Foldkit applications",
   "type": "module",
   "main": "./dist/index.js",

package/recommended.json

@@ -19,6 +19,7 @@
     "foldkit/no-disabling-dev-guardrails": "error",
     "foldkit/no-duplicate-onmount-per-element": "error",
     "foldkit/no-empty-children-array": "error",
+    "foldkit/no-empty-commands-array": "error",
     "foldkit/no-empty-object-tagged-call": "error",
     "foldkit/no-hand-rolled-command-struct": "error",
     "foldkit/no-hardcoded-route-strings": "error",
@@ -72,6 +73,7 @@
         "foldkit/no-disabling-dev-guardrails": "off",
         "foldkit/no-duplicate-onmount-per-element": "off",
         "foldkit/no-empty-children-array": "off",
+        "foldkit/no-empty-commands-array": "off",
         "foldkit/no-empty-object-tagged-call": "off",
         "foldkit/no-hand-rolled-command-struct": "off",
         "foldkit/no-hardcoded-route-strings": "off",