@foldkit/oxlint-plugin 0.5.0 → 0.6.0

package/all.json

@@ -19,6 +19,7 @@
     "foldkit/no-child-message-construction-in-root": "error",
     "foldkit/no-disabling-dev-guardrails": "error",
     "foldkit/no-duplicate-onmount-per-element": "error",
+    "foldkit/no-empty-children-array": "error",
     "foldkit/no-empty-object-tagged-call": "error",
     "foldkit/no-hand-rolled-command-struct": "error",
     "foldkit/no-hardcoded-route-strings": "error",
@@ -51,6 +52,7 @@
         "foldkit/no-child-message-construction-in-root": "off",
         "foldkit/no-disabling-dev-guardrails": "off",
         "foldkit/no-duplicate-onmount-per-element": "off",
+        "foldkit/no-empty-children-array": "off",
         "foldkit/no-empty-object-tagged-call": "off",
         "foldkit/no-hand-rolled-command-struct": "off",
         "foldkit/no-hardcoded-route-strings": "off",

package/dist/index.js

@@ -11038,6 +11038,297 @@ var noDuplicateOnmountPerElement = Rule_exports.define({
   }
 });
 
+// src/elementBuilderNames.ts
+var ELEMENT_BUILDER_NAMES = /* @__PURE__ */ new Set([
+  // HTML
+  "a",
+  "abbr",
+  "address",
+  "area",
+  "article",
+  "aside",
+  "audio",
+  "b",
+  "base",
+  "bdi",
+  "bdo",
+  "blockquote",
+  "body",
+  "br",
+  "button",
+  "canvas",
+  "caption",
+  "cite",
+  "code",
+  "col",
+  "colgroup",
+  "data",
+  "datalist",
+  "dd",
+  "del",
+  "details",
+  "dfn",
+  "dialog",
+  "div",
+  "dl",
+  "dt",
+  "em",
+  "embed",
+  "fieldset",
+  "figcaption",
+  "figure",
+  "footer",
+  "form",
+  "h1",
+  "h2",
+  "h3",
+  "h4",
+  "h5",
+  "h6",
+  "head",
+  "header",
+  "hgroup",
+  "hr",
+  "html",
+  "i",
+  "iframe",
+  "img",
+  "input",
+  "ins",
+  "kbd",
+  "label",
+  "legend",
+  "li",
+  "link",
+  "main",
+  "map",
+  "mark",
+  "menu",
+  "meta",
+  "meter",
+  "nav",
+  "noscript",
+  "object",
+  "ol",
+  "optgroup",
+  "option",
+  "output",
+  "p",
+  "picture",
+  "portal",
+  "pre",
+  "progress",
+  "q",
+  "rp",
+  "rt",
+  "ruby",
+  "s",
+  "samp",
+  "script",
+  "search",
+  "section",
+  "select",
+  "slot",
+  "small",
+  "source",
+  "span",
+  "strong",
+  "style",
+  "sub",
+  "summary",
+  "sup",
+  "table",
+  "tbody",
+  "td",
+  "template",
+  "textarea",
+  "tfoot",
+  "th",
+  "thead",
+  "time",
+  "title",
+  "tr",
+  "track",
+  "u",
+  "ul",
+  "var",
+  "video",
+  "wbr",
+  // SVG
+  "svg",
+  "animate",
+  "animateMotion",
+  "animateTransform",
+  "circle",
+  "clipPath",
+  "defs",
+  "desc",
+  "ellipse",
+  "feBlend",
+  "feColorMatrix",
+  "feComponentTransfer",
+  "feComposite",
+  "feConvolveMatrix",
+  "feDiffuseLighting",
+  "feDisplacementMap",
+  "feDistantLight",
+  "feDropShadow",
+  "feFlood",
+  "feFuncA",
+  "feFuncB",
+  "feFuncG",
+  "feFuncR",
+  "feGaussianBlur",
+  "feImage",
+  "feMerge",
+  "feMergeNode",
+  "feMorphology",
+  "feOffset",
+  "fePointLight",
+  "feSpecularLighting",
+  "feSpotLight",
+  "feTile",
+  "feTurbulence",
+  "filter",
+  "foreignObject",
+  "g",
+  "image",
+  "line",
+  "linearGradient",
+  "marker",
+  "mask",
+  "metadata",
+  "mpath",
+  "path",
+  "pattern",
+  "polygon",
+  "polyline",
+  "radialGradient",
+  "rect",
+  "set",
+  "stop",
+  "switch",
+  "symbol",
+  "text",
+  "textPath",
+  "tspan",
+  "use",
+  "view",
+  // MathML
+  "math",
+  "annotation",
+  "maction",
+  "menclose",
+  "merror",
+  "mfenced",
+  "mfrac",
+  "mglyph",
+  "mi",
+  "mlabeledtr",
+  "mlongdiv",
+  "mmultiscripts",
+  "mn",
+  "mo",
+  "mover",
+  "mpadded",
+  "mphantom",
+  "mprescripts",
+  "mroot",
+  "mrow",
+  "ms",
+  "mscarries",
+  "mscarry",
+  "msgroup",
+  "msline",
+  "mspace",
+  "msqrt",
+  "msrow",
+  "mstack",
+  "mstyle",
+  "msub",
+  "msubsup",
+  "msup",
+  "mtable",
+  "mtd",
+  "mtext",
+  "mtr",
+  "munder",
+  "munderover",
+  "semantics"
+]);
+
+// src/rules/no-empty-children-array.ts
+var BUILDER_BINDINGS = /* @__PURE__ */ new Set(["h", "ih", "inertHtml"]);
+var KEYED_PROPERTY = "keyed";
+var builderCallee = (callee) => {
+  if (!isMemberExpression(callee) || callee.computed === true) {
+    return Option_exports.none();
+  }
+  if (!isIdentifier(callee.object) || !BUILDER_BINDINGS.has(callee.object.name) || !isIdentifier(callee.property)) {
+    return Option_exports.none();
+  }
+  return Option_exports.some({
+    binding: callee.object.name,
+    property: callee.property.name
+  });
+};
+var elementCallTarget = (node) => node.arguments.length === 2 ? builderCallee(node.callee).pipe(
+  Option_exports.filter(({ property }) => ELEMENT_BUILDER_NAMES.has(property)),
+  Option_exports.map(({ binding, property }) => `${binding}.${property}([...])`)
+) : Option_exports.none();
+var keyedCallTarget = (node) => {
+  if (node.arguments.length !== 3 || !isCallExpression(node.callee)) {
+    return Option_exports.none();
+  }
+  return builderCallee(node.callee.callee).pipe(
+    Option_exports.filter(({ property }) => property === KEYED_PROPERTY),
+    Option_exports.map(
+      ({ binding }) => `${binding}.${KEYED_PROPERTY}(tag)(key, [...])`
+    )
+  );
+};
+var childrenArgument = (node) => Array_exports.last(node.arguments);
+var emptyChildrenMessage = (target) => `Omit the children argument when an element has none. Write ${target} instead of passing a trailing []. The builder defaults children to an empty array, so the two build the same vnode and the [] carries no information.`;
+var noEmptyChildrenArray = Rule_exports.define({
+  name: "no-empty-children-array",
+  meta: Rule_exports.meta({
+    type: "suggestion",
+    description: "Omit the children argument on elements that have no children."
+  }),
+  create: function* () {
+    const ctx = yield* RuleContext;
+    return {
+      CallExpression: (node) => {
+        if (!isCallExpression(node)) {
+          return Effect_exports.void;
+        }
+        const maybeTarget = Option_exports.orElse(
+          elementCallTarget(node),
+          () => keyedCallTarget(node)
+        );
+        if (Option_exports.isNone(maybeTarget)) {
+          return Effect_exports.void;
+        }
+        const maybeChildren = childrenArgument(node);
+        if (Option_exports.isNone(maybeChildren) || !isArrayExpression(maybeChildren.value) || Array_exports.isReadonlyArrayNonEmpty(maybeChildren.value.elements)) {
+          return Effect_exports.void;
+        }
+        if (Array_exports.isReadonlyArrayNonEmpty(
+          ctx.sourceCode.getCommentsInside(maybeChildren.value)
+        )) {
+          return Effect_exports.void;
+        }
+        return ctx.report(
+          Diagnostic_exports.make({
+            node: maybeChildren.value,
+            message: emptyChildrenMessage(maybeTarget.value)
+          })
+        );
+      }
+    };
+  }
+});
+
 // src/rules/no-empty-object-tagged-call.ts
 var noEmptyObjectTaggedCall = Rule_exports.define({
   name: "no-empty-object-tagged-call",
@@ -11961,6 +12252,7 @@ var basePlugin = Plugin_exports.define({
     "no-child-message-construction-in-root": noChildMessageConstructionInRoot,
     "no-disabling-dev-guardrails": noDisablingDevGuardrails,
     "no-duplicate-onmount-per-element": noDuplicateOnmountPerElement,
+    "no-empty-children-array": noEmptyChildrenArray,
     "no-empty-object-tagged-call": noEmptyObjectTaggedCall,
     "no-hand-rolled-command-struct": noHandRolledCommandStruct,
     "no-hardcoded-route-strings": noHardcodedRouteStrings,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@foldkit/oxlint-plugin",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "description": "Oxlint rules for Foldkit applications",
   "type": "module",
   "main": "./dist/index.js",

package/recommended.json

@@ -19,6 +19,7 @@
     "foldkit/no-child-message-construction-in-root": "error",
     "foldkit/no-disabling-dev-guardrails": "error",
     "foldkit/no-duplicate-onmount-per-element": "error",
+    "foldkit/no-empty-children-array": "error",
     "foldkit/no-empty-object-tagged-call": "error",
     "foldkit/no-hand-rolled-command-struct": "error",
     "foldkit/no-hardcoded-route-strings": "error",
@@ -51,6 +52,7 @@
         "foldkit/no-child-message-construction-in-root": "off",
         "foldkit/no-disabling-dev-guardrails": "off",
         "foldkit/no-duplicate-onmount-per-element": "off",
+        "foldkit/no-empty-children-array": "off",
         "foldkit/no-empty-object-tagged-call": "off",
         "foldkit/no-hand-rolled-command-struct": "off",
         "foldkit/no-hardcoded-route-strings": "off",