@foldkit/oxlint-plugin 0.10.0-canary.db46ded8d159 → 0.10.0-canary.dc82c7255dbf

package/dist/index.js

@@ -4,7 +4,7 @@ var __export = (target, all5) => {
     __defProp(target, name, { get: all5[name], enumerable: true });
 };
 
-// ../../node_modules/.pnpm/effect-oxlint@0.3.2_effect@4.0.0-rc.112/node_modules/effect-oxlint/dist/chunk.js
+// ../../node_modules/.pnpm/effect-oxlint@0.3.3_effect@4.0.0-rc.112/node_modules/effect-oxlint/dist/chunk.js
 var __defProp2 = Object.defineProperty;
 var __exportAll = (all5, no_symbols) => {
   let target = {};
@@ -7399,7 +7399,7 @@ var flatMapEager2 = flatMapEager;
 var catchEager2 = catchEager;
 var fnUntracedEager2 = fnUntracedEager;
 
-// ../../node_modules/.pnpm/effect-oxlint@0.3.2_effect@4.0.0-rc.112/node_modules/effect-oxlint/dist/RuleContext.js
+// ../../node_modules/.pnpm/effect-oxlint@0.3.3_effect@4.0.0-rc.112/node_modules/effect-oxlint/dist/RuleContext.js
 var RuleContextBase = Service()("effect-oxlint/RuleContext");
 var RuleContext = class extends RuleContextBase {
 };
@@ -10014,7 +10014,7 @@ var updateSomeAndGet = /* @__PURE__ */ dual(2, (self, pf) => sync2(() => {
 }));
 var getUnsafe3 = (self) => self.ref.current;
 
-// ../../node_modules/.pnpm/effect-oxlint@0.3.2_effect@4.0.0-rc.112/node_modules/effect-oxlint/dist/index.js
+// ../../node_modules/.pnpm/effect-oxlint@0.3.3_effect@4.0.0-rc.112/node_modules/effect-oxlint/dist/index.js
 var AST_exports = /* @__PURE__ */ __exportAll({
   calleeIdentifier: () => calleeIdentifier,
   calleeName: () => calleeName,
@@ -11086,92 +11086,134 @@ var lazyViewStableReferences = Rule_exports.define({
 
 // src/rules/mount-factory-must-use-element.ts
 var MOUNT_DEFINITION_METHODS = ["define", "defineStream"];
-var NO_ELEMENT_PARAMETER_MESSAGE = "This Mount factory never receives the element: it declares no usable element parameter. A Mount exists for element-caused, element-targeted work. If the element is irrelevant, use a Command, Subscription, or ManagedResource instead.";
-var ignoredElementParameterMessage = (parameterName) => `The element parameter \`${parameterName}\` is named as ignored. A Mount factory must read or write its live element; if the element does not matter here, the side effect has a different cause and belongs in a Command, Subscription, or ManagedResource.`;
-var unusedElementParameterMessage = (parameterName) => `The element parameter \`${parameterName}\` is never referenced in this Mount factory. A Mount factory must use its live element; work that does not need the element belongs in a Command, Subscription, or ManagedResource.`;
-var isFactoryFunction = (node) => node.type === "ArrowFunctionExpression" || node.type === "FunctionExpression";
-var isMountDefinitionChain = (call) => {
-  if (call.callee.type === "MemberExpression") {
-    return AST_exports.isMember(call.callee, "Mount", MOUNT_DEFINITION_METHODS);
-  }
-  if (call.callee.type === "CallExpression") {
-    return isMountDefinitionChain(call.callee);
-  }
-  return false;
-};
-var returnedFactoryFunction = (statement) => {
-  if (statement.type !== "ReturnStatement" || statement.argument === null) {
-    return Option_exports.none();
-  }
-  return isFactoryFunction(statement.argument) ? Option_exports.some(statement.argument) : Option_exports.none();
-};
-var descendToElementFactory = (builder) => {
-  const body = builder.body;
-  if (body === null) return builder;
-  if (isFactoryFunction(body)) return body;
-  if (body.type === "BlockStatement") {
-    return pipe(
-      body.body,
-      Array_exports.findFirst(returnedFactoryFunction),
-      Option_exports.getOrElse(() => builder)
-    );
-  }
-  return builder;
-};
+var ELEMENT_FIELD = "element";
+var NO_ELEMENT_BINDING_MESSAGE = `This Mount's \`execute\` never receives the element: it does not destructure \`element\` from its input. A Mount exists for element-caused, element-targeted work. If the element is irrelevant, use a Command, Subscription, or ManagedResource instead.`;
+var ignoredElementBindingMessage = (bindingName) => `The element binding \`${bindingName}\` is named as ignored. A Mount's \`execute\` must read or write its live element; if the element does not matter here, the side effect has a different cause and belongs in a Command, Subscription, or ManagedResource.`;
+var unusedElementBindingMessage = (bindingName) => `The element binding \`${bindingName}\` is never referenced in this Mount's \`execute\`. A Mount's \`execute\` must use its live element; work that does not need the element belongs in a Command, Subscription, or ManagedResource.`;
+var unreadElementFieldMessage = (bindingName) => `This Mount's \`execute\` reads other fields off \`${bindingName}\` but never its \`element\`. Destructure \`element\` from the input so the check can see the read, or if the element is irrelevant, use a Command, Subscription, or ManagedResource instead.`;
+var unusedInputMessage = (bindingName) => `This Mount's \`execute\` never references \`${bindingName}\`, so it never reaches the live element. Destructure \`element\` from the input so the check can see the read, or if the element is irrelevant, use a Command, Subscription, or ManagedResource instead.`;
+var isExecuteFunction = (node) => node.type === "ArrowFunctionExpression" || node.type === "FunctionExpression";
 var isRecord = (value) => typeof value === "object" && value !== null;
-var shadowsParameterName = (functionNode, parameterName) => {
+var shadowsBindingName = (functionNode, bindingName) => {
   const parameters = functionNode.params;
   if (!isRecord(parameters)) return false;
   return Object.values(parameters).some(
-    (parameter) => isRecord(parameter) && parameter.type === "Identifier" && parameter.name === parameterName
+    (parameter) => isRecord(parameter) && parameter.type === "Identifier" && parameter.name === bindingName
   );
 };
-var referencesName = (value, parameterName) => {
+var referencesName = (value, bindingName) => {
   if (!isRecord(value)) return false;
-  if (value.type === "Identifier" && value.name === parameterName) return true;
-  if ((value.type === "ArrowFunctionExpression" || value.type === "FunctionExpression") && shadowsParameterName(value, parameterName)) {
+  if (value.type === "Identifier" && value.name === bindingName) return true;
+  if ((value.type === "ArrowFunctionExpression" || value.type === "FunctionExpression") && shadowsBindingName(value, bindingName)) {
     return false;
   }
+  if (value.type === "MemberExpression" && value.computed !== true) {
+    return referencesName(value.object, bindingName);
+  }
   if (value.type === "Property") {
-    const computedKeyReferences = value.computed === true && referencesName(value.key, parameterName);
-    return computedKeyReferences || referencesName(value.value, parameterName);
+    const computedKeyReferences = value.computed === true && referencesName(value.key, bindingName);
+    return computedKeyReferences || referencesName(value.value, bindingName);
   }
   return Object.entries(value).some(
-    ([key, child]) => key !== "parent" && referencesName(child, parameterName)
+    ([key, child]) => key !== "parent" && referencesName(child, bindingName)
   );
 };
-var elementFactoryDiagnostic = (factory) => {
-  const [firstParameter] = factory.params;
-  if (firstParameter === void 0 || firstParameter.type !== "Identifier") {
-    return Option_exports.some(NO_ELEMENT_PARAMETER_MESSAGE);
+var inputUses = (value, inputName) => {
+  if (!isRecord(value)) return [];
+  if (value.type === "MemberExpression" && isRecord(value.object) && value.object.type === "Identifier" && value.object.name === inputName) {
+    if (value.computed === true) return ["MaybeElement"];
+    return isRecord(value.property) && value.property.type === "Identifier" && value.property.name === ELEMENT_FIELD ? ["Element"] : ["OtherField"];
+  }
+  if (value.type === "MemberExpression" && value.computed !== true) {
+    return inputUses(value.object, inputName);
+  }
+  if ((value.type === "ArrowFunctionExpression" || value.type === "FunctionExpression") && shadowsBindingName(value, inputName)) {
+    return [];
+  }
+  if (value.type === "Property") {
+    const keyUses = value.computed === true ? inputUses(value.key, inputName) : [];
+    return [...keyUses, ...inputUses(value.value, inputName)];
   }
-  if (firstParameter.name.startsWith("_")) {
-    return Option_exports.some(ignoredElementParameterMessage(firstParameter.name));
+  if (value.type === "Identifier" && value.name === inputName) {
+    return ["MaybeElement"];
   }
-  return referencesName(factory.body, firstParameter.name) ? Option_exports.none() : Option_exports.some(unusedElementParameterMessage(firstParameter.name));
+  return Object.entries(value).flatMap(
+    ([key, child]) => key === "parent" ? [] : inputUses(child, inputName)
+  );
 };
+var elementProperty = (pattern) => pipe(
+  pattern.properties,
+  Array_exports.findFirst(
+    (property) => property.type === "Property" && (property.key.type === "Literal" ? property.key.value === ELEMENT_FIELD : !property.computed && property.key.type === "Identifier" && property.key.name === ELEMENT_FIELD)
+  )
+);
+var restBindingName = (pattern) => pipe(
+  pattern.properties,
+  Array_exports.findFirst(
+    (property) => property.type === "RestElement" && property.argument.type === "Identifier" ? Option_exports.some(property.argument.name) : Option_exports.none()
+  )
+);
+var withoutDefault = (value) => value.type === "AssignmentPattern" ? value.left : value;
+var bindingDiagnostic = (execute, bindingName) => {
+  if (bindingName.startsWith("_")) {
+    return Option_exports.some(ignoredElementBindingMessage(bindingName));
+  }
+  return referencesName(execute.body, bindingName) ? Option_exports.none() : Option_exports.some(unusedElementBindingMessage(bindingName));
+};
+var unpackedDiagnostic = (execute, bindingName) => {
+  const uses = inputUses(execute.body, bindingName);
+  if (Array_exports.isReadonlyArrayEmpty(uses)) {
+    return Option_exports.some(unusedInputMessage(bindingName));
+  }
+  return uses.every((use) => use === "OtherField") ? Option_exports.some(unreadElementFieldMessage(bindingName)) : Option_exports.none();
+};
+var executeDiagnostic = (execute) => {
+  const [firstParameter] = execute.params;
+  if (firstParameter === void 0) {
+    return Option_exports.some(NO_ELEMENT_BINDING_MESSAGE);
+  }
+  if (firstParameter.type === "Identifier") {
+    return unpackedDiagnostic(execute, firstParameter.name);
+  }
+  if (firstParameter.type !== "ObjectPattern") {
+    return Option_exports.some(NO_ELEMENT_BINDING_MESSAGE);
+  }
+  return Option_exports.match(elementProperty(firstParameter), {
+    onNone: () => Option_exports.match(restBindingName(firstParameter), {
+      onNone: () => Option_exports.some(NO_ELEMENT_BINDING_MESSAGE),
+      onSome: (restName) => unpackedDiagnostic(execute, restName)
+    }),
+    onSome: (property) => {
+      const pattern = withoutDefault(property.value);
+      return pattern.type === "Identifier" ? bindingDiagnostic(execute, pattern.name) : Option_exports.none();
+    }
+  });
+};
+var executeFunction = (node) => pipe(
+  Array_exports.get(node.arguments, 1),
+  Option_exports.filter(isObjectExpression),
+  Option_exports.flatMap((config) => AST_exports.objectGetValue(config, "execute")),
+  Option_exports.filter(isExecuteFunction)
+);
 var mountFactoryMustUseElement = Rule_exports.define({
   name: "mount-factory-must-use-element",
   meta: Rule_exports.meta({
     type: "suggestion",
-    description: "Require Mount factories to use their live element."
+    description: "Require a Mount's execute to use its live element."
   }),
   create: function* () {
     const ctx = yield* RuleContext;
     return {
       CallExpression: (node) => {
-        if (!isCallExpression(node)) return Effect_exports.void;
-        if (node.callee.type !== "CallExpression" || !isMountDefinitionChain(node.callee)) {
-          return Effect_exports.void;
-        }
-        const [factoryArgument] = node.arguments;
-        if (factoryArgument === void 0 || !isFactoryFunction(factoryArgument)) {
+        if (!isCallExpression(node) || !AST_exports.isCallOf(node, "Mount", MOUNT_DEFINITION_METHODS)) {
           return Effect_exports.void;
         }
-        const elementFactory = descendToElementFactory(factoryArgument);
-        return Option_exports.match(elementFactoryDiagnostic(elementFactory), {
+        return Option_exports.match(executeFunction(node), {
           onNone: () => Effect_exports.void,
-          onSome: (message) => ctx.report(Diagnostic_exports.make({ node: elementFactory, message }))
+          onSome: (execute) => Option_exports.match(executeDiagnostic(execute), {
+            onNone: () => Effect_exports.void,
+            onSome: (message) => ctx.report(Diagnostic_exports.make({ node: execute, message }))
+          })
         });
       }
     };
@@ -11456,7 +11498,7 @@ var noDisablingDevGuardrails = Rule_exports.define({
 });
 
 // src/rules/no-duplicate-onmount-per-element.ts
-var DUPLICATE_ON_MOUNT_MESSAGE = "Only one OnMount attribute can attach to an element. Foldkit installs a single insert hook and tracks a single Mount fiber per element, so a later OnMount replaces the earlier one and its factory never runs. Combine the behaviors into one Mount definition.";
+var DUPLICATE_ON_MOUNT_MESSAGE = "Only one OnMount attribute can attach to an element. Foldkit installs a single insert hook and tracks a single Mount fiber per element, so a later OnMount replaces the earlier one and its `execute` never runs. Combine the behaviors into one Mount definition.";
 var isOnMountCallee = (callee) => {
   if (callee.type === "Identifier") {
     return callee.name === "OnMount";

package/dist/rules/mount-factory-must-use-element.d.ts

@@ -1,3 +1,3 @@
-/** Flags applied Mount.define and Mount.defineStream factories that never use their element parameter. A Mount exists for element-caused, element-targeted work; a factory that ignores the element belongs in a Command, Subscription, or ManagedResource. */
+/** Flags Mount.define and Mount.defineStream definitions whose `execute` never uses its element. A Mount exists for element-caused, element-targeted work; work that ignores the element belongs in a Command, Subscription, or ManagedResource. */
 export declare const mountFactoryMustUseElement: import("effect-oxlint").CreateRule;
 //# sourceMappingURL=mount-factory-must-use-element.d.ts.map

package/dist/rules/mount-factory-must-use-element.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"mount-factory-must-use-element.d.ts","sourceRoot":"","sources":["../../src/rules/mount-factory-must-use-element.ts"],"names":[],"mappings":"AA4GA,+PAA+P;AAC/P,eAAO,MAAM,0BAA0B,oCAiCrC,CAAA"}
+{"version":3,"file":"mount-factory-must-use-element.d.ts","sourceRoot":"","sources":["../../src/rules/mount-factory-must-use-element.ts"],"names":[],"mappings":"AA0NA,oPAAoP;AACpP,eAAO,MAAM,0BAA0B,oCA4BrC,CAAA"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@foldkit/oxlint-plugin",
-  "version": "0.10.0-canary.db46ded8d159",
+  "version": "0.10.0-canary.dc82c7255dbf",
   "description": "Oxlint rules for Foldkit applications",
   "type": "module",
   "main": "./dist/index.js",
@@ -15,15 +15,15 @@
     "./all.json": "./all.json"
   },
   "dependencies": {
-    "effect-oxlint": "^0.3.2"
+    "effect-oxlint": "^0.3.3"
   },
   "devDependencies": {
-    "@types/node": "^25.9.3",
+    "@types/node": "^25.9.5",
     "effect": "4.0.0-rc.112",
-    "esbuild": "^0.28.1",
+    "esbuild": "^0.28.2",
     "rimraf": "^6.1.3",
     "typescript": "^6.0.3",
-    "vitest": "^4.1.9"
+    "vitest": "^4.1.11"
   },
   "files": [
     "dist",