@foam-ai/node-cliengo 0.1.0-alpha.5 → 0.1.0-alpha.6

package/dist/node-cliengo/src/logs/pino-destination.d.ts

@@ -21,8 +21,13 @@
  *     60→FATAL. Unknown numeric levels default to INFO.
  *   - Pino uses `msg` for the message field (not `message` like Winston). We
  *     check both for compatibility with custom Pino configs.
- *   - Internal Pino fields (pid, hostname, time) are excluded from attributes
- *     to avoid noise. All other fields are forwarded.
+ *   - Trace context (traceId, spanId, traceparent) is read from the parsed
+ *     JSON line, NOT from getTraceContext(). The pino mixin injects these at
+ *     log-write time (when NR's transaction is still active). The stream write
+ *     happens asynchronously — by then NR's transaction has ended, so calling
+ *     getTraceContext() here would return empty strings.
+ *   - Internal Pino fields (pid, hostname, time) and trace fields (traceId,
+ *     spanId, traceparent) are excluded from forwarded attributes.
  *   - Callback always called — never blocks the Pino stream pipeline.
  *   - Buffer chunks: converted to string before parsing (handles both Buffer
  *     and string inputs from Node streams).

package/dist/node-cliengo/src/logs/pino-destination.js

@@ -22,8 +22,13 @@
  *     60→FATAL. Unknown numeric levels default to INFO.
  *   - Pino uses `msg` for the message field (not `message` like Winston). We
  *     check both for compatibility with custom Pino configs.
- *   - Internal Pino fields (pid, hostname, time) are excluded from attributes
- *     to avoid noise. All other fields are forwarded.
+ *   - Trace context (traceId, spanId, traceparent) is read from the parsed
+ *     JSON line, NOT from getTraceContext(). The pino mixin injects these at
+ *     log-write time (when NR's transaction is still active). The stream write
+ *     happens asynchronously — by then NR's transaction has ended, so calling
+ *     getTraceContext() here would return empty strings.
+ *   - Internal Pino fields (pid, hostname, time) and trace fields (traceId,
+ *     spanId, traceparent) are excluded from forwarded attributes.
  *   - Callback always called — never blocks the Pino stream pipeline.
  *   - Buffer chunks: converted to string before parsing (handles both Buffer
  *     and string inputs from Node streams).
@@ -32,7 +37,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.createPinoDestination = createPinoDestination;
 const api_logs_1 = require("@opentelemetry/api-logs");
 const node_stream_1 = require("node:stream");
-const trace_bridge_1 = require("../trace-bridge");
 const PINO_LEVEL_MAP = {
     10: api_logs_1.SeverityNumber.TRACE,
     20: api_logs_1.SeverityNumber.DEBUG,
@@ -66,16 +70,23 @@ function createPinoDestination(loggerProvider, serviceName) {
                 const msg = parsed.msg ?? parsed.message ?? '';
                 const severity = PINO_LEVEL_MAP[level] ?? api_logs_1.SeverityNumber.INFO;
                 const severityText = PINO_LEVEL_TEXT[level] ?? 'INFO';
-                const ctx = (0, trace_bridge_1.getTraceContext)();
+                // Read trace context from the parsed JSON line — the pino mixin already
+                // injected traceId/spanId/traceparent at log-write time (when the NR
+                // transaction was still active). Calling getTraceContext() here would be
+                // too late — the stream write happens asynchronously after NR's
+                // transaction has ended.
+                const traceId = parsed.traceId ?? '';
+                const spanId = parsed.spanId ?? '';
                 const attributes = {};
-                if (ctx.traceId) {
-                    attributes['trace.id'] = ctx.traceId;
+                if (traceId) {
+                    attributes['trace.id'] = traceId;
                 }
-                if (ctx.spanId) {
-                    attributes['span.id'] = ctx.spanId;
+                if (spanId) {
+                    attributes['span.id'] = spanId;
                 }
+                const SKIP_KEYS = new Set(['level', 'msg', 'message', 'time', 'pid', 'hostname', 'traceId', 'spanId', 'traceparent']);
                 for (const [key, val] of Object.entries(parsed)) {
-                    if (key !== 'level' && key !== 'msg' && key !== 'message' && key !== 'time' && key !== 'pid' && key !== 'hostname') {
+                    if (!SKIP_KEYS.has(key)) {
                         try {
                             attributes[key] = typeof val === 'string' ? val : JSON.stringify(val);
                         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@foam-ai/node-cliengo",
-  "version": "0.1.0-alpha.5",
+  "version": "0.1.0-alpha.6",
   "description": "Unified observability (traces, logs, metrics) for Cliengo Node.js services, connecting New Relic APM with Foam's OTel collector.",
   "main": "dist/node-cliengo/src/index.js",
   "types": "dist/node-cliengo/src/index.d.ts",