@flyingrobots/graft 0.7.0 → 0.8.0

package/src/operations/structural-blame.ts

@@ -1,197 +0,0 @@
-// ---------------------------------------------------------------------------
-// Structural Blame — symbol-level blame: who last changed a symbol's
-// signature, when it was created, and its full change history.
-// ---------------------------------------------------------------------------
-
-import { toJsonObject } from "./result-dto.js";
-import type { JsonObject } from "../contracts/json-object.js";
-
-// ---- Public types ---------------------------------------------------------
-
-export interface CommitInfo {
-  readonly sha: string;
-  readonly author: string;
-  readonly date: string;
-  readonly message: string;
-}
-
-export interface LastSignatureChange extends CommitInfo {
-  readonly previousSignature?: string | undefined;
-}
-
-export interface BlameHistoryEntry {
-  readonly sha: string;
-  readonly changeKind: string;
-  readonly date: string;
-  readonly author: string;
-  readonly signature?: string | undefined;
-}
-
-export interface StructuralBlameResult {
-  readonly symbol: string;
-  readonly filePath?: string | undefined;
-  readonly currentSignature?: string | undefined;
-  readonly kind: string;
-  readonly exported: boolean;
-  readonly created?: CommitInfo | undefined;
-  readonly lastSignatureChange?: LastSignatureChange | undefined;
-  readonly changeCount: number;
-  readonly referenceCount: number;
-  readonly referencingFiles: readonly string[];
-  readonly history: readonly BlameHistoryEntry[];
-}
-
-// ---- Input types ----------------------------------------------------------
-
-/** A single commit entry from the WARP symbol history. */
-export interface SymbolCommitInput {
-  readonly sha: string;
-  readonly changeKind: string;
-  readonly signature?: string | undefined;
-}
-
-/** Git metadata for a commit. */
-export interface CommitMetaInput {
-  readonly author: string;
-  readonly date: string;
-  readonly message: string;
-}
-
-/** Symbol metadata from the most recent commit's WARP observation. */
-export interface SymbolMetaInput {
-  readonly kind: string;
-  readonly exported: boolean;
-}
-
-export interface StructuralBlameInput {
-  readonly symbolName: string;
-  readonly filePath?: string | undefined;
-  /** The symbol's commit history from WARP. */
-  readonly commits: readonly SymbolCommitInput[];
-  /** Git metadata keyed by commit SHA. */
-  readonly commitMeta: ReadonlyMap<string, CommitMetaInput>;
-  /** Symbol kind/exported from the latest WARP observation. */
-  readonly symbolMeta?: SymbolMetaInput | undefined;
-  /** Reference count from the reference-counting query. */
-  readonly referenceCount: number;
-  /** Files referencing this symbol. */
-  readonly referencingFiles: readonly string[];
-}
-
-// ---- Implementation -------------------------------------------------------
-
-export function structuralBlame(input: StructuralBlameInput): StructuralBlameResult {
-  const { symbolName, filePath, commits, commitMeta, symbolMeta, referenceCount, referencingFiles } = input;
-
-  if (commits.length === 0) {
-    return {
-      symbol: symbolName,
-      filePath,
-      kind: symbolMeta?.kind ?? "unknown",
-      exported: symbolMeta?.exported ?? false,
-      changeCount: 0,
-      referenceCount,
-      referencingFiles,
-      history: [],
-    };
-  }
-
-  // Find creation commit (first "added" entry)
-  const creationCommit = commits.find((c) => c.changeKind === "added");
-
-  // Find all "changed" commits
-  const changedCommits = commits.filter((c) => c.changeKind === "changed");
-
-  // Build created info
-  let created: CommitInfo | undefined;
-  if (creationCommit !== undefined) {
-    const meta = commitMeta.get(creationCommit.sha);
-    if (meta !== undefined) {
-      created = { sha: creationCommit.sha, author: meta.author, date: meta.date, message: meta.message };
-    }
-  }
-
-  // Sort all commits by date (most recent first)
-  const sortedDesc = [...commits].sort((a, b) => {
-    const dateA = commitMeta.get(a.sha)?.date ?? "";
-    const dateB = commitMeta.get(b.sha)?.date ?? "";
-    return dateB.localeCompare(dateA);
-  });
-
-  // Sort all commits by date (oldest first)
-  const sortedAsc = [...commits].sort((a, b) => {
-    const dateA = commitMeta.get(a.sha)?.date ?? "";
-    const dateB = commitMeta.get(b.sha)?.date ?? "";
-    return dateA.localeCompare(dateB);
-  });
-
-  // Find last signature change — most recent by date among "changed" commits
-  let lastSignatureChange: LastSignatureChange | undefined;
-  if (changedCommits.length > 0) {
-    const sorted = [...changedCommits].sort((a, b) => {
-      const dateA = commitMeta.get(a.sha)?.date ?? "";
-      const dateB = commitMeta.get(b.sha)?.date ?? "";
-      return dateB.localeCompare(dateA);
-    });
-    const lastChanged = sorted[0];
-    if (lastChanged !== undefined) {
-      const meta = commitMeta.get(lastChanged.sha);
-      if (meta !== undefined) {
-        // Find the previous signature from the commit just before this one
-        const changeIdx = sortedAsc.findIndex((c) => c.sha === lastChanged.sha);
-        let previousSignature: string | undefined;
-        for (let i = changeIdx - 1; i >= 0; i--) {
-          const prev = sortedAsc[i];
-          if (prev?.signature !== undefined) {
-            previousSignature = prev.signature;
-            break;
-          }
-        }
-        lastSignatureChange = {
-          sha: lastChanged.sha,
-          author: meta.author,
-          date: meta.date,
-          message: meta.message,
-          previousSignature,
-        };
-      }
-    }
-  }
-
-  // Get current signature from the most recent commit
-  const mostRecent = sortedDesc[0];
-  const currentSignature = mostRecent?.signature;
-
-  // Build history entries with metadata (most recent first)
-  const historyEntries: BlameHistoryEntry[] = sortedDesc.map((c) => {
-    const meta = commitMeta.get(c.sha);
-    return {
-      sha: c.sha,
-      changeKind: c.changeKind,
-      date: meta?.date ?? "",
-      author: meta?.author ?? "",
-      signature: c.signature,
-    };
-  });
-
-  return {
-    symbol: symbolName,
-    filePath,
-    currentSignature,
-    kind: symbolMeta?.kind ?? "unknown",
-    exported: symbolMeta?.exported ?? false,
-    created,
-    lastSignatureChange,
-    changeCount: commits.length,
-    referenceCount,
-    referencingFiles,
-    history: historyEntries,
-  };
-}
-
-/**
- * Convert a StructuralBlameResult to a plain JsonObject for MCP responses.
- */
-export function structuralBlameToJson(result: StructuralBlameResult): JsonObject {
-  return toJsonObject(result);
-}

package/src/operations/structural-review.ts

@@ -1,317 +0,0 @@
-// ---------------------------------------------------------------------------
-// Structural Review — zero-noise PR review separating signal from formatting
-// ---------------------------------------------------------------------------
-
-import type { FileSystem } from "../ports/filesystem.js";
-import type { GitClient } from "../ports/git.js";
-import { graftDiff, type FileDiff, type GraftDiffOptions } from "./graft-diff.js";
-import { getChangedFilesWithStatus } from "../git/diff.js";
-
-// ---- Public types ---------------------------------------------------------
-
-export interface ReferenceCountResult {
-  readonly referenceCount: number;
-  readonly referencingFiles: readonly string[];
-}
-
-export type ReferenceCounter = (
-  symbolName: string,
-  filePath: string,
-) => Promise<ReferenceCountResult>;
-
-
-export type ReviewCategory = "structural" | "formatting" | "test" | "docs" | "config";
-
-export interface ReviewFile {
-  readonly path: string;
-  readonly category: ReviewCategory;
-  readonly structuralChanges?: { added: number; removed: number; changed: number };
-}
-
-export interface BreakingChange {
-  readonly symbol: string;
-  readonly kind: string;
-  readonly filePath: string;
-  readonly changeType: "removed_export" | "signature_changed" | "type_changed";
-  readonly previousSignature?: string;
-  readonly newSignature?: string;
-  readonly impactedFiles: number;
-  readonly impactedFilePaths: readonly string[];
-}
-
-export interface StructuralReviewResult {
-  readonly base: string;
-  readonly head: string;
-  readonly totalFiles: number;
-  readonly categories: Record<ReviewCategory, number>;
-  readonly files: readonly ReviewFile[];
-  readonly breakingChanges: readonly BreakingChange[];
-  readonly summary: string;
-}
-
-export interface StructuralReviewOptions {
-  readonly cwd: string;
-  readonly fs: FileSystem;
-  readonly git: GitClient;
-  readonly resolveWorkingTreePath: (filePath: string) => string;
-  readonly base?: string | undefined;
-  readonly head?: string | undefined;
-  readonly countReferences: ReferenceCounter;
-}
-
-// ---- File categorization --------------------------------------------------
-
-const CONFIG_PATTERNS = [
-  "package.json",
-  "tsconfig",
-  "eslint",
-  ".prettierrc",
-  ".editorconfig",
-  "vitest.config",
-  "jest.config",
-  "rollup.config",
-  "vite.config",
-  "webpack.config",
-  "babel.config",
-  ".babelrc",
-  ".npmrc",
-  ".nvmrc",
-  ".gitignore",
-  ".gitattributes",
-  "pnpm-lock.yaml",
-  "pnpm-workspace.yaml",
-  "yarn.lock",
-  "package-lock.json",
-  "Makefile",
-  "Dockerfile",
-  "docker-compose",
-];
-
-const TEST_PATTERNS = [
-  "/test/",
-  "/tests/",
-  "/__tests__/",
-  ".test.",
-  ".spec.",
-  "_test.",
-];
-
-function isTestFile(filePath: string): boolean {
-  return TEST_PATTERNS.some((p) => filePath.includes(p));
-}
-
-function isDocsFile(filePath: string): boolean {
-  return filePath.endsWith(".md") || filePath.endsWith(".txt") || filePath.endsWith(".rst");
-}
-
-function isConfigFile(filePath: string): boolean {
-  const lower = filePath.toLowerCase();
-  return CONFIG_PATTERNS.some((p) => lower.includes(p));
-}
-
-// ---- Breaking change detection --------------------------------------------
-
-async function detectBreakingChanges(
-  structuralFiles: readonly FileDiff[],
-  countReferences: ReferenceCounter,
-): Promise<BreakingChange[]> {
-  const breaking: BreakingChange[] = [];
-
-  for (const file of structuralFiles) {
-    // Removed exports → breaking
-    for (const removed of file.diff.removed) {
-      if (removed.exported !== true) continue;
-      const refs = await countReferences(removed.name, file.path);
-      breaking.push({
-        symbol: removed.name,
-        kind: removed.kind,
-        filePath: file.path,
-        changeType: "removed_export",
-        ...(removed.signature !== undefined ? { previousSignature: removed.signature } : {}),
-        impactedFiles: refs.referenceCount,
-        impactedFilePaths: refs.referencingFiles,
-      });
-    }
-
-    // Changed exported symbol signatures → potentially breaking
-    for (const changed of file.diff.changed) {
-      if (changed.exported !== true) continue;
-      if (changed.oldSignature !== undefined && changed.signature !== undefined &&
-          changed.oldSignature !== changed.signature) {
-        const refs = await countReferences(changed.name, file.path);
-        breaking.push({
-          symbol: changed.name,
-          kind: changed.kind,
-          filePath: file.path,
-          changeType: "signature_changed",
-          previousSignature: changed.oldSignature,
-          newSignature: changed.signature,
-          impactedFiles: refs.referenceCount,
-          impactedFilePaths: refs.referencingFiles,
-        });
-      }
-    }
-  }
-
-  return breaking;
-}
-
-// ---- Summary rendering ----------------------------------------------------
-
-function renderSummary(
-  base: string,
-  head: string,
-  categories: Record<ReviewCategory, number>,
-  breakingChanges: readonly BreakingChange[],
-  totalFiles: number,
-  structuralFiles: readonly FileDiff[],
-): string {
-  const parts: string[] = [];
-  parts.push(`PR Review: ${base}..${head} — ${String(totalFiles)} files changed`);
-  parts.push("");
-
-  // Structural details
-  if (categories.structural > 0) {
-    const totalAdded = structuralFiles.reduce((n, f) => n + f.diff.added.length, 0);
-    const totalChanged = structuralFiles.reduce((n, f) => n + f.diff.changed.length, 0);
-    const totalRemoved = structuralFiles.reduce((n, f) => n + f.diff.removed.length, 0);
-    const details: string[] = [];
-    if (totalAdded > 0) details.push(`${String(totalAdded)} new exports`);
-    if (totalChanged > 0) details.push(`${String(totalChanged)} sig changes`);
-    if (totalRemoved > 0) details.push(`${String(totalRemoved)} removed`);
-    const suffix = details.length > 0 ? ` (${details.join(", ")})` : "";
-    parts.push(`  Structural: ${String(categories.structural)} files${suffix}`);
-  }
-  if (categories.formatting > 0) {
-    parts.push(`  Formatting: ${String(categories.formatting)} files`);
-  }
-  if (categories.test > 0) {
-    parts.push(`  Tests: ${String(categories.test)} files`);
-  }
-  if (categories.docs > 0) {
-    parts.push(`  Docs: ${String(categories.docs)} files`);
-  }
-  if (categories.config > 0) {
-    parts.push(`  Config: ${String(categories.config)} files`);
-  }
-
-  // Breaking changes
-  for (const bc of breakingChanges) {
-    parts.push("");
-    if (bc.changeType === "removed_export") {
-      parts.push(`  ⚠ BREAKING: ${bc.symbol} — removed export`);
-      if (bc.previousSignature !== undefined) {
-        parts.push(`    Was: ${bc.previousSignature}`);
-      }
-    } else {
-      parts.push(`  ⚠ BREAKING: ${bc.symbol} — signature changed`);
-      if (bc.previousSignature !== undefined) {
-        parts.push(`    Was: ${bc.previousSignature}`);
-      }
-      if (bc.newSignature !== undefined) {
-        parts.push(`    Now: ${bc.newSignature}`);
-      }
-    }
-    parts.push(`    Impact: referenced by ${String(bc.impactedFiles)} files`);
-  }
-
-  return parts.join("\n");
-}
-
-// ---- Public API -----------------------------------------------------------
-
-export async function structuralReview(
-  opts: StructuralReviewOptions,
-): Promise<StructuralReviewResult> {
-  const base = opts.base ?? "main";
-  const head = opts.head ?? "HEAD";
-
-  // 1. Get structural diff
-  const diffOpts: GraftDiffOptions = {
-    cwd: opts.cwd,
-    fs: opts.fs,
-    git: opts.git,
-    resolveWorkingTreePath: opts.resolveWorkingTreePath,
-    base,
-    head,
-  };
-  const structDiff = await graftDiff(diffOpts);
-
-  // 2. Get ALL changed files with rename detection
-  const allChangedEntries = await getChangedFilesWithStatus({
-    cwd: opts.cwd,
-    git: opts.git,
-    base,
-    head,
-  });
-  const allChangedPaths = allChangedEntries.map((e) => e.path);
-
-  // 3. Build set of structurally-changed file paths
-  const structuralPaths = new Set(structDiff.files.map((f) => f.path));
-
-  // 4. Categorize each changed file
-  const files: ReviewFile[] = [];
-  for (const filePath of allChangedPaths) {
-    // Check if the file has actual structural (symbol-level) changes
-    const fileDiff = structuralPaths.has(filePath)
-      ? structDiff.files.find((f) => f.path === filePath)
-      : undefined;
-    const diff = fileDiff?.diff;
-    const hasStructuralChanges = diff !== undefined &&
-      (diff.added.length > 0 || diff.removed.length > 0 || diff.changed.length > 0);
-
-    if (hasStructuralChanges) {
-      files.push({
-        path: filePath,
-        category: "structural",
-        structuralChanges: { added: diff.added.length, removed: diff.removed.length, changed: diff.changed.length },
-      });
-    } else if (isTestFile(filePath)) {
-      files.push({ path: filePath, category: "test" });
-    } else if (isDocsFile(filePath)) {
-      files.push({ path: filePath, category: "docs" });
-    } else if (isConfigFile(filePath)) {
-      files.push({ path: filePath, category: "config" });
-    } else {
-      files.push({ path: filePath, category: "formatting" });
-    }
-  }
-
-  // 5. Count categories
-  const categories: Record<ReviewCategory, number> = {
-    structural: 0,
-    formatting: 0,
-    test: 0,
-    docs: 0,
-    config: 0,
-  };
-  for (const file of files) {
-    categories[file.category]++;
-  }
-
-  // 6. Detect breaking changes in structural files
-  const structuralFileDiffs = structDiff.files.filter((f) =>
-    f.diff.removed.length > 0 || f.diff.changed.length > 0,
-  );
-  const breakingChanges = await detectBreakingChanges(structuralFileDiffs, opts.countReferences);
-
-  // 7. Render summary
-  const summary = renderSummary(
-    base,
-    head,
-    categories,
-    breakingChanges,
-    allChangedPaths.length,
-    structDiff.files,
-  );
-
-  return {
-    base,
-    head,
-    totalFiles: allChangedPaths.length,
-    categories,
-    files,
-    breakingChanges,
-    summary,
-  };
-}