@flusys/nestjs-auth 1.1.0-beta → 2.0.0

package/fesm/modules/auth.module.js

@@ -5,98 +5,57 @@ function _ts_decorate(decorators, target, key, desc) {
     return c > 3 && r && Object.defineProperty(target, key, r), r;
 }
 import { CacheModule, UtilsModule } from '@flusys/nestjs-shared/modules';
-import { Module, Scope } from '@nestjs/common';
+import { Module } from '@nestjs/common';
 import { JwtModule } from '@nestjs/jwt';
 import { PassportModule } from '@nestjs/passport';
-import { getRepositoryToken } from '@nestjs/typeorm';
-import { AuthConfigService } from '../services/auth-config.service';
-import { AuthDataSourceProvider } from '../services/auth-datasource.provider';
+import { JwtAuthGuard } from '@flusys/nestjs-shared/guards';
 import { AUTH_MODULE_OPTIONS } from '../config/auth.constants';
 import { AuthenticationController, BranchController, CompanyController, CompanySelectionController, UserController, UserPermissionController } from '../controllers';
 import { Company, CompanyBranch, User, UserCompanyPermission } from '../entities';
-import { JwtAuthGuard } from '@flusys/nestjs-shared/guards';
 import { ClearToken } from '../interceptors/clear-token.interceptor';
 import { SetToken } from '../interceptors/set-token.interceptor';
 import { AuthEmailService, AuthenticationService, BranchService, CompanySelectionSessionService, CompanyService, UserPermissionService, UserService } from '../services';
+import { AuthConfigService } from '../services/auth-config.service';
+import { AuthDataSourceProvider } from '../services/auth-datasource.provider';
 import { JwtStrategy } from '../strategies/jwt.strategy';
 export class AuthModule {
     static forRoot(options) {
-        return this.buildDynamicModule(options);
+        const optionsProvider = {
+            provide: AUTH_MODULE_OPTIONS,
+            useValue: options
+        };
+        return this.buildModule(options, [
+            optionsProvider,
+            ...options.providers ?? []
+        ]);
     }
-    static forRootAsync(asyncOptions) {
-        const { global = false, includeController = true, bootstrapAppConfig: { enableCompanyFeature } = {}, imports: externalImports = [], providers: additionalProviders = [] } = asyncOptions;
-        const asyncProviders = this.createAsyncProviders(asyncOptions);
-        // Build imports
-        const imports = [
-            ...externalImports,
-            PassportModule.register({
-                defaultStrategy: 'jwt'
-            }),
-            JwtModule.register({}),
-            CacheModule,
-            UtilsModule
-        ];
-        // Build controllers based on configuration
-        const controllers = [];
-        if (includeController) {
-            // Core authentication controller (always included)
-            controllers.push(AuthenticationController);
-            // User controller (always included)
-            controllers.push(UserController);
-            // Company feature controllers (conditional)
-            if (enableCompanyFeature) {
-                controllers.push(CompanySelectionController, CompanyController, BranchController, UserPermissionController);
-            }
-        }
-        // Build providers
-        const providers = [
+    static forRootAsync(options) {
+        const asyncProviders = this.createAsyncProviders(options);
+        return this.buildModule(options, [
             ...asyncProviders,
-            ...additionalProviders,
-            // Config & Infrastructure
-            AuthConfigService,
-            AuthDataSourceProvider,
-            // Auth core
-            JwtStrategy,
-            JwtAuthGuard,
-            AuthenticationService,
-            AuthEmailService,
-            // Interceptors
-            SetToken,
-            ClearToken,
-            // Core services (always included)
-            UserService
-        ];
-        // Company feature services (conditional)
-        if (enableCompanyFeature) {
-            providers.push(CompanySelectionSessionService, CompanyService, BranchService, UserPermissionService);
-        }
-        // Build exports
-        const exports = [
-            PassportModule,
-            AUTH_MODULE_OPTIONS,
-            AuthConfigService,
-            AuthDataSourceProvider,
-            JwtStrategy,
-            JwtAuthGuard,
-            AuthenticationService,
-            AuthEmailService,
-            UserService
-        ];
-        if (enableCompanyFeature) {
-            exports.push(CompanySelectionSessionService, CompanyService, BranchService, UserPermissionService);
-        }
+            ...options.providers ?? []
+        ], options.imports);
+    }
+    /** Build the dynamic module with shared logic */ static buildModule(options, providers, externalImports = []) {
+        const { global = false, includeController = true, bootstrapAppConfig } = options;
+        const enableCompanyFeature = bootstrapAppConfig?.enableCompanyFeature ?? false;
         return {
             module: AuthModule,
             global,
-            imports,
-            controllers,
-            providers,
-            exports
+            imports: [
+                ...externalImports,
+                ...this.buildImports()
+            ],
+            controllers: this.buildControllers(includeController, enableCompanyFeature),
+            providers: [
+                ...providers,
+                ...this.buildProviders(enableCompanyFeature)
+            ],
+            exports: this.buildExports(enableCompanyFeature)
         };
     }
-    static buildDynamicModule(options) {
-        const { bootstrapAppConfig: { enableCompanyFeature } = {}, includeController = true, global = false, providers: additionalProviders = [] } = options;
-        const imports = [
+    /** Common module imports */ static buildImports() {
+        return [
             PassportModule.register({
                 defaultStrategy: 'jwt'
             }),
@@ -104,42 +63,36 @@ export class AuthModule {
             CacheModule,
             UtilsModule
         ];
-        // Build controllers based on configuration
-        const controllers = [];
-        if (includeController) {
-            // Core authentication controller (always included)
-            controllers.push(AuthenticationController);
-            // User controller (always included)
-            controllers.push(UserController);
-            // Company feature controllers (conditional)
-            if (enableCompanyFeature) {
-                controllers.push(CompanySelectionController, CompanyController, BranchController, UserPermissionController);
-            }
+    }
+    /** Build controllers based on feature flags */ static buildControllers(includeController, enableCompanyFeature) {
+        if (!includeController) return [];
+        const controllers = [
+            AuthenticationController,
+            UserController
+        ];
+        if (enableCompanyFeature) {
+            controllers.push(CompanySelectionController, CompanyController, BranchController, UserPermissionController);
         }
+        return controllers;
+    }
+    /** Core providers (without AUTH_MODULE_OPTIONS - that's added separately) */ static buildProviders(enableCompanyFeature) {
         const providers = [
-            {
-                provide: AUTH_MODULE_OPTIONS,
-                useValue: options
-            },
-            ...additionalProviders,
-            // Config & Infrastructure
             AuthConfigService,
             AuthDataSourceProvider,
-            // Auth core
             JwtStrategy,
             JwtAuthGuard,
             AuthenticationService,
             AuthEmailService,
-            // Interceptors
             SetToken,
             ClearToken,
-            // Core services (always included)
             UserService
         ];
-        // Company feature services (conditional)
         if (enableCompanyFeature) {
             providers.push(CompanySelectionSessionService, CompanyService, BranchService, UserPermissionService);
         }
+        return providers;
+    }
+    /** Build module exports */ static buildExports(enableCompanyFeature) {
         const exports = [
             PassportModule,
             AUTH_MODULE_OPTIONS,
@@ -154,16 +107,9 @@ export class AuthModule {
         if (enableCompanyFeature) {
             exports.push(CompanySelectionSessionService, CompanyService, BranchService, UserPermissionService);
         }
-        return {
-            module: AuthModule,
-            global,
-            imports,
-            controllers,
-            providers,
-            exports
-        };
+        return exports;
     }
-    static createAsyncProviders(options) {
+    /** Create async providers for forRootAsync */ static createAsyncProviders(options) {
         const staticOptions = {
             global: options.global,
             includeController: options.includeController,
@@ -173,13 +119,10 @@ export class AuthModule {
             return [
                 {
                     provide: AUTH_MODULE_OPTIONS,
-                    useFactory: async (...args)=>{
-                        const config = await options.useFactory(...args);
-                        return {
+                    useFactory: async (...args)=>({
                             ...staticOptions,
-                            config
-                        };
-                    },
+                            config: await options.useFactory(...args)
+                        }),
                     inject: options.inject || []
                 }
             ];
@@ -192,13 +135,10 @@ export class AuthModule {
                 },
                 {
                     provide: AUTH_MODULE_OPTIONS,
-                    useFactory: async (factory)=>{
-                        const config = await factory.createAuthOptions();
-                        return {
+                    useFactory: async (factory)=>({
                             ...staticOptions,
-                            config
-                        };
-                    },
+                            config: await factory.createAuthOptions()
+                        }),
                     inject: [
                         options.useClass
                     ]
@@ -209,13 +149,10 @@ export class AuthModule {
             return [
                 {
                     provide: AUTH_MODULE_OPTIONS,
-                    useFactory: async (factory)=>{
-                        const config = await factory.createAuthOptions();
-                        return {
+                    useFactory: async (factory)=>({
                             ...staticOptions,
-                            config
-                        };
-                    },
+                            config: await factory.createAuthOptions()
+                        }),
                     inject: [
                         options.useExisting
                     ]
@@ -229,35 +166,14 @@ export class AuthModule {
             }
         ];
     }
-    /**
-   * Create repository providers that use AuthDataSourceProvider
-   * This replaces TypeOrmModule.forFeature() functionality
-   * Note: Must be REQUEST-scoped since AuthDataSourceProvider is REQUEST-scoped
-   */ static getRepositoryProviders(enableCompanyFeature) {
-        const entities = this.getEntities(enableCompanyFeature);
-        return entities.map((entity)=>({
-                provide: getRepositoryToken(entity),
-                scope: Scope.REQUEST,
-                useFactory: async (dataSourceProvider)=>{
-                    return await dataSourceProvider.getRepository(entity);
-                },
-                inject: [
-                    AuthDataSourceProvider
-                ]
-            }));
-    }
-    static getEntities(enableCompanyFeature = false) {
-        const coreEntities = [
-            User
-        ];
-        const companyEntities = enableCompanyFeature ? [
+    /** Get auth entities based on feature flags */ static getEntities(enableCompanyFeature = false) {
+        return enableCompanyFeature ? [
+            User,
             Company,
             CompanyBranch,
             UserCompanyPermission
-        ] : [];
-        return [
-            ...coreEntities,
-            ...companyEntities
+        ] : [
+            User
         ];
     }
 }

package/fesm/services/auth-config.service.js

@@ -25,30 +25,43 @@ function _ts_param(paramIndex, decorator) {
         decorator(target, key, paramIndex);
     };
 }
-import { Inject, Injectable, Optional } from '@nestjs/common';
-import { AuthModuleOptions } from '../interfaces/auth-module-options.interface';
+import { Inject, Injectable, InternalServerErrorException, Logger, Optional } from '@nestjs/common';
 import { AUTH_MODULE_OPTIONS } from '../config/auth.constants';
+import { AuthModuleOptions } from '../interfaces/auth-module-options.interface';
 export class AuthConfigService {
-    // Database Mode
-    /** Get database mode (single or multi-tenant) */ getDatabaseMode() {
+    // Database Mode (required by IModuleConfigService)
+    getDatabaseMode() {
         return this.options.bootstrapAppConfig?.databaseMode ?? 'single';
     }
-    /** Check if running in multi-tenant mode */ isMultiTenant() {
+    isMultiTenant() {
         return this.getDatabaseMode() === 'multi-tenant';
     }
     // Feature Flags
-    /** Check if company feature is enabled */ isCompanyFeatureEnabled() {
+    isCompanyFeatureEnabled() {
         return this.options.bootstrapAppConfig?.enableCompanyFeature ?? false;
     }
     // JWT Configuration
     /** Get JWT secret key */ getJwtSecret() {
-        return this.config.jwtSecret ?? 'default-secret-change-in-production';
+        if (!this.config.jwtSecret) {
+            throw new InternalServerErrorException('[AuthModule] JWT_SECRET is required - set via environment or module config');
+        }
+        return this.config.jwtSecret;
     }
     /** Get JWT expiration time */ getJwtExpiration() {
         return this.config.jwtExpiration ?? '1h';
     }
     /** Get refresh token secret key */ getRefreshTokenSecret() {
-        return this.config.refreshTokenSecret ?? this.getJwtSecret();
+        if (this.config.refreshTokenSecret) {
+            return this.config.refreshTokenSecret;
+        }
+        if (process.env.NODE_ENV === 'production') {
+            throw new InternalServerErrorException('[AuthModule] REFRESH_TOKEN_SECRET is required in production - ' + 'using the same secret for access and refresh tokens is a security risk');
+        }
+        if (!this.refreshTokenSecretWarned) {
+            this.refreshTokenSecretWarned = true;
+            this.logger.warn('REFRESH_TOKEN_SECRET not configured - using JWT_SECRET as fallback. ' + 'For better security, configure a separate refresh token secret.');
+        }
+        return this.getJwtSecret();
     }
     /** Get refresh token expiration time */ getRefreshTokenExpiration() {
         return this.config.refreshTokenExpiration ?? '7d';
@@ -60,30 +73,11 @@ export class AuthConfigService {
     /** Get frontend URL for email links */ getFrontendUrl() {
         return this.config.frontendUrl;
     }
-    // Database Configuration
-    /** Get default database config */ getDefaultDatabaseConfig() {
-        return this.config.defaultDatabaseConfig ?? this.config.tenantDefaultDatabaseConfig;
-    }
-    /** Get tenant default database config (for multi-tenant) */ getTenantDefaultDatabaseConfig() {
-        return this.config.tenantDefaultDatabaseConfig;
-    }
-    /** Get registered tenants */ getTenants() {
-        return this.config.tenants ?? [];
-    }
-    // Raw Options
-    /** Get full module options */ getOptions() {
-        return {
-            ...this.options
-        };
-    }
-    /** Get runtime config */ getConfig() {
-        return {
-            ...this.config
-        };
-    }
     constructor(injectedOptions){
+        _define_property(this, "logger", new Logger(AuthConfigService.name));
         _define_property(this, "options", void 0);
         _define_property(this, "config", void 0);
+        _define_property(this, "refreshTokenSecretWarned", false);
         this.options = injectedOptions ?? {
             global: false,
             includeController: true

package/fesm/services/auth-datasource.provider.js

@@ -26,7 +26,7 @@ function _ts_param(paramIndex, decorator) {
     };
 }
 import { MultiTenantDataSourceService } from '@flusys/nestjs-shared/modules';
-import { Inject, Injectable, Logger, Optional, Scope } from '@nestjs/common';
+import { Inject, Injectable, InternalServerErrorException, Logger, Optional, Scope } from '@nestjs/common';
 import { REQUEST } from '@nestjs/core';
 import { Request } from 'express';
 import { AuthModuleOptions } from '../interfaces/auth-module-options.interface';
@@ -41,7 +41,7 @@ export class AuthDataSourceProvider extends MultiTenantDataSourceService {
             const lockPromise = (async ()=>{
                 const config = this.getDefaultDatabaseConfig();
                 if (!config) {
-                    throw new Error('Default database config is not available');
+                    throw new InternalServerErrorException('Default database config is not available');
                 }
                 const ds = await this.createDataSourceFromConfig(config);
                 AuthDataSourceProvider.singleDataSource = ds;
@@ -90,40 +90,28 @@ export class AuthDataSourceProvider extends MultiTenantDataSourceService {
         };
     }
     // Feature Flags
-    /** Get global enable company feature flag */ getEnableCompanyFeature() {
-        return this.authOptions.bootstrapAppConfig?.enableCompanyFeature ?? false;
-    }
-    /** Get enable company feature for specific tenant. Falls back to global setting. */ getEnableCompanyFeatureForTenant(tenant) {
-        return tenant?.enableCompanyFeature ?? this.getEnableCompanyFeature();
-    }
-    /** Get enable company feature for current request context */ getEnableCompanyFeatureForCurrentTenant() {
-        return this.getEnableCompanyFeatureForTenant(this.getCurrentTenant() ?? undefined);
+    /** Check if company feature is enabled (tenant-specific or global fallback) */ isCompanyFeatureEnabled(tenant) {
+        const effectiveTenant = tenant ?? this.getCurrentTenant();
+        return effectiveTenant?.enableCompanyFeature ?? this.authOptions.bootstrapAppConfig?.enableCompanyFeature ?? false;
     }
     // Entity Management
-    /** Get auth entities based on company feature flag */ async getAuthEntities(enableCompanyFeature) {
-        const enable = enableCompanyFeature ?? this.getEnableCompanyFeature();
+    /** Get auth entities based on company feature flag */ async getAuthEntities() {
         const { Company, CompanyBranch, User, UserCompanyPermission, UserToken, PendingRegistration } = await import('../entities');
         const coreEntities = [
             User,
             UserToken,
             PendingRegistration
         ];
-        const companyEntities = enable ? [
+        return this.isCompanyFeatureEnabled() ? [
+            ...coreEntities,
             Company,
             CompanyBranch,
             UserCompanyPermission
-        ] : [];
-        return [
-            ...coreEntities,
-            ...companyEntities
-        ];
+        ] : coreEntities;
     }
     // Overrides
     /** Override to dynamically set entities based on tenant config */ async createDataSourceFromConfig(config) {
-        const currentTenant = this.getCurrentTenant();
-        const enableCompanyFeature = this.getEnableCompanyFeatureForTenant(currentTenant ?? undefined);
-        const entities = await this.getAuthEntities(enableCompanyFeature);
-        return super.createDataSourceFromConfig(config, entities);
+        return super.createDataSourceFromConfig(config, await this.getAuthEntities());
     }
     constructor(authOptions, request){
         super(AuthDataSourceProvider.buildParentOptions(authOptions), request), _define_property(this, "authOptions", void 0), _define_property(this, "logger", void 0), this.authOptions = authOptions, this.logger = new Logger(AuthDataSourceProvider.name);