@fluidframework/tree 2.81.0-374083 → 2.81.1

package/dist/feature-libraries/sequence-field/moveEffectTable.d.ts

@@ -2,11 +2,63 @@
  * Copyright (c) Microsoft Corporation and contributors. All rights reserved.
  * Licensed under the MIT License.
  */
+import type { ChangeAtomId, RevisionTag, TaggedChange } from "../../core/index.js";
+import { type RangeQueryResult } from "../../util/index.js";
+import { type CrossFieldManager, CrossFieldTarget, type NodeId } from "../modular-schema/index.js";
 import type { MoveMarkEffect } from "./helperTypes.js";
-import type { Attach, CellMark, Mark, MarkEffect } from "./types.js";
+import type { CellMark, Detach, Mark, MarkEffect, MoveId, MoveIn, MoveOut } from "./types.js";
+export type MoveEffectTable = CrossFieldManager<MoveEffect>;
+/**
+ * Changes to be applied to a move mark.
+ */
+export interface MoveEffect {
+    /**
+     * Node changes which should be applied to this mark.
+     * If this mark already has node changes, `modifyAfter` should be composed as later changes.
+     */
+    modifyAfter?: NodeId;
+    /**
+     * Only used during rebasing.
+     * An effect from changeset being rebased which should be moved to the same position as this mark.
+     */
+    movedEffect?: Detach;
+    /**
+     * Rebased changes for a node which has been moved to the position of this mark.
+     */
+    rebasedChanges?: NodeId;
+    /**
+     * The ID of the other outer endpoint.
+     * Used when this is the outer endpoint in a move chain which is being composed with another move chain.
+     */
+    endpoint?: ChangeAtomId;
+    /**
+     * The ID of the truncated endpoint.
+     * Used when this mark is the outer endpoint of a chain being composed with a redundant move chain.
+     */
+    truncatedEndpoint?: ChangeAtomId;
+    /**
+     * The ID of the truncated endpoint.
+     * Used when this mark is the inner endpoint of a redundant move chain.
+     */
+    truncatedEndpointForInner?: ChangeAtomId;
+}
+export declare enum MoveEnd {
+    Source = 0,
+    Dest = 1
+}
+export interface MovePartition {
+    id: MoveId;
+    count?: number;
+    replaceWith?: Mark[];
+    modifyAfter?: TaggedChange<NodeId>;
+}
+export declare function setMoveEffect(moveEffects: MoveEffectTable, target: CrossFieldTarget, revision: RevisionTag | undefined, id: MoveId, count: number, effect: MoveEffect, invalidate?: boolean): void;
+export declare function getMoveEffect(moveEffects: MoveEffectTable, target: CrossFieldTarget, revision: RevisionTag | undefined, id: MoveId, count: number, addDependency?: boolean): RangeQueryResult<ChangeAtomId, MoveEffect>;
 export type MoveMark = CellMark<MoveMarkEffect>;
 export declare function isMoveMark(effect: MarkEffect): effect is MoveMarkEffect;
-export declare function getAttach(effect: MarkEffect): Attach | undefined;
-export type NodeRangeQueryFunc = (mark: Mark) => number;
-export declare function splitMarkForMoveEffects(mark: Mark, getLength: NodeRangeQueryFunc): Mark[];
+export declare function isMoveOut(effect: MarkEffect): effect is MoveOut;
+export declare function isMoveIn(effect: MarkEffect): effect is MoveIn;
+export declare function getMoveIn(effect: MarkEffect): MoveIn | undefined;
+export declare function splitMarkForMoveEffects(mark: Mark, effects: MoveEffectTable): Mark[];
+export declare function getCrossFieldTargetFromMove(mark: MoveMarkEffect): CrossFieldTarget;
 //# sourceMappingURL=moveEffectTable.d.ts.map

package/dist/feature-libraries/sequence-field/moveEffectTable.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"moveEffectTable.d.ts","sourceRoot":"","sources":["../../../src/feature-libraries/sequence-field/moveEffectTable.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAC;AACvD,OAAO,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,YAAY,CAAC;AAGrE,MAAM,MAAM,QAAQ,GAAG,QAAQ,CAAC,cAAc,CAAC,CAAC;AAEhD,wBAAgB,UAAU,CAAC,MAAM,EAAE,UAAU,GAAG,MAAM,IAAI,cAAc,CAEvE;AAED,wBAAgB,SAAS,CAAC,MAAM,EAAE,UAAU,GAAG,MAAM,GAAG,SAAS,CAShE;AAED,MAAM,MAAM,kBAAkB,GAAG,CAAC,IAAI,EAAE,IAAI,KAAK,MAAM,CAAC;AAExD,wBAAgB,uBAAuB,CAAC,IAAI,EAAE,IAAI,EAAE,SAAS,EAAE,kBAAkB,GAAG,IAAI,EAAE,CAGzF"}
+{"version":3,"file":"moveEffectTable.d.ts","sourceRoot":"","sources":["../../../src/feature-libraries/sequence-field/moveEffectTable.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAIH,OAAO,KAAK,EAAE,YAAY,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AACnF,OAAO,EAAE,KAAK,gBAAgB,EAAS,MAAM,qBAAqB,CAAC;AACnE,OAAO,EACN,KAAK,iBAAiB,EACtB,gBAAgB,EAChB,KAAK,MAAM,EACX,MAAM,4BAA4B,CAAC;AAEpC,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,kBAAkB,CAAC;AACvD,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,YAAY,CAAC;AAG9F,MAAM,MAAM,eAAe,GAAG,iBAAiB,CAAC,UAAU,CAAC,CAAC;AAE5D;;GAEG;AACH,MAAM,WAAW,UAAU;IAC1B;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;OAEG;IACH,cAAc,CAAC,EAAE,MAAM,CAAC;IAExB;;;OAGG;IACH,QAAQ,CAAC,EAAE,YAAY,CAAC;IAExB;;;OAGG;IACH,iBAAiB,CAAC,EAAE,YAAY,CAAC;IAEjC;;;OAGG;IACH,yBAAyB,CAAC,EAAE,YAAY,CAAC;CACzC;AAUD,oBAAY,OAAO;IAClB,MAAM,IAAA;IACN,IAAI,IAAA;CACJ;AAED,MAAM,WAAW,aAAa;IAC7B,EAAE,EAAE,MAAM,CAAC;IAGX,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,WAAW,CAAC,EAAE,IAAI,EAAE,CAAC;IACrB,WAAW,CAAC,EAAE,YAAY,CAAC,MAAM,CAAC,CAAC;CACnC;AAED,wBAAgB,aAAa,CAC5B,WAAW,EAAE,eAAe,EAC5B,MAAM,EAAE,gBAAgB,EACxB,QAAQ,EAAE,WAAW,GAAG,SAAS,EACjC,EAAE,EAAE,MAAM,EACV,KAAK,EAAE,MAAM,EACb,MAAM,EAAE,UAAU,EAClB,UAAU,GAAE,OAAc,GACxB,IAAI,CAGN;AAED,wBAAgB,aAAa,CAC5B,WAAW,EAAE,eAAe,EAC5B,MAAM,EAAE,gBAAgB,EACxB,QAAQ,EAAE,WAAW,GAAG,SAAS,EACjC,EAAE,EAAE,MAAM,EACV,KAAK,EAAE,MAAM,EACb,aAAa,GAAE,OAAc,GAC3B,gBAAgB,CAAC,YAAY,EAAE,UAAU,CAAC,CAK5C;AAED,MAAM,MAAM,QAAQ,GAAG,QAAQ,CAAC,cAAc,CAAC,CAAC;AAEhD,wBAAgB,UAAU,CAAC,MAAM,EAAE,UAAU,GAAG,MAAM,IAAI,cAAc,CAEvE;AAED,wBAAgB,SAAS,CAAC,MAAM,EAAE,UAAU,GAAG,MAAM,IAAI,OAAO,CAE/D;AAED,wBAAgB,QAAQ,CAAC,MAAM,EAAE,UAAU,GAAG,MAAM,IAAI,MAAM,CAE7D;AAED,wBAAgB,SAAS,CAAC,MAAM,EAAE,UAAU,GAAG,MAAM,GAAG,SAAS,CAYhE;AAkCD,wBAAgB,uBAAuB,CAAC,IAAI,EAAE,IAAI,EAAE,OAAO,EAAE,eAAe,GAAG,IAAI,EAAE,CAGpF;AAyBD,wBAAgB,2BAA2B,CAAC,IAAI,EAAE,cAAc,GAAG,gBAAgB,CAalF"}

package/dist/feature-libraries/sequence-field/moveEffectTable.js

@@ -4,26 +4,109 @@
  * Licensed under the MIT License.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.splitMarkForMoveEffects = exports.getAttach = exports.isMoveMark = void 0;
+exports.getCrossFieldTargetFromMove = exports.splitMarkForMoveEffects = exports.getMoveIn = exports.isMoveIn = exports.isMoveOut = exports.isMoveMark = exports.getMoveEffect = exports.setMoveEffect = exports.MoveEnd = void 0;
+const internal_1 = require("@fluidframework/core-utils/internal");
+const index_js_1 = require("../../util/index.js");
+const index_js_2 = require("../modular-schema/index.js");
 const utils_js_1 = require("./utils.js");
+var MoveEnd;
+(function (MoveEnd) {
+    MoveEnd[MoveEnd["Source"] = 0] = "Source";
+    MoveEnd[MoveEnd["Dest"] = 1] = "Dest";
+})(MoveEnd || (exports.MoveEnd = MoveEnd = {}));
+function setMoveEffect(moveEffects, target, revision, id, count, effect, invalidate = true) {
+    effect.basis = id;
+    moveEffects.set(target, revision, id, count, effect, invalidate);
+}
+exports.setMoveEffect = setMoveEffect;
+function getMoveEffect(moveEffects, target, revision, id, count, addDependency = true) {
+    const result = moveEffects.get(target, revision, id, count, addDependency);
+    return result.value === undefined
+        ? result
+        : { ...result, value: adjustMoveEffectBasis(result.value, id) };
+}
+exports.getMoveEffect = getMoveEffect;
 function isMoveMark(effect) {
-    return (0, utils_js_1.isAttach)(effect) || (0, utils_js_1.isDetach)(effect);
+    return isMoveOut(effect) || isMoveIn(effect);
 }
 exports.isMoveMark = isMoveMark;
-function getAttach(effect) {
+function isMoveOut(effect) {
+    return effect.type === "MoveOut";
+}
+exports.isMoveOut = isMoveOut;
+function isMoveIn(effect) {
+    return effect.type === "MoveIn";
+}
+exports.isMoveIn = isMoveIn;
+function getMoveIn(effect) {
     switch (effect.type) {
-        case "Insert": {
+        case "MoveIn": {
             return effect;
         }
+        case "AttachAndDetach": {
+            return getMoveIn(effect.attach);
+        }
         default: {
             return undefined;
         }
     }
 }
-exports.getAttach = getAttach;
-function splitMarkForMoveEffects(mark, getLength) {
-    const length = getLength(mark);
+exports.getMoveIn = getMoveIn;
+function adjustMoveEffectBasis(effect, newBasis) {
+    if (effect.basis === newBasis) {
+        return effect;
+    }
+    const adjusted = { ...effect, basis: newBasis };
+    const basisShift = newBasis - effect.basis;
+    (0, internal_1.assert)(basisShift > 0, 0x812 /* Expected basis shift to be positive */);
+    if (effect.endpoint !== undefined) {
+        adjusted.endpoint = adjustChangeAtomId(effect.endpoint, basisShift);
+    }
+    if (effect.truncatedEndpoint !== undefined) {
+        adjusted.truncatedEndpoint = adjustChangeAtomId(effect.truncatedEndpoint, basisShift);
+    }
+    if (effect.truncatedEndpointForInner !== undefined) {
+        adjusted.truncatedEndpointForInner = adjustChangeAtomId(effect.truncatedEndpointForInner, basisShift);
+    }
+    if (effect.movedEffect !== undefined) {
+        const [_mark1, mark2] = (0, utils_js_1.splitMarkEffect)(effect.movedEffect, basisShift);
+        adjusted.movedEffect = mark2;
+    }
+    return adjusted;
+}
+function splitMarkForMoveEffects(mark, effects) {
+    const length = getFirstMoveEffectLength(mark, mark.count, effects);
     return length < mark.count ? (0, utils_js_1.splitMark)(mark, length) : [mark];
 }
 exports.splitMarkForMoveEffects = splitMarkForMoveEffects;
+function getFirstMoveEffectLength(markEffect, count, effects) {
+    if (isMoveMark(markEffect)) {
+        return getMoveEffect(effects, getCrossFieldTargetFromMove(markEffect), markEffect.revision, markEffect.id, count).length;
+    }
+    else if ((0, utils_js_1.isAttachAndDetachEffect)(markEffect)) {
+        return Math.min(getFirstMoveEffectLength(markEffect.attach, count, effects), getFirstMoveEffectLength(markEffect.detach, count, effects));
+    }
+    return count;
+}
+function getCrossFieldTargetFromMove(mark) {
+    const type = mark.type;
+    switch (type) {
+        case "MoveIn": {
+            return index_js_2.CrossFieldTarget.Destination;
+        }
+        case "MoveOut": {
+            return index_js_2.CrossFieldTarget.Source;
+        }
+        default: {
+            (0, internal_1.unreachableCase)(type);
+        }
+    }
+}
+exports.getCrossFieldTargetFromMove = getCrossFieldTargetFromMove;
+function adjustChangeAtomId(id, shift) {
+    return {
+        ...id,
+        localId: (0, index_js_1.brand)(id.localId + shift),
+    };
+}
 //# sourceMappingURL=moveEffectTable.js.map

package/dist/feature-libraries/sequence-field/moveEffectTable.js.map

@@ -1 +1 @@
-{"version":3,"file":"moveEffectTable.js","sourceRoot":"","sources":["../../../src/feature-libraries/sequence-field/moveEffectTable.ts"],"names":[],"mappings":";AAAA;;;GAGG;;;AAIH,yCAA2D;AAI3D,SAAgB,UAAU,CAAC,MAAkB;IAC5C,OAAO,IAAA,mBAAQ,EAAC,MAAM,CAAC,IAAI,IAAA,mBAAQ,EAAC,MAAM,CAAC,CAAC;AAC7C,CAAC;AAFD,gCAEC;AAED,SAAgB,SAAS,CAAC,MAAkB;IAC3C,QAAQ,MAAM,CAAC,IAAI,EAAE,CAAC;QACrB,KAAK,QAAQ,CAAC,CAAC,CAAC;YACf,OAAO,MAAM,CAAC;QACf,CAAC;QACD,OAAO,CAAC,CAAC,CAAC;YACT,OAAO,SAAS,CAAC;QAClB,CAAC;IACF,CAAC;AACF,CAAC;AATD,8BASC;AAID,SAAgB,uBAAuB,CAAC,IAAU,EAAE,SAA6B;IAChF,MAAM,MAAM,GAAG,SAAS,CAAC,IAAI,CAAC,CAAC;IAC/B,OAAO,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,IAAA,oBAAS,EAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;AAC/D,CAAC;AAHD,0DAGC","sourcesContent":["/*!\n * Copyright (c) Microsoft Corporation and contributors. All rights reserved.\n * Licensed under the MIT License.\n */\n\nimport type { MoveMarkEffect } from \"./helperTypes.js\";\nimport type { Attach, CellMark, Mark, MarkEffect } from \"./types.js\";\nimport { isAttach, isDetach, splitMark } from \"./utils.js\";\n\nexport type MoveMark = CellMark<MoveMarkEffect>;\n\nexport function isMoveMark(effect: MarkEffect): effect is MoveMarkEffect {\n\treturn isAttach(effect) || isDetach(effect);\n}\n\nexport function getAttach(effect: MarkEffect): Attach | undefined {\n\tswitch (effect.type) {\n\t\tcase \"Insert\": {\n\t\t\treturn effect;\n\t\t}\n\t\tdefault: {\n\t\t\treturn undefined;\n\t\t}\n\t}\n}\n\nexport type NodeRangeQueryFunc = (mark: Mark) => number;\n\nexport function splitMarkForMoveEffects(mark: Mark, getLength: NodeRangeQueryFunc): Mark[] {\n\tconst length = getLength(mark);\n\treturn length < mark.count ? splitMark(mark, length) : [mark];\n}\n"]}
+{"version":3,"file":"moveEffectTable.js","sourceRoot":"","sources":["../../../src/feature-libraries/sequence-field/moveEffectTable.ts"],"names":[],"mappings":";AAAA;;;GAGG;;;AAEH,kEAA8E;AAG9E,kDAAmE;AACnE,yDAIoC;AAIpC,yCAAiF;AAoDjF,IAAY,OAGX;AAHD,WAAY,OAAO;IAClB,yCAAM,CAAA;IACN,qCAAI,CAAA;AACL,CAAC,EAHW,OAAO,uBAAP,OAAO,QAGlB;AAWD,SAAgB,aAAa,CAC5B,WAA4B,EAC5B,MAAwB,EACxB,QAAiC,EACjC,EAAU,EACV,KAAa,EACb,MAAkB,EAClB,aAAsB,IAAI;IAEzB,MAA8B,CAAC,KAAK,GAAG,EAAE,CAAC;IAC3C,WAAW,CAAC,GAAG,CAAC,MAAM,EAAE,QAAQ,EAAE,EAAE,EAAE,KAAK,EAAE,MAAM,EAAE,UAAU,CAAC,CAAC;AAClE,CAAC;AAXD,sCAWC;AAED,SAAgB,aAAa,CAC5B,WAA4B,EAC5B,MAAwB,EACxB,QAAiC,EACjC,EAAU,EACV,KAAa,EACb,gBAAyB,IAAI;IAE7B,MAAM,MAAM,GAAG,WAAW,CAAC,GAAG,CAAC,MAAM,EAAE,QAAQ,EAAE,EAAE,EAAE,KAAK,EAAE,aAAa,CAAC,CAAC;IAC3E,OAAO,MAAM,CAAC,KAAK,KAAK,SAAS;QAChC,CAAC,CAAC,MAAM;QACR,CAAC,CAAC,EAAE,GAAG,MAAM,EAAE,KAAK,EAAE,qBAAqB,CAAC,MAAM,CAAC,KAA4B,EAAE,EAAE,CAAC,EAAE,CAAC;AACzF,CAAC;AAZD,sCAYC;AAID,SAAgB,UAAU,CAAC,MAAkB;IAC5C,OAAO,SAAS,CAAC,MAAM,CAAC,IAAI,QAAQ,CAAC,MAAM,CAAC,CAAC;AAC9C,CAAC;AAFD,gCAEC;AAED,SAAgB,SAAS,CAAC,MAAkB;IAC3C,OAAO,MAAM,CAAC,IAAI,KAAK,SAAS,CAAC;AAClC,CAAC;AAFD,8BAEC;AAED,SAAgB,QAAQ,CAAC,MAAkB;IAC1C,OAAO,MAAM,CAAC,IAAI,KAAK,QAAQ,CAAC;AACjC,CAAC;AAFD,4BAEC;AAED,SAAgB,SAAS,CAAC,MAAkB;IAC3C,QAAQ,MAAM,CAAC,IAAI,EAAE,CAAC;QACrB,KAAK,QAAQ,CAAC,CAAC,CAAC;YACf,OAAO,MAAM,CAAC;QACf,CAAC;QACD,KAAK,iBAAiB,CAAC,CAAC,CAAC;YACxB,OAAO,SAAS,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;QACjC,CAAC;QACD,OAAO,CAAC,CAAC,CAAC;YACT,OAAO,SAAS,CAAC;QAClB,CAAC;IACF,CAAC;AACF,CAAC;AAZD,8BAYC;AAED,SAAS,qBAAqB,CAAC,MAA2B,EAAE,QAAgB;IAC3E,IAAI,MAAM,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;QAC/B,OAAO,MAAM,CAAC;IACf,CAAC;IAED,MAAM,QAAQ,GAAG,EAAE,GAAG,MAAM,EAAE,KAAK,EAAE,QAAQ,EAAE,CAAC;IAChD,MAAM,UAAU,GAAG,QAAQ,GAAG,MAAM,CAAC,KAAK,CAAC;IAC3C,IAAA,iBAAM,EAAC,UAAU,GAAG,CAAC,EAAE,KAAK,CAAC,yCAAyC,CAAC,CAAC;IAExE,IAAI,MAAM,CAAC,QAAQ,KAAK,SAAS,EAAE,CAAC;QACnC,QAAQ,CAAC,QAAQ,GAAG,kBAAkB,CAAC,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;IACrE,CAAC;IAED,IAAI,MAAM,CAAC,iBAAiB,KAAK,SAAS,EAAE,CAAC;QAC5C,QAAQ,CAAC,iBAAiB,GAAG,kBAAkB,CAAC,MAAM,CAAC,iBAAiB,EAAE,UAAU,CAAC,CAAC;IACvF,CAAC;IAED,IAAI,MAAM,CAAC,yBAAyB,KAAK,SAAS,EAAE,CAAC;QACpD,QAAQ,CAAC,yBAAyB,GAAG,kBAAkB,CACtD,MAAM,CAAC,yBAAyB,EAChC,UAAU,CACV,CAAC;IACH,CAAC;IAED,IAAI,MAAM,CAAC,WAAW,KAAK,SAAS,EAAE,CAAC;QACtC,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,GAAG,IAAA,0BAAe,EAAC,MAAM,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;QACxE,QAAQ,CAAC,WAAW,GAAG,KAAK,CAAC;IAC9B,CAAC;IAED,OAAO,QAAQ,CAAC;AACjB,CAAC;AAED,SAAgB,uBAAuB,CAAC,IAAU,EAAE,OAAwB;IAC3E,MAAM,MAAM,GAAG,wBAAwB,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,EAAE,OAAO,CAAC,CAAC;IACnE,OAAO,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,IAAA,oBAAS,EAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;AAC/D,CAAC;AAHD,0DAGC;AAED,SAAS,wBAAwB,CAChC,UAAsB,EACtB,KAAa,EACb,OAAwB;IAExB,IAAI,UAAU,CAAC,UAAU,CAAC,EAAE,CAAC;QAC5B,OAAO,aAAa,CACnB,OAAO,EACP,2BAA2B,CAAC,UAAU,CAAC,EACvC,UAAU,CAAC,QAAQ,EACnB,UAAU,CAAC,EAAE,EACb,KAAK,CACL,CAAC,MAAM,CAAC;IACV,CAAC;SAAM,IAAI,IAAA,kCAAuB,EAAC,UAAU,CAAC,EAAE,CAAC;QAChD,OAAO,IAAI,CAAC,GAAG,CACd,wBAAwB,CAAC,UAAU,CAAC,MAAM,EAAE,KAAK,EAAE,OAAO,CAAC,EAC3D,wBAAwB,CAAC,UAAU,CAAC,MAAM,EAAE,KAAK,EAAE,OAAO,CAAC,CAC3D,CAAC;IACH,CAAC;IAED,OAAO,KAAK,CAAC;AACd,CAAC;AAED,SAAgB,2BAA2B,CAAC,IAAoB;IAC/D,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC;IACvB,QAAQ,IAAI,EAAE,CAAC;QACd,KAAK,QAAQ,CAAC,CAAC,CAAC;YACf,OAAO,2BAAgB,CAAC,WAAW,CAAC;QACrC,CAAC;QACD,KAAK,SAAS,CAAC,CAAC,CAAC;YAChB,OAAO,2BAAgB,CAAC,MAAM,CAAC;QAChC,CAAC;QACD,OAAO,CAAC,CAAC,CAAC;YACT,IAAA,0BAAe,EAAC,IAAI,CAAC,CAAC;QACvB,CAAC;IACF,CAAC;AACF,CAAC;AAbD,kEAaC;AAED,SAAS,kBAAkB,CAAC,EAAgB,EAAE,KAAa;IAC1D,OAAO;QACN,GAAG,EAAE;QACL,OAAO,EAAE,IAAA,gBAAK,EAAC,EAAE,CAAC,OAAO,GAAG,KAAK,CAAC;KAClC,CAAC;AACH,CAAC","sourcesContent":["/*!\n * Copyright (c) Microsoft Corporation and contributors. All rights reserved.\n * Licensed under the MIT License.\n */\n\nimport { assert, unreachableCase } from \"@fluidframework/core-utils/internal\";\n\nimport type { ChangeAtomId, RevisionTag, TaggedChange } from \"../../core/index.js\";\nimport { type RangeQueryResult, brand } from \"../../util/index.js\";\nimport {\n\ttype CrossFieldManager,\n\tCrossFieldTarget,\n\ttype NodeId,\n} from \"../modular-schema/index.js\";\n\nimport type { MoveMarkEffect } from \"./helperTypes.js\";\nimport type { CellMark, Detach, Mark, MarkEffect, MoveId, MoveIn, MoveOut } from \"./types.js\";\nimport { isAttachAndDetachEffect, splitMark, splitMarkEffect } from \"./utils.js\";\n\nexport type MoveEffectTable = CrossFieldManager<MoveEffect>;\n\n/**\n * Changes to be applied to a move mark.\n */\nexport interface MoveEffect {\n\t/**\n\t * Node changes which should be applied to this mark.\n\t * If this mark already has node changes, `modifyAfter` should be composed as later changes.\n\t */\n\tmodifyAfter?: NodeId;\n\n\t/**\n\t * Only used during rebasing.\n\t * An effect from changeset being rebased which should be moved to the same position as this mark.\n\t */\n\tmovedEffect?: Detach;\n\n\t/**\n\t * Rebased changes for a node which has been moved to the position of this mark.\n\t */\n\trebasedChanges?: NodeId;\n\n\t/**\n\t * The ID of the other outer endpoint.\n\t * Used when this is the outer endpoint in a move chain which is being composed with another move chain.\n\t */\n\tendpoint?: ChangeAtomId;\n\n\t/**\n\t * The ID of the truncated endpoint.\n\t * Used when this mark is the outer endpoint of a chain being composed with a redundant move chain.\n\t */\n\ttruncatedEndpoint?: ChangeAtomId;\n\n\t/**\n\t * The ID of the truncated endpoint.\n\t * Used when this mark is the inner endpoint of a redundant move chain.\n\t */\n\ttruncatedEndpointForInner?: ChangeAtomId;\n}\n\ninterface MoveEffectWithBasis extends MoveEffect {\n\t/**\n\t * The ID for the start of the range this MoveEffect was created for.\n\t * This is used, for example, to correctly interpret `MoveEffect.endpoint` field.\n\t */\n\tbasis: MoveId;\n}\n\nexport enum MoveEnd {\n\tSource,\n\tDest,\n}\n\nexport interface MovePartition {\n\tid: MoveId;\n\n\t// Undefined means the partition is the same size as the input.\n\tcount?: number;\n\treplaceWith?: Mark[];\n\tmodifyAfter?: TaggedChange<NodeId>;\n}\n\nexport function setMoveEffect(\n\tmoveEffects: MoveEffectTable,\n\ttarget: CrossFieldTarget,\n\trevision: RevisionTag | undefined,\n\tid: MoveId,\n\tcount: number,\n\teffect: MoveEffect,\n\tinvalidate: boolean = true,\n): void {\n\t(effect as MoveEffectWithBasis).basis = id;\n\tmoveEffects.set(target, revision, id, count, effect, invalidate);\n}\n\nexport function getMoveEffect(\n\tmoveEffects: MoveEffectTable,\n\ttarget: CrossFieldTarget,\n\trevision: RevisionTag | undefined,\n\tid: MoveId,\n\tcount: number,\n\taddDependency: boolean = true,\n): RangeQueryResult<ChangeAtomId, MoveEffect> {\n\tconst result = moveEffects.get(target, revision, id, count, addDependency);\n\treturn result.value === undefined\n\t\t? result\n\t\t: { ...result, value: adjustMoveEffectBasis(result.value as MoveEffectWithBasis, id) };\n}\n\nexport type MoveMark = CellMark<MoveMarkEffect>;\n\nexport function isMoveMark(effect: MarkEffect): effect is MoveMarkEffect {\n\treturn isMoveOut(effect) || isMoveIn(effect);\n}\n\nexport function isMoveOut(effect: MarkEffect): effect is MoveOut {\n\treturn effect.type === \"MoveOut\";\n}\n\nexport function isMoveIn(effect: MarkEffect): effect is MoveIn {\n\treturn effect.type === \"MoveIn\";\n}\n\nexport function getMoveIn(effect: MarkEffect): MoveIn | undefined {\n\tswitch (effect.type) {\n\t\tcase \"MoveIn\": {\n\t\t\treturn effect;\n\t\t}\n\t\tcase \"AttachAndDetach\": {\n\t\t\treturn getMoveIn(effect.attach);\n\t\t}\n\t\tdefault: {\n\t\t\treturn undefined;\n\t\t}\n\t}\n}\n\nfunction adjustMoveEffectBasis(effect: MoveEffectWithBasis, newBasis: MoveId): MoveEffect {\n\tif (effect.basis === newBasis) {\n\t\treturn effect;\n\t}\n\n\tconst adjusted = { ...effect, basis: newBasis };\n\tconst basisShift = newBasis - effect.basis;\n\tassert(basisShift > 0, 0x812 /* Expected basis shift to be positive */);\n\n\tif (effect.endpoint !== undefined) {\n\t\tadjusted.endpoint = adjustChangeAtomId(effect.endpoint, basisShift);\n\t}\n\n\tif (effect.truncatedEndpoint !== undefined) {\n\t\tadjusted.truncatedEndpoint = adjustChangeAtomId(effect.truncatedEndpoint, basisShift);\n\t}\n\n\tif (effect.truncatedEndpointForInner !== undefined) {\n\t\tadjusted.truncatedEndpointForInner = adjustChangeAtomId(\n\t\t\teffect.truncatedEndpointForInner,\n\t\t\tbasisShift,\n\t\t);\n\t}\n\n\tif (effect.movedEffect !== undefined) {\n\t\tconst [_mark1, mark2] = splitMarkEffect(effect.movedEffect, basisShift);\n\t\tadjusted.movedEffect = mark2;\n\t}\n\n\treturn adjusted;\n}\n\nexport function splitMarkForMoveEffects(mark: Mark, effects: MoveEffectTable): Mark[] {\n\tconst length = getFirstMoveEffectLength(mark, mark.count, effects);\n\treturn length < mark.count ? splitMark(mark, length) : [mark];\n}\n\nfunction getFirstMoveEffectLength(\n\tmarkEffect: MarkEffect,\n\tcount: number,\n\teffects: MoveEffectTable,\n): number {\n\tif (isMoveMark(markEffect)) {\n\t\treturn getMoveEffect(\n\t\t\teffects,\n\t\t\tgetCrossFieldTargetFromMove(markEffect),\n\t\t\tmarkEffect.revision,\n\t\t\tmarkEffect.id,\n\t\t\tcount,\n\t\t).length;\n\t} else if (isAttachAndDetachEffect(markEffect)) {\n\t\treturn Math.min(\n\t\t\tgetFirstMoveEffectLength(markEffect.attach, count, effects),\n\t\t\tgetFirstMoveEffectLength(markEffect.detach, count, effects),\n\t\t);\n\t}\n\n\treturn count;\n}\n\nexport function getCrossFieldTargetFromMove(mark: MoveMarkEffect): CrossFieldTarget {\n\tconst type = mark.type;\n\tswitch (type) {\n\t\tcase \"MoveIn\": {\n\t\t\treturn CrossFieldTarget.Destination;\n\t\t}\n\t\tcase \"MoveOut\": {\n\t\t\treturn CrossFieldTarget.Source;\n\t\t}\n\t\tdefault: {\n\t\t\tunreachableCase(type);\n\t\t}\n\t}\n}\n\nfunction adjustChangeAtomId(id: ChangeAtomId, shift: number): ChangeAtomId {\n\treturn {\n\t\t...id,\n\t\tlocalId: brand(id.localId + shift),\n\t};\n}\n"]}

package/dist/feature-libraries/sequence-field/rebase.d.ts

@@ -2,8 +2,8 @@
  * Copyright (c) Microsoft Corporation and contributors. All rights reserved.
  * Licensed under the MIT License.
  */
-import type { IdAllocator } from "../../util/index.js";
-import { type RebaseNodeManager, type NodeChangeRebaser, type RebaseRevisionMetadata } from "../modular-schema/index.js";
+import { type IdAllocator } from "../../util/index.js";
+import { type CrossFieldManager, type NodeChangeRebaser, type RebaseRevisionMetadata } from "../modular-schema/index.js";
 import { type Changeset } from "./types.js";
 /**
  * Rebases `change` over `base` assuming they both apply to the same initial state.
@@ -11,5 +11,5 @@ import { type Changeset } from "./types.js";
  * @param base - The changeset to rebase over.
  * @returns A changeset that performs the changes in `change` but does so assuming `base` has been applied first.
  */
-export declare function rebase(change: Changeset, base: Changeset, rebaseChild: NodeChangeRebaser, genId: IdAllocator, manager: RebaseNodeManager, revisionMetadata: RebaseRevisionMetadata): Changeset;
+export declare function rebase(change: Changeset, base: Changeset, rebaseChild: NodeChangeRebaser, genId: IdAllocator, manager: CrossFieldManager, revisionMetadata: RebaseRevisionMetadata): Changeset;
 //# sourceMappingURL=rebase.d.ts.map

package/dist/feature-libraries/sequence-field/rebase.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"rebase.d.ts","sourceRoot":"","sources":["../../../src/feature-libraries/sequence-field/rebase.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAUH,OAAO,KAAK,EAAE,WAAW,EAAW,MAAM,qBAAqB,CAAC;AAChE,OAAO,EACN,KAAK,iBAAiB,EACtB,KAAK,iBAAiB,EAGtB,KAAK,sBAAsB,EAC3B,MAAM,4BAA4B,CAAC;AAKpC,OAAO,EAIN,KAAK,SAAS,EAQd,MAAM,YAAY,CAAC;AAwBpB;;;;;GAKG;AACH,wBAAgB,MAAM,CACrB,MAAM,EAAE,SAAS,EACjB,IAAI,EAAE,SAAS,EACf,WAAW,EAAE,iBAAiB,EAC9B,KAAK,EAAE,WAAW,EAClB,OAAO,EAAE,iBAAiB,EAC1B,gBAAgB,EAAE,sBAAsB,GACtC,SAAS,CAEX"}
+{"version":3,"file":"rebase.d.ts","sourceRoot":"","sources":["../../../src/feature-libraries/sequence-field/rebase.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAKH,OAAO,EAAE,KAAK,WAAW,EAAuB,MAAM,qBAAqB,CAAC;AAC5E,OAAO,EACN,KAAK,iBAAiB,EAEtB,KAAK,iBAAiB,EAGtB,KAAK,sBAAsB,EAC3B,MAAM,4BAA4B,CAAC;AAapC,OAAO,EAGN,KAAK,SAAS,EAUd,MAAM,YAAY,CAAC;AAuBpB;;;;;GAKG;AACH,wBAAgB,MAAM,CACrB,MAAM,EAAE,SAAS,EACjB,IAAI,EAAE,SAAS,EACf,WAAW,EAAE,iBAAiB,EAC9B,KAAK,EAAE,WAAW,EAClB,OAAO,EAAE,iBAAiB,EAC1B,gBAAgB,EAAE,sBAAsB,GACtC,SAAS,CASX"}

package/dist/feature-libraries/sequence-field/rebase.js

@@ -6,10 +6,11 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rebase = void 0;
 const internal_1 = require("@fluidframework/core-utils/internal");
-const index_js_1 = require("../../core/index.js");
+const index_js_1 = require("../../util/index.js");
 const index_js_2 = require("../modular-schema/index.js");
 const markListFactory_js_1 = require("./markListFactory.js");
 const markQueue_js_1 = require("./markQueue.js");
+const moveEffectTable_js_1 = require("./moveEffectTable.js");
 const types_js_1 = require("./types.js");
 const utils_js_1 = require("./utils.js");
 /**
@@ -47,24 +48,8 @@ class RebaseQueue {
     constructor(baseMarks, newMarks, metadata, moveEffects) {
         this.metadata = metadata;
         this.moveEffects = moveEffects;
-        const queryFunc = (mark) => {
-            if ((0, utils_js_1.isAttach)(mark)) {
-                return moveEffects.getNewChangesForBaseAttach((0, utils_js_1.getAttachedRootId)(mark), mark.count)
-                    .length;
-            }
-            else if ((0, utils_js_1.isDetach)(mark)) {
-                return moveEffects.doesBaseAttachNodes((0, utils_js_1.getDetachedRootId)(mark), mark.count).length;
-            }
-            let count = mark.count;
-            if (mark.type === "Rename") {
-                count = moveEffects.getNewRenameForBaseRename(mark.idOverride, count).length;
-            }
-            return mark.cellId === undefined
-                ? count
-                : moveEffects.doesBaseAttachNodes(mark.cellId, count).length;
-        };
-        this.baseMarks = new markQueue_js_1.MarkQueue(baseMarks, queryFunc);
-        this.newMarks = new markQueue_js_1.MarkQueue(newMarks, (mark) => mark.count);
+        this.baseMarks = new markQueue_js_1.MarkQueue(baseMarks, moveEffects);
+        this.newMarks = new markQueue_js_1.MarkQueue(newMarks, moveEffects);
         this.baseMarksCellSources = (0, utils_js_1.cellSourcesFromMarks)(baseMarks, utils_js_1.getInputCellId);
         this.newMarksCellSources = (0, utils_js_1.cellSourcesFromMarks)(newMarks, utils_js_1.getInputCellId);
     }
@@ -152,15 +137,14 @@ class RebaseQueue {
  * @returns a mark which has the composite effect of `mark` and `effect`.
  */
 function addMovedMarkEffect(mark, effect) {
-    if ((0, utils_js_1.isAttach)(mark) && (0, utils_js_1.isDetach)(effect)) {
+    if ((0, moveEffectTable_js_1.isMoveIn)(mark) && (0, moveEffectTable_js_1.isMoveOut)(effect)) {
         return { ...mark, type: "Insert" };
     }
-    else if ((0, utils_js_1.isRename)(mark) && (0, utils_js_1.isDetach)(effect)) {
-        const result = { ...effect, count: mark.count };
-        if (!(0, index_js_1.areEqualChangeAtomIds)(mark.idOverride, (0, utils_js_1.getDetachedRootId)(effect))) {
-            result.detachCellId = mark.idOverride;
-        }
-        return result;
+    else if ((0, utils_js_1.isRename)(mark) && (0, moveEffectTable_js_1.isMoveOut)(effect)) {
+        return { ...effect, count: mark.count, idOverride: mark.idOverride };
+    }
+    else if ((0, utils_js_1.isAttachAndDetachEffect)(mark) && (0, moveEffectTable_js_1.isMoveIn)(mark.attach) && (0, moveEffectTable_js_1.isMoveOut)(effect)) {
+        return { ...mark.detach, count: mark.count };
     }
     else if ((0, utils_js_1.isTombstone)(mark)) {
         return { ...mark, ...effect };
@@ -173,6 +157,7 @@ function rebaseMark(currMark, baseMark, rebaseChild, moveEffects) {
     if (movedNodeChanges !== undefined) {
         (0, internal_1.assert)(rebasedMark.changes === undefined, 0x8dc /* Unexpected collision of new node changes */);
         rebasedMark.changes = movedNodeChanges;
+        moveEffects.onMoveIn(movedNodeChanges);
     }
     return rebaseMarkIgnoreChild(rebasedMark, baseMark, moveEffects);
 }
@@ -185,85 +170,80 @@ function rebaseMarkIgnoreChild(currMark, baseMark, moveEffects) {
         }
         (0, internal_1.assert)(!(0, utils_js_1.isNewAttach)(currMark), 0x69d /* A new attach should not be rebased over its cell being emptied */);
         const baseCellId = (0, utils_js_1.getDetachOutputCellId)(baseMark);
-        const baseDetachId = (0, utils_js_1.getDetachedRootId)(baseMark);
-        const { remains, follows } = separateEffectsForMove((0, utils_js_1.extractMarkEffect)(currMark), baseMark, moveEffects);
-        moveRebasedChanges(moveEffects, baseDetachId, baseMark.count, currMark.changes, follows);
-        rebasedMark = { ...remains, count: baseMark.count };
-        return makeDetachedMark(rebasedMark, (0, utils_js_1.cloneCellId)(baseCellId));
+        if ((0, moveEffectTable_js_1.isMoveOut)(baseMark)) {
+            (0, internal_1.assert)((0, moveEffectTable_js_1.isMoveMark)(baseMark), 0x6f0 /* Only move marks have move IDs */);
+            (0, internal_1.assert)(!(0, utils_js_1.isNewAttach)(currMark), 0x819 /* New attaches should not be rebased over moves */);
+            const { remains, follows } = separateEffectsForMove((0, utils_js_1.extractMarkEffect)(currMark));
+            if (follows !== undefined) {
+                sendEffectToDest(follows, moveEffects, (0, utils_js_1.getEndpoint)(baseMark), baseMark.count);
+            }
+            if (currMark.changes !== undefined) {
+                moveRebasedChanges(currMark.changes, moveEffects, (0, utils_js_1.getEndpoint)(baseMark));
+            }
+            rebasedMark = { ...remains, count: baseMark.count };
+        }
+        else {
+            rebasedMark = currMark;
+        }
+        rebasedMark = makeDetachedMark(rebasedMark, (0, utils_js_1.cloneCellId)(baseCellId));
     }
     else if ((0, utils_js_1.markFillsCells)(baseMark)) {
-        return withCellId(currMark, undefined);
+        rebasedMark = (0, utils_js_1.isAttachAndDetachEffect)(currMark)
+            ? (0, utils_js_1.withNodeChange)({ ...currMark.detach, count: currMark.count }, currMark.changes)
+            : withCellId(currMark, undefined);
+    }
+    else if ((0, utils_js_1.isAttachAndDetachEffect)(baseMark)) {
+        (0, internal_1.assert)(baseMark.cellId !== undefined, 0x81a /* AttachAndDetach mark should target an empty cell */);
+        const halfRebasedMark = rebaseMarkIgnoreChild(currMark, { ...baseMark.attach, cellId: (0, utils_js_1.cloneCellId)(baseMark.cellId), count: baseMark.count }, moveEffects);
+        rebasedMark = rebaseMarkIgnoreChild(halfRebasedMark, { ...baseMark.detach, count: baseMark.count }, moveEffects);
     }
     else if ((0, utils_js_1.isRename)(baseMark)) {
-        if (currMark.type === "Rename") {
-            const doesBaseMoveAndAttach = moveEffects.doesBaseAttachNodes(baseMark.idOverride, baseMark.count).value;
-            (0, internal_1.assert)(baseMark.cellId !== undefined, "Rename should target empty cells");
-            const baseRootRename = moveEffects.getBaseRename(baseMark.cellId, baseMark.count).value;
-            const doesBaseMoveAndDetach = baseRootRename !== undefined &&
-                !(0, index_js_1.areEqualChangeAtomIds)(baseRootRename, baseMark.idOverride);
-            if (doesBaseMoveAndAttach || doesBaseMoveAndDetach) {
-                // `newMark` represents a node-targeting rename.
-                // The base changeset has moved the node which was last detached from the cell,
-                // so we should remove the rename from this location.
-                return { cellId: baseMark.idOverride, count: baseMark.count };
-            }
-        }
-        const newRenameId = moveEffects.getNewRenameForBaseRename(baseMark.idOverride, baseMark.count).value;
-        if (newRenameId !== undefined && currMark.type !== "Insert") {
-            return {
-                type: "Rename",
-                cellId: baseMark.idOverride,
-                count: baseMark.count,
-                idOverride: newRenameId,
-            };
-        }
-        return withCellId(currMark, (0, utils_js_1.getOutputCellId)(baseMark));
+        return withCellId(currMark, (0, utils_js_1.getDetachOutputCellId)(baseMark));
     }
     else {
-        return currMark;
+        rebasedMark = currMark;
     }
+    return rebasedMark;
 }
 /**
  * Returns a pair of marks that represent the effects which should remain in place in the face of concurrent move,
  * and the effects that should be sent to the move destination.
  */
-function separateEffectsForMove(mark, baseMark, nodeManager) {
+function separateEffectsForMove(mark) {
     const type = mark.type;
     switch (type) {
-        case types_js_1.NoopMarkType: {
-            return {};
-        }
-        case "Remove": {
-            if (mark.cellRename !== undefined) {
-                return { remains: { type: "Rename", idOverride: mark.cellRename }, follows: mark };
+        case "Remove":
+        case "MoveOut": {
+            // There are two scenarios that lead to a Detach mark having an idOverride:
+            // 1. The detach is a rollback (the idOverride the original id that the cell had in the input context of the attach being rolled back).
+            // 2. The detach has been composed with a Rename (the idOverride is the cell id in the output context of the rename).
+            // Since rollbacks are never rebased, we can safely assume that the idOverride is due to a Rename (scenario #2).
+            // While the detach must follow the node that it targets, the rename must remain in place because it targets the cell.
+            if (mark.idOverride !== undefined) {
+                const remains = { type: "Rename", idOverride: mark.idOverride };
+                const follows = { ...mark };
+                delete follows.idOverride;
+                return { remains, follows };
             }
-            const baseDetachId = (0, utils_js_1.getDetachedRootId)(baseMark);
-            const outputCellId = (0, utils_js_1.getDetachOutputCellId)(baseMark);
-            const doesBaseMoveNodes = !(0, index_js_1.areEqualChangeAtomIds)(outputCellId, baseDetachId) ||
-                nodeManager.doesBaseAttachNodes(baseDetachId, baseMark.count).value;
-            // We should rename these cells unless the nodes are reattached elsewhere,
-            // in which case we will rename those cells instead.
-            const remains = doesBaseMoveNodes
-                ? {}
-                : {
-                    type: "Rename",
-                    idOverride: (0, utils_js_1.getDetachOutputCellId)(mark),
-                };
-            return { remains, follows: mark };
+            return { follows: mark };
         }
+        case "AttachAndDetach": {
+            return { follows: mark.detach, remains: mark.attach };
+        }
+        case "MoveIn":
         case "Rename": {
             return { remains: mark };
         }
+        case types_js_1.NoopMarkType: {
+            return {};
+        }
         case "Insert": {
             const follows = {
-                type: "Remove",
+                type: "MoveOut",
                 id: mark.id,
             };
-            if (mark.detachCellId !== undefined) {
-                follows.detachCellId = mark.detachCellId;
-            }
             const remains = {
-                type: "Insert",
+                type: "MoveIn",
                 id: mark.id,
             };
             if (mark.revision !== undefined) {
@@ -277,10 +257,30 @@ function separateEffectsForMove(mark, baseMark, nodeManager) {
         }
     }
 }
-function moveRebasedChanges(moveEffects, baseId, count, nodeChange, newDetach) {
-    const newId = newDetach === undefined ? undefined : (0, utils_js_1.getDetachedRootId)(newDetach);
-    const detachCellId = newDetach?.detachCellId;
-    moveEffects.rebaseOverDetach(baseId, count, newId, nodeChange, detachCellId);
+// TODO: Reduce the duplication between this and other MoveEffect helpers
+function sendEffectToDest(markEffect, moveEffects, { revision, localId: id }, count) {
+    const effect = (0, moveEffectTable_js_1.getMoveEffect)(moveEffects, index_js_2.CrossFieldTarget.Destination, revision, id, count, false);
+    if (effect.length < count) {
+        const [markEffect1, markEffect2] = (0, utils_js_1.splitMarkEffect)(markEffect, effect.length);
+        const newEffect = effect.value === undefined
+            ? { movedMark: markEffect1 }
+            : { ...effect.value, movedMark: markEffect1 };
+        (0, moveEffectTable_js_1.setMoveEffect)(moveEffects, index_js_2.CrossFieldTarget.Destination, revision, id, effect.length, newEffect);
+        sendEffectToDest(markEffect2, moveEffects, { revision, localId: (0, index_js_1.brand)(id + effect.length) }, count - effect.length);
+    }
+    else {
+        const newEffect = effect.value === undefined
+            ? { movedEffect: markEffect }
+            : { ...effect.value, movedEffect: markEffect };
+        (0, moveEffectTable_js_1.setMoveEffect)(moveEffects, index_js_2.CrossFieldTarget.Destination, revision, id, count, newEffect);
+    }
+}
+function moveRebasedChanges(nodeChange, moveEffects, { revision, localId: id }) {
+    const effect = (0, moveEffectTable_js_1.getMoveEffect)(moveEffects, index_js_2.CrossFieldTarget.Destination, revision, id, 1, false).value;
+    const newEffect = effect === undefined
+        ? { rebasedChanges: nodeChange }
+        : { ...effect, rebasedChanges: nodeChange };
+    (0, moveEffectTable_js_1.setMoveEffect)(moveEffects, index_js_2.CrossFieldTarget.Destination, revision, id, 1, newEffect);
 }
 function rebaseNodeChange(currMark, baseMark, nodeRebaser) {
     const baseChange = baseMark.changes;
@@ -314,38 +314,45 @@ function withCellId(mark, cellId) {
     return newMark;
 }
 function getMovedEffectFromBaseMark(moveEffects, baseMark) {
-    return (0, utils_js_1.isAttach)(baseMark)
-        ? getMovedEffect(moveEffects, baseMark.revision, baseMark.id, baseMark.count)
-        : undefined;
+    if ((0, moveEffectTable_js_1.isMoveIn)(baseMark)) {
+        return getMovedEffect(moveEffects, baseMark.revision, baseMark.id, baseMark.count);
+    }
+    else if ((0, utils_js_1.isAttachAndDetachEffect)(baseMark) && (0, moveEffectTable_js_1.isMoveIn)(baseMark.attach)) {
+        return getMovedEffect(moveEffects, baseMark.attach.revision, baseMark.attach.id, baseMark.count);
+    }
+    else {
+        return undefined;
+    }
 }
 // It is expected that the range from `id` to `id + count - 1` has the same move effect.
 // The call sites to this function are making queries about a mark which has already been split by a `MarkQueue`
 // to match the ranges in `moveEffects`.
 // TODO: Reduce the duplication between this and other MoveEffect helpers
-function getMovedEffect(moveEffects, revision, localId, count) {
-    const entry = moveEffects.getNewChangesForBaseAttach({ revision, localId }, count);
-    (0, internal_1.assert)(entry.length === count, 0x6f3 /* Expected effect to cover entire mark */);
-    const detachId = entry.value?.detachId;
-    if (detachId === undefined) {
-        (0, internal_1.assert)(entry.value?.cellRename === undefined, "Cell detach should be accompanied by node detach");
+function getMovedEffect(moveEffects, revision, id, count) {
+    const effect = (0, moveEffectTable_js_1.getMoveEffect)(moveEffects, index_js_2.CrossFieldTarget.Destination, revision, id, count);
+    (0, internal_1.assert)(effect.length === count, 0x6f3 /* Expected effect to cover entire mark */);
+    const movedEffect = effect.value?.movedEffect;
+    if (movedEffect === undefined) {
         return undefined;
     }
-    const detach = {
-        type: "Remove",
-        revision: detachId.revision,
-        id: detachId.localId,
-    };
-    if (entry.value?.cellRename !== undefined) {
-        detach.detachCellId = entry.value.cellRename;
+    if ((0, moveEffectTable_js_1.isMoveOut)(movedEffect)) {
+        moveEffects.moveKey(index_js_2.CrossFieldTarget.Source, movedEffect.revision, movedEffect.id, count);
     }
-    return detach;
+    return movedEffect;
 }
 function getMovedChangesFromBaseMark(moveEffects, baseMark) {
-    return (0, utils_js_1.isAttach)(baseMark)
-        ? getMovedNodeChanges(moveEffects, baseMark.revision, baseMark.id)
-        : undefined;
+    if ((0, moveEffectTable_js_1.isMoveIn)(baseMark)) {
+        return getMovedNodeChanges(moveEffects, baseMark.revision, baseMark.id, baseMark.count);
+    }
+    else if ((0, utils_js_1.isAttachAndDetachEffect)(baseMark) && (0, moveEffectTable_js_1.isMoveIn)(baseMark.attach)) {
+        return getMovedNodeChanges(moveEffects, baseMark.attach.revision, baseMark.attach.id, baseMark.count);
+    }
+    else {
+        return undefined;
+    }
 }
-function getMovedNodeChanges(moveEffects, revision, localId) {
-    return moveEffects.getNewChangesForBaseAttach({ revision, localId }, 1).value?.nodeChange;
+function getMovedNodeChanges(moveEffects, revision, id, count) {
+    return (0, moveEffectTable_js_1.getMoveEffect)(moveEffects, index_js_2.CrossFieldTarget.Destination, revision, id, count).value
+        ?.rebasedChanges;
 }
 //# sourceMappingURL=rebase.js.map