@fluidframework/tree 2.80.0 → 2.81.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fluidframework/tree",
-  "version": "2.80.0",
+  "version": "2.81.0",
   "description": "Distributed tree",
   "homepage": "https://fluidframework.com",
   "repository": {
@@ -101,17 +101,17 @@
     "temp-directory": "nyc/.nyc_output"
   },
   "dependencies": {
-    "@fluid-internal/client-utils": "~2.80.0",
-    "@fluidframework/container-runtime": "~2.80.0",
-    "@fluidframework/core-interfaces": "~2.80.0",
-    "@fluidframework/core-utils": "~2.80.0",
-    "@fluidframework/datastore-definitions": "~2.80.0",
-    "@fluidframework/driver-definitions": "~2.80.0",
-    "@fluidframework/id-compressor": "~2.80.0",
-    "@fluidframework/runtime-definitions": "~2.80.0",
-    "@fluidframework/runtime-utils": "~2.80.0",
-    "@fluidframework/shared-object-base": "~2.80.0",
-    "@fluidframework/telemetry-utils": "~2.80.0",
+    "@fluid-internal/client-utils": "~2.81.0",
+    "@fluidframework/container-runtime": "~2.81.0",
+    "@fluidframework/core-interfaces": "~2.81.0",
+    "@fluidframework/core-utils": "~2.81.0",
+    "@fluidframework/datastore-definitions": "~2.81.0",
+    "@fluidframework/driver-definitions": "~2.81.0",
+    "@fluidframework/id-compressor": "~2.81.0",
+    "@fluidframework/runtime-definitions": "~2.81.0",
+    "@fluidframework/runtime-utils": "~2.81.0",
+    "@fluidframework/shared-object-base": "~2.81.0",
+    "@fluidframework/telemetry-utils": "~2.81.0",
     "@sinclair/typebox": "^0.34.13",
     "@tylerbu/sorted-btree-es6": "^1.8.0",
     "@types/ungap__structured-clone": "^1.2.0",
@@ -122,20 +122,20 @@
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.18.2",
     "@biomejs/biome": "~1.9.3",
-    "@fluid-internal/mocha-test-setup": "~2.80.0",
-    "@fluid-private/stochastic-test-utils": "~2.80.0",
-    "@fluid-private/test-dds-utils": "~2.80.0",
-    "@fluid-private/test-drivers": "~2.80.0",
-    "@fluid-tools/benchmark": "^0.51.0",
-    "@fluid-tools/build-cli": "^0.62.0",
+    "@fluid-internal/mocha-test-setup": "~2.81.0",
+    "@fluid-private/stochastic-test-utils": "~2.81.0",
+    "@fluid-private/test-dds-utils": "~2.81.0",
+    "@fluid-private/test-drivers": "~2.81.0",
+    "@fluid-tools/benchmark": "^0.52.0",
+    "@fluid-tools/build-cli": "^0.63.0",
     "@fluidframework/build-common": "^2.0.3",
-    "@fluidframework/build-tools": "^0.62.0",
-    "@fluidframework/container-definitions": "~2.80.0",
-    "@fluidframework/container-loader": "~2.80.0",
-    "@fluidframework/eslint-config-fluid": "~2.80.0",
-    "@fluidframework/test-runtime-utils": "~2.80.0",
-    "@fluidframework/test-utils": "~2.80.0",
-    "@fluidframework/tree-previous": "npm:@fluidframework/tree@2.74.0",
+    "@fluidframework/build-tools": "^0.63.0",
+    "@fluidframework/container-definitions": "~2.81.0",
+    "@fluidframework/container-loader": "~2.81.0",
+    "@fluidframework/eslint-config-fluid": "~2.81.0",
+    "@fluidframework/test-runtime-utils": "~2.81.0",
+    "@fluidframework/test-utils": "~2.81.0",
+    "@fluidframework/tree-previous": "npm:@fluidframework/tree@2.80.0",
     "@microsoft/api-extractor": "7.52.11",
     "@types/diff": "^3.5.1",
     "@types/easy-table": "^0.0.32",

package/src/codec/codec.ts

@@ -3,15 +3,15 @@
  * Licensed under the MIT License.
  */
 
-import { cleanedPackageVersion as runtimeUtilsCleanedPackageVersion } from "@fluidframework/runtime-utils/internal";
-import type { ErasedType } from "@fluidframework/core-interfaces/internal";
 import { IsoBuffer, bufferToString } from "@fluid-internal/client-utils";
+import type { ErasedType } from "@fluidframework/core-interfaces/internal";
 import { assert, fail } from "@fluidframework/core-utils/internal";
+import type { MinimumVersionForCollab } from "@fluidframework/runtime-definitions/internal";
+import { cleanedPackageVersion as runtimeUtilsCleanedPackageVersion } from "@fluidframework/runtime-utils/internal";
 import type { Static, TAnySchema, TSchema } from "@sinclair/typebox";
 
 import type { ChangeEncodingContext } from "../core/index.js";
 import type { JsonCompatibleReadOnly } from "../util/index.js";
-import type { MinimumVersionForCollab } from "@fluidframework/runtime-definitions/internal";
 
 /**
  * Translates decoded data to encoded data.
@@ -316,14 +316,17 @@ export class MappedDependentFormatVersion<
 }
 
 export const DependentFormatVersion = {
-	fromUnique: <TChildVersion extends FormatVersion>(child: TChildVersion) =>
-		new UniqueDependentFormatVersion(child),
+	fromUnique: <TChildVersion extends FormatVersion>(
+		child: TChildVersion,
+	): UniqueDependentFormatVersion<TChildVersion> => new UniqueDependentFormatVersion(child),
 	fromMap: <TParentVersion extends FormatVersion, TChildVersion extends FormatVersion>(
 		map: ReadonlyMap<TParentVersion, TChildVersion>,
-	) => new MappedDependentFormatVersion(map),
+	): MappedDependentFormatVersion<TParentVersion, TChildVersion> =>
+		new MappedDependentFormatVersion(map),
 	fromPairs: <TParentVersion extends FormatVersion, TChildVersion extends FormatVersion>(
 		pairs: Iterable<[TParentVersion, TChildVersion]>,
-	) => new MappedDependentFormatVersion(new Map(pairs)),
+	): MappedDependentFormatVersion<TParentVersion, TChildVersion> =>
+		new MappedDependentFormatVersion(new Map(pairs)),
 };
 
 /**

package/src/codec/versioned/codec.ts

@@ -4,16 +4,18 @@
  */
 
 import { assert } from "@fluidframework/core-utils/internal";
-import { UsageError } from "@fluidframework/telemetry-utils/internal";
+import type { MinimumVersionForCollab } from "@fluidframework/runtime-definitions/internal";
 import {
 	getConfigForMinVersionForCollabIterable,
 	type ConfigMapEntry,
 	type MinimumMinorSemanticVersion,
 	type SemanticVersion,
 } from "@fluidframework/runtime-utils/internal";
+import { UsageError } from "@fluidframework/telemetry-utils/internal";
 import { Type, type TSchema } from "@sinclair/typebox";
 import { gt } from "semver-ts";
 
+import { pkgVersion } from "../../packageVersion.js";
 import type {
 	JsonCompatibleReadOnly,
 	JsonCompatibleReadOnlyObject,
@@ -32,8 +34,6 @@ import {
 } from "../codec.js";
 
 import { Versioned } from "./format.js";
-import { pkgVersion } from "../../packageVersion.js";
-import type { MinimumVersionForCollab } from "@fluidframework/runtime-definitions/internal";
 
 /**
  * Json compatible data with a format version.

package/src/core/index.ts

@@ -175,6 +175,8 @@ export {
 	type GraphCommit,
 	CommitKind,
 	type CommitMetadata,
+	type LocalChangeMetadata,
+	type RemoteChangeMetadata,
 	type ChangeMetadata,
 	type RevisionTag,
 	RevisionTagSchema,

package/src/core/rebase/index.ts

@@ -12,6 +12,8 @@ export {
 	type GraphCommit,
 	CommitKind,
 	type CommitMetadata,
+	type LocalChangeMetadata,
+	type RemoteChangeMetadata,
 	type ChangeMetadata,
 	type RevisionTag,
 	RevisionTagSchema,

package/src/core/rebase/types.ts

@@ -20,6 +20,7 @@ import {
 	brandedNumberType,
 	brandedStringType,
 } from "../../util/index.js";
+import type { RevertibleAlpha } from "../revertible.js";
 
 /**
  * The identifier for a particular session/user/client that can generate `GraphCommit`s
@@ -173,28 +174,64 @@ export interface CommitMetadata {
 }
 
 /**
- * Information about a commit that has been applied.
- *
+ * Information about a change that has been applied by the local client.
+ * @sealed @alpha
+ */
+export interface LocalChangeMetadata extends CommitMetadata {
+	/**
+	 * Whether the change was made on the local machine/client or received from a remote client.
+	 */
+	readonly isLocal: true;
+	/**
+	 * Returns a serializable object that encodes the change.
+	 * @remarks This is only available for local changes.
+	 * This change object can be {@link TreeBranchAlpha.applyChange | applied to another branch} in the same state as the one which generated it.
+	 * The change object must be applied to a SharedTree with the same IdCompressor session ID as it was created from.
+	 * @privateRemarks
+	 * This is a `SerializedChange` from treeCheckout.ts.
+	 */
+	getChange(): JsonCompatibleReadOnly;
+	/**
+	 * Returns an object (a {@link RevertibleAlpha | "revertible"}) that can be used to revert the change that produced this event.
+	 * @remarks This is only available for local changes.
+	 * If the change is not revertible (for example, it was a change to the application schema), then this will return `undefined`.
+	 * Revertibles should be disposed when they are no longer needed.
+	 * @param onDisposed - A callback that will be invoked when the `Revertible` is disposed.
+	 * This happens when the `Revertible` is disposed manually or when the `TreeView` that the `Revertible` belongs to is disposed - whichever happens first.
+	 * This is typically used to clean up any resources associated with the `Revertible` in the host application.
+	 * @throws Throws an error if called outside the scope of the `changed` event that provided it.
+	 */
+	getRevertible(
+		onDisposed?: (revertible: RevertibleAlpha) => void,
+	): RevertibleAlpha | undefined;
+}
+
+/**
+ * Information about a change that has been applied by a remote client.
+ * @sealed @alpha
+ */
+export interface RemoteChangeMetadata extends CommitMetadata {
+	/**
+	 * Whether the change was made on the local machine/client or received from a remote client.
+	 */
+	readonly isLocal: false;
+	/**
+	 * Returns a serializable object that encodes the change.
+	 * @remarks This is only available for {@link LocalChangeMetadata | local changes}.
+	 */
+	readonly getChange?: undefined;
+	/**
+	 * Returns an object (a {@link RevertibleAlpha | "revertible"}) that can be used to revert the change that produced this event.
+	 * @remarks This is only available for {@link LocalChangeMetadata | local changes}.
+	 */
+	readonly getRevertible?: undefined;
+}
+
+/**
+ * Information about a {@link LocalChangeMetadata | local} or {@link RemoteChangeMetadata | remote} change that has been applied.
  * @sealed @alpha
  */
-export type ChangeMetadata = CommitMetadata &
-	(
-		| {
-				readonly isLocal: true;
-				/**
-				 * A serializable object that encodes the change.
-				 * @remarks This change object can be {@link TreeBranchAlpha.applyChange | applied to another branch} in the same state as the one which generated it.
-				 * The change object must be applied to a SharedTree with the same IdCompressor session ID as it was created from.
-				 * @privateRemarks
-				 * This is a `SerializedChange` from treeCheckout.ts.
-				 */
-				getChange(): JsonCompatibleReadOnly;
-		  }
-		| {
-				readonly isLocal: false;
-				readonly getChange?: undefined;
-		  }
-	);
+export type ChangeMetadata = LocalChangeMetadata | RemoteChangeMetadata;
 
 /**
  * Creates a new graph commit object. This is useful for creating copies of commits with different parentage.

package/src/core/rebase/utils.ts

@@ -403,10 +403,14 @@ export function rebaseChangeOverChanges<TChange>(
 		getRevInfoFromTaggedChanges([...changesToRebaseOver, changeToRebase]),
 	);
 
-	return changesToRebaseOver.reduce(
-		(a, b) => mapTaggedChange(changeToRebase, changeRebaser.rebase(a, b, revisionMetadata)),
-		changeToRebase,
-	).change;
+	let result = changeToRebase;
+	for (const b of changesToRebaseOver) {
+		result = mapTaggedChange(
+			changeToRebase,
+			changeRebaser.rebase(result, b, revisionMetadata),
+		);
+	}
+	return result.change;
 }
 
 // TODO: Deduplicate

package/src/core/schema-stored/formatV2.ts

@@ -5,13 +5,14 @@
 
 import { type ObjectOptions, type Static, Type } from "@sinclair/typebox";
 
+import { unionOptions } from "../../codec/index.js";
 import { JsonCompatibleReadOnlySchema } from "../../util/index.js";
+
 import {
 	FieldKindIdentifierSchema,
 	PersistedValueSchema,
 	TreeNodeSchemaIdentifierSchema,
 } from "./formatV1.js";
-import { unionOptions } from "../../codec/index.js";
 
 export const PersistedMetadataFormat = Type.Optional(JsonCompatibleReadOnlySchema);
 

package/src/core/tree/anchorSet.ts

@@ -1005,7 +1005,7 @@ class PathNode extends ReferenceCountedBase implements AnchorNode {
 	/**
 	 * Event emitter for this anchor.
 	 */
-	public readonly events = createEmitter<AnchorEvents>(() => this.considerDispose());
+	public readonly events = createEmitter<AnchorEvents>(this.considerDispose.bind(this));
 
 	/**
 	 * PathNode arrays are kept sorted the PathNode's parentIndex for efficient search.
@@ -1210,6 +1210,7 @@ class PathNode extends ReferenceCountedBase implements AnchorNode {
 function binaryFind(sorted: readonly PathNode[], index: number): PathNode | undefined {
 	// Try guessing the list is not sparse as a starter:
 	const guess = sorted[index];
+	// eslint-disable-next-line @typescript-eslint/prefer-optional-chain -- using ?. could change behavior
 	if (guess !== undefined && guess.parentIndex === index) {
 		return guess;
 	}

package/src/core/tree/detachedFieldIndex.ts

@@ -28,6 +28,7 @@ import type { RevisionTag, RevisionTagCodec } from "../rebase/index.js";
 import type { FieldKey } from "../schema-stored/index.js";
 
 import type * as Delta from "./delta.js";
+import { detachedFieldIndexCodecBuilder } from "./detachedFieldIndexCodecs.js";
 import type {
 	DetachedField,
 	DetachedFieldSummaryData,
@@ -35,7 +36,6 @@ import type {
 	Major,
 	Minor,
 } from "./detachedFieldIndexTypes.js";
-import { detachedFieldIndexCodecBuilder } from "./detachedFieldIndexCodecs.js";
 
 /**
  * Readonly interface for {@link DetachedFieldIndex}.

package/src/core/tree/detachedFieldIndexCodecCommon.ts

@@ -3,6 +3,8 @@
  * Licensed under the MIT License.
  */
 
+import type { Static, TSchema } from "@sinclair/typebox";
+
 import type { IJsonCodec } from "../../codec/index.js";
 import { hasSingle } from "../../util/index.js";
 
@@ -17,7 +19,6 @@ import type {
 	DetachedFieldSummaryData,
 	Major,
 } from "./detachedFieldIndexTypes.js";
-import type { Static, TSchema } from "@sinclair/typebox";
 
 // Return type is intentionally derived.
 // eslint-disable-next-line @typescript-eslint/explicit-function-return-type

package/src/core/tree/detachedFieldIndexCodecV1.ts

@@ -7,6 +7,7 @@ import { assert } from "@fluidframework/core-utils/internal";
 import type { IIdCompressor } from "@fluidframework/id-compressor";
 
 import type { CodecAndSchema, IJsonCodec } from "../../codec/index.js";
+import { brand } from "../../util/index.js";
 import {
 	type EncodedRevisionTag,
 	type RevisionTagCodec,
@@ -14,10 +15,9 @@ import {
 	RevisionTagSchema,
 } from "../rebase/index.js";
 
-import type { DetachedFieldSummaryData, Major } from "./detachedFieldIndexTypes.js";
 import { makeDetachedFieldIndexCodecFromMajorCodec } from "./detachedFieldIndexCodecCommon.js";
 import { DetachedFieldIndexFormatVersion } from "./detachedFieldIndexFormatCommon.js";
-import { brand } from "../../util/index.js";
+import type { DetachedFieldSummaryData, Major } from "./detachedFieldIndexTypes.js";
 
 class MajorCodec implements IJsonCodec<Major, EncodedRevisionTag> {
 	public constructor(

package/src/core/tree/detachedFieldIndexCodecV2.ts

@@ -5,15 +5,15 @@
 
 import { assert } from "@fluidframework/core-utils/internal";
 import type { IIdCompressor, StableId } from "@fluidframework/id-compressor";
+import { isStableId } from "@fluidframework/id-compressor/internal";
 
 import type { CodecAndSchema, IJsonCodec } from "../../codec/index.js";
 import type { EncodedRevisionTag, RevisionTagCodec, RevisionTag } from "../rebase/index.js";
 
-import { StableOrFinalRevisionTag } from "./detachedFieldIndexFormatV2.js";
-import type { DetachedFieldSummaryData, Major } from "./detachedFieldIndexTypes.js";
 import { makeDetachedFieldIndexCodecFromMajorCodec } from "./detachedFieldIndexCodecCommon.js";
-import { isStableId } from "@fluidframework/id-compressor/internal";
 import { DetachedFieldIndexFormatVersion } from "./detachedFieldIndexFormatCommon.js";
+import { StableOrFinalRevisionTag } from "./detachedFieldIndexFormatV2.js";
+import type { DetachedFieldSummaryData, Major } from "./detachedFieldIndexTypes.js";
 
 class MajorCodec implements IJsonCodec<Major> {
 	public constructor(

package/src/core/tree/detachedFieldIndexFormatV1.ts

@@ -5,9 +5,10 @@
 
 import type { Static } from "@sinclair/typebox";
 
-import { DetachedFieldIndexFormatVersion, Format } from "./detachedFieldIndexFormatCommon.js";
-import { RevisionTagSchema } from "../rebase/index.js";
 import { brand } from "../../util/index.js";
+import { RevisionTagSchema } from "../rebase/index.js";
+
+import { DetachedFieldIndexFormatVersion, Format } from "./detachedFieldIndexFormatCommon.js";
 
 export const FormatV1 = Format(
 	brand<DetachedFieldIndexFormatVersion>(DetachedFieldIndexFormatVersion.v1),

package/src/core/tree/detachedFieldIndexFormatV2.ts

@@ -5,9 +5,10 @@
 
 import { Type, type Static } from "@sinclair/typebox";
 
-import { DetachedFieldIndexFormatVersion, Format } from "./detachedFieldIndexFormatCommon.js";
-import { RevisionTagSchema, StableIdSchema } from "../rebase/index.js";
 import { brand } from "../../util/index.js";
+import { RevisionTagSchema, StableIdSchema } from "../rebase/index.js";
+
+import { DetachedFieldIndexFormatVersion, Format } from "./detachedFieldIndexFormatCommon.js";
 
 export const StableOrFinalRevisionTag = Type.Union([RevisionTagSchema, StableIdSchema]);
 

package/src/core/tree/visitDelta.ts

@@ -6,17 +6,16 @@
 import { assert } from "@fluidframework/core-utils/internal";
 
 import { type NestedMap, setInNestedMap, tryGetFromNestedMap } from "../../util/index.js";
-
+import type { RevisionTag } from "../rebase/index.js";
 import type { FieldKey } from "../schema-stored/index.js";
 
+import type { TreeChunk } from "./chunk.js";
 import { mapCursorField, type ITreeCursorSynchronous } from "./cursor.js";
 import type * as Delta from "./delta.js";
 import { areDetachedNodeIdsEqual, offsetDetachId } from "./deltaUtil.js";
 import type { DetachedFieldIndex } from "./detachedFieldIndex.js";
 import type { ForestRootId, Major, Minor } from "./detachedFieldIndexTypes.js";
 import type { NodeIndex, PlaceIndex, Range } from "./pathTree.js";
-import type { RevisionTag } from "../rebase/index.js";
-import type { TreeChunk } from "./chunk.js";
 
 /**
  * Implementation notes:
@@ -64,13 +63,16 @@ export function visitDelta(
 	const rootTransfers: Delta.DetachedNodeRename[] = [];
 	const rootDestructions: Delta.DetachedNodeDestruction[] = [];
 	const refreshers: NestedMap<Major, Minor, ITreeCursorSynchronous> = new Map();
-	delta.refreshers?.forEach(({ id: { major, minor }, trees }) => {
+	for (const {
+		id: { major, minor },
+		trees,
+	} of delta.refreshers ?? []) {
 		const treeCursors = nodeCursorsFromChunk(trees);
 		for (let i = 0; i < trees.topLevelLength; i += 1) {
 			const offsettedId = minor + i;
 			setInNestedMap(refreshers, major, offsettedId, treeCursors[i]);
 		}
-	});
+	}
 	const detachConfig: PassConfig = {
 		func: detachPass,
 		latestRevision,
@@ -204,6 +206,7 @@ function transferRoots(
 				delayed.push({ oldId, newId });
 				continue;
 			}
+			// eslint-disable-next-line @typescript-eslint/strict-boolean-expressions -- intentional behavior
 			newRootId = detachedFieldIndex.createEntry(newId, revision);
 			const fields = mapToUpdate.get(oldRootId);
 			if (fields !== undefined) {

package/src/core/tree/visitorUtils.ts

@@ -78,24 +78,40 @@ export function combineVisitors(visitors: readonly CombinableVisitor[]): Combine
 	return {
 		type: "Combined",
 		visitors: allVisitors,
-		free: () => visitors.forEach((v) => v.free()),
+		free: () => {
+			for (const v of visitors) {
+				v.free();
+			}
+		},
 		create: (...args) => {
-			allVisitors.forEach((v) => v.create(...args));
-			announcedVisitors.forEach((v) => v.afterCreate(...args));
+			for (const v of allVisitors) {
+				v.create(...args);
+			}
+			for (const v of announcedVisitors) {
+				v.afterCreate(...args);
+			}
 		},
 		destroy: (...args) => {
-			announcedVisitors.forEach((v) => v.beforeDestroy(...args));
-			allVisitors.forEach((v) => v.destroy(...args));
+			for (const v of announcedVisitors) {
+				v.beforeDestroy(...args);
+			}
+			for (const v of allVisitors) {
+				v.destroy(...args);
+			}
 		},
 		attach: (source: FieldKey, count: number, destination: PlaceIndex) => {
-			announcedVisitors.forEach((v) => v.beforeAttach(source, count, destination));
-			allVisitors.forEach((v) => v.attach(source, count, destination));
-			announcedVisitors.forEach((v) =>
+			for (const v of announcedVisitors) {
+				v.beforeAttach(source, count, destination);
+			}
+			for (const v of allVisitors) {
+				v.attach(source, count, destination);
+			}
+			for (const v of announcedVisitors) {
 				v.afterAttach(source, {
 					start: destination,
 					end: destination + count,
-				}),
-			);
+				});
+			}
 		},
 		detach: (
 			source: Range,
@@ -103,16 +119,36 @@ export function combineVisitors(visitors: readonly CombinableVisitor[]): Combine
 			id: DetachedNodeId,
 			isReplaced: boolean,
 		) => {
-			announcedVisitors.forEach((v) => v.beforeDetach(source, destination, isReplaced));
-			allVisitors.forEach((v) => v.detach(source, destination, id, isReplaced));
-			announcedVisitors.forEach((v) =>
-				v.afterDetach(source.start, source.end - source.start, destination, isReplaced),
-			);
+			for (const v of announcedVisitors) {
+				v.beforeDetach(source, destination, isReplaced);
+			}
+			for (const v of allVisitors) {
+				v.detach(source, destination, id, isReplaced);
+			}
+			for (const v of announcedVisitors) {
+				v.afterDetach(source.start, source.end - source.start, destination, isReplaced);
+			}
+		},
+		enterNode: (...args) => {
+			for (const v of allVisitors) {
+				v.enterNode(...args);
+			}
+		},
+		exitNode: (...args) => {
+			for (const v of allVisitors) {
+				v.exitNode(...args);
+			}
+		},
+		enterField: (...args) => {
+			for (const v of allVisitors) {
+				v.enterField(...args);
+			}
+		},
+		exitField: (...args) => {
+			for (const v of allVisitors) {
+				v.exitField(...args);
+			}
 		},
-		enterNode: (...args) => allVisitors.forEach((v) => v.enterNode(...args)),
-		exitNode: (...args) => allVisitors.forEach((v) => v.exitNode(...args)),
-		enterField: (...args) => allVisitors.forEach((v) => v.enterField(...args)),
-		exitField: (...args) => allVisitors.forEach((v) => v.exitField(...args)),
 	};
 }
 
@@ -138,6 +174,8 @@ export interface AnnouncedVisitor extends DeltaVisitor {
 	): void;
 }
 
+const noOp = (): void => {};
+
 /**
  * Creates an announced visitor with only the provided functions and uses a no op for the rest.
  * This is provided to make some of the delta visitor definitions cleaner.
@@ -145,7 +183,6 @@ export interface AnnouncedVisitor extends DeltaVisitor {
 export function createAnnouncedVisitor(
 	visitorFunctions: Partial<AnnouncedVisitor>,
 ): AnnouncedVisitor {
-	const noOp = (): void => {};
 	return {
 		type: "Announced",
 		free: visitorFunctions.free ?? noOp,

package/src/feature-libraries/changeAtomIdBTree.ts

@@ -6,7 +6,15 @@
 import type { ChangeAtomId, ChangesetLocalId, RevisionTag } from "../core/index.js";
 import type { TupleBTree } from "../util/index.js";
 
-export type ChangeAtomIdBTree<V> = TupleBTree<[RevisionTag | undefined, ChangesetLocalId], V>;
+/**
+ * A BTree which uses ChangeAtomId flattened into a tuple as the key.
+ * @remarks
+ * Read values with {@link getFromChangeAtomIdMap} and write values with {@link setInChangeAtomIdMap}.
+ */
+export type ChangeAtomIdBTree<V> = TupleBTree<
+	readonly [RevisionTag | undefined, ChangesetLocalId],
+	V
+>;
 
 export function getFromChangeAtomIdMap<T>(
 	map: ChangeAtomIdBTree<T>,

package/src/feature-libraries/chunked-forest/chunkTree.ts

@@ -29,9 +29,9 @@ import { getOrCreate } from "../../util/index.js";
 import { isStableNodeIdentifier } from "../node-identifier/index.js";
 
 import { BasicChunk } from "./basicChunk.js";
+import type { IncrementalEncodingPolicy } from "./codec/index.js";
 import { SequenceChunk } from "./sequenceChunk.js";
 import { type FieldShape, TreeShape, UniformChunk } from "./uniformChunk.js";
-import type { IncrementalEncodingPolicy } from "./codec/index.js";
 
 export interface Disposable {
 	/**

package/src/feature-libraries/chunked-forest/chunkedForest.ts

@@ -276,7 +276,9 @@ export class ChunkedForest implements IEditableForest {
 		};
 
 		const announcedVisitors: AnnouncedVisitor[] = [];
-		this.deltaVisitors.forEach((getVisitor) => announcedVisitors.push(getVisitor()));
+		for (const getVisitor of this.deltaVisitors) {
+			announcedVisitors.push(getVisitor());
+		}
 		const combinedVisitor = combineVisitors([forestVisitor, ...announcedVisitors]);
 		this.activeVisitor = combinedVisitor;
 		return combinedVisitor;

package/src/feature-libraries/chunked-forest/codec/chunkDecoding.ts

@@ -37,6 +37,7 @@ import {
 	decode as genericDecode,
 	readStreamIdentifier,
 } from "./chunkDecodingGeneric.js";
+import type { IncrementalDecoder } from "./codecs.js";
 import {
 	type EncodedAnyShape,
 	type EncodedChunkShape,
@@ -49,7 +50,6 @@ import {
 	FieldBatchFormatVersion,
 	SpecialField,
 } from "./format.js";
-import type { IncrementalDecoder } from "./codecs.js";
 
 export interface IdDecodingContext {
 	idCompressor: IIdCompressor;

package/src/feature-libraries/chunked-forest/codec/chunkDecodingGeneric.ts

@@ -16,8 +16,8 @@ import {
 	readStream,
 } from "./chunkCodecUtilities.js";
 import type { IdDecodingContext } from "./chunkDecoding.js";
-import type { EncodedFieldBatchGeneric, IdentifierOrIndex } from "./formatGeneric.js";
 import type { IncrementalDecoder } from "./codecs.js";
+import type { EncodedFieldBatchGeneric, IdentifierOrIndex } from "./formatGeneric.js";
 
 /**
  * General purpose shape based tree decoder which gets its support for specific shapes from the caller.

package/src/feature-libraries/chunked-forest/codec/chunkEncodingGeneric.ts

@@ -14,8 +14,8 @@ import {
 	type DeduplicationTable,
 	jsonMinimizingFilter,
 } from "./chunkCodecUtilities.js";
-import type { EncodedFieldBatchGeneric } from "./formatGeneric.js";
 import type { FieldBatchFormatVersion } from "./format.js";
+import type { EncodedFieldBatchGeneric } from "./formatGeneric.js";
 
 /**
  * An identifier which can be compressed using {@link Counter}.