@fluidframework/tree 2.74.0-365691 → 2.74.0-370705

package/src/feature-libraries/modular-schema/modularChangeCodecs.ts

@@ -3,70 +3,24 @@
  * Licensed under the MIT License.
  */
 
-import { assert, oob, fail } from "@fluidframework/core-utils/internal";
-import type { TAnySchema } from "@sinclair/typebox";
-
 import {
 	type ICodecFamily,
 	type ICodecOptions,
 	type IJsonCodec,
-	type IMultiFormatCodec,
-	type SchemaValidationFunction,
-	extractJsonValidator,
 	makeCodecFamily,
-	withSchemaValidation,
 } from "../../codec/index.js";
 import type {
 	ChangeEncodingContext,
-	ChangesetLocalId,
 	EncodedRevisionTag,
-	FieldKey,
-	FieldKindIdentifier,
-	ITreeCursorSynchronous,
-	RevisionInfo,
 	RevisionTag,
 } from "../../core/index.js";
-import {
-	type IdAllocator,
-	type JsonCompatibleReadOnly,
-	type Mutable,
-	brand,
-	idAllocatorFromMaxId,
-	newTupleBTree,
-} from "../../util/index.js";
-import {
-	type FieldBatchCodec,
-	type TreeChunk,
-	chunkFieldSingle,
-	defaultChunkPolicy,
-} from "../chunked-forest/index.js";
+import type { FieldBatchCodec } from "../chunked-forest/index.js";
 import { TreeCompressionStrategy } from "../treeCompressionUtils.js";
-
-import type { FieldChangeEncodingContext, FieldChangeHandler } from "./fieldChangeHandler.js";
-import type {
-	FieldKindConfiguration,
-	FieldKindConfigurationEntry,
-} from "./fieldKindConfiguration.js";
-import { genericFieldKind } from "./genericFieldKind.js";
-import {
-	type EncodedBuilds,
-	type EncodedBuildsArray,
-	type EncodedFieldChange,
-	type EncodedFieldChangeMap,
-	EncodedModularChangeset,
-	type EncodedNodeChangeset,
-	type EncodedRevisionInfo,
-} from "./modularChangeFormat.js";
-import {
-	newCrossFieldKeyTable,
-	type ChangeAtomIdBTree,
-	type FieldChangeMap,
-	type FieldChangeset,
-	type FieldId,
-	type ModularChangeset,
-	type NodeChangeset,
-	type NodeId,
-} from "./modularChangeTypes.js";
+import type { FieldKindConfiguration } from "./fieldKindConfiguration.js";
+import type { ModularChangeset } from "./modularChangeTypes.js";
+import { makeModularChangeCodecV1 } from "./modularChangeCodecV1.js";
+import { makeModularChangeCodecV2 } from "./modularChangeCodecV2.js";
+import type { JsonCompatibleReadOnly } from "../../util/index.js";
 
 export function makeModularChangeCodecFamily(
 	fieldKindConfigurations: ReadonlyMap<number, FieldKindConfiguration>,
@@ -84,6 +38,7 @@ export function makeModularChangeCodecFamily(
 		Array.from(fieldKindConfigurations.entries(), ([version, fieldKinds]) => [
 			version,
 			makeModularChangeCodec(
+				version,
 				fieldKinds,
 				revisionTagCodec,
 				fieldsCodec,
@@ -94,21 +49,10 @@ export function makeModularChangeCodecFamily(
 	);
 }
 
-type ModularChangeCodec = IJsonCodec<
-	ModularChangeset,
-	EncodedModularChangeset,
-	EncodedModularChangeset,
-	ChangeEncodingContext
->;
-
-type FieldCodec = IMultiFormatCodec<
-	FieldChangeset,
-	JsonCompatibleReadOnly,
-	JsonCompatibleReadOnly,
-	FieldChangeEncodingContext
->;
+const minVersionForCodec2 = 101;
 
 function makeModularChangeCodec(
+	version: number,
 	fieldKinds: FieldKindConfiguration,
 	revisionTagCodec: IJsonCodec<
 		RevisionTag,
@@ -119,441 +63,27 @@ function makeModularChangeCodec(
 	fieldsCodec: FieldBatchCodec,
 	codecOptions: ICodecOptions,
 	chunkCompressionStrategy: TreeCompressionStrategy = TreeCompressionStrategy.Compressed,
-): ModularChangeCodec {
-	// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
-	const getMapEntry = ({ kind, formatVersion }: FieldKindConfigurationEntry) => {
-		const codec = kind.changeHandler.codecsFactory(revisionTagCodec).resolve(formatVersion);
-		return {
-			codec,
-			compiledSchema: codec.json.encodedSchema
-				? extractJsonValidator(codecOptions.jsonValidator).compile(codec.json.encodedSchema)
-				: undefined,
-		};
-	};
-
-	/**
-	 * The codec version for the generic field kind.
-	 */
-	const genericFieldKindFormatVersion = 1;
-	const fieldChangesetCodecs: Map<
-		FieldKindIdentifier,
-		{
-			compiledSchema?: SchemaValidationFunction<TAnySchema>;
-			codec: FieldCodec;
-		}
-	> = new Map([
-		[
-			genericFieldKind.identifier,
-			getMapEntry({ kind: genericFieldKind, formatVersion: genericFieldKindFormatVersion }),
-		],
-	]);
-
-	fieldKinds.forEach((entry, identifier) => {
-		fieldChangesetCodecs.set(identifier, getMapEntry(entry));
-	});
-
-	const getFieldChangesetCodec = (
-		fieldKind: FieldKindIdentifier,
-	): {
-		compiledSchema?: SchemaValidationFunction<TAnySchema>;
-		codec: FieldCodec;
-	} => {
-		const entry = fieldChangesetCodecs.get(fieldKind);
-		assert(entry !== undefined, 0x5ea /* Tried to encode unsupported fieldKind */);
-		return entry;
-	};
-
-	function encodeFieldChangesForJson(
-		change: FieldChangeMap,
-		context: ChangeEncodingContext,
-		nodeChanges: ChangeAtomIdBTree<NodeChangeset>,
-	): EncodedFieldChangeMap {
-		const fieldContext: FieldChangeEncodingContext = {
-			baseContext: context,
-
-			encodeNode: (nodeId: NodeId): EncodedNodeChangeset => {
-				const node = nodeChanges.get([nodeId.revision, nodeId.localId]);
-				assert(node !== undefined, 0x92e /* Unknown node ID */);
-				return encodeNodeChangesForJson(node, fieldContext);
-			},
-
-			decodeNode: () => fail(0xb1e /* Should not decode nodes during field encoding */),
-		};
-
-		return encodeFieldChangesForJsonI(change, fieldContext);
-	}
-
-	function encodeFieldChangesForJsonI(
-		change: FieldChangeMap,
-		context: FieldChangeEncodingContext,
-	): EncodedFieldChangeMap {
-		const encodedFields: EncodedFieldChangeMap = [];
-
-		for (const [field, fieldChange] of change) {
-			const { codec, compiledSchema } = getFieldChangesetCodec(fieldChange.fieldKind);
-			const encodedChange = codec.json.encode(fieldChange.change, context);
-			if (compiledSchema !== undefined && !compiledSchema.check(encodedChange)) {
-				fail(0xb1f /* Encoded change didn't pass schema validation. */);
-			}
-
-			const fieldKey: FieldKey = field;
-			const encodedField: EncodedFieldChange = {
-				fieldKey,
-				fieldKind: fieldChange.fieldKind,
-				change: encodedChange,
-			};
-
-			encodedFields.push(encodedField);
-		}
-
-		return encodedFields;
-	}
-
-	function encodeNodeChangesForJson(
-		change: NodeChangeset,
-		context: FieldChangeEncodingContext,
-	): EncodedNodeChangeset {
-		const encodedChange: EncodedNodeChangeset = {};
-		// Note: revert constraints are ignored for now because they would only be needed if we supported reverting changes made by peers.
-		const { fieldChanges, nodeExistsConstraint } = change;
-
-		if (fieldChanges !== undefined) {
-			encodedChange.fieldChanges = encodeFieldChangesForJsonI(fieldChanges, context);
-		}
-
-		if (nodeExistsConstraint !== undefined) {
-			encodedChange.nodeExistsConstraint = nodeExistsConstraint;
-		}
-
-		return encodedChange;
-	}
-
-	function decodeFieldChangesFromJson(
-		encodedChange: EncodedFieldChangeMap,
-		parentId: NodeId | undefined,
-		decoded: ModularChangeset,
-		context: ChangeEncodingContext,
-		idAllocator: IdAllocator,
-	): FieldChangeMap {
-		const decodedFields: FieldChangeMap = new Map();
-		for (const field of encodedChange) {
-			const { codec, compiledSchema } = getFieldChangesetCodec(field.fieldKind);
-			if (compiledSchema !== undefined && !compiledSchema.check(field.change)) {
-				fail(0xb20 /* Encoded change didn't pass schema validation. */);
-			}
-
-			const fieldId: FieldId = {
-				nodeId: parentId,
-				field: field.fieldKey,
-			};
-
-			const fieldContext: FieldChangeEncodingContext = {
-				baseContext: context,
-
-				encodeNode: () => fail(0xb21 /* Should not encode nodes during field decoding */),
-
-				decodeNode: (encodedNode: EncodedNodeChangeset): NodeId => {
-					const nodeId: NodeId = {
-						revision: context.revision,
-						localId: brand(idAllocator.allocate()),
-					};
-
-					const node = decodeNodeChangesetFromJson(
-						encodedNode,
-						nodeId,
-						decoded,
-						context,
-						idAllocator,
-					);
-
-					decoded.nodeChanges.set([nodeId.revision, nodeId.localId], node);
-					decoded.nodeToParent.set([nodeId.revision, nodeId.localId], fieldId);
-					return nodeId;
-				},
-			};
-
-			const fieldChangeset = codec.json.decode(field.change, fieldContext);
-
-			const crossFieldKeys = getChangeHandler(fieldKinds, field.fieldKind).getCrossFieldKeys(
-				fieldChangeset,
-			);
-
-			for (const { key, count } of crossFieldKeys) {
-				decoded.crossFieldKeys.set(key, count, fieldId);
-			}
-
-			const fieldKey: FieldKey = brand<FieldKey>(field.fieldKey);
-
-			decodedFields.set(fieldKey, {
-				fieldKind: field.fieldKind,
-				change: brand(fieldChangeset),
-			});
-		}
-
-		return decodedFields;
-	}
-
-	function decodeNodeChangesetFromJson(
-		encodedChange: EncodedNodeChangeset,
-		id: NodeId,
-		decoded: ModularChangeset,
-		context: ChangeEncodingContext,
-		idAllocator: IdAllocator,
-	): NodeChangeset {
-		const decodedChange: NodeChangeset = {};
-		const { fieldChanges, nodeExistsConstraint } = encodedChange;
-
-		if (fieldChanges !== undefined) {
-			decodedChange.fieldChanges = decodeFieldChangesFromJson(
-				fieldChanges,
-				id,
-				decoded,
-				context,
-				idAllocator,
-			);
-		}
-
-		if (nodeExistsConstraint !== undefined) {
-			decodedChange.nodeExistsConstraint = nodeExistsConstraint;
-		}
-
-		return decodedChange;
-	}
-
-	function encodeDetachedNodes(
-		detachedNodes: ChangeAtomIdBTree<TreeChunk> | undefined,
-		context: ChangeEncodingContext,
-	): EncodedBuilds | undefined {
-		if (detachedNodes === undefined) {
-			return undefined;
-		}
-
-		const treesToEncode: ITreeCursorSynchronous[] = [];
-		const buildsArray: EncodedBuildsArray = [];
-
-		let buildsForRevision:
-			| [[ChangesetLocalId, number][], EncodedRevisionTag]
-			| [[ChangesetLocalId, number][]]
-			| undefined;
-
-		for (const [[revision, id], chunk] of detachedNodes.entries()) {
-			const encodedRevision = encodeRevisionOpt(revisionTagCodec, revision, context);
-
-			if (buildsForRevision === undefined || buildsForRevision[1] !== encodedRevision) {
-				if (buildsForRevision !== undefined) {
-					buildsArray.push(buildsForRevision);
-				}
-
-				buildsForRevision = encodedRevision !== undefined ? [[], encodedRevision] : [[]];
-			}
-
-			treesToEncode.push(chunk.cursor());
-			const treeIndexInBatch = treesToEncode.length - 1;
-			buildsForRevision?.[0].push([id, treeIndexInBatch]);
-		}
-
-		if (buildsForRevision !== undefined) {
-			buildsArray.push(buildsForRevision);
-		}
-
-		return buildsArray.length === 0
-			? undefined
-			: {
-					builds: buildsArray,
-					trees: fieldsCodec.encode(treesToEncode, {
-						encodeType: chunkCompressionStrategy,
-						schema: context.schema,
-						originatorId: context.originatorId,
-						idCompressor: context.idCompressor,
-					}),
-				};
-	}
-
-	function decodeDetachedNodes(
-		encoded: EncodedBuilds | undefined,
-		context: ChangeEncodingContext,
-	): ChangeAtomIdBTree<TreeChunk> | undefined {
-		if (encoded === undefined || encoded.builds.length === 0) {
-			return undefined;
-		}
-
-		const chunks = fieldsCodec.decode(encoded.trees, {
-			encodeType: chunkCompressionStrategy,
-			originatorId: context.originatorId,
-			idCompressor: context.idCompressor,
-		});
-		const getChunk = (index: number): TreeChunk => {
-			assert(index < chunks.length, 0x898 /* out of bounds index for build chunk */);
-			return chunkFieldSingle(chunks[index] ?? oob(), {
-				policy: defaultChunkPolicy,
-				idCompressor: context.idCompressor,
-			});
-		};
-
-		const map: ModularChangeset["builds"] = newTupleBTree();
-		encoded.builds.forEach((build) => {
-			// EncodedRevisionTag cannot be an array so this ensures that we can isolate the tuple
-			const revision =
-				build[1] === undefined ? context.revision : revisionTagCodec.decode(build[1], context);
-
-			const decodedChunks: [ChangesetLocalId, TreeChunk][] = build[0].map(([i, n]) => [
-				i,
-				getChunk(n),
-			]);
-
-			for (const [id, chunk] of decodedChunks) {
-				map.set([revision, id], chunk);
-			}
-		});
-
-		return map;
-	}
-
-	function encodeRevisionInfos(
-		revisions: readonly RevisionInfo[],
-		context: ChangeEncodingContext,
-	): EncodedRevisionInfo[] | undefined {
-		if (context.revision !== undefined) {
-			assert(
-				revisions.length === 1 &&
-					revisions[0] !== undefined &&
-					revisions[0].revision === context.revision &&
-					revisions[0].rollbackOf === undefined,
-				0x964 /* A tagged change should only contain the tagged revision */,
-			);
-
-			return undefined;
-		}
-
-		const encodedRevisions = [];
-		for (const revision of revisions) {
-			const encodedRevision: Mutable<EncodedRevisionInfo> = {
-				revision: revisionTagCodec.encode(revision.revision, context),
-			};
-
-			if (revision.rollbackOf !== undefined) {
-				encodedRevision.rollbackOf = revisionTagCodec.encode(revision.rollbackOf, context);
-			}
-
-			encodedRevisions.push(encodedRevision);
-		}
-
-		return encodedRevisions;
-	}
-
-	function decodeRevisionInfos(
-		revisions: readonly EncodedRevisionInfo[] | undefined,
-		context: ChangeEncodingContext,
-	): RevisionInfo[] | undefined {
-		if (revisions === undefined) {
-			return context.revision !== undefined ? [{ revision: context.revision }] : undefined;
-		}
-
-		const decodedRevisions = [];
-		for (const revision of revisions) {
-			const decodedRevision: Mutable<RevisionInfo> = {
-				revision: revisionTagCodec.decode(revision.revision, context),
-			};
-
-			if (revision.rollbackOf !== undefined) {
-				decodedRevision.rollbackOf = revisionTagCodec.decode(revision.rollbackOf, context);
-			}
-
-			decodedRevisions.push(decodedRevision);
-		}
-
-		return decodedRevisions;
+): IJsonCodec<
+	ModularChangeset,
+	JsonCompatibleReadOnly,
+	JsonCompatibleReadOnly,
+	ChangeEncodingContext
+> {
+	if (version < minVersionForCodec2) {
+		return makeModularChangeCodecV1(
+			fieldKinds,
+			revisionTagCodec,
+			fieldsCodec,
+			codecOptions,
+			chunkCompressionStrategy,
+		);
 	}
 
-	const modularChangeCodec: ModularChangeCodec = {
-		encode: (change, context) => {
-			// Destroys only exist in rollback changesets, which are never sent.
-			assert(change.destroys === undefined, 0x899 /* Unexpected changeset with destroys */);
-			return {
-				maxId: change.maxId,
-				revisions:
-					change.revisions === undefined
-						? undefined
-						: encodeRevisionInfos(change.revisions, context),
-				changes: encodeFieldChangesForJson(change.fieldChanges, context, change.nodeChanges),
-				builds: encodeDetachedNodes(change.builds, context),
-				refreshers: encodeDetachedNodes(change.refreshers, context),
-				violations: change.constraintViolationCount,
-			};
-		},
-
-		decode: (encodedChange: EncodedModularChangeset, context) => {
-			const decoded: Mutable<ModularChangeset> = {
-				fieldChanges: new Map(),
-				nodeChanges: newTupleBTree(),
-				nodeToParent: newTupleBTree(),
-				nodeAliases: newTupleBTree(),
-				crossFieldKeys: newCrossFieldKeyTable(),
-			};
-
-			decoded.fieldChanges = decodeFieldChangesFromJson(
-				encodedChange.changes,
-				undefined,
-				decoded,
-				context,
-				idAllocatorFromMaxId(encodedChange.maxId),
-			);
-
-			if (encodedChange.builds !== undefined) {
-				decoded.builds = decodeDetachedNodes(encodedChange.builds, context);
-			}
-			if (encodedChange.refreshers !== undefined) {
-				decoded.refreshers = decodeDetachedNodes(encodedChange.refreshers, context);
-			}
-
-			if (encodedChange.violations !== undefined) {
-				decoded.constraintViolationCount = encodedChange.violations;
-			}
-
-			const decodedRevInfos = decodeRevisionInfos(encodedChange.revisions, context);
-			if (decodedRevInfos !== undefined) {
-				decoded.revisions = decodedRevInfos;
-			}
-			if (encodedChange.maxId !== undefined) {
-				decoded.maxId = encodedChange.maxId;
-			}
-			return decoded;
-		},
-	};
-
-	return withSchemaValidation(
-		EncodedModularChangeset,
-		modularChangeCodec,
-		codecOptions.jsonValidator,
+	return makeModularChangeCodecV2(
+		fieldKinds,
+		revisionTagCodec,
+		fieldsCodec,
+		codecOptions,
+		chunkCompressionStrategy,
 	);
 }
-
-function getChangeHandler(
-	fieldKinds: FieldKindConfiguration,
-	fieldKind: FieldKindIdentifier,
-): FieldChangeHandler<unknown> {
-	if (fieldKind === genericFieldKind.identifier) {
-		return genericFieldKind.changeHandler;
-	}
-
-	const handler = fieldKinds.get(fieldKind)?.kind.changeHandler;
-	assert(handler !== undefined, 0x9c1 /* Unknown field kind */);
-	return handler;
-}
-
-function encodeRevisionOpt(
-	revisionCodec: IJsonCodec<
-		RevisionTag,
-		EncodedRevisionTag,
-		EncodedRevisionTag,
-		ChangeEncodingContext
-	>,
-	revision: RevisionTag | undefined,
-	context: ChangeEncodingContext,
-): EncodedRevisionTag | undefined {
-	if (revision === undefined) {
-		return undefined;
-	}
-
-	return revision === context.revision ? undefined : revisionCodec.encode(revision, context);
-}