@fluidframework/telemetry-utils 2.3.0-288113 → 2.3.0

package/src/telemetryEventBatcher.ts

@@ -82,11 +82,9 @@ export class TelemetryEventBatcher<TMetrics extends string> {
 		};
 
 		for (const key of Object.keys(this.dataSums) as TMetrics[]) {
-			if (this.dataSums[key] !== undefined) {
-				telemetryEvent[`avg_${key}`] = roundToDecimalPlaces(
-					this.dataSums[key]! / this.counter,
-					6,
-				);
+			const dataSum = this.dataSums[key];
+			if (dataSum !== undefined) {
+				telemetryEvent[`avg_${key}`] = roundToDecimalPlaces(dataSum / this.counter, 6);
 			}
 			if (this.dataMaxes[key] !== undefined) {
 				telemetryEvent[`max_${key}`] = this.dataMaxes[key];

package/src/utils.ts

@@ -17,7 +17,7 @@ export interface IEventSampler {
 	/**
 	 * @returns true if the event should be sampled or false if not
 	 */
-	sample: () => boolean | undefined;
+	sample: () => boolean;
 }
 
 /**
@@ -69,7 +69,7 @@ export function createSampledLogger(
 			// 2. If isSamplingDisabled is false, then event should be sampled using the event sampler, if the sampler is not defined just send all events, other use the eventSampler.sample() method.
 			// 3. If skipLoggingWhenSamplingIsDisabled is true, then no event is sent.
 			if (isSamplingDisabled || eventSampler === undefined || eventSampler.sample()) {
-				if (isSamplingDisabled && skipLoggingWhenSamplingIsDisabled) {
+				if (isSamplingDisabled && (skipLoggingWhenSamplingIsDisabled ?? false)) {
 					return;
 				}
 				logger.send(event);
@@ -77,7 +77,7 @@ export function createSampledLogger(
 		},
 		sendTelemetryEvent: (event: ITelemetryGenericEventExt): void => {
 			if (isSamplingDisabled || eventSampler === undefined || eventSampler.sample()) {
-				if (isSamplingDisabled && skipLoggingWhenSamplingIsDisabled) {
+				if (isSamplingDisabled && (skipLoggingWhenSamplingIsDisabled ?? false)) {
 					return;
 				}
 				logger.sendTelemetryEvent(event);
@@ -85,7 +85,7 @@ export function createSampledLogger(
 		},
 		sendErrorEvent: (event: ITelemetryGenericEventExt): void => {
 			if (isSamplingDisabled || eventSampler === undefined || eventSampler.sample()) {
-				if (isSamplingDisabled && skipLoggingWhenSamplingIsDisabled) {
+				if (isSamplingDisabled && (skipLoggingWhenSamplingIsDisabled ?? false)) {
 					return;
 				}
 				logger.sendErrorEvent(event);
@@ -93,7 +93,7 @@ export function createSampledLogger(
 		},
 		sendPerformanceEvent: (event: ITelemetryGenericEventExt): void => {
 			if (isSamplingDisabled || eventSampler === undefined || eventSampler.sample()) {
-				if (isSamplingDisabled && skipLoggingWhenSamplingIsDisabled) {
+				if (isSamplingDisabled && (skipLoggingWhenSamplingIsDisabled ?? false)) {
 					return;
 				}
 				logger.sendPerformanceEvent(event);