@fluidframework/telemetry-utils 2.0.0-dev-rc.5.0.0.268409 → 2.0.0-dev-rc.5.0.0.270987

package/src/errorLogging.ts

@@ -7,12 +7,7 @@ import type { ITelemetryBaseProperties, Tagged } from "@fluidframework/core-inte
 import type { ILoggingError } from "@fluidframework/core-interfaces/internal";
 import { v4 as uuid } from "uuid";
 
-import {
-	IFluidErrorBase,
-	hasErrorInstanceId,
-	isFluidError,
-	isValidLegacyError,
-} from "./fluidErrorBase.js";
+import { IFluidErrorBase, hasErrorInstanceId, isFluidError } from "./fluidErrorBase.js";
 import { convertToBasePropertyType } from "./logger.js";
 import type {
 	ITelemetryLoggerExt,
@@ -111,19 +106,6 @@ export interface IFluidErrorAnnotations {
 	props?: ITelemetryBaseProperties;
 }
 
-/**
- * For backwards compatibility with pre-errorInstanceId valid errors
- */
-function patchLegacyError(
-	legacyError: Omit<IFluidErrorBase, "errorInstanceId">,
-): asserts legacyError is IFluidErrorBase {
-	// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
-	const patchMe: { -readonly [P in "errorInstanceId"]?: IFluidErrorBase[P] } = legacyError as any;
-	if (patchMe.errorInstanceId === undefined) {
-		patchMe.errorInstanceId = uuid();
-	}
-}
-
 /**
  * Normalize the given error yielding a valid Fluid Error
  * @returns A valid Fluid Error with any provided annotations applied
@@ -136,11 +118,6 @@ export function normalizeError(
 	error: unknown,
 	annotations: IFluidErrorAnnotations = {},
 ): IFluidErrorBase {
-	// Back-compat, while IFluidErrorBase is rolled out
-	if (isValidLegacyError(error)) {
-		patchLegacyError(error);
-	}
-
 	if (isFluidError(error)) {
 		// We can simply add the telemetry props to the error and return it
 		error.addTelemetryProperties(annotations.props ?? {});
@@ -339,7 +316,7 @@ export function isExternalError(error: unknown): boolean {
 		}
 		return false;
 	}
-	return !isValidLegacyError(error);
+	return true;
 }
 
 /**
@@ -400,13 +377,6 @@ export class LoggingError
 		this._errorInstanceId = id;
 	}
 
-	/**
-	 * Backwards compatibility to appease {@link isFluidError} in old code that may handle this error.
-	 */
-	// @ts-expect-error - This field shouldn't be referenced in the current version, but needs to exist at runtime.
-	// eslint-disable-next-line @typescript-eslint/prefer-as-const
-	private readonly fluidErrorCode: "-" = "-";
-
 	/**
 	 * Create a new LoggingError
 	 * @param message - Error message to use for Error base class

package/src/fluidErrorBase.ts

@@ -96,18 +96,3 @@ export function isFluidError(error: unknown): error is IFluidErrorBase {
 		hasTelemetryPropFunctions(error)
 	);
 }
-
-/**
- * Type guard for old standard of valid/known errors.
- *
- * @internal
- */
-export function isValidLegacyError(
-	error: unknown,
-): error is Omit<IFluidErrorBase, "errorInstanceId"> {
-	return (
-		typeof (error as Partial<IFluidErrorBase>)?.errorType === "string" &&
-		typeof (error as Partial<IFluidErrorBase>)?.message === "string" &&
-		hasTelemetryPropFunctions(error)
-	);
-}

package/src/index.ts

@@ -43,12 +43,7 @@ export {
 	raiseConnectedEvent,
 	safeRaiseEvent,
 } from "./events.js";
-export {
-	hasErrorInstanceId,
-	IFluidErrorBase,
-	isFluidError,
-	isValidLegacyError,
-} from "./fluidErrorBase.js";
+export { hasErrorInstanceId, IFluidErrorBase, isFluidError } from "./fluidErrorBase.js";
 export {
 	eventNamespaceSeparator,
 	createChildLogger,

package/tsconfig.json

@@ -4,6 +4,8 @@
 	"compilerOptions": {
 		"rootDir": "./src",
 		"outDir": "./lib",
+		"exactOptionalPropertyTypes": false,
+		"noUncheckedIndexedAccess": false,
 	},
 	"include": ["src/**/*"],
 }