@fluidframework/routerlicious-driver 2.91.0 → 2.93.0

package/src/summaryTreeUploadManager.ts

@@ -5,13 +5,16 @@
 
 import { IsoBuffer, Uint8ArrayToString, gitHashFile } from "@fluid-internal/client-utils";
 import { assert, unreachableCase } from "@fluidframework/core-utils/internal";
-import { ISummaryTree, SummaryObject, SummaryType } from "@fluidframework/driver-definitions";
-import type { IGitCreateTreeEntry } from "@fluidframework/driver-definitions/internal";
-import { ISnapshotTreeEx } from "@fluidframework/driver-definitions/internal";
+import type { ISummaryTree, SummaryObject } from "@fluidframework/driver-definitions";
+import { SummaryType } from "@fluidframework/driver-definitions";
+import type {
+	IGitCreateTreeEntry,
+	ISnapshotTreeEx,
+} from "@fluidframework/driver-definitions/internal";
 import { getGitMode, getGitType } from "@fluidframework/driver-utils/internal";
-import { IWholeSummaryPayloadType } from "@fluidframework/server-services-client";
+import type { IWholeSummaryPayloadType } from "@fluidframework/server-services-client";
 
-import { IGitManager, ISummaryUploadManager } from "./storageContracts.js";
+import type { IGitManager, ISummaryUploadManager } from "./storageContracts.js";
 
 /**
  * Recursively writes summary tree as individual summary blobs.
@@ -67,7 +70,7 @@ export class SummaryTreeUploadManager implements ISummaryUploadManager {
 			}
 			case SummaryType.Handle: {
 				if (previousFullSnapshot === undefined) {
-					throw Error("Parent summary does not exist to reference by handle.");
+					throw new Error("Parent summary does not exist to reference by handle.");
 				}
 				return this.getIdFromPath(object.handleType, object.handle, previousFullSnapshot);
 			}
@@ -78,8 +81,9 @@ export class SummaryTreeUploadManager implements ISummaryUploadManager {
 				return object.id;
 			}
 
-			default:
+			default: {
 				unreachableCase(object, `Unknown type: ${(object as any).type}`);
+			}
 		}
 	}
 
@@ -142,8 +146,9 @@ export class SummaryTreeUploadManager implements ISummaryUploadManager {
 					);
 					return tryId;
 				}
-				default:
-					throw Error(`Unexpected handle summary object type: "${handleType}".`);
+				default: {
+					throw new Error(`Unexpected handle summary object type: "${handleType}".`);
+				}
 			}
 		}
 		return this.getIdFromPathCore(handleType, path.slice(1), previousSnapshot.trees[key]);

package/src/tokens.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { ITokenClaims } from "@fluidframework/driver-definitions/internal";
+import type { ITokenClaims } from "@fluidframework/driver-definitions/internal";
 
 /**
  * Abstracts the discovery of claims contained within a token.

package/src/treeUtils.ts

@@ -5,10 +5,11 @@
 
 import { IsoBuffer } from "@fluid-internal/client-utils";
 import { assert } from "@fluidframework/core-utils/internal";
-import { ISummaryTree, SummaryObject, SummaryType } from "@fluidframework/driver-definitions";
-import { ISnapshotTree } from "@fluidframework/driver-definitions/internal";
+import type { ISummaryTree, SummaryObject } from "@fluidframework/driver-definitions";
+import { SummaryType } from "@fluidframework/driver-definitions";
+import type { ISnapshotTree } from "@fluidframework/driver-definitions/internal";
 
-import { INormalizedWholeSnapshot } from "./contracts.js";
+import type { INormalizedWholeSnapshot } from "./contracts.js";
 
 /**
  * Summary tree assembler props

package/src/urlUtils.ts

@@ -3,8 +3,8 @@
  * Licensed under the MIT License.
  */
 
-import { IResolvedUrl } from "@fluidframework/driver-definitions/internal";
-import { ISession } from "@fluidframework/server-services-client";
+import type { IResolvedUrl } from "@fluidframework/driver-definitions/internal";
+import type { ISession } from "@fluidframework/server-services-client";
 
 /**
  * Assume documentId is at end of url path.
@@ -13,7 +13,7 @@ import { ISession } from "@fluidframework/server-services-client";
  * TODO: Ideally we would be able to regenerate the resolvedUrl, rather than patching the current one.
  */
 export const replaceDocumentIdInPath = (urlPath: string, documentId: string): string =>
-	urlPath.split("/").slice(0, -1).concat([documentId]).join("/");
+	[...urlPath.split("/").slice(0, -1), documentId].join("/");
 
 export const getDiscoveredFluidResolvedUrl = (
 	resolvedUrl: IResolvedUrl,

package/src/wholeSummaryDocumentStorageService.ts

@@ -10,8 +10,8 @@ import {
 } from "@fluid-internal/client-utils";
 import { assert } from "@fluidframework/core-utils/internal";
 import { getW3CData, promiseRaceWithWinner } from "@fluidframework/driver-base/internal";
-import { ISummaryHandle, ISummaryTree } from "@fluidframework/driver-definitions";
-import {
+import type { ISummaryHandle, ISummaryTree } from "@fluidframework/driver-definitions";
+import type {
 	IDocumentStorageService,
 	IDocumentStorageServicePolicies,
 	ISummaryContext,
@@ -19,20 +19,23 @@ import {
 	ISnapshotTree,
 	IVersion,
 } from "@fluidframework/driver-definitions/internal";
-import {
+import type {
 	ITelemetryLoggerExt,
 	MonitoringContext,
+} from "@fluidframework/telemetry-utils/internal";
+import {
 	PerformanceEvent,
 	createChildMonitoringContext,
 } from "@fluidframework/telemetry-utils/internal";
 
-import { ICache, InMemoryCache } from "./cache.js";
-import { INormalizedWholeSnapshot, IWholeFlatSnapshot } from "./contracts.js";
-import { GitManager } from "./gitManager.js";
-import { IRouterliciousDriverPolicies } from "./policies.js";
+import type { ICache } from "./cache.js";
+import { InMemoryCache } from "./cache.js";
+import type { INormalizedWholeSnapshot, IWholeFlatSnapshot } from "./contracts.js";
+import type { GitManager } from "./gitManager.js";
+import type { IRouterliciousDriverPolicies } from "./policies.js";
 import { convertWholeFlatSnapshotToSnapshotTreeAndBlobs } from "./r11sSnapshotParser.js";
-import { IR11sResponse } from "./restWrapper.js";
-import { ISummaryUploadManager } from "./storageContracts.js";
+import type { IR11sResponse } from "./restWrapper.js";
+import type { ISummaryUploadManager } from "./storageContracts.js";
 import {
 	convertSnapshotAndBlobsToSummaryTree,
 	evalBlobsAndTrees,
@@ -100,9 +103,9 @@ export class WholeSummaryDocumentStorageService implements IDocumentStorageServi
 						this.getCacheKey(latestSnapshotId),
 					);
 
-					const networkSnapshotP = !this.driverPolicies?.enableDiscovery
-						? this.fetchSnapshotTree(latestSnapshotId, false, "getVersions")
-						: this.fetchSnapshotTree(latestSnapshotId, true, "getVersions");
+					const networkSnapshotP = this.driverPolicies?.enableDiscovery
+						? this.fetchSnapshotTree(latestSnapshotId, true, "getVersions")
+						: this.fetchSnapshotTree(latestSnapshotId, false, "getVersions");
 
 					const promiseRaceWinner = await promiseRaceWithWinner([
 						cachedSnapshotP.catch(() => undefined),
@@ -356,10 +359,10 @@ export class WholeSummaryDocumentStorageService implements IDocumentStorageServi
 
 	private async updateBlobsCache(blobs: Map<string, ArrayBuffer>): Promise<void> {
 		const blobCachePutPs: Promise<void>[] = [];
-		blobs.forEach((value, id) => {
+		for (const [id, value] of blobs.entries()) {
 			const cacheKey = this.getCacheKey(id);
 			blobCachePutPs.push(this.blobCache.put(cacheKey, value));
-		});
+		}
 		await Promise.all(blobCachePutPs);
 	}
 

package/src/wholeSummaryUploadManager.ts

@@ -3,14 +3,14 @@
  * Licensed under the MIT License.
  */
 
-import {
+import type {
 	ISummaryTree,
 	IWholeSummaryPayload,
 	IWholeSummaryPayloadType,
-	convertSummaryTreeToWholeSummaryTree,
 } from "@fluidframework/server-services-client";
+import { convertSummaryTreeToWholeSummaryTree } from "@fluidframework/server-services-client";
 
-import { IGitManager, ISummaryUploadManager } from "./storageContracts.js";
+import type { IGitManager, ISummaryUploadManager } from "./storageContracts.js";
 
 /**
  * Converts summary to snapshot tree and uploads with single snaphot tree payload.