@fluidframework/odsp-driver 2.0.0-dev-rc.1.0.0.228517 → 2.0.0-dev-rc.2.0.0.245554

package/src/compactSnapshotWriter.ts

@@ -10,23 +10,23 @@ import {
 	ISequencedDocumentMessage,
 	ISnapshotTree,
 } from "@fluidframework/protocol-definitions";
-import { snapshotMinReadVersion } from "./compactSnapshotParser";
-import { ISnapshotContents } from "./odspPublicUtils";
-import { TreeBuilderSerializer } from "./WriteBufferUtils";
+import { ISnapshot } from "@fluidframework/driver-definitions";
+import { snapshotMinReadVersion } from "./compactSnapshotParser.js";
+import { TreeBuilderSerializer } from "./WriteBufferUtils.js";
 import {
 	addBoolProperty,
 	addNumberProperty,
 	addStringProperty,
 	addDictionaryStringProperty,
 	NodeCore,
-} from "./zipItDataRepresentationUtils";
+} from "./zipItDataRepresentationUtils.js";
 
 /**
  * Writes header section of the snapshot.
  * @param node - snapshot node to serialize to
  * @param latestSequenceNumber - latest seq number of the container.
  */
-function writeSnapshotProps(node: NodeCore, latestSequenceNumber: number) {
+function writeSnapshotProps(node: NodeCore, latestSequenceNumber: number): void {
 	addStringProperty(node, "mrv", snapshotMinReadVersion);
 	addStringProperty(node, "cv", snapshotMinReadVersion);
 	addNumberProperty(node, "lsn", latestSequenceNumber);
@@ -37,7 +37,7 @@ function writeSnapshotProps(node: NodeCore, latestSequenceNumber: number) {
  * @param snapshotNode - node to serialize to.
  * @param blobs - blobs that is being serialized
  */
-function writeBlobsSection(snapshotNode: NodeCore, blobs: Map<string, IBlob | ArrayBuffer>) {
+function writeBlobsSection(snapshotNode: NodeCore, blobs: Map<string, IBlob | ArrayBuffer>): void {
 	snapshotNode.addDictionaryString("blobs");
 	const blobsNode = snapshotNode.addNode("list");
 	for (const [storageBlobId, blob] of blobs) {
@@ -48,7 +48,7 @@ function writeBlobsSection(snapshotNode: NodeCore, blobs: Map<string, IBlob | Ar
 			blobNode.addBlob(new Uint8Array(blob));
 		} else {
 			blobNode.addBlob(
-				new Uint8Array(stringToBuffer(blob.contents, blob.encoding ?? "utf-8")),
+				new Uint8Array(stringToBuffer(blob.contents, blob.encoding ?? "utf8")),
 			);
 		}
 	}
@@ -59,13 +59,13 @@ function writeBlobsSection(snapshotNode: NodeCore, blobs: Map<string, IBlob | Ar
  * @param snapshotNode - tree node to serialize to
  * @param snapshotTree - snapshot tree that is being serialized
  */
-function writeTreeSection(snapshotNode: NodeCore, snapshotTree: ISnapshotTree) {
+function writeTreeSection(snapshotNode: NodeCore, snapshotTree: ISnapshotTree): void {
 	snapshotNode.addDictionaryString("treeNodes");
 	const treesNode = snapshotNode.addNode("list");
 	writeTreeSectionCore(treesNode, snapshotTree);
 }
 
-function writeTreeSectionCore(treesNode: NodeCore, snapshotTree: ISnapshotTree) {
+function writeTreeSectionCore(treesNode: NodeCore, snapshotTree: ISnapshotTree): void {
 	for (const [path, value] of Object.entries(snapshotTree.trees)) {
 		const treeNode = treesNode.addNode();
 		// Many leaf nodes in the tree have same names like "content", "body", "header"
@@ -81,6 +81,13 @@ function writeTreeSectionCore(treesNode: NodeCore, snapshotTree: ISnapshotTree)
 			const childNode = treeNode.addNode("list");
 			writeTreeSectionCore(childNode, value);
 		}
+		if (snapshotTree.groupId !== undefined) {
+			addDictionaryStringProperty(treeNode, "groupId", snapshotTree.groupId);
+		}
+
+		if (snapshotTree.omitted !== undefined) {
+			addBoolProperty(treeNode, "omitted", snapshotTree.omitted);
+		}
 	}
 
 	if (snapshotTree.blobs) {
@@ -103,7 +110,7 @@ function writeSnapshotSection(
 	rootNode: NodeCore,
 	snapshotTree: ISnapshotTree,
 	snapshotSequenceNumber: number,
-) {
+): void {
 	rootNode.addDictionaryString("snapshot");
 	const snapshotNode = rootNode.addNode();
 
@@ -122,7 +129,7 @@ function writeSnapshotSection(
  * @param rootNode - node to serialize to.
  * @param ops - ops that is being serialized
  */
-function writeOpsSection(rootNode: NodeCore, ops: ISequencedDocumentMessage[]) {
+function writeOpsSection(rootNode: NodeCore, ops: ISequencedDocumentMessage[]): void {
 	let firstSequenceNumber: number | undefined;
 	if (ops.length > 0) {
 		firstSequenceNumber = ops[0].sequenceNumber;
@@ -133,9 +140,9 @@ function writeOpsSection(rootNode: NodeCore, ops: ISequencedDocumentMessage[]) {
 		addNumberProperty(opsNode, "firstSequenceNumber", firstSequenceNumber);
 		opsNode.addDictionaryString("deltas");
 		const deltaNode = opsNode.addNode("list");
-		ops.forEach((op) => {
+		for (const op of ops) {
 			deltaNode.addString(JSON.stringify(op));
-		});
+		}
 	}
 }
 
@@ -144,7 +151,7 @@ function writeOpsSection(rootNode: NodeCore, ops: ISequencedDocumentMessage[]) {
  * @param snapshotContents - snapshot tree contents to serialize
  * @returns ReadBuffer - binary representation of the data.
  */
-export function convertToCompactSnapshot(snapshotContents: ISnapshotContents): Uint8Array {
+export function convertToCompactSnapshot(snapshotContents: ISnapshot): Uint8Array {
 	const builder = new TreeBuilderSerializer();
 	// Create the root node.
 	const rootNode = builder.addNode();
@@ -166,7 +173,7 @@ export function convertToCompactSnapshot(snapshotContents: ISnapshotContents): U
 	writeSnapshotSection(rootNode, snapshotContents.snapshotTree, snapshotContents.sequenceNumber);
 
 	// Add Blobs
-	writeBlobsSection(rootNode, snapshotContents.blobs);
+	writeBlobsSection(rootNode, snapshotContents.blobContents);
 
 	// Then write the ops node.
 	writeOpsSection(rootNode, snapshotContents.ops);

package/src/contracts.ts

@@ -5,7 +5,9 @@
 
 import * as api from "@fluidframework/protocol-definitions";
 import { HostStoragePolicy } from "@fluidframework/odsp-driver-definitions";
-import { ISnapshotContents } from "./odspPublicUtils";
+import { ISnapshot } from "@fluidframework/driver-definitions";
+// eslint-disable-next-line import/no-deprecated
+import { ISnapshotContents } from "./odspPublicUtils.js";
 
 /**
  * Interface for error responses for the WebSocket connection
@@ -33,7 +35,7 @@ export interface IOdspSocketError {
 	 * Any error supplied by the socket containing codes and inner errors with further
 	 * details about the error.
 	 */
-	error?: any;
+	error?: unknown;
 }
 
 /**
@@ -85,6 +87,7 @@ export interface IOdspSummaryTreeValueEntry extends IOdspSummaryTreeBaseEntry {
 	value: OdspSummaryTreeValue;
 	// Indicates that this tree entry is unreferenced. If this is not present, the tree entry is considered referenced.
 	unreferenced?: true;
+	groupId?: string;
 }
 
 export interface IOdspSummaryTreeHandleEntry extends IOdspSummaryTreeBaseEntry {
@@ -115,6 +118,7 @@ export interface IOdspSnapshotTreeEntryTree {
 	type: "tree";
 	// Indicates that this tree entry is unreferenced. If this is not present, the tree entry is considered referenced.
 	unreferenced?: true;
+	groupId?: string;
 }
 
 export interface IOdspSnapshotTreeEntryCommit {
@@ -165,6 +169,8 @@ export interface IOdspSnapshot {
  */
 export interface HostStoragePolicyInternal extends HostStoragePolicy {
 	summarizerClient?: boolean;
+
+	supportGetSnapshotApi?: boolean;
 }
 
 export interface ICreateFileResponse {
@@ -175,12 +181,16 @@ export interface ICreateFileResponse {
 	"itemUrl": string;
 	"sequenceNumber": number;
 	// sharing object contains shareId, sharingLink data or error in the response
+	// TODO: use a stronger type
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any
 	"sharing"?: any;
 	"sharingLink"?: string;
 	"sharingLinkErrorReason"?: string;
 }
 
 export interface IVersionedValueWithEpoch {
+	// TODO: use a stronger type
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any
 	value: any;
 	fluidEpoch: string;
 	// This is same as "persistedCacheValueVersion" below. This represents the version of data stored in cache.
@@ -192,7 +202,9 @@ export const persistedCacheValueVersion = 3;
 export interface IGetOpsResponse {
 	nonce: string;
 	code: number;
-	/** Time in seconds. Currently never set by PUSH */
+	/**
+	 * Time in seconds. Currently never set by PUSH
+	 */
 	retryAfter?: number;
 	messages?: api.ISequencedDocumentMessage[];
 }
@@ -200,14 +212,31 @@ export interface IGetOpsResponse {
 export interface IFlushOpsResponse {
 	nonce: string;
 	code: number;
-	/** Time in seconds */
+	/**
+	 * Time in seconds
+	 */
 	retryAfter?: number;
 	lastPersistedSequenceNumber?: number;
 }
 
 /**
  * Represents the cached snapshot value.
+ * @deprecated - This will be replaced with ISnapshotCachedEntry2 which wraps the new ISnapshot interface.
+ * For now, to support back compat from cache, we need to keep it for now.
  */
+// eslint-disable-next-line import/no-deprecated
 export interface ISnapshotCachedEntry extends ISnapshotContents {
 	cacheEntryTime: number;
 }
+
+/**
+ * Represents the cached snapshot value.
+ */
+export interface ISnapshotCachedEntry2 extends ISnapshot {
+	cacheEntryTime: number;
+}
+
+/**
+ * Represents the type of signal containing the sensitivity policy labels for the container.
+ */
+export const policyLabelsUpdatesSignalType = "PolicyLabelsUpdate";

package/src/createFile.ts

@@ -10,39 +10,36 @@ import { ITelemetryLoggerExt, PerformanceEvent } from "@fluidframework/telemetry
 import {
 	InstrumentedStorageTokenFetcher,
 	IOdspResolvedUrl,
-	OdspErrorType,
+	OdspErrorTypes,
 	ShareLinkInfoType,
-	ISharingLinkKind,
-	ShareLinkTypes,
 	IFileEntry,
 } from "@fluidframework/odsp-driver-definitions";
-import { DriverErrorType } from "@fluidframework/driver-definitions";
-import { ICreateFileResponse } from "./contracts";
-import { getUrlAndHeadersWithAuth } from "./getUrlAndHeadersWithAuth";
+import { ISnapshot } from "@fluidframework/driver-definitions";
+import { ICreateFileResponse } from "./contracts.js";
+import { getUrlAndHeadersWithAuth } from "./getUrlAndHeadersWithAuth.js";
 import {
 	buildOdspShareLinkReqParams,
 	createCacheSnapshotKey,
 	getWithRetryForTokenRefresh,
 	INewFileInfo,
 	getOrigin,
-} from "./odspUtils";
-import { ISnapshotContents } from "./odspPublicUtils";
-import { createOdspUrl } from "./createOdspUrl";
-import { getApiRoot } from "./odspUrlHelper";
-import { EpochTracker } from "./epochTracker";
-import { OdspDriverUrlResolver } from "./odspDriverUrlResolver";
+} from "./odspUtils.js";
+import { createOdspUrl } from "./createOdspUrl.js";
+import { getApiRoot } from "./odspUrlHelper.js";
+import { EpochTracker } from "./epochTracker.js";
+import { OdspDriverUrlResolver } from "./odspDriverUrlResolver.js";
 import {
 	convertCreateNewSummaryTreeToTreeAndBlobs,
 	convertSummaryIntoContainerSnapshot,
 	createNewFluidContainerCore,
-} from "./createNewUtils";
-import { runWithRetry } from "./retryUtils";
-import { pkgVersion as driverVersion } from "./packageVersion";
-import { ClpCompliantAppHeader } from "./contractsPublic";
+} from "./createNewUtils.js";
+import { runWithRetry } from "./retryUtils.js";
+import { pkgVersion as driverVersion } from "./packageVersion.js";
+import { ClpCompliantAppHeader } from "./contractsPublic.js";
 
 const isInvalidFileName = (fileName: string): boolean => {
 	const invalidCharsRegex = /["*/:<>?\\|]+/g;
-	return !!fileName.match(invalidCharsRegex);
+	return invalidCharsRegex.test(fileName);
 };
 
 /**
@@ -60,14 +57,13 @@ export async function createNewFluidFile(
 	forceAccessTokenViaAuthorizationHeader: boolean,
 	isClpCompliantApp?: boolean,
 	enableSingleRequestForShareLinkWithCreate?: boolean,
-	enableShareLinkWithCreate?: boolean,
 ): Promise<IOdspResolvedUrl> {
 	// Check for valid filename before the request to create file is actually made.
 	if (isInvalidFileName(newFileInfo.filename)) {
 		throw new NonRetryableError(
 			// pre-0.58 error message: Invalid filename
 			"Invalid filename for createNew",
-			OdspErrorType.invalidFileNameError,
+			OdspErrorTypes.invalidFileNameError,
 			{ driverVersion },
 		);
 	}
@@ -95,12 +91,7 @@ export async function createNewFluidFile(
 		itemId = content.itemId;
 		summaryHandle = content.id;
 
-		shareLinkInfo = extractShareLinkData(
-			newFileInfo.createLinkType,
-			content,
-			enableSingleRequestForShareLinkWithCreate,
-			enableShareLinkWithCreate,
-		);
+		shareLinkInfo = extractShareLinkData(content, enableSingleRequestForShareLinkWithCreate);
 	}
 
 	const odspUrl = createOdspUrl({ ...newFileInfo, itemId, dataStorePath: "/" });
@@ -117,7 +108,7 @@ export async function createNewFluidFile(
 	if (createNewSummary !== undefined && createNewCaching) {
 		assert(summaryHandle !== undefined, 0x203 /* "Summary handle is undefined" */);
 		// converting summary and getting sequence number
-		const snapshot: ISnapshotContents = convertCreateNewSummaryTreeToTreeAndBlobs(
+		const snapshot: ISnapshot = convertCreateNewSummaryTreeToTreeAndBlobs(
 			createNewSummary,
 			summaryHandle,
 		);
@@ -128,9 +119,9 @@ export async function createNewFluidFile(
 }
 
 /**
- * If user requested creation of a sharing link along with the creation of the file by providing either
- * createLinkType (now deprecated) or createLinkScope in the request parameters, extract and save
- * sharing link information from the response if it is available.
+ * If user requested creation of a sharing link along with the creation of the file by providing
+ * createLinkScope in the request parameters then extract and save the sharing link information from
+ * the response if it is available.
  * In case there was an error in creation of the sharing link, error is provided back in the response,
  * and does not impact the creation of file in ODSP.
  * @param requestedSharingLinkKind - Kind of sharing link requested to be created along with the creation of file.
@@ -138,23 +129,19 @@ export async function createNewFluidFile(
  * @returns Sharing link information received in the response from a successful creation of a file.
  */
 function extractShareLinkData(
-	requestedSharingLinkKind: ShareLinkTypes | ISharingLinkKind | undefined,
 	response: ICreateFileResponse,
 	enableSingleRequestForShareLinkWithCreate?: boolean,
-	enableShareLinkWithCreate?: boolean,
 ): ShareLinkInfoType | undefined {
-	if (!requestedSharingLinkKind) {
-		return;
-	}
 	let shareLinkInfo: ShareLinkInfoType | undefined;
 	if (enableSingleRequestForShareLinkWithCreate) {
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		const { sharing } = response;
 		if (!sharing) {
 			return;
 		}
+		/* eslint-disable @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access */
 		shareLinkInfo = {
 			createLink: {
-				type: requestedSharingLinkKind,
 				link: sharing.sharingLink
 					? {
 							scope: sharing.sharingLink.scope,
@@ -167,19 +154,7 @@ function extractShareLinkData(
 				shareId: sharing.shareId,
 			},
 		};
-	} else if (enableShareLinkWithCreate) {
-		const { sharing, sharingLink, sharingLinkErrorReason } = response;
-		if (!sharingLink && !sharingLinkErrorReason) {
-			return;
-		}
-		shareLinkInfo = {
-			createLink: {
-				type: requestedSharingLinkKind,
-				link: sharingLink,
-				error: sharingLinkErrorReason,
-				shareId: sharing?.shareId,
-			},
-		};
+		/* eslint-enable @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access */
 	}
 	return shareLinkInfo;
 }
@@ -232,12 +207,12 @@ export async function createNewEmptyFluidFile(
 					throw new NonRetryableError(
 						// pre-0.58 error message: ODSP CreateFile call returned no item ID
 						"ODSP CreateFile call returned no item ID (for empty file)",
-						DriverErrorType.incorrectServerResponse,
+						OdspErrorTypes.incorrectServerResponse,
 						{ driverVersion },
 					);
 				}
 				event.end({
-					headers: Object.keys(headers).length !== 0 ? true : undefined,
+					headers: Object.keys(headers).length > 0 ? true : undefined,
 					...fetchResponse.propsToLog,
 				});
 				return content.id;
@@ -283,7 +258,7 @@ export async function createNewFluidFileFromSummary(
 			if (!content?.itemId) {
 				throw new NonRetryableError(
 					"ODSP CreateFile call returned no item ID",
-					DriverErrorType.incorrectServerResponse,
+					OdspErrorTypes.incorrectServerResponse,
 					{ driverVersion },
 				);
 			}

package/src/createNewContainerOnExistingFile.ts

@@ -6,24 +6,24 @@
 import { ISummaryTree } from "@fluidframework/protocol-definitions";
 import { ITelemetryLoggerExt } from "@fluidframework/telemetry-utils";
 import { UsageError } from "@fluidframework/driver-utils";
+import { ISnapshot } from "@fluidframework/driver-definitions";
 import {
 	IFileEntry,
 	InstrumentedStorageTokenFetcher,
 	IOdspResolvedUrl,
 } from "@fluidframework/odsp-driver-definitions";
-import { IWriteSummaryResponse } from "./contracts";
-import { createCacheSnapshotKey, getOrigin, IExistingFileInfo } from "./odspUtils";
-import { ISnapshotContents } from "./odspPublicUtils";
-import { createOdspUrl } from "./createOdspUrl";
-import { getApiRoot } from "./odspUrlHelper";
-import { EpochTracker } from "./epochTracker";
-import { OdspDriverUrlResolver } from "./odspDriverUrlResolver";
+import { IWriteSummaryResponse } from "./contracts.js";
+import { createCacheSnapshotKey, getOrigin, IExistingFileInfo } from "./odspUtils.js";
+import { createOdspUrl } from "./createOdspUrl.js";
+import { getApiRoot } from "./odspUrlHelper.js";
+import { EpochTracker } from "./epochTracker.js";
+import { OdspDriverUrlResolver } from "./odspDriverUrlResolver.js";
 import {
 	convertCreateNewSummaryTreeToTreeAndBlobs,
 	convertSummaryIntoContainerSnapshot,
 	createNewFluidContainerCore,
-} from "./createNewUtils";
-import { ClpCompliantAppHeader } from "./contractsPublic";
+} from "./createNewUtils.js";
+import { ClpCompliantAppHeader } from "./contractsPublic.js";
 
 /**
  * Creates a new Fluid container on an existing file.
@@ -81,7 +81,7 @@ export async function createNewContainerOnExistingFile(
 
 	if (createNewCaching) {
 		// converting summary and getting sequence number
-		const snapshot: ISnapshotContents = convertCreateNewSummaryTreeToTreeAndBlobs(
+		const snapshot: ISnapshot = convertCreateNewSummaryTreeToTreeAndBlobs(
 			createNewSummary,
 			summaryHandle,
 		);

package/src/createNewModule.ts

@@ -3,5 +3,5 @@
  * Licensed under the MIT License.
  */
 
-export { createNewFluidFile } from "./createFile";
-export { createNewContainerOnExistingFile } from "./createNewContainerOnExistingFile";
+export { createNewFluidFile } from "./createFile.js";
+export { createNewContainerOnExistingFile } from "./createNewContainerOnExistingFile.js";

package/src/createNewUtils.ts

@@ -9,6 +9,7 @@ import {
 	ISummaryTree,
 	SummaryType,
 	ISnapshotTree,
+	type SummaryObject,
 } from "@fluidframework/protocol-definitions";
 import {
 	getDocAttributesFromProtocolSummary,
@@ -19,17 +20,17 @@ import { unreachableCase } from "@fluidframework/core-utils";
 import { getGitType } from "@fluidframework/protocol-base";
 import { ITelemetryLoggerExt, PerformanceEvent } from "@fluidframework/telemetry-utils";
 import { InstrumentedStorageTokenFetcher } from "@fluidframework/odsp-driver-definitions";
+import { ISnapshot } from "@fluidframework/driver-definitions";
 import {
 	IOdspSummaryPayload,
 	IOdspSummaryTree,
 	OdspSummaryTreeEntry,
 	OdspSummaryTreeValue,
-} from "./contracts";
-import { getWithRetryForTokenRefresh, maxUmpPostBodySize } from "./odspUtils";
-import { ISnapshotContents } from "./odspPublicUtils";
-import { EpochTracker, FetchType } from "./epochTracker";
-import { getUrlAndHeadersWithAuth } from "./getUrlAndHeadersWithAuth";
-import { runWithRetry } from "./retryUtils";
+} from "./contracts.js";
+import { getWithRetryForTokenRefresh, maxUmpPostBodySize } from "./odspUtils.js";
+import { EpochTracker, FetchType } from "./epochTracker.js";
+import { getUrlAndHeadersWithAuth } from "./getUrlAndHeadersWithAuth.js";
+import { runWithRetry } from "./retryUtils.js";
 
 /**
  * Converts a summary(ISummaryTree) taken in detached container to snapshot tree and blobs
@@ -37,19 +38,20 @@ import { runWithRetry } from "./retryUtils";
 export function convertCreateNewSummaryTreeToTreeAndBlobs(
 	summary: ISummaryTree,
 	treeId: string,
-): ISnapshotContents {
+): ISnapshot {
 	const protocolSummary = summary.tree[".protocol"] as ISummaryTree;
 	const documentAttributes = getDocAttributesFromProtocolSummary(protocolSummary);
 	const sequenceNumber = documentAttributes.sequenceNumber;
-	const blobs = new Map<string, ArrayBuffer>();
-	const snapshotTree = convertCreateNewSummaryTreeToTreeAndBlobsCore(summary, blobs);
+	const blobContents = new Map<string, ArrayBuffer>();
+	const snapshotTree = convertCreateNewSummaryTreeToTreeAndBlobsCore(summary, blobContents);
 	snapshotTree.id = treeId;
-	const snapshotTreeValue: ISnapshotContents = {
+	const snapshotTreeValue: ISnapshot = {
 		snapshotTree,
-		blobs,
+		blobContents,
 		ops: [],
 		sequenceNumber,
 		latestSequenceNumber: sequenceNumber,
+		snapshotFormatV: 1,
 	};
 
 	return snapshotTreeValue;
@@ -58,11 +60,12 @@ export function convertCreateNewSummaryTreeToTreeAndBlobs(
 function convertCreateNewSummaryTreeToTreeAndBlobsCore(
 	summary: ISummaryTree,
 	blobs: Map<string, ArrayBuffer>,
-) {
+): ISnapshotTree {
 	const treeNode: ISnapshotTree = {
 		blobs: {},
 		trees: {},
 		unreferenced: summary.unreferenced,
+		groupId: summary.groupId,
 	};
 	const keys = Object.keys(summary.tree);
 	for (const key of keys) {
@@ -91,14 +94,19 @@ function convertCreateNewSummaryTreeToTreeAndBlobsCore(
 				throw new Error(`No ${summaryObject.type} should be present for detached summary!`);
 			}
 			default: {
-				unreachableCase(summaryObject, `Unknown tree type ${(summaryObject as any).type}`);
+				unreachableCase(
+					summaryObject,
+					`Unknown tree type ${(summaryObject as SummaryObject).type}`,
+				);
 			}
 		}
 	}
 	return treeNode;
 }
 
-export function convertSummaryIntoContainerSnapshot(createNewSummary: ISummaryTree) {
+export function convertSummaryIntoContainerSnapshot(
+	createNewSummary: ISummaryTree,
+): IOdspSummaryPayload {
 	if (!isCombinedAppAndProtocolSummary(createNewSummary)) {
 		throw new Error("App and protocol summary required for create new path!!");
 	}
@@ -145,11 +153,13 @@ function convertSummaryToSnapshotTreeForCreateNew(summary: ISummaryTree): IOdspS
 		// property is not present, the tree entry is considered referenced. If the property is present and is true,
 		// the tree entry is considered unreferenced.
 		let unreferenced: true | undefined;
+		let groupId: string | undefined;
 
 		switch (summaryObject.type) {
 			case SummaryType.Tree: {
 				value = convertSummaryToSnapshotTreeForCreateNew(summaryObject);
 				unreferenced = summaryObject.unreferenced;
+				groupId = summaryObject.groupId;
 				break;
 			}
 			case SummaryType.Blob: {
@@ -179,6 +189,7 @@ function convertSummaryToSnapshotTreeForCreateNew(summary: ISummaryTree): IOdspS
 			type: getGitType(summaryObject),
 			value,
 			unreferenced,
+			groupId,
 		};
 		snapshotTree.entries?.push(entry);
 	}
@@ -270,7 +281,7 @@ export async function createNewFluidContainerCore<T>(args: {
 				validateResponseCallback?.(fetchResponse.content);
 
 				event.end({
-					headers: Object.keys(headers).length !== 0 ? true : undefined,
+					headers: Object.keys(headers).length > 0 ? true : undefined,
 					attempts: options.refresh ? 2 : 1,
 					...fetchResponse.propsToLog,
 				});

package/src/createOdspCreateContainerRequest.ts

@@ -4,8 +4,8 @@
  */
 import { IRequest } from "@fluidframework/core-interfaces";
 import { DriverHeader } from "@fluidframework/driver-definitions";
-import { ShareLinkTypes, ISharingLinkKind } from "@fluidframework/odsp-driver-definitions";
-import { buildOdspShareLinkReqParams } from "./odspUtils";
+import { ISharingLinkKind } from "@fluidframework/odsp-driver-definitions";
+import { buildOdspShareLinkReqParams } from "./odspUtils.js";
 
 /**
  * Create the request object with url and headers for creating a new file on OneDrive Sharepoint
@@ -22,7 +22,7 @@ export function createOdspCreateContainerRequest(
 	driveId: string,
 	filePath: string,
 	fileName: string,
-	createShareLinkType?: ShareLinkTypes | ISharingLinkKind,
+	createShareLinkType?: ISharingLinkKind,
 ): IRequest {
 	const shareLinkRequestParams = buildOdspShareLinkReqParams(createShareLinkType);
 	const createNewRequest: IRequest = {

package/src/createOdspUrl.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { OdspFluidDataStoreLocator } from "./contractsPublic";
+import { OdspFluidDataStoreLocator } from "./contractsPublic.js";
 
 /*
  * Per https://github.com/microsoft/FluidFramework/issues/1556, isolating createOdspUrl() in its own file.