@fluidframework/odsp-driver 0.59.3003 → 0.59.4000

package/src/odspDocumentDeltaConnection.ts

@@ -440,6 +440,7 @@ export class OdspDocumentDeltaConnection extends DocumentDeltaConnection {
     }
 
     protected serverDisconnectHandler = (error: IFluidErrorBase & OdspError) => {
+        this.logger.sendTelemetryEvent({ eventName: "ServerDisconnect" }, error);
         this.disposeCore(true, error);
     };
 
@@ -551,11 +552,22 @@ export class OdspDocumentDeltaConnection extends DocumentDeltaConnection {
 
             case "nack":
                 // per client / document nack handling
-                super.addTrackedListener(event, (clientIdOrDocumentId: string, message: INack[]) => {
+                super.addTrackedListener(event, (clientIdOrDocumentId: string, nacks: INack[]) => {
                     if (clientIdOrDocumentId.length === 0 ||
                         clientIdOrDocumentId === this.documentId ||
                         (this.hasDetails && clientIdOrDocumentId === this.clientId)) {
-                        this.emit("nack", clientIdOrDocumentId, message);
+                        const nackContent = nacks[0]?.content;
+                        if (nackContent !== undefined) {
+                            const { code, type, message, retryAfter } = nackContent;
+                            this.logger.sendTelemetryEvent({
+                                eventName: "ServerNack",
+                                code,
+                                type,
+                                message,
+                                retryAfterSeconds: retryAfter,
+                            });
+                        }
+                        this.emit("nack", clientIdOrDocumentId, nacks);
                     }
                 });
                 break;

package/src/odspDocumentServiceFactoryCore.ts

@@ -125,6 +125,7 @@ export class OdspDocumentServiceFactoryCore implements IDocumentServiceFactory {
                     fileEntry,
                     this.hostPolicy.cacheCreateNewSummary ?? true,
                     !!this.hostPolicy.sessionOptions?.forceAccessTokenViaAuthorizationHeader,
+                    odspResolvedUrl.isClpCompliantApp,
                 );
                 const docService = this.createDocumentServiceCore(odspResolvedUrl, odspLogger,
                     cacheAndTracker, clientIsSummarizer);
@@ -156,6 +157,12 @@ export class OdspDocumentServiceFactoryCore implements IDocumentServiceFactory {
             // create the key to separate the socket reuse cache
             this.socketReferenceKeyPrefix = uuid();
         }
+        // Set enableRedeemFallback by default as true.
+        this.hostPolicy.enableRedeemFallback = this.hostPolicy.enableRedeemFallback ?? true;
+        this.hostPolicy.sessionOptions = {
+            forceAccessTokenViaAuthorizationHeader: true,
+            ...this.hostPolicy.sessionOptions,
+        };
     }
 
     public async createDocumentService(

package/src/odspSnapshotParser.ts

@@ -58,7 +58,7 @@ export function convertOdspSnapshotToSnapsohtTreeAndBlobs(
     if (odspSnapshot.blobs) {
         odspSnapshot.blobs.forEach((blob) => {
             assert(blob.encoding === "base64" || blob.encoding === undefined,
-                0x0a4 /* `Unexpected blob encoding type: '${blob.encoding}'` */);
+                0x0a4 /* Unexpected blob encoding type */);
             blobsWithBufferContent.set(blob.id, stringToBuffer(blob.content, blob.encoding ?? "utf8"));
         });
     }

package/src/odspUtils.ts

@@ -129,21 +129,16 @@ export async function fetchHelper(
             duration: performance.now() - start,
         };
     }, (error) => {
-        // While we do not know for sure whether computer is offline, this error is not actionable and
-        // is pretty good indicator we are offline. Treating it as offline scenario will make it
-        // easier to see other errors in telemetry.
-        let online = isOnline();
+        const online = isOnline();
         const errorText = `${error}`;
-        if (errorText === "TypeError: Failed to fetch") {
-            online = OnlineStatus.Offline;
-        }
+
         // This error is thrown by fetch() when AbortSignal is provided and it gets cancelled
         if (error.name === "AbortError") {
             throw new RetryableError(
                 "Fetch Timeout (AbortError)", OdspErrorType.fetchTimeout, { driverVersion });
         }
         // TCP/IP timeout
-        if (errorText.indexOf("ETIMEDOUT") !== -1) {
+        if (errorText.includes("ETIMEDOUT")) {
             throw new RetryableError(
                 "Fetch Timeout (ETIMEDOUT)", OdspErrorType.fetchTimeout, { driverVersion });
         }
@@ -158,6 +153,8 @@ export async function fetchHelper(
                 // pre-0.58 error message prefix: Offline
                 `ODSP fetch failure (Offline): ${errorText}`, DriverErrorType.offlineError, { driverVersion });
         } else {
+            // It is perhaps still possible that this is due to being offline, the error does not reveal enough
+            // information to conclude.  Could also be DNS errors, malformed fetch request, CSP violation, etc.
             throw new RetryableError(
                 // pre-0.58 error message prefix: Fetch error
                 `ODSP fetch failure: ${errorText}`, DriverErrorType.fetchFailure, { driverVersion });
@@ -343,3 +340,7 @@ export function createCacheSnapshotKey(odspResolvedUrl: IOdspResolvedUrl): ICach
     };
     return cacheEntry;
 }
+
+// 80KB is the max body size that we can put in ump post body for server to be able to accept it.
+// Keeping it 78KB to be a little cautious. As per the telemetry 99p is less than 78KB.
+export const maxUmpPostBodySize = 79872;

package/src/packageVersion.ts

@@ -6,4 +6,4 @@
  */
 
 export const pkgName = "@fluidframework/odsp-driver";
-export const pkgVersion = "0.59.3003";
+export const pkgVersion = "0.59.4000";

package/src/prefetchLatestSnapshot.ts

@@ -50,7 +50,7 @@ export async function prefetchLatestSnapshot(
     forceAccessTokenViaAuthorizationHeader: boolean,
     logger: ITelemetryBaseLogger,
     hostSnapshotFetchOptions: ISnapshotOptions | undefined,
-    enableRedeemFallback?: boolean,
+    enableRedeemFallback: boolean = true,
     fetchBinarySnapshotFormat?: boolean,
     snapshotFormatFetchType?: SnapshotFormatSupportType,
 ): Promise<boolean> {

package/src/zipItDataRepresentationUtils.ts

@@ -107,7 +107,7 @@ export const codeToBytesMap = {
 
 export function getValueSafely(map: { [index: number]: number; }, key: number) {
     const val = map[key];
-    assert(val !== undefined, 0x287 /* `key= ${key} must exist in the map` */);
+    assert(val !== undefined, 0x287 /* key must exist in the map */);
     return val;
 }
 
@@ -123,7 +123,7 @@ export function getAndValidateNodeProps(node: NodeCore, props: string[], enforce
         }
     }
     if (enforceAllProps) {
-        assert(propSet.size === 0, 0x288 /* `All properties should exist, Not found: ${[...propSet.keys()]}` */);
+        assert(propSet.size === 0, 0x288 /* All properties should exist */);
     }
     return res;
 }