@fluidframework/merge-tree 2.1.0-276985 → 2.1.0

package/src/client.ts

@@ -73,7 +73,6 @@ import {
 	MergeTreeDeltaType,
 	ReferenceType,
 } from "./ops.js";
-// eslint-disable-next-line import/no-deprecated
 import { PropertySet, createMap } from "./properties.js";
 import { DetachedReferencePosition, ReferencePosition } from "./referencePositions.js";
 import { SnapshotLoader } from "./snapshotLoader.js";
@@ -161,14 +160,15 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		public readonly specToSegment: (spec: IJSONSegment) => ISegment,
 		public readonly logger: ITelemetryLoggerExt,
 		options?: IMergeTreeOptions & PropertySet,
-		private readonly getMinInFlightRefSeq: () => number | undefined = () => undefined,
+		private readonly getMinInFlightRefSeq: () => number | undefined = (): undefined =>
+			undefined,
 	) {
 		super();
 		this._mergeTree = new MergeTree(options);
-		this._mergeTree.mergeTreeDeltaCallback = (opArgs, deltaArgs) => {
+		this._mergeTree.mergeTreeDeltaCallback = (opArgs, deltaArgs): void => {
 			this.emit("delta", opArgs, deltaArgs, this);
 		};
-		this._mergeTree.mergeTreeMaintenanceCallback = (args, opArgs) => {
+		this._mergeTree.mergeTreeMaintenanceCallback = (args, opArgs): void => {
 			this.emit("maintenance", args, opArgs, this);
 		};
 
@@ -204,7 +204,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 			return node?.data;
 		}
 		// eslint-disable-next-line import/no-deprecated
-		const taken: SegmentGroup[] = new Array(Math.min(count, pending.length));
+		const taken: SegmentGroup[] = Array.from({ length: Math.min(count, pending.length) });
 		for (let i = taken.length - 1; i >= 0; i--) {
 			taken[i] = node!.data;
 			node = node!.prev;
@@ -271,6 +271,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	}
 
 	/**
+	 * Create and insert a segment at the specified position.
 	 * @param pos - The position to insert the segment at
 	 * @param segment - The segment to insert
 	 */
@@ -284,6 +285,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	}
 
 	/**
+	 * Create and insert a segment at the specified reference position.
 	 * @param refPos - The reference position to insert the segment at
 	 * @param segment - The segment to insert
 	 */
@@ -341,7 +343,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	): boolean {
 		return walkAllChildSegments(
 			this._mergeTree.root,
-			accum === undefined ? action : (seg) => action(seg, accum),
+			accum === undefined ? action : (seg): boolean => action(seg, accum),
 		);
 	}
 
@@ -434,7 +436,9 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	/**
 	 * Removes a `LocalReferencePosition` from this client.
 	 */
-	public removeLocalReferencePosition(lref: LocalReferencePosition) {
+	public removeLocalReferencePosition(
+		lref: LocalReferencePosition,
+	): LocalReferencePosition | undefined {
 		return this._mergeTree.removeLocalReferencePosition(lref);
 	}
 
@@ -455,7 +459,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	 * and convert the position to a character position.
 	 * @param relativePos - Id of marker (may be indirect) and whether position is before or after marker.
 	 */
-	public posFromRelativePos(relativePos: IRelativePosition) {
+	public posFromRelativePos(relativePos: IRelativePosition): number {
 		return this._mergeTree.posFromRelativePos(relativePos);
 	}
 
@@ -466,7 +470,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	/**
 	 * Revert an op
 	 */
-	public rollback?(op: any, localOpMetadata: unknown) {
+	public rollback?(op: unknown, localOpMetadata: unknown): void {
 		// eslint-disable-next-line import/no-deprecated
 		this._mergeTree.rollback(op as IMergeTreeDeltaOp, localOpMetadata as SegmentGroup);
 	}
@@ -553,6 +557,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		const clientArgs = this.getClientSequenceArgs(opArgs);
 		const range = this.getValidOpRange(op, clientArgs);
 
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
 		const segments = [this.specToSegment(op.seg)];
 
 		this._mergeTree.insertSegments(
@@ -615,10 +620,11 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 			}
 			// Validate end if not insert, or insert has end
 			//
-			if (op.type !== MergeTreeDeltaType.INSERT || end !== undefined) {
-				if (end === undefined || end <= start!) {
-					invalidPositions.push("end");
-				}
+			if (
+				(op.type !== MergeTreeDeltaType.INSERT || end !== undefined) &&
+				(end === undefined || end <= start!)
+			) {
+				invalidPositions.push("end");
 			}
 
 			if (op.type === MergeTreeDeltaType.OBLITERATE && end !== undefined && end > length) {
@@ -654,18 +660,15 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 			| ISequencedDocumentMessage
 			| Pick<ISequencedDocumentMessage, "referenceSequenceNumber" | "clientId">
 			| undefined,
-	) {
+	): {
+		clientId: number;
+		referenceSequenceNumber: number;
+		sequenceNumber: number;
+	} {
 		// If there this no sequenced message, then the op is local
 		// and unacked, so use this clients sequenced args
 		//
-		if (!sequencedMessage) {
-			const segWindow = this.getCollabWindow();
-			return {
-				clientId: segWindow.clientId,
-				referenceSequenceNumber: segWindow.currentSeq,
-				sequenceNumber: this.getLocalSequenceNumber(),
-			};
-		} else {
+		if (sequencedMessage) {
 			return {
 				clientId: this.getOrAddShortClientIdFromMessage(sequencedMessage),
 				referenceSequenceNumber: sequencedMessage.referenceSequenceNumber,
@@ -673,6 +676,13 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 				// return value isn't expected to have it either.
 				sequenceNumber: (sequencedMessage as ISequencedDocumentMessage).sequenceNumber,
 			};
+		} else {
+			const segWindow = this.getCollabWindow();
+			return {
+				clientId: segWindow.clientId,
+				referenceSequenceNumber: segWindow.currentSeq,
+				sequenceNumber: this.getLocalSequenceNumber(),
+			};
 		}
 	}
 
@@ -684,7 +694,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		return this.getClientSequenceArgsForMessage(opArgs.sequencedMessage);
 	}
 
-	private ackPendingSegment(opArgs: IMergeTreeDeltaRemoteOpArgs) {
+	private ackPendingSegment(opArgs: IMergeTreeDeltaRemoteOpArgs): void {
 		if (opArgs.op.type === MergeTreeDeltaType.GROUP) {
 			for (const memberOp of opArgs.op.ops) {
 				this._mergeTree.ackPendingSegment({
@@ -698,27 +708,29 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		}
 	}
 
-	getOrAddShortClientId(longClientId: string) {
+	getOrAddShortClientId(longClientId: string): number {
 		if (!this.clientNameToIds.get(longClientId)) {
 			this.addLongClientId(longClientId);
 		}
 		return this.getShortClientId(longClientId);
 	}
 
-	protected getShortClientId(longClientId: string) {
+	protected getShortClientId(longClientId: string): number {
 		return this.clientNameToIds.get(longClientId)!.data;
 	}
 
-	getLongClientId(shortClientId: number) {
-		return shortClientId >= 0 ? this.shortClientIdMap[shortClientId] : "original";
+	getLongClientId(shortClientId: number): string {
+		return shortClientId >= 0 ? this.shortClientIdMap[shortClientId]! : "original";
 	}
 
-	addLongClientId(longClientId: string) {
+	addLongClientId(longClientId: string): void {
 		this.clientNameToIds.put(longClientId, this.shortClientIdMap.length);
 		this.shortClientIdMap.push(longClientId);
 	}
 
-	private getOrAddShortClientIdFromMessage(msg: Pick<ISequencedDocumentMessage, "clientId">) {
+	private getOrAddShortClientIdFromMessage(
+		msg: Pick<ISequencedDocumentMessage, "clientId">,
+	): number {
 		return this.getOrAddShortClientId(msg.clientId ?? "server");
 	}
 
@@ -731,7 +743,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	 * @param segment - The segment to find the position for
 	 * @param localSeq - The localSeq to find the position of the segment at
 	 */
-	public findReconnectionPosition(segment: ISegment, localSeq: number) {
+	public findReconnectionPosition(segment: ISegment, localSeq: number): number {
 		assert(
 			localSeq <= this._mergeTree.collabWindow.localSeq,
 			0x032 /* "localSeq greater than collab window" */,
@@ -783,7 +795,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 			const segmentPosition = this.findReconnectionPosition(segment, segmentGroup.localSeq);
 			let newOp: IMergeTreeDeltaOp | undefined;
 			switch (resetOp.type) {
-				case MergeTreeDeltaType.ANNOTATE:
+				case MergeTreeDeltaType.ANNOTATE: {
 					assert(
 						segment.propertyManager?.hasPendingProperties(resetOp.props) === true,
 						0x036 /* "Segment has no pending properties" */,
@@ -806,17 +818,20 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 						);
 					}
 					break;
+				}
 
-				case MergeTreeDeltaType.INSERT:
+				case MergeTreeDeltaType.INSERT: {
 					assert(
 						segment.seq === UnassignedSequenceNumber,
 						0x037 /* "Segment already has assigned sequence number" */,
 					);
 					let segInsertOp = segment;
+					// The suppression is needed because the segment needs to have a type of any.
+					// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
 					if (typeof resetOp.seg === "object" && resetOp.seg.props !== undefined) {
 						segInsertOp = segment.clone();
-						// eslint-disable-next-line import/no-deprecated
 						segInsertOp.properties = createMap();
+						// eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access
 						segInsertOp.addProperties(resetOp.seg.props);
 					}
 					if (segment.movedSeq !== UnassignedSequenceNumber) {
@@ -824,8 +839,9 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 					}
 					newOp = createInsertSegmentOp(segmentPosition, segInsertOp);
 					break;
+				}
 
-				case MergeTreeDeltaType.REMOVE:
+				case MergeTreeDeltaType.REMOVE: {
 					if (
 						segment.localRemovedSeq !== undefined &&
 						segment.removedSeq === UnassignedSequenceNumber &&
@@ -839,7 +855,8 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 						);
 					}
 					break;
-				case MergeTreeDeltaType.OBLITERATE:
+				}
+				case MergeTreeDeltaType.OBLITERATE: {
 					if (
 						segment.localMovedSeq !== undefined &&
 						segment.movedSeq === UnassignedSequenceNumber &&
@@ -853,8 +870,10 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 						);
 					}
 					break;
-				default:
+				}
+				default: {
 					throw new Error(`Invalid op type`);
+				}
 			}
 
 			if (newOp && resetOp.type === MergeTreeDeltaType.OBLITERATE) {
@@ -892,23 +911,27 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		return opList;
 	}
 
-	private applyRemoteOp(opArgs: IMergeTreeDeltaRemoteOpArgs) {
+	private applyRemoteOp(opArgs: IMergeTreeDeltaRemoteOpArgs): void {
 		const op = opArgs.op;
 		const msg = opArgs.sequencedMessage;
 		this.getOrAddShortClientIdFromMessage(msg);
 		switch (op.type) {
-			case MergeTreeDeltaType.INSERT:
+			case MergeTreeDeltaType.INSERT: {
 				this.applyInsertOp(opArgs);
 				break;
-			case MergeTreeDeltaType.REMOVE:
+			}
+			case MergeTreeDeltaType.REMOVE: {
 				this.applyRemoveRangeOp(opArgs);
 				break;
-			case MergeTreeDeltaType.ANNOTATE:
+			}
+			case MergeTreeDeltaType.ANNOTATE: {
 				this.applyAnnotateRangeOp(opArgs);
 				break;
-			case MergeTreeDeltaType.OBLITERATE:
+			}
+			case MergeTreeDeltaType.OBLITERATE: {
 				this.applyObliterateRangeOp(opArgs);
 				break;
+			}
 			case MergeTreeDeltaType.GROUP: {
 				for (const memberOp of op.ops) {
 					this.applyRemoteOp({
@@ -919,34 +942,41 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 				}
 				break;
 			}
-			default:
+			default: {
 				break;
+			}
 		}
 	}
 
 	public applyStashedOp(op: IMergeTreeOp): void {
 		switch (op.type) {
-			case MergeTreeDeltaType.INSERT:
+			case MergeTreeDeltaType.INSERT: {
 				this.applyInsertOp({ op });
 				break;
-			case MergeTreeDeltaType.REMOVE:
+			}
+			case MergeTreeDeltaType.REMOVE: {
 				this.applyRemoveRangeOp({ op });
 				break;
-			case MergeTreeDeltaType.ANNOTATE:
+			}
+			case MergeTreeDeltaType.ANNOTATE: {
 				this.applyAnnotateRangeOp({ op });
 				break;
-			case MergeTreeDeltaType.OBLITERATE:
+			}
+			case MergeTreeDeltaType.OBLITERATE: {
 				this.applyObliterateRangeOp({ op });
 				break;
-			case MergeTreeDeltaType.GROUP:
+			}
+			case MergeTreeDeltaType.GROUP: {
 				op.ops.map((o) => this.applyStashedOp(o));
 				break;
-			default:
+			}
+			default: {
 				unreachableCase(op, "unrecognized op type");
+			}
 		}
 	}
 
-	public applyMsg(msg: ISequencedDocumentMessage, local: boolean = false) {
+	public applyMsg(msg: ISequencedDocumentMessage, local: boolean = false): void {
 		// Ensure client ID is registered
 		this.getOrAddShortClientIdFromMessage(msg);
 		// Apply if an operation message
@@ -969,7 +999,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		this.updateSeqNumbers(min, msg.sequenceNumber);
 	}
 
-	private updateSeqNumbers(min: number, seq: number) {
+	private updateSeqNumbers(min: number, seq: number): void {
 		const collabWindow = this.getCollabWindow();
 		// Equal is fine here due to SharedSegmentSequence<>.snapshotContent() potentially updating with same #
 		assert(
@@ -1027,7 +1057,8 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 					// eslint-disable-next-line import/no-deprecated
 					return createGroupOp();
 				}
-				firstGroup = segmentGroup[0];
+				// TODO Non null asserting, why is this not null?
+				firstGroup = segmentGroup[0]!;
 			} else {
 				firstGroup = segmentGroup;
 			}
@@ -1057,7 +1088,8 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 				);
 
 				for (let i = 0; i < resetOp.ops.length; i++) {
-					opList.push(...this.resetPendingDeltaToOps(resetOp.ops[i], segmentGroup[i]));
+					// Non null asserting because resetOp and segmentGroup are arrays of same length and loop is length of resetOp
+					opList.push(...this.resetPendingDeltaToOps(resetOp.ops[i]!, segmentGroup[i]!));
 				}
 			} else {
 				// A group op containing a single op will pass a direct reference to 'segmentGroup'
@@ -1066,11 +1098,12 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 					resetOp.ops.length === 1,
 					0x03b /* "Number of ops in 'resetOp' must match the number of segment groups provided." */,
 				);
-				opList.push(...this.resetPendingDeltaToOps(resetOp.ops[0], segmentGroup));
+				// Non null asserting because of length assert above
+				opList.push(...this.resetPendingDeltaToOps(resetOp.ops[0]!, segmentGroup));
 			}
 		} else {
 			assert(
-				(resetOp.type as any) !== MergeTreeDeltaType.GROUP,
+				(resetOp.type as unknown) !== MergeTreeDeltaType.GROUP,
 				0x03c /* "Reset op has 'group' delta type!" */,
 			);
 			assert(
@@ -1079,8 +1112,9 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 			);
 			opList.push(...this.resetPendingDeltaToOps(resetOp, segmentGroup));
 		}
+		// TODO why are we non null asserting here?
 		// eslint-disable-next-line import/no-deprecated
-		return opList.length === 1 ? opList[0] : createGroupOp(...opList);
+		return opList.length === 1 ? opList[0]! : createGroupOp(...opList);
 	}
 
 	// eslint-disable-next-line import/no-deprecated
@@ -1139,38 +1173,43 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		return loader.initialize(storage);
 	}
 
-	private getLocalSequenceNumber() {
+	private getLocalSequenceNumber(): number {
 		const segWindow = this.getCollabWindow();
 		return segWindow.collaborating ? UnassignedSequenceNumber : UniversalSequenceNumber;
 	}
 
 	// eslint-disable-next-line import/no-deprecated
-	localTransaction(groupOp: IMergeTreeGroupMsg) {
+	localTransaction(groupOp: IMergeTreeGroupMsg): void {
 		for (const op of groupOp.ops) {
 			const opArgs: IMergeTreeDeltaOpArgs = {
 				op,
 				groupOp,
 			};
 			switch (op.type) {
-				case MergeTreeDeltaType.INSERT:
+				case MergeTreeDeltaType.INSERT: {
 					this.applyInsertOp(opArgs);
 					break;
-				case MergeTreeDeltaType.ANNOTATE:
+				}
+				case MergeTreeDeltaType.ANNOTATE: {
 					this.applyAnnotateRangeOp(opArgs);
 					break;
-				case MergeTreeDeltaType.REMOVE:
+				}
+				case MergeTreeDeltaType.REMOVE: {
 					this.applyRemoveRangeOp(opArgs);
 					break;
-				case MergeTreeDeltaType.OBLITERATE:
+				}
+				case MergeTreeDeltaType.OBLITERATE: {
 					this.applyObliterateRangeOp(opArgs);
 					break;
-				default:
+				}
+				default: {
 					break;
+				}
 			}
 		}
 	}
 
-	updateMinSeq(minSeq: number) {
+	updateMinSeq(minSeq: number): void {
 		this._mergeTree.setMinSeq(minSeq);
 	}
 
@@ -1178,7 +1217,10 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		pos: number,
 		sequenceArgs?: Pick<ISequencedDocumentMessage, "referenceSequenceNumber" | "clientId">,
 		localSeq?: number,
-	) {
+	): {
+		segment: T | undefined;
+		offset: number | undefined;
+	} {
 		const { referenceSequenceNumber, clientId } =
 			this.getClientSequenceArgsForMessage(sequenceArgs);
 		return this._mergeTree.getContainingSegment<T>(
@@ -1189,7 +1231,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		);
 	}
 
-	getPropertiesAtPosition(pos: number) {
+	getPropertiesAtPosition(pos: number): PropertySet | undefined {
 		let propertiesAtPosition: PropertySet | undefined;
 		const segoff = this.getContainingSegment(pos);
 		const seg = segoff.segment;
@@ -1199,7 +1241,10 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		return propertiesAtPosition;
 	}
 
-	getRangeExtentsOfPosition(pos: number) {
+	getRangeExtentsOfPosition(pos: number): {
+		posStart: number | undefined;
+		posAfterEnd: number | undefined;
+	} {
 		let posStart: number | undefined;
 		let posAfterEnd: number | undefined;
 
@@ -1212,19 +1257,23 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 		return { posStart, posAfterEnd };
 	}
 
-	getCurrentSeq() {
+	getCurrentSeq(): number {
 		return this.getCollabWindow().currentSeq;
 	}
 
-	getClientId() {
+	getClientId(): number {
 		return this.getCollabWindow().clientId;
 	}
 
-	getLength() {
+	getLength(): number {
 		return this._mergeTree.length ?? 0;
 	}
 
-	startOrUpdateCollaboration(longClientId: string | undefined, minSeq = 0, currentSeq = 0) {
+	startOrUpdateCollaboration(
+		longClientId: string | undefined,
+		minSeq = 0,
+		currentSeq = 0,
+	): void {
 		// we should always have a client id if we are collaborating
 		// if the client id is undefined we are likely bound to a detached
 		// container, so we should keep going in local mode. once
@@ -1258,7 +1307,7 @@ export class Client extends TypedEventEmitter<IClientEvents> {
 	 * @param markerLabel - Label of the marker to search for
 	 * @param forwards - Whether the desired marker comes before (false) or after (true) `startPos`
 	 */
-	searchForMarker(startPos: number, markerLabel: string, forwards = true) {
+	searchForMarker(startPos: number, markerLabel: string, forwards = true): Marker | undefined {
 		const clientId = this.getClientId();
 		return this._mergeTree.searchForMarker(startPos, clientId, markerLabel, forwards);
 	}

package/src/collections/list.ts

@@ -33,11 +33,13 @@ class HeadNode<T> {
 	public get prev(): DataNode<T> | undefined {
 		return this._prev === this.headNode ? undefined : (this._prev as DataNode<T>);
 	}
-	public get list() {
+	public get list(): DoublyLinkedList<T> | undefined {
 		return this.headNode._list;
 	}
 }
 
+// The any is needed for use in the remove function, where the nodes are defined with a generic type.
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 const DeadHead = new HeadNode<any>(undefined);
 
 class DataNode<T> extends HeadNode<T> implements ListNode<T> {
@@ -54,7 +56,7 @@ function insertAfter<T>(node: DataNode<T> | HeadNode<T>, items: T[]): ListNodeRa
 	let previousNode = node;
 	const oldNext = previousNode._next;
 	let newRange: ListNodeRange<T> | undefined;
-	items.forEach((n) => {
+	for (const n of items) {
 		const newNode = new DataNode<T>(node.headNode, n);
 		if (newRange === undefined) {
 			newRange = { first: newNode, last: newNode };
@@ -64,7 +66,7 @@ function insertAfter<T>(node: DataNode<T> | HeadNode<T>, items: T[]): ListNodeRa
 		newNode._prev = previousNode;
 		previousNode._next = newNode;
 		previousNode = newNode;
-	});
+	}
 	oldNext._prev = previousNode;
 	previousNode._next = oldNext;
 	// explicitly prevent newRange from being undefined without casting,
@@ -191,6 +193,7 @@ export class DoublyLinkedList<T>
 		if (this._includes(node)) {
 			node._prev._next = node._next;
 			node._next._prev = node._prev;
+			// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 			node.headNode = node._next = node._prev = DeadHead;
 			this._len--;
 			return node;
@@ -222,10 +225,10 @@ export class DoublyLinkedList<T>
 
 	private _len: number = 0;
 	private readonly headNode: HeadNode<T> | DataNode<T> = new HeadNode(this);
-	public get length() {
+	public get length(): number {
 		return this._len;
 	}
-	public get empty() {
+	public get empty(): boolean {
 		return this._len === 0;
 	}
 	public get first(): ListNode<T> | undefined {
@@ -242,7 +245,7 @@ export function walkList<T>(
 	visitor: (node: ListNode<T>) => boolean | void,
 	start?: ListNode<T>,
 	forward: boolean = true,
-) {
+): boolean {
 	let current: ListNode<T> | undefined;
 	if (start) {
 		if (!list.includes(start)) {