@fluidframework/merge-tree 0.53.0 → 0.54.2

package/src/partialLengths.ts

@@ -236,7 +236,7 @@ export class PartialSequenceLengths {
                         PartialSequenceLengths.insertSegment(combinedPartialLengths, segment);
                     }
                 }
-                const removalInfo = mergeTree.getRemovalInfo(segment);
+                const removalInfo: IRemovalInfo = segment;
                 // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                 if (seqLTE(removalInfo.removedSeq!, collabWindow.minSeq)) {
                     combinedPartialLengths.minLength -= segment.cachedLength;
@@ -425,7 +425,7 @@ export class PartialSequenceLengths {
                 segCount += branchPartialLengths.segmentCount;
             } else {
                 const segment = child;
-                const removalInfo = mergeTree.getRemovalInfo(segment);
+                const removalInfo: IRemovalInfo = segment;
 
                 if (segment.seq === seq) {
                     if (removalInfo.removedSeq !== seq) {

package/src/textSegment.ts

@@ -9,6 +9,16 @@ import { IJSONSegment } from "./ops";
 import { PropertySet } from "./properties";
 import { LocalReferenceCollection } from "./localReference";
 
+// Maximum length of text segment to be considered to be merged with other segment.
+// Maximum segment length is at least 2x of it (not taking into account initial segment creation).
+// The bigger it is, the more expensive it is to break segment into sub-segments (on edits)
+// The smaller it is, the more segments we have in snapshots (and in memory) - it's more expensive to load snapshots.
+// Small number also makes ReplayTool produce false positives ("same" snapshots have slightly different binary
+// representations).  More measurements needs to be done, but it's very likely the right spot is somewhere between
+// 1K-2K mark.  That said, we also break segments on newline and there are very few segments that are longer than 256
+// because of it.  Must be an even number
+const TextSegmentGranularity = 256;
+
 export interface IJSONTextSegment extends IJSONSegment {
     text: string;
 }
@@ -63,8 +73,8 @@ export class TextSegment extends BaseSegment {
     public canAppend(segment: ISegment): boolean {
         return !this.text.endsWith("\n")
             && TextSegment.is(segment)
-            && (this.cachedLength <= MergeTree.TextSegmentGranularity ||
-                segment.cachedLength <= MergeTree.TextSegmentGranularity);
+            && (this.cachedLength <= TextSegmentGranularity ||
+                segment.cachedLength <= TextSegmentGranularity);
     }
 
     public toString() {