@fluidframework/local-driver 2.91.0 → 2.92.0

package/src/localDocumentService.ts

@@ -4,9 +4,9 @@
  */
 
 import { TypedEventEmitter } from "@fluid-internal/client-utils";
-import { ITelemetryBaseLogger } from "@fluidframework/core-interfaces";
-import { IClient } from "@fluidframework/driver-definitions";
-import {
+import type { ITelemetryBaseLogger } from "@fluidframework/core-interfaces";
+import type { IClient } from "@fluidframework/driver-definitions";
+import type {
 	IDocumentDeltaConnection,
 	IDocumentDeltaStorageService,
 	IDocumentService,
@@ -15,8 +15,8 @@ import {
 	IDocumentStorageService,
 	IResolvedUrl,
 } from "@fluidframework/driver-definitions/internal";
-import { ITokenProvider } from "@fluidframework/routerlicious-driver";
-import { ILocalDeltaConnectionServer } from "@fluidframework/server-local-server";
+import type { ITokenProvider } from "@fluidframework/routerlicious-driver";
+import type { ILocalDeltaConnectionServer } from "@fluidframework/server-local-server";
 import { GitManager } from "@fluidframework/server-services-client";
 import { TestHistorian } from "@fluidframework/server-test-utils";
 

package/src/localDocumentServiceFactory.ts

@@ -3,9 +3,9 @@
  * Licensed under the MIT License.
  */
 
-import { ITelemetryBaseLogger } from "@fluidframework/core-interfaces";
-import { ISummaryTree } from "@fluidframework/driver-definitions";
-import {
+import type { ITelemetryBaseLogger } from "@fluidframework/core-interfaces";
+import type { ISummaryTree } from "@fluidframework/driver-definitions";
+import type {
 	IDocumentService,
 	IDocumentServiceFactory,
 	IDocumentServicePolicies,
@@ -13,10 +13,10 @@ import {
 	NackErrorType,
 } from "@fluidframework/driver-definitions/internal";
 import { DefaultTokenProvider } from "@fluidframework/routerlicious-driver/internal";
-import { ILocalDeltaConnectionServer } from "@fluidframework/server-local-server";
+import type { ILocalDeltaConnectionServer } from "@fluidframework/server-local-server";
 
 import { createDocument } from "./localCreateDocument.js";
-import { LocalDocumentDeltaConnection } from "./localDocumentDeltaConnection.js";
+import type { LocalDocumentDeltaConnection } from "./localDocumentDeltaConnection.js";
 import { createLocalDocumentService } from "./localDocumentService.js";
 import { localDriverCompatDetailsForLoader } from "./localLayerCompatState.js";
 

package/src/localDocumentStorageService.ts

@@ -10,25 +10,25 @@ import {
 	stringToBuffer,
 } from "@fluid-internal/client-utils";
 import { assert } from "@fluidframework/core-utils/internal";
-import { ISummaryHandle, ISummaryTree } from "@fluidframework/driver-definitions";
-import {
+import type { ISummaryHandle, ISummaryTree } from "@fluidframework/driver-definitions";
+import type {
+	ICreateBlobResponse,
 	IDocumentStorageService,
 	IDocumentStorageServicePolicies,
 	IResolvedUrl,
-	type ISnapshot,
-	type ISnapshotFetchOptions,
-	ISummaryContext,
-	ICreateBlobResponse,
+	ISnapshot,
+	ISnapshotFetchOptions,
 	ISnapshotTreeEx,
+	ISummaryContext,
 	IVersion,
 } from "@fluidframework/driver-definitions/internal";
 import { buildGitTreeHierarchy } from "@fluidframework/protocol-base";
-import { ILocalDeltaConnectionServer } from "@fluidframework/server-local-server";
-import {
+import type { ILocalDeltaConnectionServer } from "@fluidframework/server-local-server";
+import type {
 	GitManager,
 	ISummaryUploadManager,
-	SummaryTreeUploadManager,
 } from "@fluidframework/server-services-client";
+import { SummaryTreeUploadManager } from "@fluidframework/server-services-client";
 
 import { createDocument } from "./localCreateDocument.js";
 
@@ -218,7 +218,7 @@ export class LocalDocumentStorageService implements IDocumentStorageService {
 				);
 			}),
 		);
-		const isAncestorOfDescendantsWithGroupId = descendants.some((keep) => keep);
+		const isAncestorOfDescendantsWithGroupId = descendants.some(Boolean);
 
 		// We don't want to return prematurely as we still may have children that we want to keep.
 		if (

package/src/localResolver.ts

@@ -3,14 +3,10 @@
  * Licensed under the MIT License.
  */
 
-import { IRequest } from "@fluidframework/core-interfaces";
+import type { IRequest } from "@fluidframework/core-interfaces";
 import { assert } from "@fluidframework/core-utils/internal";
-import {
-	DriverHeader,
-	IResolvedUrl,
-	IUrlResolver,
-	ScopeType,
-} from "@fluidframework/driver-definitions/internal";
+import type { IResolvedUrl, IUrlResolver } from "@fluidframework/driver-definitions/internal";
+import { DriverHeader, ScopeType } from "@fluidframework/driver-definitions/internal";
 
 import { generateToken } from "./auth.js";
 
@@ -48,7 +44,7 @@ export class LocalResolver implements IUrlResolver {
 	 */
 	public async resolve(request: IRequest): Promise<IResolvedUrl> {
 		const parsedUrl = new URL(request.url);
-		const fullPath = `${parsedUrl.pathname.substr(1)}${parsedUrl.search}`;
+		const fullPath = `${parsedUrl.pathname.slice(1)}${parsedUrl.search}`;
 		// TODO Why are we non null asserting here
 		// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 		const documentId = fullPath.split("/")[0]!;
@@ -74,13 +70,13 @@ export class LocalResolver implements IUrlResolver {
 	): Promise<string> {
 		let url = relativeUrl;
 		if (url.startsWith("/")) {
-			url = url.substr(1);
+			url = url.slice(1);
 		}
 		const parsedUrl = new URL(resolvedUrl.url);
 		if (parsedUrl.pathname === null) {
 			throw new Error("Url should contain tenant and docId!!");
 		}
-		const [, , documentId] = parsedUrl.pathname.split("/");
+		const documentId = parsedUrl.pathname.split("/")[2];
 		assert(
 			!!documentId,
 			0x09a /* "'documentId' must be a defined, non-zero length string." */,

package/src/localSessionStorageDb.ts

@@ -4,8 +4,8 @@
  */
 
 import { EventEmitter } from "@fluid-internal/client-utils";
-import { ICollection, IDb } from "@fluidframework/server-services-core";
-import { ITestDbFactory } from "@fluidframework/server-test-utils";
+import type { ICollection, IDb } from "@fluidframework/server-services-core";
+import type { ITestDbFactory } from "@fluidframework/server-test-utils";
 import { v4 as uuid } from "uuid";
 
 /**
@@ -44,18 +44,18 @@ class LocalSessionStorageCollection<T> implements ICollection<T> {
 		function getValueByKey(propertyBag, key: string): any {
 			const keys = key.split(".");
 			let value = propertyBag;
-			keys.forEach((splitKey) => {
+			for (const splitKey of keys) {
 				value = value[splitKey];
-			});
+			}
 			return value;
 		}
 
 		// getting keys of the query we are trying to find
 		const queryKeys = Object.keys(query);
 		let filteredCollection = this.getAllInternal();
-		queryKeys.forEach((key) => {
+		for (const key of queryKeys) {
 			if (!query[key]) {
-				return;
+				continue;
 			}
 			if (query[key].$gt > 0 || query[key].$lt > 0) {
 				if (query[key].$gt > 0) {
@@ -73,7 +73,7 @@ class LocalSessionStorageCollection<T> implements ICollection<T> {
 					(value) => getValueByKey(value, key) === query[key],
 				);
 			}
-		});
+		}
 
 		if (sort && Object.keys(sort).length === 1) {
 			function compare(a, b): number {
@@ -115,13 +115,13 @@ class LocalSessionStorageCollection<T> implements ICollection<T> {
 	 */
 	public async update(query: any, set: any, addToSet: any): Promise<void> {
 		const value = this.findOneInternal(query);
-		if (!value) {
-			throw new Error("Not found");
-		} else {
+		if (value) {
 			for (const key of Object.keys(set)) {
 				value[key] = set[key];
 			}
 			this.insertInternal(value);
+		} else {
+			throw new Error("Not found");
 		}
 	}
 
@@ -133,13 +133,13 @@ class LocalSessionStorageCollection<T> implements ICollection<T> {
 	 */
 	public async upsert(query: any, set: any, addToSet: any): Promise<void> {
 		const value = this.findOneInternal(query);
-		if (!value) {
-			this.insertInternal(set);
-		} else {
+		if (value) {
 			for (const key of Object.keys(set)) {
 				value[key] = set[key];
 			}
 			this.insertInternal(value);
+		} else {
+			this.insertInternal(set);
 		}
 	}
 

package/src/packageVersion.ts

@@ -6,4 +6,4 @@
  */
 
 export const pkgName = "@fluidframework/local-driver";
-export const pkgVersion = "2.91.0";
+export const pkgVersion = "2.92.0";