@fluidframework/driver-utils 2.0.0-internal.3.0.5 → 2.0.0-internal.3.1.1

package/src/blobAggregationStorage.ts

@@ -4,61 +4,63 @@
  */
 
 import {
-     IDocumentStorageService,
-    IDocumentStorageServicePolicies,
-     ISummaryContext,
+	FetchSource,
+	IDocumentStorageService,
+	IDocumentStorageServicePolicies,
+	ISummaryContext,
 } from "@fluidframework/driver-definitions";
 import {
-    ICreateBlobResponse,
-    ISnapshotTree,
-    ISummaryHandle,
-    ISummaryTree,
-    IVersion,
-    SummaryType,
+	ICreateBlobResponse,
+	ISnapshotTree,
+	ISummaryHandle,
+	ISummaryTree,
+	IVersion,
+	SummaryType,
 } from "@fluidframework/protocol-definitions";
 import {
-    assert,
-    bufferToString,
-    stringToBuffer,
-    unreachableCase,
-    fromUtf8ToBase64,
-    Uint8ArrayToString,
- } from "@fluidframework/common-utils";
+	assert,
+	bufferToString,
+	stringToBuffer,
+	unreachableCase,
+	fromUtf8ToBase64,
+	Uint8ArrayToString,
+} from "@fluidframework/common-utils";
 import { ITelemetryLogger } from "@fluidframework/common-definitions";
 import { loggerToMonitoringContext } from "@fluidframework/telemetry-utils";
 
 /*
  * Work around for bufferToString having a bug - it can't consume IsoBuffer!
  * To be removed once bufferToString is fixed!
-*/
+ */
 function bufferToString2(blob: ArrayBufferLike, encoding: "utf-8" | "base64"): string {
-    if (blob instanceof Uint8Array) { // IsoBuffer does not have ctor, so it's not in proto chain :(
-        return Uint8ArrayToString(blob, encoding);
-    }
-    return bufferToString(blob, encoding);
+	if (blob instanceof Uint8Array) {
+		// IsoBuffer does not have ctor, so it's not in proto chain :(
+		return Uint8ArrayToString(blob, encoding);
+	}
+	return bufferToString(blob, encoding);
 }
 
- /**
-  * Class responsible for aggregating smaller blobs into one and unpacking it later on.
-  */
+/**
+ * Class responsible for aggregating smaller blobs into one and unpacking it later on.
+ */
 class BlobAggregator {
-    private readonly content: [string, string][] = [];
-
-    public addBlob(key: string, content: string) {
-        this.content.push([key, content]);
-    }
-
-    public getAggregatedBlobContent() {
-        if (this.content.length === 0) {
-            return undefined;
-        }
-        return JSON.stringify(this.content);
-    }
-
-    static load(input: ArrayBufferLike) {
-        const data = bufferToString2(input, "utf-8");
-        return JSON.parse(data) as [string, string][];
-    }
+	private readonly content: [string, string][] = [];
+
+	public addBlob(key: string, content: string) {
+		this.content.push([key, content]);
+	}
+
+	public getAggregatedBlobContent() {
+		if (this.content.length === 0) {
+			return undefined;
+		}
+		return JSON.stringify(this.content);
+	}
+
+	static load(input: ArrayBufferLike) {
+		const data = bufferToString2(input, "utf-8");
+		return JSON.parse(data) as [string, string][];
+	}
 }
 
 /*
@@ -66,51 +68,56 @@ class BlobAggregator {
  * It relies on abstract methods for reads and storing unpacked blobs.
  */
 export abstract class SnapshotExtractor {
-    protected readonly aggregatedBlobName = "__big";
-    protected readonly virtualIdPrefix = "__";
-
-    // counter for generation of virtual storage IDs
-    protected virtualIdCounter = 0;
-    protected getNextVirtualId() {
-        return `${this.virtualIdPrefix}${++this.virtualIdCounter}`;
-    }
-
-    abstract getBlob(id: string, tree: ISnapshotTree): Promise<ArrayBufferLike>;
-    abstract setBlob(id: string, tree: ISnapshotTree, content: string);
-
-    public async unpackSnapshotCore(snapshot: ISnapshotTree, level = 0): Promise<void> {
-        for (const key of Object.keys(snapshot.trees)) {
-            const obj = snapshot.trees[key];
-            await this.unpackSnapshotCore(obj, level + 1);
-        }
-
-        // For future proof, we will support multiple aggregated blobs with any name
-        // that starts with this.aggregatedBlobName
-        for (const key of Object.keys(snapshot.blobs)) {
-            if (!key.startsWith(this.aggregatedBlobName)) { continue; }
-            const blobId = snapshot.blobs[key];
-            if (blobId !== undefined) {
-                const blob = await this.getBlob(blobId, snapshot);
-                for (const [path, value] of BlobAggregator.load(blob)) {
-                    const id = this.getNextVirtualId();
-                    this.setBlob(id, snapshot, value);
-                    const pathSplit = path.split("/");
-                    let subTree = snapshot;
-                    for (const subPath of pathSplit.slice(0, pathSplit.length - 1)) {
-                        if (subTree.trees[subPath] === undefined) {
-                            subTree.trees[subPath] = { blobs: {}, trees: {} };
-                        }
-                        subTree = subTree.trees[subPath];
-                    }
-                    const blobName = pathSplit[pathSplit.length - 1];
-                    assert(subTree.blobs[blobName] === undefined, 0x0f6 /* "real blob ID exists" */);
-                    subTree.blobs[blobName] = id;
-                }
-                // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
-                delete snapshot.blobs[this.aggregatedBlobName];
-            }
-        }
-    }
+	protected readonly aggregatedBlobName = "__big";
+	protected readonly virtualIdPrefix = "__";
+
+	// counter for generation of virtual storage IDs
+	protected virtualIdCounter = 0;
+	protected getNextVirtualId() {
+		return `${this.virtualIdPrefix}${++this.virtualIdCounter}`;
+	}
+
+	abstract getBlob(id: string, tree: ISnapshotTree): Promise<ArrayBufferLike>;
+	abstract setBlob(id: string, tree: ISnapshotTree, content: string);
+
+	public async unpackSnapshotCore(snapshot: ISnapshotTree, level = 0): Promise<void> {
+		for (const key of Object.keys(snapshot.trees)) {
+			const obj = snapshot.trees[key];
+			await this.unpackSnapshotCore(obj, level + 1);
+		}
+
+		// For future proof, we will support multiple aggregated blobs with any name
+		// that starts with this.aggregatedBlobName
+		for (const key of Object.keys(snapshot.blobs)) {
+			if (!key.startsWith(this.aggregatedBlobName)) {
+				continue;
+			}
+			const blobId = snapshot.blobs[key];
+			if (blobId !== undefined) {
+				const blob = await this.getBlob(blobId, snapshot);
+				for (const [path, value] of BlobAggregator.load(blob)) {
+					const id = this.getNextVirtualId();
+					this.setBlob(id, snapshot, value);
+					const pathSplit = path.split("/");
+					let subTree = snapshot;
+					for (const subPath of pathSplit.slice(0, pathSplit.length - 1)) {
+						if (subTree.trees[subPath] === undefined) {
+							subTree.trees[subPath] = { blobs: {}, trees: {} };
+						}
+						subTree = subTree.trees[subPath];
+					}
+					const blobName = pathSplit[pathSplit.length - 1];
+					assert(
+						subTree.blobs[blobName] === undefined,
+						0x0f6 /* "real blob ID exists" */,
+					);
+					subTree.blobs[blobName] = id;
+				}
+				// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+				delete snapshot.blobs[this.aggregatedBlobName];
+			}
+		}
+	}
 }
 
 /*
@@ -127,16 +134,19 @@ export abstract class SnapshotExtractor {
  * fixing existing flows to allow switching of storage.
  */
 class SnapshotExtractorInPlace extends SnapshotExtractor {
-    public async getBlob(id: string, tree: ISnapshotTree): Promise<ArrayBufferLike> {
-        const blob = tree.blobs[id];
-        assert(blob !== undefined, 0x0f7 /* "aggregate blob missing" */);
-        return stringToBuffer(blob, "base64");
-    }
-
-    public setBlob(id: string, tree: ISnapshotTree, content: string) {
-        assert(tree.blobs[id] === undefined, 0x0f8 /* "blob from aggregate blob exists on its own" */);
-        tree.blobs[id] = fromUtf8ToBase64(content);
-    }
+	public async getBlob(id: string, tree: ISnapshotTree): Promise<ArrayBufferLike> {
+		const blob = tree.blobs[id];
+		assert(blob !== undefined, 0x0f7 /* "aggregate blob missing" */);
+		return stringToBuffer(blob, "base64");
+	}
+
+	public setBlob(id: string, tree: ISnapshotTree, content: string) {
+		assert(
+			tree.blobs[id] === undefined,
+			0x0f8 /* "blob from aggregate blob exists on its own" */,
+		);
+		tree.blobs[id] = fromUtf8ToBase64(content);
+	}
 }
 
 /*
@@ -145,230 +155,272 @@ class SnapshotExtractorInPlace extends SnapshotExtractor {
  * When snapshot is read, it will unpack aggregated blobs and provide them transparently to caller.
  */
 export class BlobAggregationStorage extends SnapshotExtractor implements IDocumentStorageService {
-    // Tells data store if it can use incremental summary (i.e. reuse DDSes from previous summary
-    // when only one DDS changed).
-    // The answer has to be know long before we enable actual packing. The reason for the is the following:
-    // A the moment when we enable packing, we should assume that all clients out there wil already have bits
-    // that can unpack properly (i.e. enough time passed since we deployed bits that can unpack)
-    // But we can still have clients where some of them already pack, and some do not. If one summary was
-    // using packing, then it relies on non-incremental summaries going forward, even if next client who
-    // produced summary is not packing!
-    // This can have slight improvement by enabling it per file (based on "did summary we loaded from contain
-    // aggregated blobs"), but that's harder to make reliable, so going for simplicity.
-    static readonly fullDataStoreSummaries = true;
-
-    protected loadedFromSummary = false;
-
-    protected virtualBlobs = new Map<string, ArrayBufferLike>();
-
-    static wrap(
-        storage: IDocumentStorageService,
-        logger: ITelemetryLogger,
-        allowPacking?: boolean,
-        packingLevel = 2,
-    ) {
-        if (storage instanceof BlobAggregationStorage) {
-            return storage;
-        }
-        const mc = loggerToMonitoringContext(logger);
-        const realAllowPackaging = mc.config.getBoolean("FluidAggregateBlobs") ?? allowPacking ?? false;
-
-        // Always create BlobAggregationStorage even if storage is not asking for packing.
-        // This is mostly to avoid cases where future changes in policy would result in inability to
-        // load old files that were created with aggregation on.
-        const minBlobSize = storage.policies?.minBlobSize;
-        return new BlobAggregationStorage(storage, logger, realAllowPackaging, packingLevel, minBlobSize);
-    }
-
-    static async unpackSnapshot(snapshot: ISnapshotTree) {
-        const converter = new SnapshotExtractorInPlace();
-        await converter.unpackSnapshotCore(snapshot);
-    }
-
-    public get policies(): IDocumentStorageServicePolicies | undefined {
-        const policies = this.storage.policies;
-        if (policies) {
-            return { ...policies, minBlobSize: undefined };
-        }
-    }
-
-    public async unpackSnapshot(snapshot: ISnapshotTree) {
-        // SummarizerNodeWithGC.refreshLatestSummary can call it when this.loadedFromSummary === false
-        // (I assumed after file was created)
-        // assert(!this.loadedFromSummary, "unpack without summary");
-
-        this.loadedFromSummary = true;
-        await this.unpackSnapshotCore(snapshot);
-    }
-
-    protected constructor(
-        private readonly storage: IDocumentStorageService,
-        private readonly logger: ITelemetryLogger,
-        private readonly allowPacking: boolean,
-        private readonly packingLevel: number,
-        private readonly blobCutOffSize?: number) {
-        super();
-    }
-
-    public setBlob(id: string, tree: ISnapshotTree, content: string) {
-        this.virtualBlobs.set(id, stringToBuffer(content, "utf-8"));
-    }
-
-    public async getBlob(id: string, tree: ISnapshotTree): Promise<ArrayBufferLike> {
-        return this.readBlob(id).catch((error) => {
-            this.logger.sendErrorEvent({ eventName: "BlobDedupNoAggregateBlob" }, error);
-            throw error;
-        });
-    }
-
-    public get repositoryUrl() { return this.storage.repositoryUrl; }
-    public async getVersions(versionId: string | null, count: number) {
-        return this.storage.getVersions(versionId, count);
-    }
-
-    public async downloadSummary(handle: ISummaryHandle): Promise<ISummaryTree> {
-        throw new Error("NYI");
-    }
-
-    // for now we are not optimizing these blobs, with assumption that this API is used only
-    // for big blobs (images)
-    public async createBlob(file: ArrayBufferLike): Promise<ICreateBlobResponse> {
-        return this.storage.createBlob(file);
-    }
-
-    public async getSnapshotTree(version?: IVersion): Promise<ISnapshotTree | null> {
-        const tree = await this.storage.getSnapshotTree(version);
-        if (tree) {
-            await this.unpackSnapshot(tree);
-        }
-        return tree;
-    }
-
-    public async readBlob(id: string): Promise<ArrayBufferLike> {
-        if (this.isRealStorageId(id)) {
-            return this.storage.readBlob(id);
-        }
-        // We support only reading blobs from the summary we loaded from.
-        // This may need to be extended to any general summary in the future as runtime usage pattern
-        // of storage changes (for example, data stores start to load from recent summary, not from original
-        // summary whole container loaded from)
-
-        // are there other ways we can get here? createFile is one flow, but we should not be reading blobs
-        // in such flow
-        assert(this.loadedFromSummary, 0x0f9 /* "never read summary" */);
-        const blob = this.virtualBlobs.get(id);
-        assert(blob !== undefined, 0x0fa /* "virtual blob not found" */);
-        return blob;
-    }
-
-    public async uploadSummaryWithContext(summary: ISummaryTree, context: ISummaryContext): Promise<string> {
-        const summaryNew = this.allowPacking ? await this.compressSmallBlobs(summary) : summary;
-        return this.storage.uploadSummaryWithContext(summaryNew, context);
-    }
-
-    // For simplification, we assume that
-    // - blob aggregation is done at data store level only for now
-    // - data store either reuses previous summary, or generates full summary, i.e. there is no partial (some DDS)
-    // summary produced by data stores.
-    // These simplifications allow us not to touch handles, as they are self-contained (either do not use aggregated
-    // blob Or contain aggregated blob that stays relevant for that sub-tree)
-    // Note:
-    // From perf perspective, it makes sense to place aggregated blobs one level up in the tree not to create extra
-    // tree nodes (i.e. have shallow tree with less edges). But that creates problems with reusability of trees at
-    // incremental summary time - we would need to understand handles and parse them. In current design we can skip
-    // that step because if data store is reused, the hole sub-tree is reused included aggregated blob embedded into it
-    // and that means we can do nothing and be correct!
-    private async compressSmallBlobs(
-        summary: ISummaryTree,
-        path = "",
-        level = 0,
-        aggregatorArg?: BlobAggregator): Promise<ISummaryTree> {
-        if (this.blobCutOffSize === undefined || this.blobCutOffSize < 0) {
-            return summary;
-        }
-
-        let shouldCompress: boolean = false;
-
-        let aggregator = aggregatorArg;
-        // checking if this is a dataStore tree, since we only pack at data store level
-        if (Object.keys(summary.tree).includes(".component")) {
-            assert(aggregator === undefined, 0x0fb /* "logic err with aggregator" */);
-            assert(level === this.packingLevel, 0x23b /* "we are not packing at the right level" */);
-            aggregator = new BlobAggregator();
-            shouldCompress = true;
-        } else {
-            assert(level !== this.packingLevel, 0x23c /* "we are not packing at the right level" */);
-        }
-
-        const newSummary: ISummaryTree = { ...summary };
-        newSummary.tree = { ...newSummary.tree };
-        for (const key of Object.keys(summary.tree)) {
-            const obj = summary.tree[key];
-            // Get path relative to root of data store (where we do aggregation)
-            const newPath = shouldCompress ? key : `${path}/${key}`;
-            switch (obj.type) {
-                case SummaryType.Tree:
-                    // If client created empty tree, keep it as is
-                    // Also do not package search blobs - they are part of storage contract
-                    if (obj.tree !== {} && key !== "__search") {
-                        const tree = await this.compressSmallBlobs(obj, newPath, level + 1, aggregator);
-                        newSummary.tree[key] = tree;
-                        if (tree.tree === {}) {
-                            // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
-                            delete newSummary.tree[key];
-                        }
-                    }
-                    break;
-                case SummaryType.Blob:
-                    if (aggregator && typeof obj.content == "string" && obj.content.length < this.blobCutOffSize) {
-                        aggregator.addBlob(newPath, obj.content);
-                        // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
-                        delete newSummary.tree[key];
-                    }
-                    break;
-                case SummaryType.Handle: {
-                    // Would be nice to:
-                    // Trees: expand the tree
-                    // Blobs: parse handle and ensure it points to real blob, not virtual blob.
-                    // We can avoid it for now given data store is the granularity of incremental summaries.
-                    let handlePath = obj.handle;
-                    if (handlePath.startsWith("/")) {
-                        handlePath = handlePath.substr(1);
-                    }
-                    // Ensure only whole data stores can be reused, no reusing at deeper level!
-                    assert(level === 0, 0x0fc /* "tree reuse at lower level" */);
-                    assert(!handlePath.includes("/"),
-                        0x0fd /* "data stores are writing incremental summaries!" */);
-                    break;
-                }
-                case SummaryType.Attachment:
-                    assert(this.isRealStorageId(obj.id), 0x0fe /* "attachment is aggregate blob" */);
-                    break;
-                default:
-                    unreachableCase(obj, `Unknown type: ${(obj as any).type}`);
-            }
-        }
-
-        assert(newSummary.tree[this.aggregatedBlobName] === undefined, 0x0ff /* "duplicate aggregate blob" */);
-        if (shouldCompress) {
-            // Note: It would be great to add code here to unpack aggregate blob back to normal blobs
-            // If only one blob made it into aggregate. Currently that does not happen as we always have
-            // at least one .component blob and at least one DDS that has .attributes blob, so it's not an issue.
-            // But it's possible that in future that would be great addition!
-            // Good news - it's backward compatible change.
-            assert(aggregator !== undefined, 0x100 /* "logic error" */);
-            const content = aggregator.getAggregatedBlobContent();
-            if (content !== undefined) {
-                newSummary.tree[this.aggregatedBlobName] = {
-                    type: SummaryType.Blob,
-                    content,
-                };
-            }
-        }
-        return newSummary;
-    }
-
-    protected isRealStorageId(id: string): boolean {
-        return !id.startsWith(this.virtualIdPrefix);
-    }
+	// Tells data store if it can use incremental summary (i.e. reuse DDSes from previous summary
+	// when only one DDS changed).
+	// The answer has to be know long before we enable actual packing. The reason for the is the following:
+	// A the moment when we enable packing, we should assume that all clients out there wil already have bits
+	// that can unpack properly (i.e. enough time passed since we deployed bits that can unpack)
+	// But we can still have clients where some of them already pack, and some do not. If one summary was
+	// using packing, then it relies on non-incremental summaries going forward, even if next client who
+	// produced summary is not packing!
+	// This can have slight improvement by enabling it per file (based on "did summary we loaded from contain
+	// aggregated blobs"), but that's harder to make reliable, so going for simplicity.
+	static readonly fullDataStoreSummaries = true;
+
+	protected loadedFromSummary = false;
+
+	protected virtualBlobs = new Map<string, ArrayBufferLike>();
+
+	static wrap(
+		storage: IDocumentStorageService,
+		logger: ITelemetryLogger,
+		allowPacking?: boolean,
+		packingLevel = 2,
+	) {
+		if (storage instanceof BlobAggregationStorage) {
+			return storage;
+		}
+		const mc = loggerToMonitoringContext(logger);
+		const realAllowPackaging =
+			mc.config.getBoolean("FluidAggregateBlobs") ?? allowPacking ?? false;
+
+		// Always create BlobAggregationStorage even if storage is not asking for packing.
+		// This is mostly to avoid cases where future changes in policy would result in inability to
+		// load old files that were created with aggregation on.
+		const minBlobSize = storage.policies?.minBlobSize;
+		return new BlobAggregationStorage(
+			storage,
+			logger,
+			realAllowPackaging,
+			packingLevel,
+			minBlobSize,
+		);
+	}
+
+	static async unpackSnapshot(snapshot: ISnapshotTree) {
+		const converter = new SnapshotExtractorInPlace();
+		await converter.unpackSnapshotCore(snapshot);
+	}
+
+	public get policies(): IDocumentStorageServicePolicies | undefined {
+		const policies = this.storage.policies;
+		if (policies) {
+			return { ...policies, minBlobSize: undefined };
+		}
+	}
+
+	public async unpackSnapshot(snapshot: ISnapshotTree) {
+		// SummarizerNodeWithGC.refreshLatestSummary can call it when this.loadedFromSummary === false
+		// (I assumed after file was created)
+		// assert(!this.loadedFromSummary, "unpack without summary");
+
+		this.loadedFromSummary = true;
+		await this.unpackSnapshotCore(snapshot);
+	}
+
+	protected constructor(
+		private readonly storage: IDocumentStorageService,
+		private readonly logger: ITelemetryLogger,
+		private readonly allowPacking: boolean,
+		private readonly packingLevel: number,
+		private readonly blobCutOffSize?: number,
+	) {
+		super();
+	}
+
+	public setBlob(id: string, tree: ISnapshotTree, content: string) {
+		this.virtualBlobs.set(id, stringToBuffer(content, "utf-8"));
+	}
+
+	public async getBlob(id: string, tree: ISnapshotTree): Promise<ArrayBufferLike> {
+		return this.readBlob(id).catch((error) => {
+			this.logger.sendErrorEvent({ eventName: "BlobDedupNoAggregateBlob" }, error);
+			throw error;
+		});
+	}
+
+	public get repositoryUrl() {
+		return this.storage.repositoryUrl;
+	}
+	public async getVersions(
+		versionId: string | null,
+		count: number,
+		scenarioName?: string,
+		fetchSource?: FetchSource,
+	) {
+		return this.storage.getVersions(versionId, count, scenarioName, fetchSource);
+	}
+
+	public async downloadSummary(handle: ISummaryHandle): Promise<ISummaryTree> {
+		throw new Error("NYI");
+	}
+
+	// for now we are not optimizing these blobs, with assumption that this API is used only
+	// for big blobs (images)
+	public async createBlob(file: ArrayBufferLike): Promise<ICreateBlobResponse> {
+		return this.storage.createBlob(file);
+	}
+
+	public async getSnapshotTree(version?: IVersion): Promise<ISnapshotTree | null> {
+		const tree = await this.storage.getSnapshotTree(version);
+		if (tree) {
+			await this.unpackSnapshot(tree);
+		}
+		return tree;
+	}
+
+	public async readBlob(id: string): Promise<ArrayBufferLike> {
+		if (this.isRealStorageId(id)) {
+			return this.storage.readBlob(id);
+		}
+		// We support only reading blobs from the summary we loaded from.
+		// This may need to be extended to any general summary in the future as runtime usage pattern
+		// of storage changes (for example, data stores start to load from recent summary, not from original
+		// summary whole container loaded from)
+
+		// are there other ways we can get here? createFile is one flow, but we should not be reading blobs
+		// in such flow
+		assert(this.loadedFromSummary, 0x0f9 /* "never read summary" */);
+		const blob = this.virtualBlobs.get(id);
+		assert(blob !== undefined, 0x0fa /* "virtual blob not found" */);
+		return blob;
+	}
+
+	public async uploadSummaryWithContext(
+		summary: ISummaryTree,
+		context: ISummaryContext,
+	): Promise<string> {
+		const summaryNew = this.allowPacking ? await this.compressSmallBlobs(summary) : summary;
+		return this.storage.uploadSummaryWithContext(summaryNew, context);
+	}
+
+	// For simplification, we assume that
+	// - blob aggregation is done at data store level only for now
+	// - data store either reuses previous summary, or generates full summary, i.e. there is no partial (some DDS)
+	// summary produced by data stores.
+	// These simplifications allow us not to touch handles, as they are self-contained (either do not use aggregated
+	// blob Or contain aggregated blob that stays relevant for that sub-tree)
+	// Note:
+	// From perf perspective, it makes sense to place aggregated blobs one level up in the tree not to create extra
+	// tree nodes (i.e. have shallow tree with less edges). But that creates problems with reusability of trees at
+	// incremental summary time - we would need to understand handles and parse them. In current design we can skip
+	// that step because if data store is reused, the hole sub-tree is reused included aggregated blob embedded into it
+	// and that means we can do nothing and be correct!
+	private async compressSmallBlobs(
+		summary: ISummaryTree,
+		path = "",
+		level = 0,
+		aggregatorArg?: BlobAggregator,
+	): Promise<ISummaryTree> {
+		if (this.blobCutOffSize === undefined || this.blobCutOffSize < 0) {
+			return summary;
+		}
+
+		let shouldCompress: boolean = false;
+
+		let aggregator = aggregatorArg;
+		// checking if this is a dataStore tree, since we only pack at data store level
+		if (Object.keys(summary.tree).includes(".component")) {
+			assert(aggregator === undefined, 0x0fb /* "logic err with aggregator" */);
+			assert(
+				level === this.packingLevel,
+				0x23b /* "we are not packing at the right level" */,
+			);
+			aggregator = new BlobAggregator();
+			shouldCompress = true;
+		} else {
+			assert(
+				level !== this.packingLevel,
+				0x23c /* "we are not packing at the right level" */,
+			);
+		}
+
+		const newSummary: ISummaryTree = { ...summary };
+		newSummary.tree = { ...newSummary.tree };
+		for (const key of Object.keys(summary.tree)) {
+			const obj = summary.tree[key];
+			// Get path relative to root of data store (where we do aggregation)
+			const newPath = shouldCompress ? key : `${path}/${key}`;
+			switch (obj.type) {
+				case SummaryType.Tree:
+					// If client created empty tree, keep it as is
+					// Also do not package search blobs - they are part of storage contract
+					if (obj.tree !== {} && key !== "__search") {
+						const tree = await this.compressSmallBlobs(
+							obj,
+							newPath,
+							level + 1,
+							aggregator,
+						);
+						newSummary.tree[key] = tree;
+						if (tree.tree === {}) {
+							// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+							delete newSummary.tree[key];
+						}
+					}
+					break;
+				case SummaryType.Blob:
+					if (
+						aggregator &&
+						typeof obj.content == "string" &&
+						obj.content.length < this.blobCutOffSize
+					) {
+						aggregator.addBlob(newPath, obj.content);
+						// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
+						delete newSummary.tree[key];
+					}
+					break;
+				case SummaryType.Handle: {
+					// Would be nice to:
+					// Trees: expand the tree
+					// Blobs: parse handle and ensure it points to real blob, not virtual blob.
+					// We can avoid it for now given data store is the granularity of incremental summaries.
+					let handlePath = obj.handle;
+					if (handlePath.startsWith("/")) {
+						handlePath = handlePath.substr(1);
+					}
+					// Ensure only whole data stores can be reused, no reusing at deeper level!
+					assert(level === 0, 0x0fc /* "tree reuse at lower level" */);
+					assert(
+						!handlePath.includes("/"),
+						0x0fd /* "data stores are writing incremental summaries!" */,
+					);
+					break;
+				}
+				case SummaryType.Attachment:
+					assert(
+						this.isRealStorageId(obj.id),
+						0x0fe /* "attachment is aggregate blob" */,
+					);
+					break;
+				default:
+					unreachableCase(obj, `Unknown type: ${(obj as any).type}`);
+			}
+		}
+
+		assert(
+			newSummary.tree[this.aggregatedBlobName] === undefined,
+			0x0ff /* "duplicate aggregate blob" */,
+		);
+		if (shouldCompress) {
+			// Note: It would be great to add code here to unpack aggregate blob back to normal blobs
+			// If only one blob made it into aggregate. Currently that does not happen as we always have
+			// at least one .component blob and at least one DDS that has .attributes blob, so it's not an issue.
+			// But it's possible that in future that would be great addition!
+			// Good news - it's backward compatible change.
+			assert(aggregator !== undefined, 0x100 /* "logic error" */);
+			const content = aggregator.getAggregatedBlobContent();
+			if (content !== undefined) {
+				newSummary.tree[this.aggregatedBlobName] = {
+					type: SummaryType.Blob,
+					content,
+				};
+			}
+		}
+		return newSummary;
+	}
+
+	protected isRealStorageId(id: string): boolean {
+		return !id.startsWith(this.virtualIdPrefix);
+	}
 }