@fluidframework/datastore 2.1.0-276985 → 2.1.0-281041

package/lib/public.d.ts

@@ -5,7 +5,7 @@
 
 /*
  * THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
- * Generated by "flub generate entrypoints" in @fluidframework/build-tools.
+ * Generated by "flub generate entrypoints" in @fluid-tools/build-cli.
  */
 
 export {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fluidframework/datastore",
-  "version": "2.1.0-276985",
+  "version": "2.1.0-281041",
   "description": "Fluid data store implementation",
   "homepage": "https://fluidframework.com",
   "repository": {
@@ -67,29 +67,29 @@
     "temp-directory": "nyc/.nyc_output"
   },
   "dependencies": {
-    "@fluid-internal/client-utils": "2.1.0-276985",
-    "@fluidframework/container-definitions": "2.1.0-276985",
-    "@fluidframework/core-interfaces": "2.1.0-276985",
-    "@fluidframework/core-utils": "2.1.0-276985",
-    "@fluidframework/datastore-definitions": "2.1.0-276985",
-    "@fluidframework/driver-definitions": "2.1.0-276985",
-    "@fluidframework/driver-utils": "2.1.0-276985",
-    "@fluidframework/id-compressor": "2.1.0-276985",
-    "@fluidframework/runtime-definitions": "2.1.0-276985",
-    "@fluidframework/runtime-utils": "2.1.0-276985",
-    "@fluidframework/telemetry-utils": "2.1.0-276985",
+    "@fluid-internal/client-utils": "2.1.0-281041",
+    "@fluidframework/container-definitions": "2.1.0-281041",
+    "@fluidframework/core-interfaces": "2.1.0-281041",
+    "@fluidframework/core-utils": "2.1.0-281041",
+    "@fluidframework/datastore-definitions": "2.1.0-281041",
+    "@fluidframework/driver-definitions": "2.1.0-281041",
+    "@fluidframework/driver-utils": "2.1.0-281041",
+    "@fluidframework/id-compressor": "2.1.0-281041",
+    "@fluidframework/runtime-definitions": "2.1.0-281041",
+    "@fluidframework/runtime-utils": "2.1.0-281041",
+    "@fluidframework/telemetry-utils": "2.1.0-281041",
     "uuid": "^9.0.0"
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.15.2",
-    "@biomejs/biome": "^1.7.3",
-    "@fluid-internal/mocha-test-setup": "2.1.0-276985",
-    "@fluid-tools/build-cli": "^0.39.0",
+    "@biomejs/biome": "~1.8.3",
+    "@fluid-internal/mocha-test-setup": "2.1.0-281041",
+    "@fluid-tools/build-cli": "^0.40.0",
     "@fluidframework/build-common": "^2.0.3",
-    "@fluidframework/build-tools": "^0.39.0",
-    "@fluidframework/datastore-previous": "npm:@fluidframework/datastore@2.0.0-rc.5.0.0",
+    "@fluidframework/build-tools": "^0.40.0",
+    "@fluidframework/datastore-previous": "npm:@fluidframework/datastore@2.0.0",
     "@fluidframework/eslint-config-fluid": "^5.3.0",
-    "@fluidframework/test-runtime-utils": "2.1.0-276985",
+    "@fluidframework/test-runtime-utils": "2.1.0-281041",
     "@microsoft/api-extractor": "^7.45.1",
     "@types/lodash": "^4.14.118",
     "@types/mocha": "^9.1.1",
@@ -116,18 +116,19 @@
     "api-extractor:commonjs": "flub generate entrypoints --outDir ./dist",
     "api-extractor:esnext": "flub generate entrypoints --outDir ./lib --node10TypeCompat",
     "build": "fluid-build . --task build",
+    "build:api-reports": "concurrently \"npm:build:api-reports:*\"",
+    "build:api-reports:current": "api-extractor run --local --config api-extractor/api-extractor.current.json",
+    "build:api-reports:legacy": "api-extractor run --local --config api-extractor/api-extractor.legacy.json",
     "build:commonjs": "fluid-build . --task commonjs",
     "build:compile": "fluid-build . --task compile",
-    "build:docs": "concurrently \"npm:build:docs:*\"",
-    "build:docs:current": "api-extractor run --local",
-    "build:docs:legacy": "api-extractor run --local --config api-extractor/api-extractor.legacy.json",
+    "build:docs": "api-extractor run --local",
     "build:esnext": "tsc --project ./tsconfig.json",
     "build:genver": "gen-version",
     "build:test": "npm run build:test:esm && npm run build:test:cjs",
     "build:test:cjs": "fluid-tsc commonjs --project ./src/test/tsconfig.cjs.json",
     "build:test:esm": "tsc --project ./src/test/tsconfig.json",
     "check:are-the-types-wrong": "attw --pack .",
-    "check:biome": "biome check . --formatter-enabled=true",
+    "check:biome": "biome check .",
     "check:exports": "concurrently \"npm:check:exports:*\"",
     "check:exports:bundle-release-tags": "api-extractor run --config api-extractor/api-extractor-lint-bundle.json",
     "check:exports:cjs:legacy": "api-extractor run --config api-extractor/api-extractor-lint-legacy.cjs.json",
@@ -136,14 +137,15 @@
     "check:exports:esm:public": "api-extractor run --config api-extractor/api-extractor-lint-public.esm.json",
     "check:format": "npm run check:biome",
     "check:prettier": "prettier --check . --cache --ignore-path ../../../.prettierignore",
-    "ci:build:docs": "concurrently \"npm:ci:build:docs:*\"",
-    "ci:build:docs:current": "api-extractor run",
-    "ci:build:docs:legacy": "api-extractor run --config api-extractor/api-extractor.legacy.json",
+    "ci:build:api-reports": "concurrently \"npm:ci:build:api-reports:*\"",
+    "ci:build:api-reports:current": "api-extractor run --config api-extractor/api-extractor.current.json",
+    "ci:build:api-reports:legacy": "api-extractor run --config api-extractor/api-extractor.legacy.json",
+    "ci:build:docs": "api-extractor run",
     "clean": "rimraf --glob dist lib \"*.d.ts\" \"**/*.tsbuildinfo\" \"**/*.build.log\" _api-extractor-temp nyc",
     "eslint": "eslint --format stylish src",
     "eslint:fix": "eslint --format stylish src --fix --fix-type problem,suggestion,layout",
     "format": "npm run format:biome",
-    "format:biome": "biome check . --formatter-enabled=true --apply",
+    "format:biome": "biome check . --write",
     "format:prettier": "prettier --write . --cache --ignore-path ../../../.prettierignore",
     "lint": "fluid-build . --task lint",
     "lint:fix": "fluid-build . --task eslint:fix --task format",

package/src/channelStorageService.ts

@@ -3,6 +3,7 @@
  * Licensed under the MIT License.
  */
 
+import { assert } from "@fluidframework/core-utils/internal";
 import { IChannelStorageService } from "@fluidframework/datastore-definitions/internal";
 import {
 	IDocumentStorageService,
@@ -17,14 +18,12 @@ export class ChannelStorageService implements IChannelStorageService {
 		tree: ISnapshotTree,
 		results: { [path: string]: string },
 	) {
-		// eslint-disable-next-line guard-for-in, no-restricted-syntax
-		for (const path in tree.trees) {
-			ChannelStorageService.flattenTree(`${base}${path}/`, tree.trees[path], results);
+		for (const [path, subtree] of Object.entries(tree.trees)) {
+			ChannelStorageService.flattenTree(`${base}${path}/`, subtree, results);
 		}
 
-		// eslint-disable-next-line guard-for-in, no-restricted-syntax
-		for (const blob in tree.blobs) {
-			results[`${base}${blob}`] = tree.blobs[blob];
+		for (const [blobName, blobId] of Object.entries(tree.blobs)) {
+			results[`${base}${blobName}`] = blobId;
 		}
 	}
 
@@ -49,6 +48,7 @@ export class ChannelStorageService implements IChannelStorageService {
 
 	public async readBlob(path: string): Promise<ArrayBufferLike> {
 		const id = await this.getIdForPath(path);
+		assert(id !== undefined, "id is undefined in ChannelStorageService.readBlob()");
 		const blob = this.extraBlobs !== undefined ? this.extraBlobs.get(id) : undefined;
 
 		if (blob !== undefined) {
@@ -77,7 +77,7 @@ export class ChannelStorageService implements IChannelStorageService {
 		return Object.keys(tree?.blobs ?? {});
 	}
 
-	private async getIdForPath(path: string): Promise<string> {
+	private async getIdForPath(path: string): Promise<string | undefined> {
 		return this.flattenedTree[path];
 	}
 }

package/src/dataStoreRuntime.ts

@@ -255,7 +255,7 @@ export class FluidDataStoreRuntime
 
 		// Must always receive the data store type inside of the attributes
 		if (tree?.trees !== undefined) {
-			Object.keys(tree.trees).forEach((path) => {
+			Object.entries(tree.trees).forEach(([path, subtree]) => {
 				// Issue #4414
 				if (path === "_search") {
 					return;
@@ -266,7 +266,7 @@ export class FluidDataStoreRuntime
 				// container from snapshot where we load detached container from a snapshot, isLocalDataStore would be
 				// true. In this case create a RehydratedLocalChannelContext.
 				if (dataStoreContext.isLocalDataStore) {
-					channelContext = this.createRehydratedLocalChannelContext(path, tree.trees[path]);
+					channelContext = this.createRehydratedLocalChannelContext(path, subtree);
 					// This is the case of rehydrating a detached container from snapshot. Now due to delay loading of
 					// data store, if the data store is loaded after the container is attached, then we missed making
 					// the channel visible. So do it now. Otherwise, add it to local channel context queue, so
@@ -284,7 +284,7 @@ export class FluidDataStoreRuntime
 						(content, localOpMetadata) => this.submitChannelOp(path, content, localOpMetadata),
 						(address: string) => this.setChannelDirty(address),
 						path,
-						tree.trees[path],
+						subtree,
 						this.sharedObjectRegistry,
 						undefined /* extraBlobs */,
 						this.dataStoreContext.getCreateChildSummarizerNodeFn(path, {
@@ -362,17 +362,19 @@ export class FluidDataStoreRuntime
 				return await this.request(parser.createSubRequest(1));
 			}
 
-			// Check for a data type reference first
-			const context = this.contexts.get(id);
-			if (context !== undefined && parser.isLeaf(1)) {
-				try {
-					const channel = await context.getChannel();
+			if (id !== undefined) {
+				// Check for a data type reference first
+				const context = this.contexts.get(id);
+				if (context !== undefined && parser.isLeaf(1)) {
+					try {
+						const channel = await context.getChannel();
 
-					return { mimeType: "fluid/object", status: 200, value: channel };
-				} catch (error) {
-					this.mc.logger.sendErrorEvent({ eventName: "GetChannelFailedInRequest" }, error);
+						return { mimeType: "fluid/object", status: 200, value: channel };
+					} catch (error) {
+						this.mc.logger.sendErrorEvent({ eventName: "GetChannelFailedInRequest" }, error);
 
-					return createResponseError(500, `Failed to get Channel: ${error}`, request);
+						return createResponseError(500, `Failed to get Channel: ${error}`, request);
+					}
 				}
 			}
 
@@ -850,7 +852,9 @@ export class FluidDataStoreRuntime
 						0x181 /* "BaseSnapshot should be there as detached container loaded from snapshot" */,
 					);
 					summaryTree = convertSnapshotTreeToSummaryTree(
-						this.dataStoreContext.baseSnapshot.trees[contextId],
+						// TODO why are we non null asserting here?
+						// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+						this.dataStoreContext.baseSnapshot.trees[contextId]!,
 					);
 				}
 				summaryBuilder.addWithStats(contextId, summaryTree);

package/src/packageVersion.ts

@@ -6,4 +6,4 @@
  */
 
 export const pkgName = "@fluidframework/datastore";
-export const pkgVersion = "2.1.0-276985";
+export const pkgVersion = "2.1.0-281041";

package/tsconfig.json

@@ -5,7 +5,6 @@
 	"compilerOptions": {
 		"rootDir": "./src",
 		"outDir": "./lib",
-		"noUncheckedIndexedAccess": false,
 		"exactOptionalPropertyTypes": false,
 	},
 }