@fluidframework/container-runtime 2.80.0 → 2.81.0

package/src/gc/gcHelpers.ts

@@ -251,6 +251,7 @@ export function unpackChildNodesGCDetails(
 		}
 
 		let childGCDetails = childGCDetailsMap.get(childId);
+		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- using ??= could change behavior if value is falsy
 		if (childGCDetails === undefined) {
 			childGCDetails = { gcData: { gcNodes: {} }, usedRoutes: [] };
 		}

package/src/packageVersion.ts

@@ -6,4 +6,4 @@
  */
 
 export const pkgName = "@fluidframework/container-runtime";
-export const pkgVersion = "2.80.0";
+export const pkgVersion = "2.81.0";

package/src/summary/summarizerNode/summarizerNodeWithGc.ts

@@ -415,6 +415,7 @@ export class SummarizerNodeWithGC extends SummarizerNode implements IRootSummari
 			// If the child route used routes are not defined, initialize it now and it can be used for all child nodes
 			// created until this summarization process is completed. This is an optimization to unpack the used routes
 			// only when needed.
+			// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- using ??= could change behavior if value is falsy
 			if (this.wipChildNodesUsedRoutes === undefined) {
 				this.wipChildNodesUsedRoutes = unpackChildNodesUsedRoutes(this.usedRoutes);
 			}

package/src/summary/summaryDelayLoadedModule/summaryGenerator.ts

@@ -131,7 +131,7 @@ export class SummaryGenerator extends TypedEventEmitter<ISummarizerEvents> {
 		 * For submit failures, submitFailureResult should be provided. For nack failures, nackSummaryResult should
 		 * be provided. For op broadcast failures, only errors / properties should be provided.
 		 */
-		const fail = (
+		const summaryFail = (
 			errorCode: SummarizeErrorCode,
 			error: IRetriableFailureError,
 			properties?: SummaryGeneratorTelemetry,
@@ -191,7 +191,7 @@ export class SummaryGenerator extends TypedEventEmitter<ISummarizerEvents> {
 				const errorCode: SummarizeErrorCode = "submitSummaryFailure";
 				const retriableError =
 					summaryData.error ?? new RetriableSummaryError(getFailMessage(errorCode));
-				return fail(errorCode, retriableError, summarizeTelemetryProps, {
+				return summaryFail(errorCode, retriableError, summarizeTelemetryProps, {
 					stage: summaryData.stage,
 				});
 			}
@@ -227,7 +227,7 @@ export class SummaryGenerator extends TypedEventEmitter<ISummarizerEvents> {
 			summarizeEvent.reportEvent("generate", { ...summarizeTelemetryProps });
 			resultsBuilder.summarySubmitted.resolve({ success: true, data: summaryData });
 		} catch (error) {
-			return fail(
+			return summaryFail(
 				"submitSummaryFailure",
 				wrapError(
 					error,
@@ -260,13 +260,13 @@ export class SummaryGenerator extends TypedEventEmitter<ISummarizerEvents> {
 			);
 			if (waitBroadcastResult.result === "cancelled") {
 				const errorCode: SummarizeErrorCode = "disconnect";
-				return fail(errorCode, new RetriableSummaryError(getFailMessage(errorCode)));
+				return summaryFail(errorCode, new RetriableSummaryError(getFailMessage(errorCode)));
 			}
 			if (waitBroadcastResult.result !== "done") {
 				// The summary op may not have been received within the timeout due to a transient error. So,
 				// fail with a retriable error to re-attempt the summary if possible.
 				const errorCode: SummarizeErrorCode = "summaryOpWaitTimeout";
-				return fail(
+				return summaryFail(
 					errorCode,
 					new RetriableSummaryError(getFailMessage(errorCode), 0 /* retryAfterSeconds */),
 				);
@@ -296,13 +296,13 @@ export class SummaryGenerator extends TypedEventEmitter<ISummarizerEvents> {
 			);
 			if (waitAckNackResult.result === "cancelled") {
 				const errorCode: SummarizeErrorCode = "disconnect";
-				return fail(errorCode, new RetriableSummaryError(getFailMessage(errorCode)));
+				return summaryFail(errorCode, new RetriableSummaryError(getFailMessage(errorCode)));
 			}
 			if (waitAckNackResult.result !== "done") {
 				const errorCode: SummarizeErrorCode = "summaryAckWaitTimeout";
 				// The summary ack may not have been received within the timeout due to a transient error. So,
 				// fail with a retriable error to re-attempt the summary if possible.
-				return fail(
+				return summaryFail(
 					errorCode,
 					new RetriableSummaryError(getFailMessage(errorCode), 0 /* retryAfterSeconds */),
 				);
@@ -363,7 +363,7 @@ export class SummaryGenerator extends TypedEventEmitter<ISummarizerEvents> {
 					0x25f /* "retryAfterSeconds" */,
 				);
 				// This will only set resultsBuilder.receivedSummaryAckOrNack, as other promises are already set.
-				return fail(
+				return summaryFail(
 					errorCode,
 					error,
 					{ ...summarizeTelemetryProps, nackRetryAfter: retryAfterSeconds },

package/.eslintrc.cjs

@@ -1,30 +0,0 @@
-/*!
- * Copyright (c) Microsoft Corporation and contributors. All rights reserved.
- * Licensed under the MIT License.
- */
-
-module.exports = {
-	extends: [require.resolve("@fluidframework/eslint-config-fluid/recommended"), "prettier"],
-	parserOptions: {
-		project: ["./tsconfig.json", "./src/test/tsconfig.json"],
-	},
-	rules: {
-		// AB#51780: temporarily disabled because of crashes in typescript-eslint on destructuring in promise chains.
-		// See: channelCollection.ts:1070
-		"@typescript-eslint/unbound-method": "off",
-	},
-	overrides: [
-		{
-			// Rules only for test files
-			files: ["*.spec.ts", "src/test/**"],
-			rules: {
-				// TODO: remove these overrides and fix violations
-				"@typescript-eslint/explicit-function-return-type": "off",
-				"unicorn/consistent-function-scoping": "off",
-
-				// Test files are run in node only so additional node libraries can be used.
-				"import-x/no-nodejs-modules": ["error", { allow: ["node:assert", "node:crypto"] }],
-			},
-		},
-	],
-};