@fluidframework/container-runtime 2.63.0-359461 → 2.63.0-359962

package/dist/blobManager/blobManager.js

@@ -28,12 +28,14 @@ class BlobHandle extends internal_3.FluidHandleBase {
         return (this._events ??= (0, client_utils_1.createEmitter)());
     }
     get payloadState() {
-        return this._state;
+        return this._payloadState;
     }
     get payloadShareError() {
         return this._payloadShareError;
     }
-    constructor(path, routeContext, get, payloadPending, onAttachGraph) {
+    constructor(path, routeContext, 
+    // TODO: just take the blob rather than a get function?
+    get, payloadPending, onAttachGraph) {
         super();
         this.path = path;
         this.routeContext = routeContext;
@@ -41,15 +43,15 @@ class BlobHandle extends internal_3.FluidHandleBase {
         this.payloadPending = payloadPending;
         this.onAttachGraph = onAttachGraph;
         this.attached = false;
-        this._state = "pending";
         this.notifyShared = () => {
-            this._state = "shared";
+            this._payloadState = "shared";
             this._events?.emit("payloadShared");
         };
         this.notifyFailed = (error) => {
             this._payloadShareError = error;
             this._events?.emit("payloadShareFailed", error);
         };
+        this._payloadState = payloadPending ? "pending" : "shared";
         this.absolutePath = (0, internal_3.generateHandleContextPath)(path, this.routeContext);
     }
     attachGraph() {
@@ -60,20 +62,201 @@ class BlobHandle extends internal_3.FluidHandleBase {
     }
 }
 exports.BlobHandle = BlobHandle;
+/**
+ * Check if for a given uploaded or attaching blob, the TTL is too close to expiry to safely attempt
+ * an attach. Currently using a heuristic of half the TTL duration having passed since upload.
+ */
+const isTTLTooCloseToExpiry = (blobRecord) => blobRecord.minTTLInSeconds !== undefined &&
+    Date.now() - blobRecord.uploadTime > (blobRecord.minTTLInSeconds / 2) * 1000;
+const createAbortError = () => new internal_4.LoggingError("uploadBlob aborted");
 exports.blobManagerBasePath = "_blobs";
 class BlobManager {
     constructor(props) {
         this.internalEvents = (0, client_utils_1.createEmitter)();
         /**
-         * Blobs which we have not yet seen a BlobAttach op round-trip and not yet attached to a DDS.
+         * The localBlobCache has a dual role of caching locally-created blobs, as well as tracking their state as they
+         * are shared. Keys are localIds.
+         */
+        this.localBlobCache = new Map();
+        /**
+         * Blobs with an attached handle that have not finished blob-attaching are the set we need to provide from
+         * getPendingState().  This stores their local IDs, and then we can look them up against the localBlobCache.
          */
-        this.pendingBlobs = new Map();
+        this.pendingBlobsWithAttachedHandles = new Set();
         /**
-         * Track ops in flight for online flow. This is used for optimizations where if we receive an ack for a storage ID,
-         * we can resolve all pending blobs with the same storage ID even though they may have different local IDs. That's
-         * because we know that the server will not delete the blob corresponding to that storage ID.
+         * Local IDs for any pending blobs we loaded with and have not yet started the upload/attach flow for.
          */
-        this.opsInFlight = new Map();
+        this.pendingOnlyLocalIds = new Set();
+        /**
+         * Upload and attach the localBlobCache entry for the given localId.
+         *
+         * Expects the localBlobCache entry for the given localId to be in either localOnly or uploaded state
+         * when called. Returns a promise that resolves when the blob completes uploading and attaching, or else
+         * rejects if an error is encountered or the signal is aborted.
+         */
+        this.uploadAndAttach = async (localId, signal) => {
+            if (signal?.aborted === true) {
+                this.localBlobCache.delete(localId);
+                this.pendingBlobsWithAttachedHandles.delete(localId);
+                throw createAbortError();
+            }
+            const localBlobRecordInitial = this.localBlobCache.get(localId);
+            (0, internal_2.assert)(localBlobRecordInitial?.state === "localOnly" ||
+                localBlobRecordInitial?.state === "uploaded", "Expect uploadAndAttach to be called with either localOnly or uploaded state");
+            const { blob } = localBlobRecordInitial;
+            /**
+             * Expects the localBlobCache entry for the given localId to be in either localOnly or uploaded state
+             * when called. Returns a promise that resolves when the blob is in uploaded or attached state, or else
+             * rejects on error during upload or if the signal is aborted.
+             *
+             * Most of the time this should be expected to exit in uploaded state, but if we are loading from pending
+             * state we may see an attach op from the client that generated the pending state, which can complete the
+             * attach while the upload is outstanding.
+             */
+            const ensureUploaded = async () => {
+                const localBlobRecord = this.localBlobCache.get(localId);
+                if (localBlobRecord?.state === "uploaded") {
+                    // In normal creation flows, the blob will be in localOnly state here. But in the case of loading
+                    // with pending state we can call it with an uploaded-but-not-attached blob. Start the upload
+                    // flow only if it's localOnly.
+                    return;
+                }
+                (0, internal_2.assert)(localBlobRecord?.state === "localOnly", "Attempting to upload from unexpected state");
+                this.localBlobCache.set(localId, { state: "uploading", blob });
+                await new Promise((resolve, reject) => {
+                    // If we eventually have driver-level support for abort, then this can simplify a bit as we won't
+                    // need to track upload completion and abort separately. Until then, we need to handle the case that
+                    // the upload continues and settles after becoming irrelevant due to signal abort or blob attach.
+                    let uploadHasBecomeIrrelevant = false;
+                    const onSignalAbort = () => {
+                        removeListeners();
+                        uploadHasBecomeIrrelevant = true;
+                        this.localBlobCache.delete(localId);
+                        this.pendingBlobsWithAttachedHandles.delete(localId);
+                        reject(createAbortError());
+                    };
+                    const onProcessedBlobAttach = (_localId, _storageId) => {
+                        if (_localId === localId) {
+                            removeListeners();
+                            uploadHasBecomeIrrelevant = true;
+                            resolve();
+                        }
+                    };
+                    const removeListeners = () => {
+                        this.internalEvents.off("processedBlobAttach", onProcessedBlobAttach);
+                        signal?.removeEventListener("abort", onSignalAbort);
+                    };
+                    this.internalEvents.on("processedBlobAttach", onProcessedBlobAttach);
+                    signal?.addEventListener("abort", onSignalAbort);
+                    this.storage
+                        .createBlob(blob)
+                        .then((createBlobResponse) => {
+                        if (!uploadHasBecomeIrrelevant) {
+                            removeListeners();
+                            this.localBlobCache.set(localId, {
+                                state: "uploaded",
+                                blob,
+                                storageId: createBlobResponse.id,
+                                uploadTime: Date.now(),
+                                minTTLInSeconds: createBlobResponse.minTTLInSeconds,
+                            });
+                            resolve();
+                        }
+                    })
+                        .catch((error) => {
+                        if (!uploadHasBecomeIrrelevant) {
+                            removeListeners();
+                            // If the storage call errors, we can't recover. Reject to throw back to the caller.
+                            this.localBlobCache.delete(localId);
+                            this.pendingBlobsWithAttachedHandles.delete(localId);
+                            reject(error);
+                        }
+                    });
+                });
+            };
+            /**
+             * Expects the localBlobCache entry for the given localId to be in uploaded or attached state when called.
+             * Returns a promise that resolves to true if the blob is successfully attached, or false if it cannot be
+             * attached and the upload flow needs to be restarted from the top (currently only if the TTL expires before
+             * attach can be completed). In the latter case, the localBlobRecord will also be reset to localOnly state.
+             * The promise rejects if the signal is aborted.
+             */
+            const tryAttach = async () => {
+                const localBlobRecord = this.localBlobCache.get(localId);
+                if (localBlobRecord?.state === "attached") {
+                    // In normal creation flows, the blob will be in uploaded state here. But if we are loading from pending
+                    // state and see an attach op from the client that generated the pending state, we may have reached
+                    // attached state in the middle of the upload attempt. In that case there's no more work to do and we
+                    // can just return.
+                    return true;
+                }
+                (0, internal_2.assert)(localBlobRecord?.state === "uploaded", "Attempting to attach from unexpected state");
+                // If we just uploaded the blob TTL really shouldn't be expired at this location. But if we loaded from
+                // pending state, the upload may have happened some time far in the past and could be expired here.
+                if (isTTLTooCloseToExpiry(localBlobRecord)) {
+                    // If the TTL is expired, we assume it's gone from the storage and so is effectively localOnly again.
+                    // Then when we re-enter the loop, we'll re-upload it.
+                    this.localBlobCache.set(localId, { state: "localOnly", blob });
+                    // Emitting here isn't really necessary since the only listener would be attached below. Including here
+                    // for completeness though, in case we add other listeners in the future.
+                    this.internalEvents.emit("blobExpired", localId);
+                    return false;
+                }
+                else {
+                    this.localBlobCache.set(localId, {
+                        ...localBlobRecord,
+                        state: "attaching",
+                    });
+                    // Send and await a blob attach op. This serves two purposes:
+                    // 1. If its a new blob, i.e., it isn't de-duped, the server will keep the blob alive if it sees this op
+                    //    until its storage ID is added to the next summary.
+                    // 2. It will create a local ID to storage ID mapping in all clients which is needed to retrieve the
+                    //    blob from the server via the storage ID.
+                    return new Promise((resolve, reject) => {
+                        const onProcessedBlobAttach = (_localId, _storageId) => {
+                            if (_localId === localId) {
+                                removeListeners();
+                                resolve(true);
+                            }
+                        };
+                        // Although we already checked for TTL expiry above, the op we're about to send may later be asked
+                        // to resubmit. Before we resubmit, we check again for TTL expiry - this listener is how we learn if
+                        // we discovered expiry in the resubmit flow.
+                        const onBlobExpired = (_localId) => {
+                            if (_localId === localId) {
+                                removeListeners();
+                                resolve(false);
+                            }
+                        };
+                        const onSignalAbort = () => {
+                            removeListeners();
+                            this.localBlobCache.delete(localId);
+                            this.pendingBlobsWithAttachedHandles.delete(localId);
+                            reject(createAbortError());
+                        };
+                        const removeListeners = () => {
+                            this.internalEvents.off("processedBlobAttach", onProcessedBlobAttach);
+                            this.internalEvents.off("blobExpired", onBlobExpired);
+                            signal?.removeEventListener("abort", onSignalAbort);
+                        };
+                        this.internalEvents.on("processedBlobAttach", onProcessedBlobAttach);
+                        this.internalEvents.on("blobExpired", onBlobExpired);
+                        signal?.addEventListener("abort", onSignalAbort);
+                        this.sendBlobAttachOp(localId, localBlobRecord.storageId);
+                    });
+                }
+            };
+            let attachCompleted = false;
+            while (!attachCompleted) {
+                await ensureUploaded();
+                attachCompleted = await tryAttach();
+                // If something stopped the attach from completing successfully (currently just TTL expiry),
+                // we expect that the blob was already updated to reflect the updated state (i.e. back to localOnly)
+                // and we'll try the loop again from the top.
+            }
+            // When the blob successfully attaches, the localBlobRecord will have been updated to attached state
+            // at the time we processed the op, so there's nothing else to do here.
+        };
         /**
          * Called in detached state just prior to attaching, this will update the redirect table by
          * converting the pseudo storage IDs into real storage IDs using the provided detachedStorageTable.
@@ -93,14 +276,27 @@ class BlobManager {
             for (const [localId, detachedStorageId] of redirectTableEntries) {
                 const newStorageId = detachedStorageTable.get(detachedStorageId);
                 (0, internal_2.assert)(newStorageId !== undefined, 0xc53 /* Couldn't find a matching storage ID */);
-                this.setRedirection(localId, newStorageId);
+                this.redirectTable.set(localId, newStorageId);
                 // set identity (id -> id) entry
-                this.setRedirection(newStorageId, newStorageId);
+                this.redirectTable.set(newStorageId, newStorageId);
             }
         };
-        const { routeContext, blobManagerLoadInfo, storage, sendBlobAttachOp, blobRequested, isBlobDeleted, runtime, localIdGenerator, createBlobPayloadPending, } = props;
+        /**
+         * Upload and attach any pending blobs that the BlobManager was loaded with that have not already
+         * been attached in the meantime.
+         * @returns A promise that resolves when all the uploads and attaches have completed, or rejects
+         * if any of them fail.
+         */
+        this.sharePendingBlobs = async () => {
+            const localIdsToUpload = [...this.pendingOnlyLocalIds];
+            this.pendingOnlyLocalIds.clear();
+            // TODO: Determine if Promise.all is ergonomic at the callsite. Would Promise.allSettled be better?
+            await Promise.all(localIdsToUpload.map(async (localId) => this.uploadAndAttach(localId)));
+        };
+        const { routeContext, blobManagerLoadInfo, storage, sendBlobAttachOp, blobRequested, isBlobDeleted, runtime, pendingBlobs, localIdGenerator, createBlobPayloadPending, } = props;
         this.routeContext = routeContext;
         this.storage = storage;
+        this.sendBlobAttachOp = sendBlobAttachOp;
         this.blobRequested = blobRequested;
         this.isBlobDeleted = isBlobDeleted;
         this.runtime = runtime;
@@ -111,44 +307,30 @@ class BlobManager {
             namespace: "BlobManager",
         });
         this.redirectTable = (0, blobManagerSnapSum_js_1.toRedirectTable)(blobManagerLoadInfo, this.mc.logger);
-        this.sendBlobAttachOp = (localId, storageId) => {
-            const pendingEntry = this.pendingBlobs.get(localId);
-            (0, internal_2.assert)(pendingEntry !== undefined, 0x725 /* Must have pending blob entry for upcoming op */);
-            if (pendingEntry?.uploadTime !== undefined &&
-                pendingEntry?.minTTLInSeconds !== undefined) {
-                const secondsSinceUpload = (Date.now() - pendingEntry.uploadTime) / 1000;
-                const expired = pendingEntry.minTTLInSeconds - secondsSinceUpload < 0;
-                this.mc.logger.sendTelemetryEvent({
-                    eventName: "sendBlobAttach",
-                    secondsSinceUpload,
-                    minTTLInSeconds: pendingEntry.minTTLInSeconds,
-                    expired,
-                });
-                if (expired) {
-                    // reupload blob and reset previous fields
-                    this.pendingBlobs.set(localId, {
-                        ...pendingEntry,
-                        storageId: undefined,
-                        uploadTime: undefined,
-                        minTTLInSeconds: undefined,
-                        opsent: false,
-                        uploadP: this.uploadBlob(localId, pendingEntry.blob),
-                    });
-                    return;
-                }
+        // We populate the localBlobCache with any pending blobs we are provided, which makes them available
+        // to access even though they are not shared yet. However, we don't start the share flow until it is
+        // explicitly invoked via sharePendingBlobs() in case we are loaded in a frozen container.
+        if (pendingBlobs !== undefined) {
+            for (const [localId, serializableBlobRecord] of Object.entries(pendingBlobs)) {
+                (0, internal_2.assert)(!this.redirectTable.has(localId), "Pending blob already in redirect table");
+                const localBlobRecord = {
+                    ...serializableBlobRecord,
+                    blob: (0, client_utils_1.stringToBuffer)(serializableBlobRecord.blob, "base64"),
+                };
+                this.localBlobCache.set(localId, localBlobRecord);
+                // Since we received these blobs from pending state, we'll assume they were only added to the
+                // pending state at generation time because their handles were attached. We add them back here
+                // in case we need to round-trip them back out again due to another getPendingBlobs() call.
+                this.pendingBlobsWithAttachedHandles.add(localId);
+                this.pendingOnlyLocalIds.add(localId);
             }
-            pendingEntry.opsent = true;
-            sendBlobAttachOp(localId, storageId);
-        };
-    }
-    createAbortError(pending) {
-        return new internal_4.LoggingError("uploadBlob aborted", {
-            acked: pending?.acked,
-            uploadTime: pending?.uploadTime,
-        });
+        }
     }
+    /**
+     * Returns whether a blob with the given localId can be retrieved by the BlobManager via getBlob().
+     */
     hasBlob(localId) {
-        return this.redirectTable.get(localId) !== undefined;
+        return this.redirectTable.has(localId) || this.localBlobCache.has(localId);
     }
     /**
      * Lookup the blob storage ID for a given local blob id.
@@ -181,15 +363,16 @@ class BlobManager {
         // Note that this will throw if the blob is inactive or tombstoned and throwing on incorrect usage
         // is configured.
         this.blobRequested((0, exports.getGCNodePathFromLocalId)(localId));
-        const pending = this.pendingBlobs.get(localId);
-        if (pending) {
-            return pending.blob;
+        const localBlobRecord = this.localBlobCache.get(localId);
+        if (localBlobRecord !== undefined) {
+            return localBlobRecord.blob;
         }
         let storageId = this.redirectTable.get(localId);
         if (storageId === undefined) {
             // Only blob handles explicitly marked with pending payload are permitted to exist without
             // yet knowing their storage id. Otherwise they must already be associated with a storage id.
-            // Handles for detached blobs are not payload pending.
+            // Handles for detached blobs are not payload pending, though they should also always be present
+            // in the localBlobCache and therefore should never need to refer to storage.
             (0, internal_2.assert)(payloadPending, 0x11f /* "requesting unknown blobs" */);
             // If we didn't find it in the redirectTable and it's payloadPending, assume the attach op is coming
             // eventually and wait. We do this even if the local client doesn't have the blob payloadPending flag
@@ -217,33 +400,15 @@ class BlobManager {
             });
         }, { end: true, cancel: "error" });
     }
-    getBlobHandle(localId) {
-        (0, internal_2.assert)(this.redirectTable.has(localId) || this.pendingBlobs.has(localId), 0x384 /* requesting handle for unknown blob */);
-        const pending = this.pendingBlobs.get(localId);
-        // Create a callback function for once the handle has been attached
-        const callback = pending
-            ? () => {
-                pending.attached = true;
-                // Notify listeners (e.g. serialization process) that handle has been attached
-                this.internalEvents.emit("handleAttached", pending);
-                this.deletePendingBlobMaybe(localId);
-            }
-            : undefined;
-        return new BlobHandle((0, exports.getGCNodePathFromLocalId)(localId), this.routeContext, async () => this.getBlob(localId, false), false, // payloadPending
-        callback);
-    }
-    async createBlobDetached(blob) {
-        const localId = this.localIdGenerator();
-        // Blobs created while the container is detached are stored in IDetachedBlobStorage.
-        // The 'IContainerStorageService.createBlob()' call below will respond with a pseudo storage ID.
-        // That pseudo storage ID will be replaced with the real storage ID at attach time.
-        const { id: detachedStorageId } = await this.storage.createBlob(blob);
-        this.setRedirection(localId, detachedStorageId);
-        return this.getBlobHandle(localId);
+    getNonPayloadPendingBlobHandle(localId) {
+        const localBlobRecord = this.localBlobCache.get(localId);
+        (0, internal_2.assert)(localBlobRecord !== undefined, 0x384 /* requesting handle for unknown blob */);
+        (0, internal_2.assert)(localBlobRecord.state === "attached", "Expected blob to be attached");
+        return new BlobHandle((0, exports.getGCNodePathFromLocalId)(localId), this.routeContext, async () => this.getBlob(localId, false), false);
     }
     async createBlob(blob, signal) {
         if (this.runtime.attachState === internal_1.AttachState.Detached) {
-            return this.createBlobDetached(blob);
+            return this.createBlobDetached(blob, signal);
         }
         if (this.runtime.attachState === internal_1.AttachState.Attaching) {
             // blob upload is not supported in "Attaching" state
@@ -252,177 +417,46 @@ class BlobManager {
         }
         (0, internal_2.assert)(this.runtime.attachState === internal_1.AttachState.Attached, 0x385 /* For clarity and paranoid defense against adding future attachment states */);
         return this.createBlobPayloadPending
-            ? this.createBlobWithPayloadPending(blob)
+            ? this.createBlobWithPayloadPending(blob, signal)
             : this.createBlobLegacy(blob, signal);
     }
-    async createBlobLegacy(blob, signal) {
+    async createBlobDetached(blob, signal) {
         if (signal?.aborted === true) {
-            throw this.createAbortError();
+            throw createAbortError();
         }
-        // Create a local ID for the blob. After uploading it to storage and before returning it, a local ID to
-        // storage ID mapping is created.
         const localId = this.localIdGenerator();
-        const pendingEntry = {
-            blob,
-            handleP: new internal_2.Deferred(),
-            uploadP: this.uploadBlob(localId, blob),
-            attached: false,
-            acked: false,
-            abortSignal: signal,
-            opsent: false,
-        };
-        this.pendingBlobs.set(localId, pendingEntry);
-        const abortListener = () => {
-            if (pendingEntry.acked !== true) {
-                pendingEntry.handleP.reject(this.createAbortError(pendingEntry));
-            }
-        };
-        signal?.addEventListener("abort", abortListener, { once: true });
-        return pendingEntry.handleP.promise.finally(() => {
-            signal?.removeEventListener("abort", abortListener);
-        });
+        this.localBlobCache.set(localId, { state: "uploading", blob });
+        // Blobs created while the container is detached are stored in IDetachedBlobStorage.
+        // The 'IContainerStorageService.createBlob()' call below will respond with a pseudo storage ID.
+        // That pseudo storage ID will be replaced with the real storage ID at attach time.
+        const { id: detachedStorageId } = await this.storage.createBlob(blob);
+        // From the perspective of the BlobManager, the blob is now fully attached. The actual
+        // upload/attach process at container attach time is treated as opaque to this tracking.
+        this.localBlobCache.set(localId, { state: "attached", blob });
+        this.redirectTable.set(localId, detachedStorageId);
+        return this.getNonPayloadPendingBlobHandle(localId);
     }
-    createBlobWithPayloadPending(blob) {
+    async createBlobLegacy(blob, signal) {
         const localId = this.localIdGenerator();
+        this.localBlobCache.set(localId, { state: "localOnly", blob });
+        await this.uploadAndAttach(localId, signal);
+        return this.getNonPayloadPendingBlobHandle(localId);
+    }
+    createBlobWithPayloadPending(blob, signal) {
+        const localId = this.localIdGenerator();
+        this.localBlobCache.set(localId, { state: "localOnly", blob });
         const blobHandle = new BlobHandle((0, exports.getGCNodePathFromLocalId)(localId), this.routeContext, async () => blob, true, // payloadPending
         () => {
-            const pendingEntry = {
-                blob,
-                handleP: new internal_2.Deferred(),
-                uploadP: this.uploadBlob(localId, blob),
-                attached: true,
-                acked: false,
-                opsent: false,
-            };
-            this.pendingBlobs.set(localId, pendingEntry);
+            this.pendingBlobsWithAttachedHandles.add(localId);
+            const uploadAndAttachP = this.uploadAndAttach(localId, signal);
+            uploadAndAttachP.then(blobHandle.notifyShared).catch((error) => {
+                // TODO: notifyShared won't fail directly, but it emits an event to the customer.
+                // Consider what to do if the customer's code throws. reportError is nice.
+            });
+            uploadAndAttachP.catch(blobHandle.notifyFailed);
         });
-        const onProcessedBlobAttach = (_localId, _storageId) => {
-            if (_localId === localId) {
-                this.internalEvents.off("processedBlobAttach", onProcessedBlobAttach);
-                blobHandle.notifyShared();
-            }
-        };
-        this.internalEvents.on("processedBlobAttach", onProcessedBlobAttach);
-        const onUploadFailed = (_localId, error) => {
-            if (_localId === localId) {
-                this.internalEvents.off("uploadFailed", onUploadFailed);
-                blobHandle.notifyFailed(error);
-            }
-        };
-        this.internalEvents.on("uploadFailed", onUploadFailed);
         return blobHandle;
     }
-    /**
-     * Upload a blob to the storage service.
-     * @returns A promise that resolves when the upload is complete and a blob attach op has been sent (but not ack'd).
-     *
-     * @privateRemarks This method must not reject, as there is no error handling for it in current tracking.
-     */
-    async uploadBlob(localId, blob) {
-        let response;
-        try {
-            response = await this.storage.createBlob(blob);
-        }
-        catch (error) {
-            const entry = this.pendingBlobs.get(localId);
-            this.mc.logger.sendTelemetryEvent({
-                eventName: "UploadBlobReject",
-                // TODO: better typing
-                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
-                error: error,
-                message: entry === undefined ? "Missing pendingBlob" : undefined,
-                localId,
-            });
-            // We probably should assert the pendingBlobs entry here, but we don't currently have any error handling
-            // for the uploadP - a promise rejection would be unhandled anyway. For now we can detect this with the
-            // message on the UploadBlobReject telemetry.
-            if (entry !== undefined) {
-                entry.handleP.reject(error);
-                this.deletePendingBlob(localId);
-            }
-            this.internalEvents.emit("uploadFailed", localId, error);
-            return;
-        }
-        try {
-            this.onUploadResolve(localId, response);
-        }
-        catch (error) {
-            this.mc.logger.sendTelemetryEvent({
-                eventName: "OnUploadResolveError",
-                // TODO: better typing
-                // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
-                error: error,
-                localId,
-            });
-        }
-    }
-    /**
-     * Set up a mapping in the redirect table from fromId to toId. Also, notify the runtime that a reference is added
-     * which is required for GC.
-     */
-    setRedirection(fromId, toId) {
-        this.redirectTable.set(fromId, toId);
-    }
-    deletePendingBlobMaybe(localId) {
-        if (this.pendingBlobs.has(localId)) {
-            const entry = this.pendingBlobs.get(localId);
-            if (entry?.attached === true && entry?.acked === true) {
-                this.deletePendingBlob(localId);
-            }
-        }
-    }
-    deletePendingBlob(id) {
-        this.pendingBlobs.delete(id);
-    }
-    onUploadResolve(localId, response) {
-        const entry = this.pendingBlobs.get(localId);
-        (0, internal_2.assert)(entry !== undefined, 0x6c8 /* pending blob entry not found for uploaded blob */);
-        if (entry.abortSignal?.aborted === true && entry.opsent !== true) {
-            this.mc.logger.sendTelemetryEvent({
-                eventName: "BlobAborted",
-                localId,
-            });
-            this.deletePendingBlob(localId);
-            return;
-        }
-        (0, internal_2.assert)(entry.storageId === undefined, 0x386 /* Must have pending blob entry for uploaded blob */);
-        entry.storageId = response.id;
-        entry.uploadTime = Date.now();
-        entry.minTTLInSeconds = response.minTTLInSeconds;
-        // Send a blob attach op. This serves two purposes:
-        // 1. If its a new blob, i.e., it isn't de-duped, the server will keep the blob alive if it sees this op
-        //    until its storage ID is added to the next summary.
-        // 2. It will create a local ID to storage ID mapping in all clients which is needed to retrieve the
-        //    blob from the server via the storage ID.
-        if (entry.opsent !== true) {
-            this.sendBlobAttachOp(localId, response.id);
-        }
-        const storageIds = (0, blobManagerSnapSum_js_1.getStorageIds)(this.redirectTable);
-        if (storageIds.has(response.id)) {
-            // The blob is de-duped. Set up a local ID to storage ID mapping and return the blob. Since this is
-            // an existing blob, we don't have to wait for the op to be ack'd since this step has already
-            // happened before and so, the server won't delete it.
-            this.setRedirection(localId, response.id);
-            const blobHandle = this.getBlobHandle(localId);
-            blobHandle.notifyShared();
-            entry.handleP.resolve(blobHandle);
-            this.deletePendingBlobMaybe(localId);
-        }
-        else {
-            // If there is already an op for this storage ID, append the local ID to the list. Once any op for
-            // this storage ID is ack'd, all pending blobs for it can be resolved since the op will keep the
-            // blob alive in storage.
-            let setForRemoteId = this.opsInFlight.get(response.id);
-            if (setForRemoteId === undefined) {
-                setForRemoteId = new Set();
-                this.opsInFlight.set(response.id, setForRemoteId);
-            }
-            // seeing the same localId twice can happen if a blob is being reuploaded and stashed.
-            // TODO: review stashing logic and see if we can avoid this, as well in tests.
-            setForRemoteId.add(localId);
-        }
-        return response;
-    }
     /**
      * Resubmit a BlobAttach op. Used to add storage IDs to ops that were
      * submitted to runtime while disconnected.
@@ -431,54 +465,47 @@ class BlobManager {
     reSubmit(metadata) {
         (0, internal_2.assert)((0, metadata_js_1.isBlobMetadata)(metadata), 0xc01 /* Expected blob metadata for a BlobAttach op */);
         const { localId, blobId: storageId } = metadata;
-        // Any blob that we're actively trying to advance to attached state must have a
-        // pendingBlobs entry. Decline to resubmit for anything else.
-        // For example, we might be asked to resubmit stashed ops for blobs that never had
-        // their handle attached - these won't have a pendingBlobs entry and we shouldn't
-        // try to attach them since they won't be accessible to the customer and would just
-        // be considered garbage immediately.
-        if (this.pendingBlobs.has(localId)) {
-            this.sendBlobAttachOp(localId, storageId);
+        // Any blob that we're actively trying to advance to attached state must be in attaching state.
+        // Decline to resubmit for anything else.
+        // For example, we might be asked to resubmit stashed ops for blobs that never had their handle
+        // attached - these won't have a localBlobCache entry because we filter them out when generating
+        // pending state. We shouldn't try to attach them since they won't be accessible to the customer
+        // and would just be considered garbage immediately.
+        // TODO: Is it possible that we'd be asked to resubmit for a pending blob before we call sharePendingBlobs?
+        const localBlobRecord = this.localBlobCache.get(localId);
+        if (localBlobRecord?.state === "attaching") {
+            // If the TTL is expired, we assume it's gone from the storage and so is effectively localOnly again.
+            if (isTTLTooCloseToExpiry(localBlobRecord)) {
+                this.localBlobCache.set(localId, { state: "localOnly", blob: localBlobRecord.blob });
+                this.internalEvents.emit("blobExpired", localId);
+            }
+            else {
+                this.sendBlobAttachOp(localId, storageId);
+            }
         }
     }
     processBlobAttachMessage(message, local) {
         (0, internal_2.assert)((0, metadata_js_1.isBlobMetadata)(message.metadata), 0xc02 /* Expected blob metadata for a BlobAttach op */);
         const { localId, blobId: storageId } = message.metadata;
-        const pendingEntry = this.pendingBlobs.get(localId);
-        if (pendingEntry?.abortSignal?.aborted === true) {
-            this.deletePendingBlob(localId);
-            return;
+        const maybeLocalBlobRecord = this.localBlobCache.get(localId);
+        if (maybeLocalBlobRecord !== undefined) {
+            const attachedBlobRecord = {
+                state: "attached",
+                blob: maybeLocalBlobRecord.blob,
+            };
+            // Processing a blob attach op is authoritative and may stomp on any existing state. Other
+            // callsites that update localBlobCache entries must take proper caution to handle the case
+            // that a blob attach op is processed concurrently.
+            this.localBlobCache.set(localId, attachedBlobRecord);
+            // Note there may or may not be an entry in pendingBlobsWithAttachedHandles for this localId,
+            // in particular for the non-payloadPending case since we should be reaching this point
+            // before even returning a handle to the caller.
+            this.pendingBlobsWithAttachedHandles.delete(localId);
+            this.pendingOnlyLocalIds.delete(localId);
         }
-        this.setRedirection(localId, storageId);
+        this.redirectTable.set(localId, storageId);
         // set identity (id -> id) entry
-        this.setRedirection(storageId, storageId);
-        if (local) {
-            const waitingBlobs = this.opsInFlight.get(storageId);
-            if (waitingBlobs !== undefined) {
-                // For each op corresponding to this storage ID that we are waiting for, resolve the pending blob.
-                // This is safe because the server will keep the blob alive and the op containing the local ID to
-                // storage ID is already in flight and any op containing this local ID will be sequenced after that.
-                for (const pendingLocalId of waitingBlobs) {
-                    const entry = this.pendingBlobs.get(pendingLocalId);
-                    (0, internal_2.assert)(entry !== undefined, 0x38f /* local online BlobAttach op with no pending blob entry */);
-                    this.setRedirection(pendingLocalId, storageId);
-                    entry.acked = true;
-                    const blobHandle = this.getBlobHandle(pendingLocalId);
-                    blobHandle.notifyShared();
-                    entry.handleP.resolve(blobHandle);
-                    this.deletePendingBlobMaybe(pendingLocalId);
-                }
-                this.opsInFlight.delete(storageId);
-            }
-            const localEntry = this.pendingBlobs.get(localId);
-            if (localEntry) {
-                localEntry.acked = true;
-                const blobHandle = this.getBlobHandle(localId);
-                blobHandle.notifyShared();
-                localEntry.handleP.resolve(blobHandle);
-                this.deletePendingBlobMaybe(localId);
-            }
-        }
+        this.redirectTable.set(storageId, storageId);
         this.internalEvents.emit("processedBlobAttach", localId, storageId);
     }
     summarize(telemetryContext) {
@@ -503,18 +530,9 @@ class BlobManager {
         }
         return gcData;
     }
-    /**
-     * Delete attachment blobs that are sweep ready.
-     * @param sweepReadyBlobRoutes - The routes of blobs that are sweep ready and should be deleted. These routes will
-     * be based off of local ids.
-     * @returns The routes of blobs that were deleted.
-     */
-    deleteSweepReadyNodes(sweepReadyBlobRoutes) {
-        this.deleteBlobsFromRedirectTable(sweepReadyBlobRoutes);
-        return [...sweepReadyBlobRoutes];
-    }
     /**
      * Delete blobs with the given routes from the redirect table.
+     * @returns The routes of blobs that were deleted.
      *
      * @remarks
      * The routes are GC nodes paths of format -`/<blobManagerBasePath>/<localId>`.
@@ -529,11 +547,11 @@ class BlobManager {
      * will ensure we don't create an attachment blob for them at the next summary. The service would then delete them
      * some time in the future.
      */
-    deleteBlobsFromRedirectTable(blobRoutes) {
+    deleteSweepReadyNodes(sweepReadyBlobRoutes) {
         // maybeUnusedStorageIds is used to compute the set of storage IDs that *used to have a local ID*, but that
         // local ID is being deleted.
         const maybeUnusedStorageIds = new Set();
-        for (const route of blobRoutes) {
+        for (const route of sweepReadyBlobRoutes) {
             const localId = getLocalIdFromGCNodePath(route);
             // If the blob hasn't already been deleted, log an error because this should never happen.
             // If the blob has already been deleted, log a telemetry event. This can happen because multiple GC
@@ -567,6 +585,7 @@ class BlobManager {
         for (const storageId of maybeUnusedStorageIds) {
             this.redirectTable.delete(storageId);
         }
+        return [...sweepReadyBlobRoutes];
     }
     /**
      * Verifies that the blob with given id is not deleted, i.e., it has not been garbage collected. If the blob is GC'd,
@@ -589,28 +608,31 @@ class BlobManager {
      * To be used in getPendingLocalState flow. Get a serializable record of the blobs that are
      * pending upload and/or their BlobAttach op, which can be given to a new BlobManager to
      * resume work.
-     *
-     * @privateRemarks
-     * For now, we don't track any pending blobs since the getPendingBlobs flow doesn't enable
-     * restoring to a state where an accessible handle has been stored by the customer (and we'll
-     * just drop any BlobAttach ops on the ground during reSubmit). However, once we add support
-     * for payload-pending handles, this will return the blobs associated with those handles.
      */
     getPendingBlobs() {
-        return undefined;
-    }
-    /**
-     * Part of container serialization when imminent closure is enabled (Currently when calling closeAndGetPendingLocalState).
-     * This asynchronous function resolves all pending createBlob calls and waits for each blob
-     * to be attached. It will also send BlobAttach ops for each pending blob that hasn't sent it
-     * yet so that serialized container can resubmit them when rehydrated.
-     *
-     * @param stopBlobAttachingSignal - Optional signal to abort the blob attaching process.
-     * @returns - A promise that resolves with the details of the attached blobs,
-     * or undefined if no blobs were processed.
-     */
-    async attachAndGetPendingBlobs(stopBlobAttachingSignal) {
-        throw new internal_4.UsageError("attachAndGetPendingBlobs is no longer supported");
+        const pendingBlobs = {};
+        for (const localId of this.pendingBlobsWithAttachedHandles) {
+            const localBlobRecord = this.localBlobCache.get(localId);
+            (0, internal_2.assert)(localBlobRecord !== undefined, "Pending blob must be in local cache");
+            (0, internal_2.assert)(localBlobRecord.state === "uploading" ||
+                localBlobRecord.state === "uploaded" ||
+                localBlobRecord.state === "attaching", "Pending blob must be in uploading, uploaded, or attaching state");
+            // We treat blobs in both uploaded and attaching state as just being uploaded, to distrust
+            // whether we expect to see any ack for a BlobAttach op. We just remain prepared to handle
+            // a BlobAttach op for it if we do see one after loading from pending state.
+            pendingBlobs[localId] =
+                localBlobRecord.state === "uploading"
+                    ? {
+                        state: "localOnly",
+                        blob: (0, client_utils_1.bufferToString)(localBlobRecord.blob, "base64"),
+                    }
+                    : {
+                        ...localBlobRecord,
+                        state: "uploaded",
+                        blob: (0, client_utils_1.bufferToString)(localBlobRecord.blob, "base64"),
+                    };
+        }
+        return Object.keys(pendingBlobs).length > 0 ? pendingBlobs : undefined;
     }
 }
 exports.BlobManager = BlobManager;