@fluidframework/container-runtime 2.62.0-356644 → 2.63.0-358419

package/lib/containerRuntime.js

@@ -11,9 +11,7 @@ import { FetchSource, MessageType } from "@fluidframework/driver-definitions/int
 import { readAndParse } from "@fluidframework/driver-utils/internal";
 import { createIdCompressor, createSessionId, deserializeIdCompressor, } from "@fluidframework/id-compressor/internal";
 import { FlushMode, FlushModeExperimental, channelsTreeName, gcTreeKey, } from "@fluidframework/runtime-definitions/internal";
-import { defaultMinVersionForCollab, isValidMinVersionForCollab, } from "@fluidframework/runtime-utils/internal";
-import { GCDataBuilder, RequestParser, RuntimeHeaders, TelemetryContext, addBlobToSummary, addSummarizeResultToSummary, calculateStats, create404Response, exceptionToResponse, seqFromTree, } from "@fluidframework/runtime-utils/internal";
-import { semanticVersionToMinimumVersionForCollab } from "@fluidframework/runtime-utils/internal";
+import { addBlobToSummary, addSummarizeResultToSummary, calculateStats, create404Response, defaultMinVersionForCollab, exceptionToResponse, GCDataBuilder, isValidMinVersionForCollab, RequestParser, RuntimeHeaders, semanticVersionToMinimumVersionForCollab, seqFromTree, TelemetryContext, } from "@fluidframework/runtime-utils/internal";
 import { DataCorruptionError, DataProcessingError, extractSafePropertiesFromMessage, GenericError, LoggingError, PerformanceEvent, 
 // eslint-disable-next-line import/no-deprecated
 TaggedLoggerAdapter, UsageError, createChildLogger, createChildMonitoringContext, createSampledLogger, loggerToMonitoringContext, raiseConnectedEvent, wrapError, tagCodeArtifacts, normalizeError, } from "@fluidframework/telemetry-utils/internal";
@@ -39,7 +37,8 @@ import { PendingStateManager, } from "./pendingStateManager.js";
 import { BatchRunCounter, RunCounter } from "./runCounter.js";
 import { runtimeCompatDetailsForLoader, validateLoaderCompatibility, } from "./runtimeLayerCompatState.js";
 import { SignalTelemetryManager } from "./signalTelemetryProcessing.js";
-import { DocumentsSchemaController, OrderedClientElection, RetriableSummaryError, aliasBlobName, chunksBlobName, recentBatchInfoBlobName, createRootSummarizerNodeWithGC, electedSummarizerBlobName, extractSummaryMetadataMessage, idCompressorBlobName, metadataBlobName, rootHasIsolatedChannels, wrapSummaryInChannelsTree, formCreateSummarizerFn, summarizerRequestUrl, SummaryManager, SummarizerClientElection, SummaryCollection, OrderedClientCollection, validateSummaryHeuristicConfiguration, DefaultSummaryConfiguration, isSummariesDisabled, summarizerClientType, } from "./summary/index.js";
+// These types are imported as types here because they are present in summaryDelayLoadedModule, which is loaded dynamically when required.
+import { aliasBlobName, chunksBlobName, createRootSummarizerNodeWithGC, DefaultSummaryConfiguration, DocumentsSchemaController, electedSummarizerBlobName, extractSummaryMetadataMessage, formCreateSummarizerFn, idCompressorBlobName, isSummariesDisabled, metadataBlobName, OrderedClientCollection, OrderedClientElection, recentBatchInfoBlobName, RetriableSummaryError, rootHasIsolatedChannels, SummarizerClientElection, summarizerClientType, summarizerRequestUrl, SummaryCollection, SummaryManager, validateSummaryHeuristicConfiguration, wrapSummaryInChannelsTree, } from "./summary/index.js";
 import { Throttler, formExponentialFn } from "./throttler.js";
 /**
  * Creates an error object to be thrown / passed to Container's close fn in case of an unknown message type.
@@ -161,7 +160,7 @@ export const makeLegacySendBatchFn = (submitFn, deltaManager) => (batch) => {
  * Please see addMetadataToSummary() as well
  */
 function lastMessageFromMetadata(metadata) {
-    return metadata?.documentSchema?.runtime?.explicitSchemaControl
+    return metadata?.documentSchema?.runtime?.explicitSchemaControl === true
         ? metadata?.lastMessage
         : metadata?.message;
 }
@@ -298,7 +297,7 @@ export class ContainerRuntime extends TypedEventEmitter {
         const registry = new FluidDataStoreRegistry(registryEntries);
         const tryFetchBlob = async (blobName) => {
             const blobId = context.baseSnapshot?.blobs[blobName];
-            if (context.baseSnapshot && blobId) {
+            if (context.baseSnapshot !== undefined && blobId !== undefined) {
                 // IContainerContext storage api return type still has undefined in 0.39 package version.
                 // So once we release 0.40 container-defn package we can remove this check.
                 assert(context.storage !== undefined, 0x1f5 /* "Attached state should have storage" */);
@@ -320,7 +319,7 @@ export class ContainerRuntime extends TypedEventEmitter {
         const runtimeSequenceNumber = messageAtLastSummary?.sequenceNumber;
         const protocolSequenceNumber = context.deltaManager.initialSequenceNumber;
         // When we load with pending state, we reuse an old snapshot so we don't expect these numbers to match
-        if (!context.pendingLocalState && runtimeSequenceNumber !== undefined) {
+        if (context.pendingLocalState === undefined && runtimeSequenceNumber !== undefined) {
             // Unless bypass is explicitly set, then take action when sequence numbers mismatch.
             // eslint-disable-next-line unicorn/no-lonely-if -- Separate if statements make flow easier to parse
             if (loadSequenceNumberVerification !== "bypass" &&
@@ -701,6 +700,7 @@ export class ContainerRuntime extends TypedEventEmitter {
         this.getConnectionState = getConnectionState;
         // In old loaders without dispose functionality, closeFn is equivalent but will also switch container to readonly mode
         this.disposeFn = disposeFn ?? closeFn;
+        this.isSnapshotInstanceOfISnapshot = snapshotWithContents !== undefined;
         // Validate that the Loader is compatible with this Runtime.
         const maybeLoaderCompatDetailsForRuntime = context;
         validateLoaderCompatibility(maybeLoaderCompatDetailsForRuntime.ILayerCompatDetails, this.disposeFn);
@@ -738,7 +738,7 @@ export class ContainerRuntime extends TypedEventEmitter {
             submitSignalFn(envelope, targetClientId);
         };
         this.submitSignalFn = (envelope, targetClientId) => {
-            if (envelope.address?.startsWith("/")) {
+            if (envelope.address?.startsWith("/") === true) {
                 throw new Error("General path based addressing is not implemented");
             }
             sequenceAndSubmitSignal(envelope, targetClientId);
@@ -939,9 +939,6 @@ export class ContainerRuntime extends TypedEventEmitter {
         // Function to get the GC details from the base snapshot we loaded from.
         async () => this.garbageCollector.getBaseGCDetails());
         const parentContext = wrapContext(this);
-        if (snapshotWithContents !== undefined) {
-            this.isSnapshotInstanceOfISnapshot = true;
-        }
         // Due to a mismatch between different layers in terms of
         // what is the interface of passing signals, we need the
         // downstream stores to wrap the signal.
@@ -1429,7 +1426,7 @@ export class ContainerRuntime extends TypedEventEmitter {
             this.messageAtLastSummary;
         const documentSchema = this.documentsSchemaController.summarizeDocumentSchema(this.deltaManager.lastSequenceNumber);
         // Is document schema explicit control on?
-        const explicitSchemaControl = documentSchema?.runtime.explicitSchemaControl;
+        const explicitSchemaControl = documentSchema?.runtime.explicitSchemaControl === true;
         const metadata = {
             ...this.createContainerMetadata,
             // Increment the summary number for the next summary that will be generated.
@@ -1439,7 +1436,7 @@ export class ContainerRuntime extends TypedEventEmitter {
             telemetryDocumentId: this.telemetryDocumentId,
             // If explicit document schema control is not on, use legacy way to supply last message (using 'message' property).
             // Otherwise use new 'lastMessage' property, but also put content into the 'message' property that cases old
-            // runtimes (that preceed document schema control capabilities) to close container on load due to mismatch in
+            // runtimes (that preceded document schema control capabilities) to close container on load due to mismatch in
             // last message's sequence number.
             // See also lastMessageFromMetadata()
             message: explicitSchemaControl
@@ -1753,7 +1750,7 @@ export class ContainerRuntime extends TypedEventEmitter {
             if ("batchStart" in inboundResult) {
                 const batchStart = inboundResult.batchStart;
                 const result = this.duplicateBatchDetector?.processInboundBatch(batchStart);
-                if (result?.duplicate) {
+                if (result?.duplicate === true) {
                     const error = new DataCorruptionError("Duplicate batch - The same batch was sequenced twice", { batchId: batchStart.batchId });
                     this.mc.logger.sendTelemetryEvent({
                         eventName: "DuplicateBatch",
@@ -2093,7 +2090,7 @@ export class ContainerRuntime extends TypedEventEmitter {
         let checkpoint;
         // eslint-disable-next-line import/no-deprecated
         let stageControls;
-        if (this.mc.config.getBoolean("Fluid.ContainerRuntime.EnableRollback")) {
+        if (this.mc.config.getBoolean("Fluid.ContainerRuntime.EnableRollback") === true) {
             if (!this.batchRunner.running && !this.inStagingMode) {
                 stageControls = this.enterStagingMode();
             }
@@ -2192,7 +2189,7 @@ export class ContainerRuntime extends TypedEventEmitter {
     shouldSendOps() {
         // Note that the real (non-proxy) delta manager is needed here to get the readonly info. This is because
         // container runtime's ability to send ops depend on the actual readonly state of the delta manager.
-        return this.connected && !this.innerDeltaManager.readOnlyInfo.readonly;
+        return this.connected && this.innerDeltaManager.readOnlyInfo.readonly !== true;
     }
     getQuorum() {
         return this._quorum;
@@ -2653,11 +2650,11 @@ export class ContainerRuntime extends TypedEventEmitter {
             // Because handles are unchanged dataStores in the current logic,
             // summarized dataStore count is total dataStore count minus handle count
             const dataStoreTree = summaryTree.tree[channelsTreeName];
-            assert(dataStoreTree.type === SummaryType.Tree, 0x1fc /* "summary is not a tree" */);
+            assert(dataStoreTree?.type === SummaryType.Tree, 0x1fc /* "summary is not a tree" */);
             const handleCount = Object.values(dataStoreTree.tree).filter((value) => value.type === SummaryType.Handle).length;
-            const gcSummaryTreeStats = summaryTree.tree[gcTreeKey]
-                ? calculateStats(summaryTree.tree[gcTreeKey])
-                : undefined;
+            const gcSummaryTreeStats = summaryTree.tree[gcTreeKey] === undefined
+                ? undefined
+                : calculateStats(summaryTree.tree[gcTreeKey]);
             const summaryStats = {
                 dataStoreCount: this.channelCollection.size,
                 summarizedDataStoreCount: this.channelCollection.size - handleCount,
@@ -2704,7 +2701,7 @@ export class ContainerRuntime extends TypedEventEmitter {
                 // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
                 head: parent,
                 message,
-                parents: parent ? [parent] : [],
+                parents: parent === undefined ? [] : [parent],
             };
             const uploadData = {
                 ...generateSummaryData,
@@ -2778,7 +2775,7 @@ export class ContainerRuntime extends TypedEventEmitter {
         // This is a fallback to make progress in documents where there are consistently pending ops in
         // the summarizer.
         if (finalAttempt &&
-            this.mc.config.getBoolean("Fluid.Summarizer.SkipFailingIncorrectSummary")) {
+            this.mc.config.getBoolean("Fluid.Summarizer.SkipFailingIncorrectSummary") === true) {
             const error = DataProcessingError.create("Pending ops during summarization", "submitSummary", undefined, { pendingMessages: this.pendingMessagesCount });
             logger.sendErrorEvent({
                 eventName: "SkipFailingIncorrectSummary",
@@ -2882,7 +2879,7 @@ export class ContainerRuntime extends TypedEventEmitter {
             containerRuntimeMessage.type === ContainerMessageType.BlobAttach, 0x93f /* metadata */);
         // Note that the real (non-proxy) delta manager is used here to get the readonly info. This is because
         // container runtime's ability to submit ops depend on the actual readonly state of the delta manager.
-        if (this.innerDeltaManager.readOnlyInfo.readonly) {
+        if (this.innerDeltaManager.readOnlyInfo.readonly === true) {
             this.mc.logger.sendTelemetryEvent({
                 eventName: "SubmitOpInReadonly",
                 connected: this.connected,
@@ -3211,7 +3208,7 @@ export class ContainerRuntime extends TypedEventEmitter {
                 const versions = await this.storage.getVersions(
                 // eslint-disable-next-line unicorn/no-null
                 null, 1, scenarioName, FetchSource.noCache);
-                assert(!!versions && !!versions[0], 0x137 /* "Failed to get version from storage" */);
+                assert(versions[0] !== undefined, 0x137 /* "Failed to get version from storage" */);
                 snapshotTree = await this.storage.getSnapshotTree(versions[0]);
                 assert(!!snapshotTree, 0x138 /* "Failed to get snapshot from storage" */);
                 props.snapshotVersion = versions[0].id;
@@ -3239,7 +3236,7 @@ export class ContainerRuntime extends TypedEventEmitter {
             throw new UsageError("getPendingLocalState is not yet supported in staging mode");
         }
         this.verifyNotClosed();
-        if (props?.notifyImminentClosure) {
+        if (props?.notifyImminentClosure === true) {
             throw new UsageError("notifyImminentClosure is no longer supported in ContainerRuntime");
         }
         if (this.batchRunner.running) {