@fluidframework/container-runtime 2.62.0-356644 → 2.62.0

package/src/pendingStateManager.ts

@@ -160,6 +160,8 @@ function buildPendingMessageContent(message: InboundSequencedContainerRuntimeMes
 }
 
 function typesOfKeys<T extends object>(obj: T): Record<keyof T, string> {
+	// TODO: Fix this violation and remove the disable
+	// eslint-disable-next-line unicorn/no-array-reduce
 	return Object.keys(obj).reduce((acc, key) => {
 		acc[key] = typeof obj[key];
 		return acc;
@@ -174,7 +176,10 @@ function scrubAndStringify(
 
 	// For these known/expected keys, we can either drill into the object (for contents)
 	// or just use the value as-is (since it's not personal info)
-	scrubbed.contents = message.contents && typesOfKeys(message.contents);
+	scrubbed.contents =
+		typeof message.contents === "object" && message.contents !== null
+			? typesOfKeys(message.contents)
+			: undefined;
 	scrubbed.type = message.type;
 
 	return JSON.stringify(scrubbed);
@@ -733,7 +738,7 @@ export class PendingStateManager implements IDisposable {
 					pendingMessageBatchMetadata: asBatchMetadata(pendingMessage.opMetadata)?.batch,
 					messageBatchMetadata: asBatchMetadata(firstMessage?.metadata)?.batch,
 				},
-				messageDetails: firstMessage && extractSafePropertiesFromMessage(firstMessage),
+				messageDetails: extractSafePropertiesFromMessage(firstMessage),
 			});
 		}
 	}
@@ -797,9 +802,10 @@ export class PendingStateManager implements IDisposable {
 			assert(batchMetadataFlag !== false, 0x41b /* We cannot process batches in chunks */);
 
 			// The next message starts a batch (possibly single-message), and we'll need its batchId.
-			const batchId = pendingMessage.batchInfo.ignoreBatchId
-				? undefined
-				: getEffectiveBatchId(pendingMessage);
+			const batchId =
+				pendingMessage.batchInfo.ignoreBatchId === true
+					? undefined
+					: getEffectiveBatchId(pendingMessage);
 
 			const staged = pendingMessage.batchInfo.staged;
 

package/src/summary/summaryDelayLoadedModule/runningSummarizer.ts

@@ -310,7 +310,8 @@ export class RunningSummarizer
 			"Fluid.Summarizer.AttemptsForSubmitFailures",
 		);
 		this.maxAttemptsForSubmitFailures =
-			overrideMaxAttempts && overrideMaxAttempts < defaultMaxAttemptsForSubmitFailures
+			overrideMaxAttempts !== undefined &&
+			overrideMaxAttempts < defaultMaxAttemptsForSubmitFailures
 				? overrideMaxAttempts
 				: defaultMaxAttemptsForSubmitFailures;
 	}
@@ -502,7 +503,7 @@ export class RunningSummarizer
 		// This will try to run lastSummary if needed.
 		if (
 			allowLastSummary &&
-			this.heuristicRunner?.shouldRunLastSummary() &&
+			this.heuristicRunner?.shouldRunLastSummary() === true &&
 			this.summarizingLock === undefined
 		) {
 			this.trySummarizeOnce(

package/src/summary/summaryDelayLoadedModule/summarizer.ts

@@ -326,7 +326,7 @@ export class Summarizer extends TypedEventEmitter<ISummarizerEvents> implements
 
 	public summarizeOnDemand(options: IOnDemandSummarizeOptions): ISummarizeResults {
 		try {
-			if (this._disposed || this.runningSummarizer?.disposed) {
+			if (this._disposed || this.runningSummarizer?.disposed === true) {
 				throw new UsageError("Summarizer is already disposed.");
 			}
 			if (

package/src/summary/summaryDelayLoadedModule/summaryGenerator.ts

@@ -188,7 +188,7 @@ export class SummaryGenerator {
 			 * state change of multiple data stores. So, the total number of data stores that are summarized should not
 			 * exceed the number of ops since last summary + number of data store whose reference state changed.
 			 */
-			if (!submitSummaryOptions.fullTree) {
+			if (submitSummaryOptions.fullTree !== true) {
 				const { summarizedDataStoreCount, gcStateUpdatedDataStoreCount = 0 } =
 					summaryData.summaryStats;
 				if (