@fluidframework/container-runtime 2.61.0 → 2.62.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fluidframework/container-runtime",
-  "version": "2.61.0",
+  "version": "2.62.0",
   "description": "Fluid container runtime",
   "homepage": "https://fluidframework.com",
   "repository": {
@@ -119,18 +119,18 @@
     "temp-directory": "nyc/.nyc_output"
   },
   "dependencies": {
-    "@fluid-internal/client-utils": "~2.61.0",
-    "@fluidframework/container-definitions": "~2.61.0",
-    "@fluidframework/container-runtime-definitions": "~2.61.0",
-    "@fluidframework/core-interfaces": "~2.61.0",
-    "@fluidframework/core-utils": "~2.61.0",
-    "@fluidframework/datastore": "~2.61.0",
-    "@fluidframework/driver-definitions": "~2.61.0",
-    "@fluidframework/driver-utils": "~2.61.0",
-    "@fluidframework/id-compressor": "~2.61.0",
-    "@fluidframework/runtime-definitions": "~2.61.0",
-    "@fluidframework/runtime-utils": "~2.61.0",
-    "@fluidframework/telemetry-utils": "~2.61.0",
+    "@fluid-internal/client-utils": "~2.62.0",
+    "@fluidframework/container-definitions": "~2.62.0",
+    "@fluidframework/container-runtime-definitions": "~2.62.0",
+    "@fluidframework/core-interfaces": "~2.62.0",
+    "@fluidframework/core-utils": "~2.62.0",
+    "@fluidframework/datastore": "~2.62.0",
+    "@fluidframework/driver-definitions": "~2.62.0",
+    "@fluidframework/driver-utils": "~2.62.0",
+    "@fluidframework/id-compressor": "~2.62.0",
+    "@fluidframework/runtime-definitions": "~2.62.0",
+    "@fluidframework/runtime-utils": "~2.62.0",
+    "@fluidframework/telemetry-utils": "~2.62.0",
     "@tylerbu/sorted-btree-es6": "^1.8.0",
     "double-ended-queue": "^2.1.0-0",
     "lz4js": "^0.2.0",
@@ -140,16 +140,16 @@
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.17.1",
     "@biomejs/biome": "~1.9.3",
-    "@fluid-internal/mocha-test-setup": "~2.61.0",
-    "@fluid-private/stochastic-test-utils": "~2.61.0",
-    "@fluid-private/test-pairwise-generator": "~2.61.0",
+    "@fluid-internal/mocha-test-setup": "~2.62.0",
+    "@fluid-private/stochastic-test-utils": "~2.62.0",
+    "@fluid-private/test-pairwise-generator": "~2.62.0",
     "@fluid-tools/benchmark": "^0.51.0",
     "@fluid-tools/build-cli": "^0.58.3",
     "@fluidframework/build-common": "^2.0.3",
     "@fluidframework/build-tools": "^0.58.3",
     "@fluidframework/container-runtime-previous": "npm:@fluidframework/container-runtime@2.60.0",
     "@fluidframework/eslint-config-fluid": "^6.0.0",
-    "@fluidframework/test-runtime-utils": "~2.61.0",
+    "@fluidframework/test-runtime-utils": "~2.62.0",
     "@microsoft/api-extractor": "7.52.11",
     "@types/double-ended-queue": "^2.1.0",
     "@types/lz4js": "^0.2.0",
@@ -213,7 +213,7 @@
     "test:benchmark:report": "cross-env \"MOCHA_SPEC=dist/**/*.perf.spec.*js\" mocha --timeout 10s --perfMode --parentProcess --fgrep @Benchmark --fgrep @ExecutionTime --reporter @fluid-tools/benchmark/dist/MochaReporter.js",
     "test:coverage": "c8 npm test",
     "test:mocha": "npm run test:mocha:esm && echo skipping cjs to avoid overhead - npm run test:mocha:cjs",
-    "test:mocha:cjs": "cross-env MOCHA_SPEC=dist/test mocha",
+    "test:mocha:cjs": "cross-env FLUID_TEST_MODULE_SYSTEM=CJS mocha",
     "test:mocha:esm": "mocha",
     "test:mocha:verbose": "cross-env FLUID_TEST_VERBOSE=1 npm run test:mocha",
     "tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && npm run place:cjs:package-stub",

package/src/blobManager/blobManager.ts

@@ -274,7 +274,10 @@ export class BlobManager {
 				pendingEntry !== undefined,
 				0x725 /* Must have pending blob entry for upcoming op */,
 			);
-			if (pendingEntry?.uploadTime && pendingEntry?.minTTLInSeconds) {
+			if (
+				pendingEntry?.uploadTime !== undefined &&
+				pendingEntry?.minTTLInSeconds !== undefined
+			) {
 				const secondsSinceUpload = (Date.now() - pendingEntry.uploadTime) / 1000;
 				const expired = pendingEntry.minTTLInSeconds - secondsSinceUpload < 0;
 				this.mc.logger.sendTelemetryEvent({
@@ -376,6 +379,8 @@ export class BlobManager {
 			// eventually and wait. We do this even if the local client doesn't have the blob payloadPending flag
 			// enabled, in case a remote client does have it enabled. This wait may be infinite if the uploading
 			// client failed the upload and doesn't exist anymore.
+			// TODO: Fix this violation and remove the disable
+			// eslint-disable-next-line require-atomic-updates
 			storageId = await new Promise<string>((resolve) => {
 				const onProcessBlobAttach = (_localId: string, _storageId: string): void => {
 					if (_localId === localId) {
@@ -466,7 +471,7 @@ export class BlobManager {
 		blob: ArrayBufferLike,
 		signal?: AbortSignal,
 	): Promise<IFluidHandleInternalPayloadPending<ArrayBufferLike>> {
-		if (signal?.aborted) {
+		if (signal?.aborted === true) {
 			throw this.createAbortError();
 		}
 
@@ -485,7 +490,7 @@ export class BlobManager {
 		this.pendingBlobs.set(localId, pendingEntry);
 
 		const abortListener = (): void => {
-			if (!pendingEntry.acked) {
+			if (pendingEntry.acked !== true) {
 				pendingEntry.handleP.reject(this.createAbortError(pendingEntry));
 			}
 		};
@@ -593,7 +598,7 @@ export class BlobManager {
 	private deletePendingBlobMaybe(localId: string): void {
 		if (this.pendingBlobs.has(localId)) {
 			const entry = this.pendingBlobs.get(localId);
-			if (entry?.attached && entry?.acked) {
+			if (entry?.attached === true && entry?.acked === true) {
 				this.deletePendingBlob(localId);
 			}
 		}
@@ -612,7 +617,7 @@ export class BlobManager {
 		const entry = this.pendingBlobs.get(localId);
 
 		assert(entry !== undefined, 0x6c8 /* pending blob entry not found for uploaded blob */);
-		if (entry.abortSignal?.aborted === true && !entry.opsent) {
+		if (entry.abortSignal?.aborted === true && entry.opsent !== true) {
 			this.mc.logger.sendTelemetryEvent({
 				eventName: "BlobAborted",
 				localId,
@@ -632,7 +637,7 @@ export class BlobManager {
 		//    until its storage ID is added to the next summary.
 		// 2. It will create a local ID to storage ID mapping in all clients which is needed to retrieve the
 		//    blob from the server via the storage ID.
-		if (!entry.opsent) {
+		if (entry.opsent !== true) {
 			this.sendBlobAttachOp(localId, response.id);
 		}
 		const storageIds = getStorageIds(this.redirectTable);
@@ -687,7 +692,7 @@ export class BlobManager {
 		);
 		const { localId, blobId: storageId } = message.metadata;
 		const pendingEntry = this.pendingBlobs.get(localId);
-		if (pendingEntry?.abortSignal?.aborted) {
+		if (pendingEntry?.abortSignal?.aborted === true) {
 			this.deletePendingBlob(localId);
 			return;
 		}

package/src/blobManager/blobManagerSnapSum.ts

@@ -42,7 +42,7 @@ const loadV1 = async (
 		return {};
 	}
 	let redirectTableEntries: [string, string][] = [];
-	const tableId = blobsTree.blobs[redirectTableBlobName];
+	const tableId: string | undefined = blobsTree.blobs[redirectTableBlobName];
 	if (tableId) {
 		redirectTableEntries = await readAndParse(context.storage, tableId);
 	}

package/src/channelCollection.ts

@@ -545,7 +545,7 @@ export class ChannelCollection implements IFluidDataStoreChannel, IDisposable {
 
 		// If message timestamp doesn't exist, this is called in a detached container. Don't notify GC in that case
 		// because it doesn't run in detached container and doesn't need to know about this route.
-		if (messageTimestampMs) {
+		if (messageTimestampMs !== undefined) {
 			this.parentContext.addedGCOutboundRoute("/", `/${internalId}`, messageTimestampMs);
 		}
 
@@ -1613,8 +1613,8 @@ export function getSummaryForDatastores(
 	}
 
 	if (rootHasIsolatedChannels(metadata)) {
-		const datastoresSnapshot = snapshot.trees[channelsTreeName];
-		assert(!!datastoresSnapshot, 0x168 /* Expected tree in snapshot not found */);
+		const datastoresSnapshot: ISnapshotTree | undefined = snapshot.trees[channelsTreeName];
+		assert(datastoresSnapshot !== undefined, 0x168 /* Expected tree in snapshot not found */);
 		return datastoresSnapshot;
 	} else {
 		// back-compat: strip out all non-datastore paths before giving to DataStores object.

package/src/containerRuntime.ts

@@ -83,6 +83,7 @@ import type {
 	ISnapshotTree,
 	ISummaryContent,
 	ISummaryContext,
+	SummaryObject,
 } from "@fluidframework/driver-definitions/internal";
 import { FetchSource, MessageType } from "@fluidframework/driver-definitions/internal";
 import { readAndParse } from "@fluidframework/driver-utils/internal";
@@ -128,22 +129,20 @@ import type {
 	MinimumVersionForCollab,
 } from "@fluidframework/runtime-definitions/internal";
 import {
-	defaultMinVersionForCollab,
-	isValidMinVersionForCollab,
-} from "@fluidframework/runtime-utils/internal";
-import {
-	GCDataBuilder,
-	RequestParser,
-	RuntimeHeaders,
-	TelemetryContext,
 	addBlobToSummary,
 	addSummarizeResultToSummary,
 	calculateStats,
 	create404Response,
+	defaultMinVersionForCollab,
 	exceptionToResponse,
+	GCDataBuilder,
+	isValidMinVersionForCollab,
+	RequestParser,
+	RuntimeHeaders,
+	semanticVersionToMinimumVersionForCollab,
 	seqFromTree,
+	TelemetryContext,
 } from "@fluidframework/runtime-utils/internal";
-import { semanticVersionToMinimumVersionForCollab } from "@fluidframework/runtime-utils/internal";
 import type {
 	IEventSampler,
 	IFluidErrorBase,
@@ -257,56 +256,54 @@ import {
 } from "./runtimeLayerCompatState.js";
 import { SignalTelemetryManager } from "./signalTelemetryProcessing.js";
 // These types are imported as types here because they are present in summaryDelayLoadedModule, which is loaded dynamically when required.
-import type {
-	IDocumentSchemaChangeMessageIncoming,
-	IDocumentSchemaCurrent,
-	Summarizer,
-	IDocumentSchemaFeatures,
-	EnqueueSummarizeResult,
-	ISerializedElection,
-	ISummarizeResults,
-} from "./summary/index.js";
 import {
+	aliasBlobName,
+	chunksBlobName,
+	createRootSummarizerNodeWithGC,
+	DefaultSummaryConfiguration,
 	DocumentsSchemaController,
+	electedSummarizerBlobName,
+	type EnqueueSummarizeResult,
+	extractSummaryMetadataMessage,
+	formCreateSummarizerFn,
 	type IBaseSummarizeResult,
 	type IConnectableRuntime,
 	type IContainerRuntimeMetadata,
 	type ICreateContainerMetadata,
+	idCompressorBlobName,
+	type IdCompressorMode,
+	type IDocumentSchemaChangeMessageIncoming,
+	type IDocumentSchemaCurrent,
+	type IDocumentSchemaFeatures,
 	type IEnqueueSummarizeOptions,
-	type IGenerateSummaryTreeResult,
 	type IGeneratedSummaryStats,
+	type IGenerateSummaryTreeResult,
 	type IOnDemandSummarizeOptions,
 	type IRefreshSummaryAckOptions,
 	type IRootSummarizerNodeWithGC,
+	type ISerializedElection,
+	isSummariesDisabled,
 	type ISubmitSummaryOptions,
+	type ISummarizeResults,
 	type ISummarizerInternalsProvider,
 	type ISummarizerRuntime,
+	type ISummaryConfiguration,
 	type ISummaryMetadataMessage,
-	type IdCompressorMode,
+	metadataBlobName,
+	OrderedClientCollection,
 	OrderedClientElection,
-	RetriableSummaryError,
-	type SubmitSummaryResult,
-	aliasBlobName,
-	chunksBlobName,
 	recentBatchInfoBlobName,
-	createRootSummarizerNodeWithGC,
-	electedSummarizerBlobName,
-	extractSummaryMetadataMessage,
-	idCompressorBlobName,
-	metadataBlobName,
+	RetriableSummaryError,
 	rootHasIsolatedChannels,
-	wrapSummaryInChannelsTree,
-	formCreateSummarizerFn,
-	summarizerRequestUrl,
-	SummaryManager,
+	type SubmitSummaryResult,
+	type Summarizer,
 	SummarizerClientElection,
+	summarizerClientType,
+	summarizerRequestUrl,
 	SummaryCollection,
-	OrderedClientCollection,
+	SummaryManager,
 	validateSummaryHeuristicConfiguration,
-	type ISummaryConfiguration,
-	DefaultSummaryConfiguration,
-	isSummariesDisabled,
-	summarizerClientType,
+	wrapSummaryInChannelsTree,
 } from "./summary/index.js";
 import { Throttler, formExponentialFn } from "./throttler.js";
 
@@ -682,7 +679,7 @@ export const makeLegacySendBatchFn =
 function lastMessageFromMetadata(
 	metadata: IContainerRuntimeMetadata | undefined,
 ): ISummaryMetadataMessage | undefined {
-	return metadata?.documentSchema?.runtime?.explicitSchemaControl
+	return metadata?.documentSchema?.runtime?.explicitSchemaControl === true
 		? metadata?.lastMessage
 		: metadata?.message;
 }
@@ -973,7 +970,7 @@ export class ContainerRuntime
 
 		const tryFetchBlob = async <T>(blobName: string): Promise<T | undefined> => {
 			const blobId = context.baseSnapshot?.blobs[blobName];
-			if (context.baseSnapshot && blobId) {
+			if (context.baseSnapshot !== undefined && blobId !== undefined) {
 				// IContainerContext storage api return type still has undefined in 0.39 package version.
 				// So once we release 0.40 container-defn package we can remove this check.
 				assert(
@@ -1013,7 +1010,7 @@ export class ContainerRuntime
 		const runtimeSequenceNumber = messageAtLastSummary?.sequenceNumber;
 		const protocolSequenceNumber = context.deltaManager.initialSequenceNumber;
 		// When we load with pending state, we reuse an old snapshot so we don't expect these numbers to match
-		if (!context.pendingLocalState && runtimeSequenceNumber !== undefined) {
+		if (context.pendingLocalState === undefined && runtimeSequenceNumber !== undefined) {
 			// Unless bypass is explicitly set, then take action when sequence numbers mismatch.
 			// eslint-disable-next-line unicorn/no-lonely-if -- Separate if statements make flow easier to parse
 			if (
@@ -1463,7 +1460,7 @@ export class ContainerRuntime
 	 */
 	private readonly loadedFromVersionId: string | undefined;
 
-	private readonly isSnapshotInstanceOfISnapshot: boolean | undefined;
+	private readonly isSnapshotInstanceOfISnapshot: boolean;
 
 	/**
 	 * The summary context of the last acked summary. The properties from this as used when uploading a summary.
@@ -1559,6 +1556,8 @@ export class ContainerRuntime
 		// In old loaders without dispose functionality, closeFn is equivalent but will also switch container to readonly mode
 		this.disposeFn = disposeFn ?? closeFn;
 
+		this.isSnapshotInstanceOfISnapshot = snapshotWithContents !== undefined;
+
 		// Validate that the Loader is compatible with this Runtime.
 		const maybeLoaderCompatDetailsForRuntime = context as FluidObject<ILayerCompatDetails>;
 		validateLoaderCompatibility(
@@ -1607,7 +1606,7 @@ export class ContainerRuntime
 			submitSignalFn(envelope, targetClientId);
 		};
 		this.submitSignalFn = (envelope: UnsequencedSignalEnvelope, targetClientId?: string) => {
-			if (envelope.address?.startsWith("/")) {
+			if (envelope.address?.startsWith("/") === true) {
 				throw new Error("General path based addressing is not implemented");
 			}
 			sequenceAndSubmitSignal(envelope, targetClientId);
@@ -1874,10 +1873,6 @@ export class ContainerRuntime
 
 		const parentContext = wrapContext(this);
 
-		if (snapshotWithContents !== undefined) {
-			this.isSnapshotInstanceOfISnapshot = true;
-		}
-
 		// Due to a mismatch between different layers in terms of
 		// what is the interface of passing signals, we need the
 		// downstream stores to wrap the signal.
@@ -2548,7 +2543,7 @@ export class ContainerRuntime
 		);
 
 		// Is document schema explicit control on?
-		const explicitSchemaControl = documentSchema?.runtime.explicitSchemaControl;
+		const explicitSchemaControl = documentSchema?.runtime.explicitSchemaControl === true;
 
 		const metadata: IContainerRuntimeMetadata = {
 			...this.createContainerMetadata,
@@ -2559,7 +2554,7 @@ export class ContainerRuntime
 			telemetryDocumentId: this.telemetryDocumentId,
 			// If explicit document schema control is not on, use legacy way to supply last message (using 'message' property).
 			// Otherwise use new 'lastMessage' property, but also put content into the 'message' property that cases old
-			// runtimes (that preceed document schema control capabilities) to close container on load due to mismatch in
+			// runtimes (that preceded document schema control capabilities) to close container on load due to mismatch in
 			// last message's sequence number.
 			// See also lastMessageFromMetadata()
 			message: explicitSchemaControl
@@ -2960,7 +2955,7 @@ export class ContainerRuntime
 			if ("batchStart" in inboundResult) {
 				const batchStart: BatchStartInfo = inboundResult.batchStart;
 				const result = this.duplicateBatchDetector?.processInboundBatch(batchStart);
-				if (result?.duplicate) {
+				if (result?.duplicate === true) {
 					const error = new DataCorruptionError(
 						"Duplicate batch - The same batch was sequenced twice",
 						{ batchId: batchStart.batchId },
@@ -3430,7 +3425,7 @@ export class ContainerRuntime
 		let checkpoint: IBatchCheckpoint | undefined;
 		// eslint-disable-next-line import/no-deprecated
 		let stageControls: StageControlsExperimental | undefined;
-		if (this.mc.config.getBoolean("Fluid.ContainerRuntime.EnableRollback")) {
+		if (this.mc.config.getBoolean("Fluid.ContainerRuntime.EnableRollback") === true) {
 			if (!this.batchRunner.running && !this.inStagingMode) {
 				stageControls = this.enterStagingMode();
 			}
@@ -3640,7 +3635,7 @@ export class ContainerRuntime
 	private shouldSendOps(): boolean {
 		// Note that the real (non-proxy) delta manager is needed here to get the readonly info. This is because
 		// container runtime's ability to send ops depend on the actual readonly state of the delta manager.
-		return this.connected && !this.innerDeltaManager.readOnlyInfo.readonly;
+		return this.connected && this.innerDeltaManager.readOnlyInfo.readonly !== true;
 	}
 
 	private readonly _quorum: IQuorumClients;
@@ -4299,15 +4294,16 @@ export class ContainerRuntime
 			// Counting dataStores and handles
 			// Because handles are unchanged dataStores in the current logic,
 			// summarized dataStore count is total dataStore count minus handle count
-			const dataStoreTree = summaryTree.tree[channelsTreeName];
+			const dataStoreTree: SummaryObject | undefined = summaryTree.tree[channelsTreeName];
 
-			assert(dataStoreTree.type === SummaryType.Tree, 0x1fc /* "summary is not a tree" */);
+			assert(dataStoreTree?.type === SummaryType.Tree, 0x1fc /* "summary is not a tree" */);
 			const handleCount = Object.values(dataStoreTree.tree).filter(
 				(value) => value.type === SummaryType.Handle,
 			).length;
-			const gcSummaryTreeStats = summaryTree.tree[gcTreeKey]
-				? calculateStats(summaryTree.tree[gcTreeKey])
-				: undefined;
+			const gcSummaryTreeStats =
+				summaryTree.tree[gcTreeKey] === undefined
+					? undefined
+					: calculateStats(summaryTree.tree[gcTreeKey]);
 
 			const summaryStats: IGeneratedSummaryStats = {
 				dataStoreCount: this.channelCollection.size,
@@ -4358,7 +4354,7 @@ export class ContainerRuntime
 				// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 				head: parent!,
 				message,
-				parents: parent ? [parent] : [],
+				parents: parent === undefined ? [] : [parent],
 			};
 			const uploadData = {
 				...generateSummaryData,
@@ -4444,7 +4440,7 @@ export class ContainerRuntime
 		// the summarizer.
 		if (
 			finalAttempt &&
-			this.mc.config.getBoolean("Fluid.Summarizer.SkipFailingIncorrectSummary")
+			this.mc.config.getBoolean("Fluid.Summarizer.SkipFailingIncorrectSummary") === true
 		) {
 			const error = DataProcessingError.create(
 				"Pending ops during summarization",
@@ -4599,7 +4595,7 @@ export class ContainerRuntime
 
 		// Note that the real (non-proxy) delta manager is used here to get the readonly info. This is because
 		// container runtime's ability to submit ops depend on the actual readonly state of the delta manager.
-		if (this.innerDeltaManager.readOnlyInfo.readonly) {
+		if (this.innerDeltaManager.readOnlyInfo.readonly === true) {
 			this.mc.logger.sendTelemetryEvent({
 				eventName: "SubmitOpInReadonly",
 				connected: this.connected,
@@ -5031,10 +5027,7 @@ export class ContainerRuntime
 						scenarioName,
 						FetchSource.noCache,
 					);
-					assert(
-						!!versions && !!versions[0],
-						0x137 /* "Failed to get version from storage" */,
-					);
+					assert(versions[0] !== undefined, 0x137 /* "Failed to get version from storage" */);
 					snapshotTree = await this.storage.getSnapshotTree(versions[0]);
 					assert(!!snapshotTree, 0x138 /* "Failed to get snapshot from storage" */);
 					props.snapshotVersion = versions[0].id;
@@ -5070,7 +5063,7 @@ export class ContainerRuntime
 		}
 
 		this.verifyNotClosed();
-		if (props?.notifyImminentClosure) {
+		if (props?.notifyImminentClosure === true) {
 			throw new UsageError("notifyImminentClosure is no longer supported in ContainerRuntime");
 		}
 

package/src/dataStoreContext.ts

@@ -282,7 +282,7 @@ export abstract class FluidDataStoreContext
 
 	private isStagingMode: boolean = false;
 	public isReadOnly = (): boolean =>
-		(this.isStagingMode && this.channel?.policies?.readonlyInStagingMode !== false) ||
+		(this.isStagingMode && this.channel?.policies?.readonlyInStagingMode === true) ||
 		this.parentContext.isReadOnly();
 
 	public get connected(): boolean {
@@ -1231,7 +1231,7 @@ export class RemoteFluidDataStoreContext extends FluidDataStoreContext {
 	private snapshotFetchRequired: boolean | undefined;
 	private readonly runtime: IContainerRuntimeBase;
 	private readonly blobContents: Map<string, ArrayBuffer> | undefined;
-	private readonly isSnapshotInISnapshotFormat: boolean | undefined;
+	private readonly isSnapshotInISnapshotFormat: boolean;
 
 	constructor(props: IRemoteFluidDataStoreContextProps) {
 		super(props, true /* existing */, false /* isLocalDataStore */, () => {
@@ -1290,7 +1290,7 @@ export class RemoteFluidDataStoreContext extends FluidDataStoreContext {
 				this.blobContents,
 			);
 		}
-		if (this.snapshotFetchRequired) {
+		if (this.snapshotFetchRequired === true) {
 			assert(
 				this.loadingGroupId !== undefined,
 				0x8f5 /* groupId should be present to fetch snapshot */,

package/src/deltaScheduler.ts

@@ -69,7 +69,7 @@ export class DeltaScheduler {
 	}
 
 	private readonly batchBegin = (message: ISequencedDocumentMessage): void => {
-		if (!this.processingStartTime) {
+		if (this.processingStartTime === undefined) {
 			this.processingStartTime = performanceNow();
 		}
 		if (this.schedulingLog === undefined && this.schedulingCount % 500 === 0) {

package/src/gc/garbageCollection.ts

@@ -5,6 +5,7 @@
 
 import type { IRequest } from "@fluidframework/core-interfaces";
 import { assert, LazyPromise, Timer } from "@fluidframework/core-utils/internal";
+import type { ISnapshotTree } from "@fluidframework/driver-definitions/internal";
 import {
 	type IGarbageCollectionDetailsBase,
 	type ISummarizeResult,
@@ -190,7 +191,7 @@ export class GarbageCollector implements IGarbageCollector {
 			);
 			let timeoutMs = this.configs.sessionExpiryTimeoutMs;
 
-			if (pendingSessionExpiryTimerStarted) {
+			if (pendingSessionExpiryTimerStarted !== undefined) {
 				// NOTE: This assumes the client clock hasn't been tampered with since the original session
 				const timeLapsedSincePendingTimer = Date.now() - pendingSessionExpiryTimerStarted;
 				timeoutMs -= timeLapsedSincePendingTimer;
@@ -232,7 +233,7 @@ export class GarbageCollector implements IGarbageCollector {
 
 				try {
 					// For newer documents, GC data should be present in the GC tree in the root of the snapshot.
-					const gcSnapshotTree = baseSnapshot.trees[gcTreeKey];
+					const gcSnapshotTree: ISnapshotTree | undefined = baseSnapshot.trees[gcTreeKey];
 					if (gcSnapshotTree === undefined) {
 						// back-compat - Older documents get their gc data reset for simplicity as there are few of them
 						// incremental gc summary will not work with older gc data as well
@@ -845,6 +846,8 @@ export class GarbageCollector implements IGarbageCollector {
 			if (gcDataSuperSet.gcNodes[sourceNodeId] === undefined) {
 				gcDataSuperSet.gcNodes[sourceNodeId] = outboundRoutes;
 			} else {
+				// TODO: Fix this violation and remove the disable
+				// eslint-disable-next-line @fluid-internal/fluid/no-unchecked-record-access
 				gcDataSuperSet.gcNodes[sourceNodeId].push(...outboundRoutes);
 			}
 			newOutboundRoutesSinceLastRun.push(...outboundRoutes);

package/src/gc/gcConfigs.ts

@@ -178,7 +178,7 @@ export function computeTombstoneTimeout(
 	sessionExpiryTimeoutMs: number | undefined,
 ): number | undefined {
 	const bufferMs = oneDayMs;
-	return (
-		sessionExpiryTimeoutMs && sessionExpiryTimeoutMs + maxSnapshotCacheExpiryMs + bufferMs
-	);
+	return sessionExpiryTimeoutMs === undefined
+		? undefined
+		: sessionExpiryTimeoutMs + maxSnapshotCacheExpiryMs + bufferMs;
 }

package/src/gc/gcReferenceGraphAlgorithm.ts

@@ -31,7 +31,7 @@ export function runGarbageCollection(
 
 		// Get the node for the referenced id and add its outbound routes to referencedIds since they are
 		// also referenced.
-		const routes = referenceGraph[id];
+		const routes: string[] | undefined = referenceGraph[id];
 		if (routes !== undefined) {
 			referencedIds.push(...routes);
 		}

package/src/gc/gcTelemetry.ts

@@ -210,10 +210,9 @@ export class GCTelemetryTracker {
 					return this.configs.tombstoneTimeoutMs;
 				}
 				case UnreferencedState.SweepReady: {
-					return (
-						this.configs.tombstoneTimeoutMs &&
-						this.configs.tombstoneTimeoutMs + this.configs.sweepGracePeriodMs
-					);
+					return this.configs.tombstoneTimeoutMs === undefined
+						? undefined
+						: this.configs.tombstoneTimeoutMs + this.configs.sweepGracePeriodMs;
 				}
 				default: {
 					return undefined;
@@ -327,7 +326,7 @@ export class GCTelemetryTracker {
 		if (
 			usageType === "Loaded" &&
 			this.configs.throwOnTombstoneLoad &&
-			!headers?.allowTombstone
+			headers?.allowTombstone !== true
 		) {
 			this.mc.logger.sendErrorEvent(event);
 		} else {

package/src/inboundBatchAggregator.ts

@@ -190,7 +190,7 @@ export class InboundBatchAggregator {
 		//    - here, when queue was empty and start of batch showed up (batchMetadata === true below).
 		// 2. resumed when batch end comes in (batchMetadata === false below)
 
-		if (batchMetadata) {
+		if (batchMetadata === true) {
 			assert(
 				this.currentBatchClientId === undefined,
 				0x29e /* "there can't be active batch" */,

package/src/metadata.ts

@@ -52,7 +52,8 @@ export interface IBlobMetadata {
 
 export const isBlobMetadata = (metadata: unknown): metadata is IBlobMetadata => {
 	return (
-		!!metadata &&
+		typeof metadata === "object" &&
+		metadata !== null &&
 		typeof (metadata as IBlobMetadata).blobId === "string" &&
 		typeof (metadata as IBlobMetadata).localId === "string"
 	);

package/src/opLifecycle/opGroupingManager.ts

@@ -134,9 +134,9 @@ export class OpGroupingManager {
 		// We expect this will be on the first message, if present at all.
 		let groupedBatchId;
 		for (const message of batch.messages) {
-			if (message.metadata) {
+			if (message.metadata !== undefined) {
 				const { batch: _batch, batchId, ...rest } = message.metadata;
-				if (batchId) {
+				if (batchId !== undefined) {
 					groupedBatchId = batchId;
 				}
 				assert(Object.keys(rest).length === 0, 0x5dd /* cannot group ops with metadata */);

package/src/packageVersion.ts

@@ -6,4 +6,4 @@
  */
 
 export const pkgName = "@fluidframework/container-runtime";
-export const pkgVersion = "2.61.0";
+export const pkgVersion = "2.62.0";