@fluidframework/container-runtime 2.20.0 → 2.22.0

package/src/dataStore.ts

@@ -82,18 +82,20 @@ class DataStore implements IDataStore {
 		switch (this.aliasState) {
 			// If we're already aliasing, check if it's for the same value and return
 			// the stored promise, otherwise return 'AlreadyAliased'
-			case AliasState.Aliasing:
+			case AliasState.Aliasing: {
 				assert(
 					this.aliasResult !== undefined,
 					0x316 /* There should be a cached promise of in-progress aliasing */,
 				);
 				await this.aliasResult;
 				return this.alias === alias ? "Success" : "AlreadyAliased";
+			}
 
 			// If this datastore is already aliased, return true only if this
 			// is a repeated call for the same alias
-			case AliasState.Aliased:
+			case AliasState.Aliased: {
 				return this.alias === alias ? "Success" : "AlreadyAliased";
+			}
 
 			case AliasState.None: {
 				const existingAlias = this.pendingAliases.get(alias);
@@ -108,8 +110,9 @@ class DataStore implements IDataStore {
 				break;
 			}
 
-			default:
+			default: {
 				unreachableCase(this.aliasState);
+			}
 		}
 
 		this.aliasState = AliasState.Aliasing;

package/src/dataStoreContext.ts

@@ -300,7 +300,8 @@ export abstract class FluidDataStoreContext
 			return aliasedDataStores.has(this.id);
 		}
 
-		return (await this.getInitialSnapshotDetails()).isRootDataStore;
+		const snapshotDetails = await this.getInitialSnapshotDetails();
+		return snapshotDetails.isRootDataStore;
 	}
 
 	/**
@@ -383,15 +384,9 @@ export abstract class FluidDataStoreContext
 				? this.parentContext.attachState
 				: AttachState.Detached;
 
-		const thisSummarizeInternal = async (
-			fullTree: boolean,
-			trackState: boolean,
-			telemetryContext?: ITelemetryContext,
-		): Promise<ISummarizeInternalResult> =>
-			this.summarizeInternal(fullTree, trackState, telemetryContext);
-
 		this.summarizerNode = props.createSummarizerNodeFn(
-			thisSummarizeInternal,
+			async (fullTree, trackState, telemetryContext) =>
+				this.summarizeInternal(fullTree, trackState, telemetryContext),
 			async (fullGC?: boolean) => this.getGCDataInternal(fullGC),
 		);
 
@@ -619,9 +614,7 @@ export abstract class FluidDataStoreContext
 		channel: IFluidDataStoreChannel,
 		messageCollection: IRuntimeMessageCollection,
 	): void {
-		if (channel.processMessages !== undefined) {
-			channel.processMessages(messageCollection);
-		} else {
+		if (channel.processMessages === undefined) {
 			const { envelope, messagesContent, local } = messageCollection;
 			for (const { contents, localOpMetadata, clientSequenceNumber } of messagesContent) {
 				channel.process(
@@ -630,6 +623,8 @@ export abstract class FluidDataStoreContext
 					localOpMetadata,
 				);
 			}
+		} else {
+			channel.processMessages(messageCollection);
 		}
 	}
 
@@ -657,7 +652,7 @@ export abstract class FluidDataStoreContext
 			);
 			this.pendingMessagesState.messageCollections.push({
 				...messageCollection,
-				messagesContent: Array.from(messagesContent),
+				messagesContent: [...messagesContent],
 			});
 			this.pendingMessagesState.pendingCount += messagesContent.length;
 			this.thresholdOpsCounter.sendIfMultiple(
@@ -1149,6 +1144,7 @@ export class RemoteFluidDataStoreContext extends FluidDataStoreContext {
 	 */
 	public setAttachState(attachState: AttachState.Attaching | AttachState.Attached): void {}
 
+	// eslint-disable-next-line unicorn/consistent-function-scoping -- Property is defined once; no need to extract inner lambda
 	private readonly initialSnapshotDetailsP = new LazyPromise<ISnapshotDetails>(async () => {
 		// Sequence number of the snapshot.
 		let sequenceNumber: number | undefined;
@@ -1281,7 +1277,7 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 
 	public setAttachState(attachState: AttachState.Attaching | AttachState.Attached): void {
 		switch (attachState) {
-			case AttachState.Attaching:
+			case AttachState.Attaching: {
 				assert(
 					this.attachState === AttachState.Detached,
 					0x14d /* "Should move from detached to attaching" */,
@@ -1295,7 +1291,8 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 					this.emit("attaching");
 				}
 				break;
-			case AttachState.Attached:
+			}
+			case AttachState.Attached: {
 				// We can get called into here twice, as result of both container and data store being attached, if
 				// those processes overlapped, for example, in a flow like that one:
 				// 1. Container attach started
@@ -1318,8 +1315,10 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 					}
 				}
 				break;
-			default:
+			}
+			default: {
 				unreachableCase(attachState, "unreached");
+			}
 		}
 	}
 
@@ -1364,6 +1363,7 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 		return this.channel.getAttachGCData(telemetryContext);
 	}
 
+	// eslint-disable-next-line unicorn/consistent-function-scoping -- Property is defined once; no need to extract inner lambda
 	private readonly initialSnapshotDetailsP = new LazyPromise<ISnapshotDetails>(async () => {
 		let snapshot = this.snapshotTree;
 		// eslint-disable-next-line import/no-deprecated

package/src/dataStoreContexts.ts

@@ -34,6 +34,7 @@ export class DataStoreContexts
 	 */
 	private readonly deferredContexts = new Map<string, Deferred<FluidDataStoreContext>>();
 
+	// eslint-disable-next-line unicorn/consistent-function-scoping -- Property is defined once; no need to extract inner lambda
 	private readonly disposeOnce = new Lazy<void>(() => {
 		// close/stop all store contexts
 		for (const [fluidDataStoreId, contextD] of this.deferredContexts) {

package/src/deltaScheduler.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { performance, type TypedEventEmitter } from "@fluid-internal/client-utils";
+import { performanceNow, type TypedEventEmitter } from "@fluid-internal/client-utils";
 import { IDeltaManagerFull } from "@fluidframework/container-definitions/internal";
 import { ISequencedDocumentMessage } from "@fluidframework/driver-definitions/internal";
 import type { IContainerRuntimeBaseEvents } from "@fluidframework/runtime-definitions/internal";
@@ -67,7 +67,7 @@ export class DeltaScheduler {
 
 	private readonly batchBegin = (message: ISequencedDocumentMessage): void => {
 		if (!this.processingStartTime) {
-			this.processingStartTime = performance.now();
+			this.processingStartTime = performanceNow();
 		}
 		if (this.schedulingLog === undefined && this.schedulingCount % 500 === 0) {
 			// Every 500th time we are scheduling the inbound queue, we log telemetry for the
@@ -79,7 +79,7 @@ export class DeltaScheduler {
 				numberOfBatchesProcessed: 0,
 				firstSequenceNumber: message.sequenceNumber,
 				lastSequenceNumber: message.sequenceNumber,
-				startTime: performance.now(),
+				startTime: performanceNow(),
 			};
 		}
 	};
@@ -92,7 +92,7 @@ export class DeltaScheduler {
 		}
 
 		if (this.shouldRunScheduler()) {
-			const currentTime = performance.now();
+			const currentTime = performanceNow();
 			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 			const elapsedTime = currentTime - this.processingStartTime!;
 			if (elapsedTime > this.currentAllowedProcessingTimeForTurn) {
@@ -126,7 +126,7 @@ export class DeltaScheduler {
 							processingTime: formatTick(this.schedulingLog.totalProcessingTime),
 							numberOfTurns: this.schedulingLog.numberOfTurns,
 							batchesProcessed: this.schedulingLog.numberOfBatchesProcessed,
-							timeToResume: formatTick(performance.now() - currentTime),
+							timeToResume: formatTick(performanceNow() - currentTime),
 						});
 					}
 					this.deltaManager.inbound.resume();
@@ -141,7 +141,7 @@ export class DeltaScheduler {
 		if (this.schedulingLog) {
 			// Add the time taken for processing the final ops to the total processing time in the
 			// telemetry log object.
-			const currentTime = performance.now();
+			const currentTime = performanceNow();
 			// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 			this.schedulingLog.totalProcessingTime += currentTime - this.processingStartTime!;
 

package/src/gc/garbageCollection.ts

@@ -34,17 +34,22 @@ import { IRefreshSummaryResult } from "../summary/index.js";
 
 import { generateGCConfigs } from "./gcConfigs.js";
 import {
+	// eslint-disable-next-line import/no-deprecated
 	GCNodeType,
 	GarbageCollectionMessage,
 	GarbageCollectionMessageType,
+	// eslint-disable-next-line import/no-deprecated
 	IGCMetadata,
 	IGCResult,
+	// eslint-disable-next-line import/no-deprecated
 	IGCStats,
 	IGarbageCollectionRuntime,
 	IGarbageCollector,
 	IGarbageCollectorConfigs,
 	IGarbageCollectorCreateParams,
+	// eslint-disable-next-line import/no-deprecated
 	IMarkPhaseStats,
+	// eslint-disable-next-line import/no-deprecated
 	ISweepPhaseStats,
 	UnreferencedState,
 	type IGCNodeUpdatedProps,
@@ -305,7 +310,7 @@ export class GarbageCollector implements IGarbageCollector {
 						),
 					);
 				}
-				gcNodes[nodeId] = Array.from(nodeData.outboundRoutes);
+				gcNodes[nodeId] = [...nodeData.outboundRoutes];
 			}
 			this.gcDataFromLastRun = { gcNodes };
 		});
@@ -324,7 +329,7 @@ export class GarbageCollector implements IGarbageCollector {
 
 			const gcNodes: { [id: string]: string[] } = {};
 			for (const [nodeId, nodeData] of Object.entries(baseSnapshotData.gcState.gcNodes)) {
-				gcNodes[nodeId] = Array.from(nodeData.outboundRoutes);
+				gcNodes[nodeId] = [...nodeData.outboundRoutes];
 			}
 			// Run GC on the nodes in the base summary to get the routes used in each node in the container.
 			// This is an optimization for space (vs performance) wherein we don't need to store the used routes of
@@ -347,8 +352,10 @@ export class GarbageCollector implements IGarbageCollector {
 	/**
 	 * API for ensuring the correct auto-recovery mitigations
 	 */
+	// TODO: consider hoisting this to an outer scope as an optimization
+	// eslint-disable-next-line unicorn/consistent-function-scoping
 	private readonly autoRecovery = (() => {
-		// This uses a hidden state machine for forcing fullGC as part of autorecovery,
+		// This uses a hidden state machine for forcing fullGC as part of auto-recovery,
 		// to regenerate the GC data for each node.
 		//
 		// Once fullGC has been requested, we need to wait until GC has run and the summary has been acked before clearing the state.
@@ -410,7 +417,7 @@ export class GarbageCollector implements IGarbageCollector {
 		// Initialize the tombstone state from the snapshot. Also, notify the runtime of tombstone routes.
 		if (baseSnapshotData.tombstones !== undefined) {
 			// Create a copy since we are writing from a source we don't control
-			this.tombstones = Array.from(baseSnapshotData.tombstones);
+			this.tombstones = [...baseSnapshotData.tombstones];
 			this.runtime.updateTombstonedRoutes(this.tombstones);
 		}
 
@@ -435,14 +442,14 @@ export class GarbageCollector implements IGarbageCollector {
 			},
 			async (event) => {
 				// If the GC state hasn't been initialized yet, initialize it and return.
-				if (!initialized) {
-					await this.initializeGCStateFromBaseSnapshotP;
-				} else {
+				if (initialized) {
 					// If the GC state has been initialized, update the tracking of unreferenced nodes as per the current
 					// reference timestamp.
 					for (const [, nodeStateTracker] of this.unreferencedNodesState) {
 						nodeStateTracker.updateTracking(currentReferenceTimestampMs);
 					}
+				} else {
+					await this.initializeGCStateFromBaseSnapshotP;
 				}
 				event.end({
 					details: { initialized, unrefNodeCount: this.unreferencedNodesState.size },
@@ -509,6 +516,7 @@ export class GarbageCollector implements IGarbageCollector {
 			fullGC?: boolean;
 		},
 		telemetryContext?: ITelemetryContext,
+		// eslint-disable-next-line import/no-deprecated
 	): Promise<IGCStats | undefined> {
 		const fullGC =
 			options.fullGC ?? (this.configs.runFullGC === true || this.autoRecovery.useFullGC());
@@ -606,6 +614,7 @@ export class GarbageCollector implements IGarbageCollector {
 		fullGC: boolean,
 		currentReferenceTimestampMs: number,
 		logger: ITelemetryLoggerExt,
+		// eslint-disable-next-line import/no-deprecated
 	): Promise<IGCStats> {
 		// 1. Generate / analyze the runtime's reference graph.
 		// Get the reference graph (gcData) and run GC algorithm to get referenced / unreferenced nodes.
@@ -761,6 +770,7 @@ export class GarbageCollector implements IGarbageCollector {
 			// local state when processing the op.
 			const sweepReadyDSAndBlobs = nodesToDelete.filter((nodeId) => {
 				const nodeType = this.runtime.getNodeType(nodeId);
+				// eslint-disable-next-line import/no-deprecated
 				return nodeType === GCNodeType.DataStore || nodeType === GCNodeType.Blob;
 			});
 			const contents: GarbageCollectionMessage = {
@@ -838,16 +848,14 @@ export class GarbageCollector implements IGarbageCollector {
 		 */
 		const gcDataSuperSet = concatGarbageCollectionData(previousGCData, currentGCData);
 		const newOutboundRoutesSinceLastRun: string[] = [];
-		this.newReferencesSinceLastRun.forEach(
-			(outboundRoutes: string[], sourceNodeId: string) => {
-				if (gcDataSuperSet.gcNodes[sourceNodeId] === undefined) {
-					gcDataSuperSet.gcNodes[sourceNodeId] = outboundRoutes;
-				} else {
-					gcDataSuperSet.gcNodes[sourceNodeId].push(...outboundRoutes);
-				}
-				newOutboundRoutesSinceLastRun.push(...outboundRoutes);
-			},
-		);
+		for (const [sourceNodeId, outboundRoutes] of this.newReferencesSinceLastRun) {
+			if (gcDataSuperSet.gcNodes[sourceNodeId] === undefined) {
+				gcDataSuperSet.gcNodes[sourceNodeId] = outboundRoutes;
+			} else {
+				gcDataSuperSet.gcNodes[sourceNodeId].push(...outboundRoutes);
+			}
+			newOutboundRoutesSinceLastRun.push(...outboundRoutes);
+		}
 
 		/**
 		 * Run GC on the above reference graph starting with root and all new outbound routes. This will generate a
@@ -894,6 +902,7 @@ export class GarbageCollector implements IGarbageCollector {
 		);
 	}
 
+	// eslint-disable-next-line import/no-deprecated
 	public getMetadata(): IGCMetadata {
 		return {
 			/**
@@ -950,11 +959,12 @@ export class GarbageCollector implements IGarbageCollector {
 					this.autoRecovery.requestFullGCOnNextRun();
 					break;
 				}
-				default:
+				default: {
 					throw DataProcessingError.create(
 						`Garbage collection message of unknown type ${gcMessageType}`,
 						"processMessage",
 					);
+				}
 			}
 		}
 	}
@@ -975,7 +985,7 @@ export class GarbageCollector implements IGarbageCollector {
 		// The ids in the sweep-ready nodes do not contain DDS node ids. This is an optimization to reduce the size
 		// of the GC op. Since GC applies to data store only, all its DDSes are deleted along with it. So, get the
 		// DDS nodes ID from the unreferenced nodes state.
-		const allSweepReadyNodeIds = Array.from(sweepReadyNodeIds);
+		const allSweepReadyNodeIds = [...sweepReadyNodeIds];
 		for (const [id] of this.unreferencedNodesState) {
 			// Ignore data store nodes since they would already be in the list.
 			const pathParts = id.split("/");
@@ -1024,7 +1034,7 @@ export class GarbageCollector implements IGarbageCollector {
 		// trackedId will be either DataStore or Blob ID (not sub-DataStore ID, since some of those are unrecognized by GC)
 		const trackedId = node.path;
 		const isTombstoned = this.tombstones.includes(trackedId);
-		const fullPath = request !== undefined ? urlToGCNodePath(request.url) : trackedId;
+		const fullPath = request === undefined ? trackedId : urlToGCNodePath(request.url);
 
 		// This will log if appropriate
 		this.telemetryTracker.nodeUsed(trackedId, {
@@ -1055,6 +1065,7 @@ export class GarbageCollector implements IGarbageCollector {
 		// Unless this is a Loaded event for a Blob or DataStore, we're done after telemetry tracking
 		const loadedBlobOrDataStore =
 			reason === "Loaded" &&
+			// eslint-disable-next-line import/no-deprecated
 			(nodeType === GCNodeType.Blob || nodeType === GCNodeType.DataStore);
 		if (!loadedBlobOrDataStore) {
 			return;
@@ -1182,7 +1193,9 @@ export class GarbageCollector implements IGarbageCollector {
 	 * @param gcResult - The result of the current GC run.
 	 * @returns the stats of the mark phase run.
 	 */
+	// eslint-disable-next-line import/no-deprecated
 	private getMarkPhaseStats(gcResult: IGCResult): IMarkPhaseStats {
+		// eslint-disable-next-line import/no-deprecated
 		const markPhaseStats: IMarkPhaseStats = {
 			nodeCount: 0,
 			dataStoreCount: 0,
@@ -1209,6 +1222,7 @@ export class GarbageCollector implements IGarbageCollector {
 				markPhaseStats.unrefNodeCount++;
 			}
 
+			// eslint-disable-next-line import/no-deprecated
 			if (this.runtime.getNodeType(nodeId) === GCNodeType.DataStore) {
 				markPhaseStats.dataStoreCount++;
 				if (stateUpdated) {
@@ -1218,6 +1232,7 @@ export class GarbageCollector implements IGarbageCollector {
 					markPhaseStats.unrefDataStoreCount++;
 				}
 			}
+			// eslint-disable-next-line import/no-deprecated
 			if (this.runtime.getNodeType(nodeId) === GCNodeType.Blob) {
 				markPhaseStats.attachmentBlobCount++;
 				if (stateUpdated) {
@@ -1251,10 +1266,13 @@ export class GarbageCollector implements IGarbageCollector {
 	private getSweepPhaseStats(
 		deletedNodes: Set<string>,
 		sweepReadyNodes: Set<string>,
+		// eslint-disable-next-line import/no-deprecated
 		markPhaseStats: IMarkPhaseStats,
+		// eslint-disable-next-line import/no-deprecated
 	): ISweepPhaseStats {
 		// Initialize the life time node counts to the mark phase node counts. If sweep is not enabled,
 		// these will be the life time node count for this container.
+		// eslint-disable-next-line import/no-deprecated
 		const sweepPhaseStats: ISweepPhaseStats = {
 			lifetimeNodeCount: markPhaseStats.nodeCount,
 			lifetimeDataStoreCount: markPhaseStats.dataStoreCount,
@@ -1266,25 +1284,32 @@ export class GarbageCollector implements IGarbageCollector {
 
 		// The runtime can't reliably identify the type of deleted nodes. So, get the type here. This should
 		// be good enough because the only types that participate in GC today are data stores, DDSes and blobs.
+		// eslint-disable-next-line import/no-deprecated, unicorn/consistent-function-scoping
 		const getDeletedNodeType = (nodeId: string): GCNodeType => {
 			const pathParts = nodeId.split("/");
 			if (pathParts[1] === blobManagerBasePath) {
+				// eslint-disable-next-line import/no-deprecated
 				return GCNodeType.Blob;
 			}
 			if (pathParts.length === 2) {
+				// eslint-disable-next-line import/no-deprecated
 				return GCNodeType.DataStore;
 			}
 			if (pathParts.length === 3) {
+				// eslint-disable-next-line import/no-deprecated
 				return GCNodeType.SubDataStore;
 			}
+			// eslint-disable-next-line import/no-deprecated
 			return GCNodeType.Other;
 		};
 
 		for (const nodeId of deletedNodes) {
 			sweepPhaseStats.deletedNodeCount++;
 			const nodeType = getDeletedNodeType(nodeId);
+			// eslint-disable-next-line import/no-deprecated
 			if (nodeType === GCNodeType.DataStore) {
 				sweepPhaseStats.deletedDataStoreCount++;
+				// eslint-disable-next-line import/no-deprecated
 			} else if (nodeType === GCNodeType.Blob) {
 				sweepPhaseStats.deletedAttachmentBlobCount++;
 			}
@@ -1305,8 +1330,10 @@ export class GarbageCollector implements IGarbageCollector {
 		for (const nodeId of sweepReadyNodes) {
 			sweepPhaseStats.deletedNodeCount++;
 			const nodeType = this.runtime.getNodeType(nodeId);
+			// eslint-disable-next-line import/no-deprecated
 			if (nodeType === GCNodeType.DataStore) {
 				sweepPhaseStats.deletedDataStoreCount++;
+				// eslint-disable-next-line import/no-deprecated
 			} else if (nodeType === GCNodeType.Blob) {
 				sweepPhaseStats.deletedAttachmentBlobCount++;
 			}

package/src/gc/gcConfigs.ts

@@ -9,10 +9,13 @@ import {
 	validatePrecondition,
 } from "@fluidframework/telemetry-utils/internal";
 
+// eslint-disable-next-line import/no-deprecated
 import { IContainerRuntimeMetadata } from "../summary/index.js";
 
 import {
+	// eslint-disable-next-line import/no-deprecated
 	GCFeatureMatrix,
+	// eslint-disable-next-line import/no-deprecated
 	GCVersion,
 	IGCMetadata_Deprecated,
 	IGCRuntimeOptions,
@@ -42,6 +45,7 @@ export function generateGCConfigs(
 	mc: MonitoringContext,
 	createParams: {
 		gcOptions: IGCRuntimeOptions;
+		// eslint-disable-next-line import/no-deprecated
 		metadata: IContainerRuntimeMetadata | undefined;
 		existing: boolean;
 		isSummarizerClient: boolean;
@@ -50,7 +54,9 @@ export function generateGCConfigs(
 	let gcAllowed: boolean = true;
 	let sessionExpiryTimeoutMs: number | undefined;
 	let tombstoneTimeoutMs: number | undefined;
+	// eslint-disable-next-line import/no-deprecated
 	let persistedGcFeatureMatrix: GCFeatureMatrix | undefined;
+	// eslint-disable-next-line import/no-deprecated
 	let gcVersionInBaseSnapshot: GCVersion | undefined;
 
 	/**
@@ -98,7 +104,9 @@ export function generateGCConfigs(
 	// Note that if no generation option is provided, Sweep is allowed for any document.
 	const sweepAllowed = shouldAllowGcSweep(
 		persistedGcFeatureMatrix ?? {} /* featureMatrix */,
-		createParams.gcOptions[gcGenerationOptionName] /* currentGeneration */,
+		createParams.gcOptions[gcGenerationOptionName] as
+			| number
+			| undefined /* currentGeneration */,
 	);
 
 	/**

package/src/gc/gcDefinitions.ts

@@ -21,7 +21,9 @@ import {
 import { RuntimeHeaderData } from "../containerRuntime.js";
 import { ContainerRuntimeGCMessage } from "../messageTypes.js";
 import {
+	// eslint-disable-next-line import/no-deprecated
 	IContainerRuntimeMetadata,
+	// eslint-disable-next-line import/no-deprecated
 	ICreateContainerMetadata,
 	IRefreshSummaryResult,
 } from "../summary/index.js";
@@ -29,6 +31,7 @@ import {
 /**
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export type GCVersion = number;
 
@@ -91,6 +94,7 @@ export const defaultSweepGracePeriodMs = 1 * oneDayMs; // 1 day
  * @see IGCMetadata.gcFeatureMatrix and @see gcGenerationOptionName
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export type GCFeatureMatrix =
 	| {
@@ -131,6 +135,7 @@ export interface IGCMetadata_Deprecated {
  *
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface IGCMetadata {
 	/**
@@ -181,6 +186,7 @@ export interface IGCMetadata {
  * The statistics of the system state after a garbage collection mark phase run.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface IMarkPhaseStats {
 	/**
@@ -225,6 +231,7 @@ export interface IMarkPhaseStats {
  * The statistics of the system state after a garbage collection sweep phase run.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface ISweepPhaseStats {
 	/**
@@ -257,6 +264,7 @@ export interface ISweepPhaseStats {
  * The statistics of the system state after a garbage collection run.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface IGCStats extends IMarkPhaseStats, ISweepPhaseStats {}
 
@@ -264,6 +272,7 @@ export interface IGCStats extends IMarkPhaseStats, ISweepPhaseStats {}
  * The types of GC nodes in the GC reference graph.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export const GCNodeType = {
 	// Nodes that are for data stores.
@@ -279,6 +288,7 @@ export const GCNodeType = {
 /**
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export type GCNodeType = (typeof GCNodeType)[keyof typeof GCNodeType];
 
@@ -502,7 +512,9 @@ export interface IGarbageCollectorCreateParams {
 	readonly gcOptions: IGCRuntimeOptions;
 	readonly baseLogger: ITelemetryLoggerExt;
 	readonly existing: boolean;
+	// eslint-disable-next-line import/no-deprecated
 	readonly metadata: IContainerRuntimeMetadata | undefined;
+	// eslint-disable-next-line import/no-deprecated
 	readonly createContainerMetadata: ICreateContainerMetadata;
 	readonly baseSnapshot: ISnapshotTree | undefined;
 	readonly isSummarizerClient: boolean;

package/src/gc/gcHelpers.ts

@@ -15,8 +15,11 @@ import {
 import type { IConfigProvider } from "@fluidframework/telemetry-utils/internal";
 
 import {
+	// eslint-disable-next-line import/no-deprecated
 	GCFeatureMatrix,
+	// eslint-disable-next-line import/no-deprecated
 	GCVersion,
+	// eslint-disable-next-line import/no-deprecated
 	IGCMetadata,
 	gcVersionUpgradeToV4Key,
 	nextGCVersion,
@@ -28,6 +31,7 @@ import {
 	IGarbageCollectionState,
 } from "./gcSummaryDefinitions.js";
 
+// eslint-disable-next-line import/no-deprecated
 export function getGCVersion(metadata?: IGCMetadata): GCVersion {
 	if (!metadata) {
 		// Force to 0/disallowed in prior versions
@@ -63,6 +67,7 @@ export function getGCVersionInEffect(configProvider: IConfigProvider): number {
  * @returns true if GC Sweep should be allowed for this document
  */
 export function shouldAllowGcSweep(
+	// eslint-disable-next-line import/no-deprecated
 	featureMatrix: GCFeatureMatrix,
 	currentGeneration: number | undefined,
 ): boolean {
@@ -105,7 +110,7 @@ export function concatGarbageCollectionStates(
 	const combinedGCNodes: { [id: string]: IGarbageCollectionNodeData } = {};
 	for (const [nodeId, nodeData] of Object.entries(gcState1.gcNodes)) {
 		combinedGCNodes[nodeId] = {
-			outboundRoutes: Array.from(nodeData.outboundRoutes),
+			outboundRoutes: [...nodeData.outboundRoutes],
 			unreferencedTimestampMs: nodeData.unreferencedTimestampMs,
 		};
 	}
@@ -114,7 +119,7 @@ export function concatGarbageCollectionStates(
 		let combineNodeData = combinedGCNodes[nodeId];
 		if (combineNodeData === undefined) {
 			combineNodeData = {
-				outboundRoutes: Array.from(nodeData.outboundRoutes),
+				outboundRoutes: [...nodeData.outboundRoutes],
 				unreferencedTimestampMs: nodeData.unreferencedTimestampMs,
 			};
 		} else {
@@ -149,7 +154,7 @@ export function concatGarbageCollectionStates(
 export function cloneGCData(gcData: IGarbageCollectionData): IGarbageCollectionData {
 	const clonedGCNodes: { [id: string]: string[] } = {};
 	for (const [id, outboundRoutes] of Object.entries(gcData.gcNodes)) {
-		clonedGCNodes[id] = Array.from(outboundRoutes);
+		clonedGCNodes[id] = [...outboundRoutes];
 	}
 	return {
 		gcNodes: clonedGCNodes,
@@ -166,7 +171,7 @@ export function concatGarbageCollectionData(
 	const combinedGCData: IGarbageCollectionData = cloneGCData(gcData1);
 	for (const [id, routes] of Object.entries(gcData2.gcNodes)) {
 		if (combinedGCData.gcNodes[id] === undefined) {
-			combinedGCData.gcNodes[id] = Array.from(routes);
+			combinedGCData.gcNodes[id] = [...routes];
 		} else {
 			const combinedRoutes = [...routes, ...combinedGCData.gcNodes[id]];
 			combinedGCData.gcNodes[id] = [...new Set(combinedRoutes)];

package/src/gc/gcSummaryStateTracker.ts

@@ -16,6 +16,7 @@ import { SummaryTreeBuilder, mergeStats } from "@fluidframework/runtime-utils/in
 
 import { IRefreshSummaryResult } from "../summary/index.js";
 
+// eslint-disable-next-line import/no-deprecated
 import { IGCStats, IGarbageCollectorConfigs } from "./gcDefinitions.js";
 import { generateSortedGCState } from "./gcHelpers.js";
 import {
@@ -98,7 +99,7 @@ export class GCSummaryStateTracker {
 		// Serialize and write deleted nodes, if any. This is done irrespective of whether sweep is enabled or not so
 		// to identify deleted nodes' usage.
 		const serializedDeletedNodes =
-			deletedNodes.size > 0 ? JSON.stringify(Array.from(deletedNodes).sort()) : undefined;
+			deletedNodes.size > 0 ? JSON.stringify([...deletedNodes].sort()) : undefined;
 		// Serialize and write tombstones, if any.
 		const serializedTombstones =
 			tombstones.length > 0 ? JSON.stringify(tombstones.sort()) : undefined;
@@ -230,6 +231,7 @@ export class GCSummaryStateTracker {
 	/**
 	 * Called to update the state from a GC run's stats. Used to update the count of data stores whose state updated.
 	 */
+	// eslint-disable-next-line import/no-deprecated
 	public updateStateFromGCRunStats(stats: IGCStats): void {
 		this.updatedDSCountSinceLastSummary += stats.updatedDataStoreCount;
 	}