@fluidframework/container-runtime 2.12.0 → 2.20.0

package/src/summary/documentSchema.ts

@@ -148,21 +148,21 @@ interface IProperty<T = unknown> {
 }
 
 class TrueOrUndefined implements IProperty<true | undefined> {
-	public and(currentDocSchema?: true, desiredDocSchema?: true) {
+	public and(currentDocSchema?: true, desiredDocSchema?: true): true | undefined {
 		return currentDocSchema === true && desiredDocSchema === true ? true : undefined;
 	}
 
-	public or(currentDocSchema?: true, desiredDocSchema?: true) {
+	public or(currentDocSchema?: true, desiredDocSchema?: true): true | undefined {
 		return currentDocSchema === true || desiredDocSchema === true ? true : undefined;
 	}
 
-	public validate(t: unknown) {
+	public validate(t: unknown): t is true | undefined {
 		return t === undefined || t === true;
 	}
 }
 
 class TrueOrUndefinedMax extends TrueOrUndefined {
-	public and(currentDocSchema?: true, desiredDocSchema?: true) {
+	public and(currentDocSchema?: true, desiredDocSchema?: true): true | undefined {
 		return this.or(currentDocSchema, desiredDocSchema);
 	}
 }
@@ -170,7 +170,7 @@ class TrueOrUndefinedMax extends TrueOrUndefined {
 class MultiChoice implements IProperty<string | undefined> {
 	constructor(private readonly choices: string[]) {}
 
-	public and(currentDocSchema?: string, desiredDocSchema?: string) {
+	public and(currentDocSchema?: string, desiredDocSchema?: string): string | undefined {
 		if (currentDocSchema === undefined || desiredDocSchema === undefined) {
 			return undefined;
 		}
@@ -179,7 +179,7 @@ class MultiChoice implements IProperty<string | undefined> {
 		];
 	}
 
-	public or(currentDocSchema?: string, desiredDocSchema?: string) {
+	public or(currentDocSchema?: string, desiredDocSchema?: string): string | undefined {
 		if (currentDocSchema === undefined) {
 			return desiredDocSchema;
 		}
@@ -191,30 +191,36 @@ class MultiChoice implements IProperty<string | undefined> {
 		];
 	}
 
-	public validate(t: unknown) {
+	public validate(t: unknown): boolean {
 		return t === undefined || (typeof t === "string" && this.choices.includes(t));
 	}
 }
 
 class IdCompressorProperty extends MultiChoice {
 	// document schema always wins!
-	public and(currentDocSchema?: string, desiredDocSchema?: string) {
+	public and(currentDocSchema?: string, desiredDocSchema?: string): string | undefined {
 		return currentDocSchema;
 	}
 }
 
 class CheckVersions implements IProperty<string[] | undefined> {
-	public or(currentDocSchema: string[] = [], desiredDocSchema: string[] = []) {
+	public or(
+		currentDocSchema: string[] = [],
+		desiredDocSchema: string[] = [],
+	): string[] | undefined {
 		const set = new Set<string>([...currentDocSchema, ...desiredDocSchema]);
 		return arrayToProp([...set.values()]);
 	}
 
 	// Once version is there, it stays there forever.
-	public and(currentDocSchema: string[] = [], desiredDocSchema: string[] = []) {
+	public and(
+		currentDocSchema: string[] = [],
+		desiredDocSchema: string[] = [],
+	): string[] | undefined {
 		return this.or(currentDocSchema, desiredDocSchema);
 	}
 
-	public validate(t: unknown) {
+	public validate(t: unknown): boolean {
 		return t === undefined || (Array.isArray(t) && !t.includes(pkgVersion));
 	}
 }
@@ -238,7 +244,7 @@ const documentSchemaSupportedConfigs = {
 function checkRuntimeCompatibility(
 	documentSchema: IDocumentSchema | undefined,
 	schemaName: string,
-) {
+): void {
 	// Back-compat - we can't do anything about legacy documents.
 	// There is no way to validate them, so we are taking a guess that safe deployment processes used by a given app
 	// do not run into compat problems.
@@ -278,6 +284,7 @@ function checkRuntimeCompatibility(
 	}
 
 	if (unknownProperty !== undefined) {
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		const value = documentSchema[unknownProperty];
 		throw DataProcessingError.create(
 			msg,
@@ -286,6 +293,7 @@ function checkRuntimeCompatibility(
 			{
 				codeVersion: currentDocumentVersionSchema,
 				property: unknownProperty,
+				// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 				value,
 				schemaName,
 			},
@@ -354,11 +362,11 @@ function same(
 	return true;
 }
 
-function boolToProp(b: boolean) {
+function boolToProp(b: boolean): true | undefined {
 	return b ? true : undefined;
 }
 
-function arrayToProp(arr: string[]) {
+function arrayToProp(arr: string[]): string[] | undefined {
 	return arr.length === 0 ? undefined : arr;
 }
 
@@ -580,7 +588,11 @@ export class DocumentsSchemaController {
 		}
 	}
 
-	private validateSeqNumber(schemaSeqNumber: number, lastKnowSeqNumber, message: string) {
+	private validateSeqNumber(
+		schemaSeqNumber: number,
+		lastKnowSeqNumber: number,
+		message: string,
+	): void {
 		if (!Number.isInteger(schemaSeqNumber) || !(schemaSeqNumber <= lastKnowSeqNumber)) {
 			throw DataProcessingError.create(
 				"DocSchema: Incorrect sequence number",
@@ -608,7 +620,7 @@ export class DocumentsSchemaController {
 		content: IDocumentSchemaChangeMessage,
 		local: boolean,
 		sequenceNumber: number,
-	) {
+	): boolean {
 		return this.processDocumentSchemaMessages([content], local, sequenceNumber);
 	}
 
@@ -624,7 +636,7 @@ export class DocumentsSchemaController {
 		contents: IDocumentSchemaChangeMessage[],
 		local: boolean,
 		sequenceNumber: number,
-	) {
+	): boolean {
 		for (const content of contents) {
 			this.validateSeqNumber(content.refSeq, this.documentSchema.refSeq, "content.refSeq");
 			this.validateSeqNumber(this.documentSchema.refSeq, sequenceNumber, "refSeq");
@@ -672,7 +684,7 @@ export class DocumentsSchemaController {
 		return true;
 	}
 
-	public onDisconnect() {
+	public onDisconnect(): void {
 		this.sendOp = true;
 	}
 }

package/src/summary/index.ts

@@ -44,12 +44,10 @@ export {
 	ISummarizeHeuristicData,
 	ISummarizer,
 	ISummarizeResults,
-	ISummarizerEvents,
 	ISummarizerInternalsProvider,
 	ISummarizerRuntime,
 	ISummaryCancellationToken,
 	SubmitSummaryResult,
-	SummarizerStopReason,
 	EnqueueSummarizeResult,
 	IAckSummaryResult,
 	IBaseSummarizeResult,
@@ -67,7 +65,6 @@ export {
 	SubmitSummaryFailureData,
 	SummaryStage,
 	IRetriableFailureError,
-	ISummarizeEventProps,
 } from "./summarizerTypes.js";
 export {
 	IAckedSummary,

package/src/summary/orderedClientElection.ts

@@ -31,50 +31,72 @@ export type Immutable<T> = T extends ImmutablePrimitives
 				? ReadonlySet<Immutable<V>>
 				: { readonly [K in keyof T]: Immutable<T[K]> };
 
-/** Minimum information for a client tracked for election consideration. */
+/**
+ * Minimum information for a client tracked for election consideration.
+ */
 export interface ITrackedClient {
 	readonly clientId: string;
 	readonly sequenceNumber: number;
 	readonly client: Immutable<IClient>;
 }
 
-/** Common contract for link nodes within an OrderedClientCollection. */
+/**
+ * Common contract for link nodes within an OrderedClientCollection.
+ */
 export interface ILinkNode {
 	readonly sequenceNumber: number;
 	youngerClient: ILinkedClient | undefined;
 }
 
-/** Placeholder root node within an OrderedClientCollection; does not represent a client. */
+/**
+ * Placeholder root node within an OrderedClientCollection; does not represent a client.
+ */
 export interface IRootLinkNode extends ILinkNode {
 	readonly sequenceNumber: -1;
 	readonly olderClient: undefined;
 }
 
-/** Additional information required to keep track of the client within the doubly-linked list. */
+/**
+ * Additional information required to keep track of the client within the doubly-linked list.
+ */
 export interface ILinkedClient extends ILinkNode, ITrackedClient {
 	olderClient: LinkNode;
 }
 
-/** Any link node within OrderedClientCollection including the placeholder root node. */
+/**
+ * Any link node within OrderedClientCollection including the placeholder root node.
+ */
 export type LinkNode = IRootLinkNode | ILinkedClient;
 
-/** Events raised by an OrderedClientCollection. */
+/**
+ * Events raised by an OrderedClientCollection.
+ */
 export interface IOrderedClientCollectionEvents extends IEvent {
-	/** Event fires when client is being added. */
+	/**
+	 * Event fires when client is being added.
+	 */
 	(
 		event: "addClient" | "removeClient",
 		listener: (client: ILinkedClient, sequenceNumber: number) => void,
 	);
 }
 
-/** Contract for a sorted collection of all clients in the quorum. */
+/**
+ * Contract for a sorted collection of all clients in the quorum.
+ */
 export interface IOrderedClientCollection
 	extends IEventProvider<IOrderedClientCollectionEvents> {
-	/** Count of clients in the collection. */
+	/**
+	 * Count of clients in the collection.
+	 */
 	readonly count: number;
-	/** Pointer to the oldest client in the collection. */
+	/**
+	 * Pointer to the oldest client in the collection.
+	 */
 	readonly oldestClient: ILinkedClient | undefined;
-	/** Returns a sorted array of all the clients in the collection. */
+	/**
+	 * Returns a sorted array of all the clients in the collection.
+	 */
 	getAllClients(): ILinkedClient[];
 }
 
@@ -89,22 +111,28 @@ export class OrderedClientCollection
 	extends TypedEventEmitter<IOrderedClientCollectionEvents>
 	implements IOrderedClientCollection
 {
-	/** Collection of ALL clients currently in the quorum, with client ids as keys. */
+	/**
+	 * Collection of ALL clients currently in the quorum, with client ids as keys.
+	 */
 	private readonly clientMap = new Map<string, ILinkedClient>();
-	/** Placeholder head node of linked list, for simplified null checking. */
+	/**
+	 * Placeholder head node of linked list, for simplified null checking.
+	 */
 	private readonly rootNode: IRootLinkNode = {
 		sequenceNumber: -1,
 		olderClient: undefined,
 		youngerClient: undefined,
 	};
-	/** Pointer to end of linked list, for optimized client adds. */
+	/**
+	 * Pointer to end of linked list, for optimized client adds.
+	 */
 	private _youngestClient: LinkNode = this.rootNode;
 	private readonly logger: ITelemetryLoggerExt;
 
-	public get count() {
+	public get count(): number {
 		return this.clientMap.size;
 	}
-	public get oldestClient() {
+	public get oldestClient(): ILinkedClient | undefined {
 		return this.rootNode.youngerClient;
 	}
 
@@ -201,7 +229,9 @@ export class OrderedClientCollection
 		return removeClient;
 	}
 
-	/** Returns an array of all clients being tracked in order from oldest to newest. */
+	/**
+	 * Returns an array of all clients being tracked in order from oldest to newest.
+	 */
 	public getAllClients(): ILinkedClient[] {
 		const result: ILinkedClient[] = [];
 		let currClient: LinkNode = this.rootNode;
@@ -213,17 +243,27 @@ export class OrderedClientCollection
 	}
 }
 
-/** Events raised by an OrderedClientElection. */
+/**
+ * Events raised by an OrderedClientElection.
+ */
 export interface IOrderedClientElectionEvents extends IEvent {
-	/** Event fires when the currently elected client changes. */
+	/**
+	 * Event fires when the currently elected client changes.
+	 */
 	(
 		event: "election",
 		listener: (
-			/** Newly elected client. */
+			/**
+			 * Newly elected client.
+			 */
 			client: ITrackedClient | undefined,
-			/** Sequence number where election took place. */
+			/**
+			 * Sequence number where election took place.
+			 */
 			sequenceNumber: number,
-			/** Previously elected client. */
+			/**
+			 * Previously elected client.
+			 */
 			prevClient: ITrackedClient | undefined,
 		) => void,
 	);
@@ -235,7 +275,9 @@ export interface IOrderedClientElectionEvents extends IEvent {
  * @alpha
  */
 export interface ISerializedElection {
-	/** Sequence number at the time of the latest election. */
+	/**
+	 * Sequence number at the time of the latest election.
+	 */
 	readonly electionSequenceNumber: number;
 
 	/**
@@ -248,13 +290,19 @@ export interface ISerializedElection {
 	 */
 	readonly electedClientId: string | undefined;
 
-	/** Most recently elected parent client id. This is always an interactive client. */
+	/**
+	 * Most recently elected parent client id. This is always an interactive client.
+	 */
 	readonly electedParentId: string | undefined;
 }
 
-/** Contract for maintaining a deterministic client election based on eligibility. */
+/**
+ * Contract for maintaining a deterministic client election based on eligibility.
+ */
 export interface IOrderedClientElection extends IEventProvider<IOrderedClientElectionEvents> {
-	/** Count of eligible clients in the collection. */
+	/**
+	 * Count of eligible clients in the collection.
+	 */
 	readonly eligibleCount: number;
 
 	/**
@@ -266,17 +314,29 @@ export interface IOrderedClientElection extends IEventProvider<IOrderedClientEle
 	 * 2. the non-interactive summarizer client itself.
 	 */
 	readonly electedClient: ITrackedClient | undefined;
-	/** Currently elected parent client. This is always an interactive client. */
+	/**
+	 * Currently elected parent client. This is always an interactive client.
+	 */
 	readonly electedParent: ITrackedClient | undefined;
-	/** Sequence number of most recent election. */
+	/**
+	 * Sequence number of most recent election.
+	 */
 	readonly electionSequenceNumber: number;
-	/** Resets the currently elected client back to the oldest eligible client. */
+	/**
+	 * Resets the currently elected client back to the oldest eligible client.
+	 */
 	resetElectedClient(sequenceNumber: number): void;
-	/** Peeks at what the next elected client would be if incrementElectedClient were called. */
+	/**
+	 * Peeks at what the next elected client would be if incrementElectedClient were called.
+	 */
 	peekNextElectedClient(): ITrackedClient | undefined;
-	/** Returns a sorted array of all the eligible clients in the collection. */
+	/**
+	 * Returns a sorted array of all the eligible clients in the collection.
+	 */
 	getAllEligibleClients(): ITrackedClient[];
-	/** Serialize election data */
+	/**
+	 * Serialize election data
+	 */
 	serialize(): ISerializedElection;
 }
 
@@ -295,10 +355,10 @@ export class OrderedClientElection
 	private _electedParent: ILinkedClient | undefined;
 	private _electionSequenceNumber: number;
 
-	public get eligibleCount() {
+	public get eligibleCount(): number {
 		return this._eligibleCount;
 	}
-	public get electionSequenceNumber() {
+	public get electionSequenceNumber(): number {
 		return this._electionSequenceNumber;
 	}
 
@@ -338,17 +398,19 @@ export class OrderedClientElection
 	 *
 	 * vii. SummaryManager running on B spawns a summarizer client, B'. electedParent === B, electedClient === B'
 	 */
-	public get electedClient() {
+	public get electedClient(): ILinkedClient | undefined {
 		return this._electedClient;
 	}
-	public get electedParent() {
+	public get electedParent(): ILinkedClient | undefined {
 		return this._electedParent;
 	}
 
 	constructor(
 		private readonly logger: ITelemetryLoggerExt,
 		private readonly orderedClientCollection: IOrderedClientCollection,
-		/** Serialized state from summary or current sequence number at time of load if new. */
+		/**
+		 * Serialized state from summary or current sequence number at time of load if new.
+		 */
 		initialState: ISerializedElection | number,
 		private readonly isEligibleFn: (c: ITrackedClient) => boolean,
 		private readonly recordPerformanceEvents: boolean = false,
@@ -617,7 +679,7 @@ export class OrderedClientElection
 		sequenceNumber: number,
 		forceSend: boolean = false,
 		reason?: string,
-	) {
+	): void {
 		if (this.recordPerformanceEvents || forceSend) {
 			this.logger.sendPerformanceEvent({
 				eventName,

package/src/summary/runWhileConnectedCoordinator.ts

@@ -36,7 +36,7 @@ export class RunWhileConnectedCoordinator implements ICancellableSummarizerContr
 	private _cancelled = false;
 	private readonly stopDeferred = new Deferred<SummarizerStopReason>();
 
-	public get cancelled() {
+	public get cancelled(): boolean {
 		if (!this._cancelled) {
 			assert(this.active(), 0x25d /* "We should never connect as 'read'" */);
 
@@ -63,7 +63,10 @@ export class RunWhileConnectedCoordinator implements ICancellableSummarizerContr
 		return this.stopDeferred.promise;
 	}
 
-	public static async create(runtime: IConnectableRuntime, active: () => boolean) {
+	public static async create(
+		runtime: IConnectableRuntime,
+		active: () => boolean,
+	): Promise<RunWhileConnectedCoordinator> {
 		const obj = new RunWhileConnectedCoordinator(runtime, active);
 		await obj.waitStart();
 		return obj;
@@ -87,7 +90,7 @@ export class RunWhileConnectedCoordinator implements ICancellableSummarizerContr
 	 * of non-summarized ops, where can make determination to continue with summary even if main
 	 * client is disconnected.
 	 */
-	protected async waitStart() {
+	protected async waitStart(): Promise<void> {
 		if (this.runtime.disposed) {
 			this.stop("summarizerClientDisconnected");
 			return;

package/src/summary/runningSummarizer.ts

@@ -23,6 +23,7 @@ import {
 	createChildLogger,
 	createChildMonitoringContext,
 	isFluidError,
+	type ITelemetryLoggerExt,
 } from "@fluidframework/telemetry-utils/internal";
 
 import { ISummaryConfiguration } from "../containerRuntime.js";
@@ -163,7 +164,7 @@ export class RunningSummarizer
 		return summarizer;
 	}
 
-	public get disposed() {
+	public get disposed(): boolean {
 		return this._disposed;
 	}
 	private stopping = false;
@@ -189,7 +190,9 @@ export class RunningSummarizer
 
 	private readonly runtimeListener;
 
-	/** The maximum number of summary attempts to do when submit summary fails. */
+	/**
+	 * The maximum number of summary attempts to do when submit summary fails.
+	 */
 	private readonly maxAttemptsForSubmitFailures: number;
 
 	/**
@@ -317,7 +320,7 @@ export class RunningSummarizer
 				: defaultMaxAttemptsForSubmitFailures;
 	}
 
-	private async handleSummaryAck(ack: IAckedSummary) {
+	private async handleSummaryAck(ack: IAckedSummary): Promise<void> {
 		const refSequenceNumber = ack.summaryOp.referenceSequenceNumber;
 		const summaryLogger = this.tryGetCorrelatedLogger(refSequenceNumber) ?? this.mc.logger;
 		const summaryOpHandle = ack.summaryOp.contents.handle;
@@ -352,7 +355,7 @@ export class RunningSummarizer
 
 	private readonly refreshLatestSummaryAckAndHandleError = async (
 		options: IRefreshSummaryAckOptions,
-	) => {
+	): Promise<void> => {
 		return this.refreshLatestSummaryAckCallback(options).catch(async (error) => {
 			// If the error is 404, so maybe the fetched version no longer exists on server. We just
 			// ignore this error in that case, as that means we will have another summaryAck for the
@@ -387,7 +390,7 @@ export class RunningSummarizer
 	 * @param referenceSequenceNumber - The referenceSequenceNumber of the summary from which to start processing
 	 * acks.
 	 */
-	private async processIncomingSummaryAcks(referenceSequenceNumber: number) {
+	private async processIncomingSummaryAcks(referenceSequenceNumber: number): Promise<void> {
 		// Start waiting for acks that are for summaries newer that the one this client loaded from.
 		let nextReferenceSequenceNumber = referenceSequenceNumber;
 		while (!this.disposed) {
@@ -417,15 +420,19 @@ export class RunningSummarizer
 	 * but only if they're logging about that same summary.
 	 * @param summaryOpRefSeq - RefSeq number of the summary op, to ensure the log correlation will be correct
 	 */
-	public tryGetCorrelatedLogger = (summaryOpRefSeq) =>
+	public tryGetCorrelatedLogger = (
+		summaryOpRefSeq: number,
+	): ITelemetryLoggerExt | undefined =>
 		this.heuristicData.lastAttempt.refSequenceNumber === summaryOpRefSeq
 			? this.mc.logger
 			: undefined;
 
-	/** We only want a single heuristic runner micro-task (will provide better optimized grouping of ops) */
+	/**
+	 * We only want a single heuristic runner micro-task (will provide better optimized grouping of ops)
+	 */
 	private heuristicRunnerMicroTaskExists = false;
 
-	public handleOp(op: ISequencedDocumentMessage, runtimeMessage: boolean) {
+	public handleOp(op: ISequencedDocumentMessage, runtimeMessage: boolean): void {
 		this.heuristicData.lastOpSequenceNumber = op.sequenceNumber;
 
 		if (runtimeMessage) {
@@ -525,7 +532,7 @@ export class RunningSummarizer
 		this.lastSummarizeFailureEventProps = undefined;
 	}
 
-	private async waitStart() {
+	private async waitStart(): Promise<void> {
 		// Wait no longer than ack timeout for all pending
 		const waitStartResult = await raceTimer(
 			this.summaryWatcher.waitFlushed(),
@@ -548,11 +555,11 @@ export class RunningSummarizer
 		this.initialized = true;
 	}
 
-	private beforeSummaryAction() {
+	private beforeSummaryAction(): void {
 		this.summarizeCount++;
 	}
 
-	private afterSummaryAction() {
+	private afterSummaryAction(): void {
 		const retry = this.tryWhileSummarizing;
 		this.tryWhileSummarizing = false;
 
@@ -576,7 +583,7 @@ export class RunningSummarizer
 		before: () => void,
 		action: () => Promise<T>,
 		after: () => void,
-	) {
+	): Promise<T> {
 		assert(
 			this.summarizingLock === undefined,
 			0x25b /* "Caller is responsible for checking lock" */,
@@ -680,7 +687,9 @@ export class RunningSummarizer
 		return resultsBuilder.build();
 	}
 
-	/** Heuristics summarize attempt. */
+	/**
+	 * Heuristics summarize attempt.
+	 */
 	private trySummarize(reason: SummarizeReason): void {
 		if (this.summarizingLock !== undefined) {
 			// lockedSummaryAction() will retry heuristic-based summary at the end of current attempt
@@ -712,7 +721,13 @@ export class RunningSummarizer
 		reason: SummarizeReason,
 	): Promise<ISummarizeResults | undefined> {
 		// Helper to set summarize options, telemetry properties and call summarize.
-		const attemptSummarize = (attemptNumber: number, finalAttempt: boolean) => {
+		const attemptSummarize = (
+			attemptNumber: number,
+			finalAttempt: boolean,
+		): {
+			summarizeProps: ISummarizeTelemetryProperties;
+			summarizeResult: ISummarizeResults;
+		} => {
 			const summarizeOptions: ISummarizeOptions = {
 				fullTree: false,
 			};
@@ -878,7 +893,7 @@ export class RunningSummarizer
 	private async summarizeOnDemandWithRetries(
 		reason: SummarizeReason,
 		resultsBuilder: SummarizeResultBuilder,
-	) {
+	): Promise<ISummarizeResults> {
 		const results = await this.trySummarizeWithRetries(reason);
 		if (results === undefined) {
 			resultsBuilder.fail(
@@ -896,7 +911,9 @@ export class RunningSummarizer
 		return resultsBuilder.build();
 	}
 
-	/** {@inheritdoc (ISummarizer:interface).summarizeOnDemand} */
+	/**
+	 * {@inheritdoc (ISummarizer:interface).summarizeOnDemand}
+	 */
 	public summarizeOnDemand(
 		options: IOnDemandSummarizeOptions,
 		resultsBuilder: SummarizeResultBuilder = new SummarizeResultBuilder(),
@@ -932,7 +949,9 @@ export class RunningSummarizer
 		return resultsBuilder.build();
 	}
 
-	/** {@inheritdoc (ISummarizer:interface).enqueueSummarize} */
+	/**
+	 * {@inheritdoc (ISummarizer:interface).enqueueSummarize}
+	 */
 	public enqueueSummarize(options: IEnqueueSummarizeOptions): EnqueueSummarizeResult {
 		const { reason, afterSequenceNumber = 0, override = false, ...summarizeOptions } = options;
 		let overridden = false;
@@ -968,7 +987,7 @@ export class RunningSummarizer
 			: results;
 	}
 
-	private tryRunEnqueuedSummary() {
+	private tryRunEnqueuedSummary(): boolean {
 		if (this.stopping) {
 			this.disposeEnqueuedSummary();
 			return false;
@@ -992,7 +1011,7 @@ export class RunningSummarizer
 		return true;
 	}
 
-	private disposeEnqueuedSummary() {
+	private disposeEnqueuedSummary(): void {
 		if (this.enqueuedSummary !== undefined) {
 			this.enqueuedSummary.resultsBuilder.fail(
 				"RunningSummarizer stopped or disposed",