@fluidframework/container-runtime 2.1.0-281041 → 2.1.0

package/lib/containerRuntime.js

@@ -25,7 +25,7 @@ import { FluidDataStoreRegistry } from "./dataStoreRegistry.js";
 import { DeltaManagerPendingOpsProxy, DeltaManagerSummarizerProxy, } from "./deltaManagerProxies.js";
 import { GCNodeType, GarbageCollector, gcGenerationOptionName, } from "./gc/index.js";
 import { ContainerMessageType, } from "./messageTypes.js";
-import { OpCompressor, OpDecompressor, OpGroupingManager, OpSplitter, Outbox, RemoteMessageProcessor, } from "./opLifecycle/index.js";
+import { ensureContentsDeserialized, OpCompressor, OpDecompressor, OpGroupingManager, OpSplitter, Outbox, RemoteMessageProcessor, } from "./opLifecycle/index.js";
 import { pkgVersion } from "./packageVersion.js";
 import { PendingStateManager, } from "./pendingStateManager.js";
 import { ScheduleManager } from "./scheduleManager.js";
@@ -1464,14 +1464,22 @@ export class ContainerRuntime extends TypedEventEmitter {
         // It may be a legacy runtime message (ie already unpacked and ContainerMessageType)
         // or something different, like a system message.
         const modernRuntimeMessage = messageArg.type === MessageType.Operation;
+        const savedOp = messageArg.metadata?.savedOp;
+        // There is some ancient back-compat code that we'd like to instrument
+        // to understand if/when it is hit.
+        const logLegacyCase = (codePath) => this.logger.sendTelemetryEvent({
+            eventName: "LegacyMessageFormat",
+            details: { codePath, type: messageArg.type },
+        });
         // Do shallow copy of message, as the processing flow will modify it.
         // There might be multiple container instances receiving the same message.
         // We do not need to make a deep copy. Each layer will just replace message.contents itself,
         // but will not modify the contents object (likely it will replace it on the message).
         const messageCopy = { ...messageArg };
-        const savedOp = messageCopy.metadata?.savedOp;
+        // We expect runtime messages to have JSON contents - deserialize it in place.
+        ensureContentsDeserialized(messageCopy, modernRuntimeMessage, logLegacyCase);
         if (modernRuntimeMessage) {
-            const processResult = this.remoteMessageProcessor.process(messageCopy);
+            const processResult = this.remoteMessageProcessor.process(messageCopy, logLegacyCase);
             if (processResult === undefined) {
                 // This means the incoming message is an incomplete part of a message or batch
                 // and we need to process more messages before the rest of the system can understand it.
@@ -2747,7 +2755,7 @@ export class ContainerRuntime extends TypedEventEmitter {
                     fetchSource: FetchSource.noCache,
                 });
                 const id = snapshot.snapshotTree.id;
-                assert(id !== undefined, "id of the fetched snapshot should be defined");
+                assert(id !== undefined, 0x9d0 /* id of the fetched snapshot should be defined */);
                 props.snapshotVersion = id;
                 snapshotTree = snapshot.snapshotTree;
             }