@fluidframework/container-runtime 2.0.0-dev-rc.3.0.0.253463 → 2.0.0-dev-rc.3.0.0.254513

package/dist/containerRuntime.js

@@ -297,6 +297,18 @@ class ContainerRuntime extends client_utils_1.TypedEventEmitter {
                 }
             }
         }
+        let desiredIdCompressorMode;
+        switch (mc.config.getBoolean("Fluid.ContainerRuntime.IdCompressorEnabled")) {
+            case true:
+                desiredIdCompressorMode = "on";
+                break;
+            case false:
+                desiredIdCompressorMode = undefined;
+                break;
+            default:
+                desiredIdCompressorMode = enableRuntimeIdCompressor;
+                break;
+        }
         // Enabling the IdCompressor is a one-way operation and we only want to
         // allow new containers to turn it on.
         let idCompressorMode;
@@ -308,24 +320,19 @@ class ContainerRuntime extends client_utils_1.TypedEventEmitter {
             // 3) Same logic applies for "delayed" mode
             // Maybe in the future we will need to enabled (and figure how to do it safely) "delayed" -> "on" change.
             // We could do "off" -> "on" transition too, if all clients start loading compressor (but not using it initially) and
-            // do so for a while - this will allow clients to eventually to disregard "off" setting (when it's safe so) and start
+            // do so for a while - this will allow clients to eventually disregard "off" setting (when it's safe so) and start
             // using compressor in future sessions.
             // Everyting is possible, but it needs to be designed and executed carefully, when such need arises.
             idCompressorMode = metadata?.documentSchema?.runtime
                 ?.idCompressorMode;
+            // This is the only exception to the rule above - we have proper plumbing to load ID compressor on schema change
+            // event. It is loaded async (relative to op processing), so this conversion is only safe for off -> delayed conversion!
+            if (idCompressorMode === undefined && desiredIdCompressorMode === "delayed") {
+                idCompressorMode = desiredIdCompressorMode;
+            }
         }
         else {
-            switch (mc.config.getBoolean("Fluid.ContainerRuntime.IdCompressorEnabled")) {
-                case true:
-                    idCompressorMode = "on";
-                    break;
-                case false:
-                    idCompressorMode = undefined;
-                    break;
-                default:
-                    idCompressorMode = enableRuntimeIdCompressor;
-                    break;
-            }
+            idCompressorMode = desiredIdCompressorMode;
         }
         const createIdCompressorFn = async () => {
             const { createIdCompressor, deserializeIdCompressor, createSessionId } = await import("@fluidframework/id-compressor/internal");
@@ -1485,6 +1492,7 @@ class ContainerRuntime extends client_utils_1.TypedEventEmitter {
                     // Some other client turned on the id compressor. If we have not turned it on,
                     // put it in a pending queue and delay finalization.
                     if (this._idCompressor === undefined) {
+                        (0, internal_2.assert)(this.idCompressorMode !== undefined, "id compressor should be enabled");
                         this.pendingIdCompressorOps.push(range);
                     }
                     else {