@fluidframework/container-runtime 2.0.0-dev-rc.2.0.0.246488 → 2.0.0-dev-rc.3.0.0.250606

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fluidframework/container-runtime",
-  "version": "2.0.0-dev-rc.2.0.0.246488",
+  "version": "2.0.0-dev-rc.3.0.0.250606",
   "description": "Fluid container runtime",
   "homepage": "https://fluidframework.com",
   "repository": {
@@ -137,20 +137,20 @@
     "temp-directory": "nyc/.nyc_output"
   },
   "dependencies": {
-    "@fluid-internal/client-utils": "2.0.0-dev-rc.2.0.0.246488",
+    "@fluid-internal/client-utils": "2.0.0-dev-rc.3.0.0.250606",
     "@fluidframework/common-definitions": "^1.1.0",
-    "@fluidframework/container-definitions": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/container-runtime-definitions": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/core-interfaces": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/core-utils": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/datastore": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/driver-definitions": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/driver-utils": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/id-compressor": "2.0.0-dev-rc.2.0.0.246488",
+    "@fluidframework/container-definitions": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/container-runtime-definitions": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/core-interfaces": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/core-utils": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/datastore": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/driver-definitions": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/driver-utils": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/id-compressor": "2.0.0-dev-rc.3.0.0.250606",
     "@fluidframework/protocol-definitions": "^3.2.0",
-    "@fluidframework/runtime-definitions": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/runtime-utils": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluidframework/telemetry-utils": "2.0.0-dev-rc.2.0.0.246488",
+    "@fluidframework/runtime-definitions": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/runtime-utils": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluidframework/telemetry-utils": "2.0.0-dev-rc.3.0.0.250606",
     "@tylerbu/sorted-btree-es6": "^1.8.0",
     "double-ended-queue": "^2.1.0-0",
     "lz4js": "^0.2.0",
@@ -158,15 +158,17 @@
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.13.3",
-    "@fluid-internal/mocha-test-setup": "2.0.0-dev-rc.2.0.0.246488",
-    "@fluid-private/stochastic-test-utils": "2.0.0-dev-rc.2.0.0.246488",
+    "@biomejs/biome": "^1.6.2",
+    "@fluid-internal/mocha-test-setup": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluid-private/stochastic-test-utils": "2.0.0-dev-rc.3.0.0.250606",
+    "@fluid-private/test-pairwise-generator": "2.0.0-dev-rc.3.0.0.250606",
     "@fluid-tools/benchmark": "^0.48.0",
     "@fluid-tools/build-cli": "^0.34.0",
     "@fluidframework/build-common": "^2.0.3",
     "@fluidframework/build-tools": "^0.34.0",
     "@fluidframework/container-runtime-previous": "npm:@fluidframework/container-runtime@2.0.0-internal.8.0.0",
     "@fluidframework/eslint-config-fluid": "^5.1.0",
-    "@fluidframework/test-runtime-utils": "2.0.0-dev-rc.2.0.0.246488",
+    "@fluidframework/test-runtime-utils": "2.0.0-dev-rc.3.0.0.250606",
     "@microsoft/api-extractor": "^7.42.3",
     "@types/double-ended-queue": "^2.1.0",
     "@types/mocha": "^9.1.1",
@@ -222,6 +224,16 @@
       "RemovedFunctionDeclaration_isStableId": {
         "backCompat": false,
         "forwardCompat": false
+      },
+      "InterfaceDeclaration_IContainerRuntimeMetadata": {
+        "backCompat": false
+      },
+      "RemovedEnumDeclaration_RuntimeMessage": {
+        "backCompat": false,
+        "forwardCompat": false
+      },
+      "InterfaceDeclaration_IChunkedOp": {
+        "backCompat": false
       }
     }
   },
@@ -239,16 +251,18 @@
     "build:test:cjs": "fluid-tsc commonjs --project ./src/test/tsconfig.cjs.json",
     "build:test:esm": "tsc --project ./src/test/tsconfig.json",
     "check:are-the-types-wrong": "attw --pack . --entrypoints .",
+    "check:biome": "biome check .",
+    "check:prettier": "prettier --check . --cache --ignore-path ../../../.prettierignore",
     "check:release-tags": "api-extractor run --local --config ./api-extractor-lint.json",
     "ci:build:docs": "api-extractor run",
     "clean": "rimraf --glob dist lib \"**/*.tsbuildinfo\" \"**/*.build.log\" _api-extractor-temp nyc",
     "eslint": "eslint --format stylish src",
     "eslint:fix": "eslint --format stylish src --fix --fix-type problem,suggestion,layout",
-    "format": "npm run prettier:fix",
-    "lint": "npm run prettier && npm run check:release-tags && npm run eslint",
-    "lint:fix": "npm run prettier:fix && npm run eslint:fix",
-    "prettier": "prettier --check . --cache --ignore-path ../../../.prettierignore",
-    "prettier:fix": "prettier --write . --cache --ignore-path ../../../.prettierignore",
+    "format": "fluid-build --task format .",
+    "format:biome": "biome check --apply .",
+    "format:prettier": "prettier --write . --cache --ignore-path ../../../.prettierignore",
+    "lint": "fluid-build . --task lint",
+    "lint:fix": "fluid-build . --task eslint:fix --task format",
     "test": "npm run test:mocha",
     "test:benchmark:report": "mocha --timeout 999999 --perfMode --parentProcess --fgrep @Benchmark --reporter @fluid-tools/benchmark/dist/MochaReporter.js \"./dist/**/*.perf.spec.*js\"",
     "test:coverage": "c8 npm test",

package/src/batchTracker.ts

@@ -3,12 +3,12 @@
  * Licensed under the MIT License.
  */
 
-import { ITelemetryLoggerExt, createChildLogger } from "@fluidframework/telemetry-utils";
-import { assert } from "@fluidframework/core-utils";
 import type { EventEmitter } from "@fluid-internal/client-utils";
 import { performance } from "@fluid-internal/client-utils";
-import { ISequencedDocumentMessage } from "@fluidframework/protocol-definitions";
 import { ITelemetryBaseLogger } from "@fluidframework/core-interfaces";
+import { assert } from "@fluidframework/core-utils";
+import { ISequencedDocumentMessage } from "@fluidframework/protocol-definitions";
+import { ITelemetryLoggerExt, createChildLogger } from "@fluidframework/telemetry-utils";
 
 export class BatchTracker {
 	private readonly logger: ITelemetryLoggerExt;

package/src/blobManager.ts

@@ -3,8 +3,14 @@
  * Licensed under the MIT License.
  */
 
-import { v4 as uuid } from "uuid";
+import { TypedEventEmitter, bufferToString, stringToBuffer } from "@fluid-internal/client-utils";
+import { AttachState, ICriticalContainerError } from "@fluidframework/container-definitions";
+import {
+	IContainerRuntime,
+	IContainerRuntimeEvents,
+} from "@fluidframework/container-runtime-definitions";
 import { IFluidHandle, IFluidHandleContext } from "@fluidframework/core-interfaces";
+import { assert, Deferred } from "@fluidframework/core-utils";
 import { IDocumentStorageService } from "@fluidframework/driver-definitions";
 import {
 	ICreateBlobResponse,
@@ -12,31 +18,25 @@ import {
 	ISnapshotTree,
 } from "@fluidframework/protocol-definitions";
 import {
+	IGarbageCollectionData,
+	ISummaryTreeWithStats,
+	ITelemetryContext,
+} from "@fluidframework/runtime-definitions";
+import {
+	SummaryTreeBuilder,
 	createResponseError,
 	generateHandleContextPath,
 	responseToException,
-	SummaryTreeBuilder,
 } from "@fluidframework/runtime-utils";
-import { assert, Deferred } from "@fluidframework/core-utils";
-import { bufferToString, stringToBuffer, TypedEventEmitter } from "@fluid-internal/client-utils";
 import {
-	IContainerRuntime,
-	IContainerRuntimeEvents,
-} from "@fluidframework/container-runtime-definitions";
-import { AttachState, ICriticalContainerError } from "@fluidframework/container-definitions";
-import {
-	createChildMonitoringContext,
 	GenericError,
 	LoggingError,
 	MonitoringContext,
 	PerformanceEvent,
+	createChildMonitoringContext,
 	wrapError,
 } from "@fluidframework/telemetry-utils";
-import {
-	IGarbageCollectionData,
-	ISummaryTreeWithStats,
-	ITelemetryContext,
-} from "@fluidframework/runtime-definitions";
+import { v4 as uuid } from "uuid";
 
 import { canRetryOnError, runWithRetry } from "@fluidframework/driver-utils";
 import { IBlobMetadata } from "./metadata.js";

package/src/channelCollection.ts

@@ -3,92 +3,92 @@
  * Licensed under the MIT License.
  */
 
+import { AttachState } from "@fluidframework/container-definitions";
 import {
-	ITelemetryBaseLogger,
+	FluidObject,
 	IDisposable,
 	IFluidHandle,
 	IRequest,
-	FluidObject,
 	IResponse,
+	ITelemetryBaseLogger,
 } from "@fluidframework/core-interfaces";
+import { assert, Lazy, LazyPromise } from "@fluidframework/core-utils";
 import { FluidObjectHandle } from "@fluidframework/datastore";
+import { buildSnapshotTree } from "@fluidframework/driver-utils";
 import { ISequencedDocumentMessage, ISnapshotTree } from "@fluidframework/protocol-definitions";
 import {
 	AliasResult,
-	channelsTreeName,
 	CreateSummarizerNodeSource,
 	IAttachMessage,
 	IEnvelope,
 	IFluidDataStoreChannel,
+	IFluidDataStoreContext,
 	IFluidDataStoreContextDetached,
+	IFluidDataStoreFactory,
+	IFluidDataStoreRegistry,
+	IFluidParentContext,
 	IGarbageCollectionData,
 	IInboundSignalMessage,
-	IFluidParentContext,
-	InboundAttachMessage,
 	ISummarizeResult,
 	ISummaryTreeWithStats,
 	ITelemetryContext,
-	IFluidDataStoreFactory,
-	IFluidDataStoreContext,
+	InboundAttachMessage,
 	NamedFluidDataStoreRegistryEntries,
-	IFluidDataStoreRegistry,
+	channelsTreeName,
 } from "@fluidframework/runtime-definitions";
 import {
+	GCDataBuilder,
+	RequestParser,
+	SummaryTreeBuilder,
 	convertSnapshotTreeToSummaryTree,
 	convertSummaryTreeToITree,
 	create404Response,
 	createResponseError,
-	GCDataBuilder,
+	encodeCompactIdToString,
 	isSerializedHandle,
 	processAttachMessageGCData,
 	responseToException,
-	SummaryTreeBuilder,
 	unpackChildNodesUsedRoutes,
-	RequestParser,
-	encodeCompactIdToString,
 } from "@fluidframework/runtime-utils";
 import {
-	createChildMonitoringContext,
 	DataCorruptionError,
 	DataProcessingError,
-	extractSafePropertiesFromMessage,
 	LoggingError,
 	MonitoringContext,
-	tagCodeArtifacts,
 	createChildLogger,
+	createChildMonitoringContext,
+	extractSafePropertiesFromMessage,
+	tagCodeArtifacts,
 } from "@fluidframework/telemetry-utils";
-import { AttachState } from "@fluidframework/container-definitions";
-import { buildSnapshotTree } from "@fluidframework/driver-utils";
-import { assert, Lazy, LazyPromise } from "@fluidframework/core-utils";
-import { DataStoreContexts } from "./dataStoreContexts.js";
-import { defaultRuntimeHeaderData, RuntimeHeaderData } from "./containerRuntime.js";
-import {
-	FluidDataStoreContext,
-	RemoteFluidDataStoreContext,
-	LocalFluidDataStoreContext,
-	createAttributesBlob,
-	LocalDetachedFluidDataStoreContext,
-	IFluidDataStoreContextInternal,
-	ILocalDetachedFluidDataStoreContextProps,
-} from "./dataStoreContext.js";
-import { StorageServiceWithAttachBlobs } from "./storageServiceWithAttachBlobs.js";
+import { RuntimeHeaderData, defaultRuntimeHeaderData } from "./containerRuntime.js";
 import {
 	IDataStoreAliasMessage,
 	channelToDataStore,
 	isDataStoreAliasMessage,
 } from "./dataStore.js";
+import {
+	FluidDataStoreContext,
+	IFluidDataStoreContextInternal,
+	ILocalDetachedFluidDataStoreContextProps,
+	LocalDetachedFluidDataStoreContext,
+	LocalFluidDataStoreContext,
+	RemoteFluidDataStoreContext,
+	createAttributesBlob,
+} from "./dataStoreContext.js";
+import { DataStoreContexts } from "./dataStoreContexts.js";
+import { FluidDataStoreRegistry } from "./dataStoreRegistry.js";
 import {
 	GCNodeType,
 	detectOutboundRoutesViaDDSKey,
 	trimLeadingAndTrailingSlashes,
 } from "./gc/index.js";
+import { ContainerMessageType, LocalContainerRuntimeMessage } from "./messageTypes.js";
+import { StorageServiceWithAttachBlobs } from "./storageServiceWithAttachBlobs.js";
 import {
 	IContainerRuntimeMetadata,
 	nonDataStorePaths,
 	rootHasIsolatedChannels,
 } from "./summary/index.js";
-import { ContainerMessageType, LocalContainerRuntimeMessage } from "./messageTypes.js";
-import { FluidDataStoreRegistry } from "./dataStoreRegistry.js";
 
 /**
  * Accepted header keys for requests coming to the runtime.
@@ -746,9 +746,49 @@ export class ChannelCollection implements IFluidDataStoreChannel, IDisposable {
 	}
 
 	private async applyStashedAttachOp(message: IAttachMessage) {
-		this.pendingAttach.set(message.id, message);
-		// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-		this.processAttachMessage({ contents: message } as ISequencedDocumentMessage, false);
+		const { id, snapshot } = message;
+
+		// build the snapshot from the summary in the attach message
+		const flatAttachBlobs = new Map<string, ArrayBufferLike>();
+		const snapshotTree = buildSnapshotTree(snapshot.entries, flatAttachBlobs);
+		const storage = new StorageServiceWithAttachBlobs(
+			this.parentContext.storage,
+			flatAttachBlobs,
+		);
+
+		// create a local datastore context for the data store context,
+		// which this message represents. All newly created data store
+		// contexts start as a local context on the client that created
+		// them, and for stashed ops, the client that applies it plays
+		// the role of creating client.
+		const dataStoreContext = new LocalFluidDataStoreContext({
+			id,
+			pkg: undefined,
+			parentContext: this.wrapContextForInnerChannel(id),
+			storage,
+			scope: this.parentContext.scope,
+			createSummarizerNodeFn: this.parentContext.getCreateChildSummarizerNodeFn(id, {
+				type: CreateSummarizerNodeSource.FromSummary,
+			}),
+			makeLocallyVisibleFn: () => this.makeDataStoreLocallyVisible(id),
+			snapshotTree,
+		});
+
+		// realize the local context, as local contexts shouldn't be delay
+		// loaded, as this client is playing the role of creating client,
+		// and creating clients always create realized data store contexts.
+		const channel = await dataStoreContext.realize();
+		await channel.entryPoint.get();
+
+		// add to the list of bound or remoted, as this context must be bound
+		// to had an attach message sent, and is the non-detached case is remoted.
+		this.contexts.addBoundOrRemoted(dataStoreContext);
+		if (this.parentContext.attachState !== AttachState.Detached) {
+			// if the client is not detached put in the pending attach list
+			// so that on ack of the stashed op, the context is found.
+			// detached client don't send ops, so should not expect and ack.
+			this.pendingAttach.set(message.id, message);
+		}
 	}
 
 	public process(

package/src/connectionTelemetry.ts

@@ -3,6 +3,16 @@
  * Licensed under the MIT License.
  */
 
+import { performance } from "@fluid-internal/client-utils";
+import { IDeltaManager } from "@fluidframework/container-definitions";
+import { IContainerRuntimeEvents } from "@fluidframework/container-runtime-definitions";
+import { IEventProvider } from "@fluidframework/core-interfaces";
+import { assert } from "@fluidframework/core-utils";
+import {
+	IDocumentMessage,
+	ISequencedDocumentMessage,
+	MessageType,
+} from "@fluidframework/protocol-definitions";
 import {
 	IEventSampler,
 	ISampledTelemetryLogger,
@@ -11,16 +21,6 @@ import {
 	createSampledLogger,
 	formatTick,
 } from "@fluidframework/telemetry-utils";
-import { IDeltaManager } from "@fluidframework/container-definitions";
-import {
-	IDocumentMessage,
-	ISequencedDocumentMessage,
-	MessageType,
-} from "@fluidframework/protocol-definitions";
-import { assert } from "@fluidframework/core-utils";
-import { performance } from "@fluid-internal/client-utils";
-import { IContainerRuntimeEvents } from "@fluidframework/container-runtime-definitions";
-import { IEventProvider } from "@fluidframework/core-interfaces";
 
 /**
  * We report various latency-related errors when waiting for op roundtrip takes longer than that amout of time.

package/src/containerHandleContext.ts

@@ -3,8 +3,8 @@
  * Licensed under the MIT License.
  */
 
-import { IFluidHandleContext, IRequest, IResponse } from "@fluidframework/core-interfaces";
 import { AttachState } from "@fluidframework/container-definitions";
+import { IFluidHandleContext, IRequest, IResponse } from "@fluidframework/core-interfaces";
 import { generateHandleContextPath } from "@fluidframework/runtime-utils";
 import { ContainerRuntime } from "./containerRuntime.js";