@fluid-internal/client-utils 2.0.0-dev.6.4.0.192049 → 2.0.0-dev.7.2.0.204906

package/src/bufferNode.ts

@@ -8,10 +8,11 @@
  * exposing the entirely of Node's typings.  This should match the public interface
  * of the browser implementation, so any changes made in one should be made in both.
  *
- * @public
+ * @internal
  */
 export declare class Buffer extends Uint8Array {
-	toString(encoding?: string): string;
+	// eslint-disable-next-line unicorn/text-encoding-identifier-case -- this value is supported, just discouraged
+	toString(encoding?: "utf8" | "utf-8" | "base64"): string;
 
 	/**
 	 * Static constructor
@@ -27,12 +28,12 @@ export declare class Buffer extends Uint8Array {
 }
 
 /**
- * @public
+ * @internal
  */
 export const IsoBuffer = Buffer;
 
 /**
- * @public
+ * @internal
  */
 export type IsoBuffer = Buffer;
 
@@ -46,9 +47,14 @@ export type IsoBuffer = Buffer;
  *
  * @internal
  */
-export function Uint8ArrayToString(arr: Uint8Array, encoding?: string): string {
-	// Make this check because Buffer.from(arr) will always do a buffer copy
-	return Buffer.isBuffer(arr) ? arr.toString(encoding) : Buffer.from(arr).toString(encoding);
+export function Uint8ArrayToString(
+	arr: Uint8Array,
+	// eslint-disable-next-line unicorn/text-encoding-identifier-case -- this value is supported, just discouraged
+	encoding?: "utf8" | "utf-8" | "base64",
+): string {
+	// Buffer extends Uint8Array.  Therefore, 'arr' may already be a Buffer, in
+	// which case we can avoid copying the Uint8Array into a new Buffer instance.
+	return (Buffer.isBuffer(arr) ? arr : Buffer.from(arr)).toString(encoding);
 }
 
 /**
@@ -76,5 +82,8 @@ export function stringToBuffer(input: string, encoding: string): ArrayBufferLike
  *
  * @internal
  */
-export const bufferToString = (blob: ArrayBufferLike, encoding: string): string =>
-	IsoBuffer.from(blob).toString(encoding);
+export const bufferToString = (
+	blob: ArrayBufferLike,
+	// eslint-disable-next-line unicorn/text-encoding-identifier-case -- this value is supported, just discouraged
+	encoding: "utf8" | "utf-8" | "base64",
+): string => IsoBuffer.from(blob).toString(encoding);

package/src/eventForwarder.ts

@@ -3,6 +3,8 @@
  * Licensed under the MIT License.
  */
 
+// False positive: this is an import from the `events` package, not from Node.
+// eslint-disable-next-line unicorn/prefer-node-protocol
 import { EventEmitter } from "events";
 import { IDisposable, IEvent, IEventProvider } from "@fluidframework/core-interfaces";
 import { TypedEventEmitter } from "./typedEventEmitter";

package/src/performanceNode.ts

@@ -3,7 +3,8 @@
  * Licensed under the MIT License.
  */
 
-// eslint-disable-next-line import/no-nodejs-modules
+// This is referring to our own `perf_hooks`, not Node's.
+// eslint-disable-next-line import/no-nodejs-modules, unicorn/prefer-node-protocol
 import { performance as nodePerformance } from "perf_hooks";
 import { IsomorphicPerformance } from "./performanceIsomorphic";
 

package/src/typedEventEmitter.ts

@@ -3,6 +3,8 @@
  * Licensed under the MIT License.
  */
 
+// False positive: this is an import from the `events` package, not from Node.
+// eslint-disable-next-line unicorn/prefer-node-protocol
 import { EventEmitter } from "events";
 import {
 	IEvent,

package/tsconfig.json

@@ -8,6 +8,7 @@
 		"paths": {
 			"perf_hooks": ["types/perf_hooks.d.ts"],
 		},
+		"types": ["events"],
 	},
 	"include": ["src/**/*"],
 	"exclude": ["src/test/**/*"],