@fluid-experimental/property-changeset 2.0.0-internal.1.2.0.93071 → 2.0.0-internal.1.2.2

package/lib/changeset_operations/array.js

@@ -23,13 +23,37 @@ const { isPrimitiveType } = TypeIdHelper;
  */
 var ArrayChangeSetRangeType;
 (function (ArrayChangeSetRangeType) {
+    /**
+     * A complete operation of change set A.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["completeA"] = 0] = "completeA";
+    /**
+     * A complete operation of change set B.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["completeB"] = 1] = "completeB";
+    /**
+     * A partial operation of change set A.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["partOfA"] = 2] = "partOfA";
+    /**
+     * A partial operation of change set B.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["partOfB"] = 3] = "partOfB";
+    /**
+     * A complete operation of change set A overlapping with a partial operation of change set B.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["completeApartOfB"] = 4] = "completeApartOfB";
+    /**
+     * A complete operation of change set B overlapping with a partial operation of change set A.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["completeBpartOfA"] = 5] = "completeBpartOfA";
+    /**
+     * A complete operation of change set A overlapping a complete operation of change set B.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["completeAcompleteB"] = 6] = "completeAcompleteB";
+    /**
+     * A partial operation of change set A, a partial operation of change set B.
+     */
     ArrayChangeSetRangeType[ArrayChangeSetRangeType["partOfApartOfB"] = 7] = "partOfApartOfB";
 })(ArrayChangeSetRangeType || (ArrayChangeSetRangeType = {}));
 /**
@@ -105,12 +129,7 @@ const getRangeForAppliedOperation = function (in_operation, io_resultingRange, i
     io_resultingRange.op.operation[0] = in_operation.operation[0];
     io_resultingRange.begin = in_operation.operation[0];
     io_resultingRange.op._absoluteBegin = in_operation.operation[0];
-    if (in_flag !== undefined) {
-        io_resultingRange.flag = in_flag;
-    }
-    else {
-        io_resultingRange.flag = ArrayChangeSetRangeType.completeB;
-    }
+    io_resultingRange.flag = in_flag !== undefined ? in_flag : ArrayChangeSetRangeType.completeB;
     switch (in_operation.type) {
         case ArrayChangeSetIterator.types.INSERT:
             io_resultingRange.end = in_operation.operation[0];
@@ -125,12 +144,9 @@ const getRangeForAppliedOperation = function (in_operation, io_resultingRange, i
         case ArrayChangeSetIterator.types.REMOVE:
             let numberOfRemovedElements = getOpLength(in_operation.operation);
             io_resultingRange.end = in_operation.operation[0] + numberOfRemovedElements;
-            if (Array.isArray(in_operation.operation[1])) {
-                io_resultingRange.op.operation[1] = in_operation.operation[1].slice();
-            }
-            else {
-                io_resultingRange.op.operation[1] = in_operation.operation[1];
-            }
+            io_resultingRange.op.operation[1] = Array.isArray(in_operation.operation[1])
+                ? in_operation.operation[1].slice()
+                : in_operation.operation[1];
             io_resultingRange.removeInsertOperation = in_operation.removeInsertOperation;
             return;
         case ArrayChangeSetIterator.types.MODIFY:
@@ -393,22 +409,14 @@ const splitOverlapping = function (io_rangeA, io_rangeB, io_resultingSegment, in
                 io_resultingSegment.end = io_rangeA.end;
                 io_resultingSegment.op = undefined; // This is used to indicate that we don't need any operation
                 if (io_rangeB.op.operation[1].length === rangeLength) {
-                    if (io_rangeA.op.operation[1].length === rangeLength) {
-                        // We consume both A and B
-                        io_resultingSegment.flag = ArrayChangeSetRangeType.completeAcompleteB;
-                    }
-                    else {
-                        io_resultingSegment.flag = ArrayChangeSetRangeType.completeBpartOfA;
-                    }
+                    io_resultingSegment.flag = io_rangeA.op.operation[1].length === rangeLength
+                        ? ArrayChangeSetRangeType.completeAcompleteB
+                        : ArrayChangeSetRangeType.completeBpartOfA;
                 }
                 else {
-                    if (io_rangeA.op.operation[1].length === rangeLength) {
-                        // We consume A and leave a part of B
-                        io_resultingSegment.flag = ArrayChangeSetRangeType.completeApartOfB;
-                    }
-                    else {
-                        io_resultingSegment.flag = ArrayChangeSetRangeType.partOfApartOfB;
-                    }
+                    io_resultingSegment.flag = io_rangeA.op.operation[1].length === rangeLength
+                        ? ArrayChangeSetRangeType.completeApartOfB
+                        : ArrayChangeSetRangeType.partOfApartOfB;
                 }
                 // cut the remaining segment entry
                 if (io_resultingSegment.flag === ArrayChangeSetRangeType.partOfApartOfB ||
@@ -739,13 +747,7 @@ const handleCombinations = function (in_segment, in_isPrimitiveType) {
                 }
                 case ArrayChangeSetIterator.types.REMOVE: {
                     // Attention: B removes A completely, kill A to avoid zero inserts
-                    let opBLen;
-                    if (isNumber(opB.operation[1])) {
-                        opBLen = opB.operation[1];
-                    }
-                    else {
-                        opBLen = opB.operation[1].length;
-                    }
+                    const opBLen = isNumber(opB.operation[1]) ? opB.operation[1] : opB.operation[1].length;
                     if (opBLen !== opA.operation[1].length) {
                         throw new Error("handleCombinations: insert-remove: unequal number of affected entries");
                     }
@@ -849,21 +851,27 @@ const arraysHaveSameValues = function (in_arr1, in_arr2) {
  *
  * We have to handle the conflicting rebase changes. The changes we do, are summarized in this table.
  * Other is the modified, rebased (on own) changeset.
+ *
+ * ```
  *                   BASE
  *                  /    \
  *                 /      \
  *               OWN      OTHER
+ * ```
  *
  * gets rebased to:
  *
+ * ```
  *                 BASE
  *                  /
  *               OWN
  *                  \
  *                OTHER
+ * ```
  *
  * conflict default behavior in ()
  *
+ * ```
  * -------|-----------------+------------------+------------------|
  *    \Own|    insert       |       modify     |     remove       |
  *     \  |                 |                  |                  |
@@ -882,6 +890,7 @@ const arraysHaveSameValues = function (in_arr1, in_arr2) {
  * remove | change          | change           | change           |
  *        | [rem orig. data]| (note the user)  | [rem dupl. rem]  |
  * -------|-----------------+------------------+------------------|
+ * ```
  *
  * @param {{opA:{}, opB:{}}} in_segment - The two ops to be combined
  * @param {Array.<property-changeset.ChangeSet.ConflictInfo>} out_conflicts - A list of paths that resulted in
@@ -966,20 +975,8 @@ const handleRebaseCombinations = function (in_segment, out_conflicts, in_basePat
                 }
                 case ArrayChangeSetIterator.types.REMOVE: {
                     // Remove already in A, no need to add the same again -> write nop
-                    let opBLen;
-                    let opALen;
-                    if (isNumber(opB.operation[1])) {
-                        opBLen = opB.operation[1];
-                    }
-                    else {
-                        opBLen = opB.operation[1].length;
-                    }
-                    if (isNumber(opA.operation[1])) {
-                        opALen = opA.operation[1];
-                    }
-                    else {
-                        opALen = opA.operation[1].length;
-                    }
+                    const opBLen = isNumber(opB.operation[1]) ? opB.operation[1] : opB.operation[1].length;
+                    const opALen = isNumber(opA.operation[1]) ? opA.operation[1] : opA.operation[1].length;
                     if (opBLen !== opALen) {
                         throw new Error("handleRebaseCombinations: remove-remove: unequal number of affected entries, " +
                             "this should never happen! Probably a bug in splitRange.");
@@ -1121,6 +1118,7 @@ const applyRebaseSegment = function (in_segment, io_changeset, in_currentIndexOf
         pushOp(in_segment.opB, io_changeset, in_currentIndexOffset, in_options);
     }
 };
+// eslint-disable-next-line @typescript-eslint/no-namespace
 export var ChangeSetArrayFunctions;
 (function (ChangeSetArrayFunctions) {
     /**
@@ -1384,21 +1382,27 @@ export var ChangeSetArrayFunctions;
      *
      * We have to handle the conflicting rebase changes. The changes we do, are summarized in this table.
      * Other is the modified, rebased (on own) changeset.
+     *
+     * ```
      *                   BASE
      *                  /    \
      *                 /      \
      *               OWN      OTHER
+     * ```
      *
      * gets rebased to:
      *
+     * ```
      *                 BASE
      *                  /
      *               OWN
      *                  \
      *                OTHER
+     * ```
      *
      * conflict default behavior in ()
      *
+     * ```
      * -------|-----------------+------------------+------------------|----------------|
      *    \Own|    insert       |       modify     |     remove       |   String set   |
      *     \  |                 |                  |                  |                |
@@ -1419,6 +1423,7 @@ export var ChangeSetArrayFunctions;
      *  set   |           'other's set overwrites whatever happend before              |
      *        |                 |                  |                  |                |
      * --------------------------------------------------------------------------------|
+     * ```
      *
      * @param in_ownPropertyChangeSet - The ChangeSet for the property stored in this object
      * @param io_rebasePropertyChangeSetParent - The Array containing the ChangeSet for the property to be rebased