@fluentui/react-menu 0.0.0-nightlycc44f3625c20211220.1 → 0.0.0-nightlye0b8e1fa6920220128.1

package/CHANGELOG.json

@@ -2,15 +2,15 @@
   "name": "@fluentui/react-menu",
   "entries": [
     {
-      "date": "Mon, 20 Dec 2021 04:17:51 GMT",
-      "tag": "@fluentui/react-menu_v0.0.0-nightlycc44f3625c20211220.1",
-      "version": "0.0.0-nightlycc44f3625c20211220.1",
+      "date": "Fri, 28 Jan 2022 04:13:21 GMT",
+      "tag": "@fluentui/react-menu_v0.0.0-nightlye0b8e1fa6920220128.1",
+      "version": "0.0.0-nightlye0b8e1fa6920220128.1",
       "comments": {
         "prerelease": [
           {
             "author": "email not defined",
             "package": "@fluentui/react-menu",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a",
             "comment": "Release nightly v9"
           },
           {
@@ -25,6 +25,36 @@
             "commit": "6ca0355f6740f836ff4df009687718a380085247",
             "comment": "fix: Focus on first menu item on click"
           },
+          {
+            "author": "lingfangao@hotmail.com",
+            "package": "@fluentui/react-menu",
+            "commit": "4f22b6dad04ea37eb53e4af23c73d2de4db512a2",
+            "comment": "fix: MenuTrigger should work correctly when `aria-disabled=\"true\"`"
+          },
+          {
+            "author": "lingfangao@hotmail.com",
+            "package": "@fluentui/react-menu",
+            "commit": "d2eb57808a403b70845a732a62b55aa64d66b2a0",
+            "comment": "Allow `MenuTrigger` to be wrapped by another trigger"
+          },
+          {
+            "author": "behowell@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "317209bb5cd57c40f35bc42060acb7e3cce5ec95",
+            "comment": "BREAKING: Rename component hooks add the suffix _unstable, as their API has not been finalized yet"
+          },
+          {
+            "author": "Humberto.Morimoto@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "38c8bed2c707014688ae2ae689033fa36ef23075",
+            "comment": "Updating packages based on changes to focusIndicator functions to remove functions from makeStyles in @fluentui/react-tabster."
+          },
+          {
+            "author": "behowell@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "7cc28ed8320b00f42d91c63882f10316db2205c5",
+            "comment": "Remove component's shorthandProps array"
+          },
           {
             "author": "olfedias@microsoft.com",
             "package": "@fluentui/react-menu",
@@ -37,85 +67,139 @@
             "commit": "4121754498bba5137f769295e2b7a2899f557278",
             "comment": "fix: Call `useCheckmarkStyles` in `useMenuItemStyles`"
           },
+          {
+            "author": "Humberto.Morimoto@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "e0b8e1fa6980077e7b311fd1c72c28d3e4305db0",
+            "comment": "Updating based on changes to composition types."
+          },
+          {
+            "author": "Humberto.Morimoto@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "6c32d0180e89674a46daf795de69e5dc6ca71ef7",
+            "comment": "Updating based on removal of functions from makeStyles."
+          },
+          {
+            "author": "Humberto.Morimoto@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "227e09f59026e2bd243422427d9e230d6aa892ca",
+            "comment": "Replacing use of functions in makeStyles with direct use of tokens."
+          },
+          {
+            "author": "olfedias@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "d8fe0da13e1d34028a51e5d740e7bdc78c3a6862",
+            "comment": "use Griffel packages"
+          },
+          {
+            "author": "behowell@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "23b8a6df449d6e76b90ae5ca9bd2285febdff222",
+            "comment": "Apply fontSize styling to icon slot"
+          },
           {
             "author": "ololubek@microsoft.com",
             "package": "@fluentui/react-menu",
-            "commit": "7cb2a5d8db1b6a1ddb638aa82d5815ab5ae84e69",
-            "comment": "(fix): Update react-icons dependency to latest version"
+            "commit": "63cbefe55e5db10eedbde19392aa8b6376d6a7f7",
+            "comment": "Update react-icons usage to resizable icons"
           },
           {
-            "author": "beachball",
+            "author": "lingfangao@hotmail.com",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/keyboard-keys to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "commit": "95a6a32cbffa9d86d6017cf8e0204d4b459ef370",
+            "comment": "feat: implement `MenuSplitGroup` component for split menu items"
           },
           {
-            "author": "beachball",
+            "author": "Humberto.Morimoto@microsoft.com",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-context-selector to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "commit": "00a5d945904c896a0664de6ba72c145a255f0848",
+            "comment": "Updating use of tokens.fontWeight now that we don't need to use casting."
           },
           {
-            "author": "beachball",
+            "author": "ololubek@microsoft.com",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-make-styles to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "commit": "7cb2a5d8db1b6a1ddb638aa82d5815ab5ae84e69",
+            "comment": "(fix): Update react-icons dependency to latest version"
+          },
+          {
+            "author": "lingfangao@hotmail.com",
+            "package": "@fluentui/react-menu",
+            "commit": "07d9ed6d1b436b7ca9571c94fbb0bcbdb080f235",
+            "comment": "breaking: MenuTrigger must be the first child of the `Menu`"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-portal to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/keyboard-keys to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-positioning to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/react-context-selector to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-shared-contexts to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/react-portal to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-tabster to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/react-positioning to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-utilities to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/react-shared-contexts to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/babel-make-styles to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/react-tabster to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/jest-serializer-make-styles to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/react-utilities to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           },
           {
             "author": "beachball",
             "package": "@fluentui/react-menu",
-            "comment": "Bump @fluentui/react-conformance-make-styles to v0.0.0-nightlycc44f3625c20211220.1",
-            "commit": "0839b0d96424e04706bd895d731d371acd3baaf5"
+            "comment": "Bump @fluentui/react-conformance-griffel to v0.0.0-nightlye0b8e1fa6920220128.1",
+            "commit": "90d10ec8c2d159575962c4d3d913317633b44a7a"
           }
         ],
         "none": [
+          {
+            "author": "email not defined",
+            "package": "@fluentui/react-menu",
+            "commit": "97752a0e494875c4dc22b268030d7d5e51b19211",
+            "comment": "Add workaround for cypress bug"
+          },
+          {
+            "author": "olfedias@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "c061e98be4b4a718c72a144a1f60bb5515824612",
+            "comment": "remove inline-style-expand-shorthand from tsconfigs"
+          },
           {
             "author": "elcraig@microsoft.com",
             "package": "@fluentui/react-menu",
             "commit": "3360b45ec159250b1346c91afad7dce138e6bc20",
             "comment": "Update API file to version generated by typescript 4.3"
+          },
+          {
+            "author": "martinhochel@microsoft.com",
+            "package": "@fluentui/react-menu",
+            "commit": "8dfa712156b70414205b87b5b6d099367b0c297d",
+            "comment": "chore: use storybook runner for all vNext packages"
           }
         ]
       }

package/CHANGELOG.md

@@ -1,33 +1,44 @@
 # Change Log - @fluentui/react-menu
 
-This log was last generated on Mon, 20 Dec 2021 04:17:51 GMT and should not be manually modified.
+This log was last generated on Fri, 28 Jan 2022 04:13:21 GMT and should not be manually modified.
 
 <!-- Start content -->
 
-## [0.0.0-nightlycc44f3625c20211220.1](https://github.com/microsoft/fluentui/tree/@fluentui/react-menu_v0.0.0-nightlycc44f3625c20211220.1)
+## [0.0.0-nightlye0b8e1fa6920220128.1](https://github.com/microsoft/fluentui/tree/@fluentui/react-menu_v0.0.0-nightlye0b8e1fa6920220128.1)
 
-Mon, 20 Dec 2021 04:17:51 GMT 
-[Compare changes](https://github.com/microsoft/fluentui/compare/@fluentui/react-menu_v9.0.0-beta.5..@fluentui/react-menu_v0.0.0-nightlycc44f3625c20211220.1)
+Fri, 28 Jan 2022 04:13:21 GMT 
+[Compare changes](https://github.com/microsoft/fluentui/compare/@fluentui/react-menu_v9.0.0-beta.5..@fluentui/react-menu_v0.0.0-nightlye0b8e1fa6920220128.1)
 
 ### Changes
 
-- Release nightly v9 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by email not defined)
+- Release nightly v9 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by email not defined)
 - fix: set `aria-expanded` and `aria-haspopup` values correctly ([PR #20957](https://github.com/microsoft/fluentui/pull/20957) by lingfangao@hotmail.com)
 - fix: Focus on first menu item on click ([PR #20955](https://github.com/microsoft/fluentui/pull/20955) by lingfangao@hotmail.com)
+- fix: MenuTrigger should work correctly when `aria-disabled="true"` ([PR #21349](https://github.com/microsoft/fluentui/pull/21349) by lingfangao@hotmail.com)
+- Allow `MenuTrigger` to be wrapped by another trigger ([PR #21225](https://github.com/microsoft/fluentui/pull/21225) by lingfangao@hotmail.com)
+- BREAKING: Rename component hooks add the suffix _unstable, as their API has not been finalized yet ([PR #21365](https://github.com/microsoft/fluentui/pull/21365) by behowell@microsoft.com)
+- Updating packages based on changes to focusIndicator functions to remove functions from makeStyles in @fluentui/react-tabster. ([PR #21035](https://github.com/microsoft/fluentui/pull/21035) by Humberto.Morimoto@microsoft.com)
+- Remove component's shorthandProps array ([PR #21134](https://github.com/microsoft/fluentui/pull/21134) by behowell@microsoft.com)
 - update styles to not use CSS shorthands ([PR #20820](https://github.com/microsoft/fluentui/pull/20820) by olfedias@microsoft.com)
 - fix: Call `useCheckmarkStyles` in `useMenuItemStyles` ([PR #20956](https://github.com/microsoft/fluentui/pull/20956) by lingfangao@hotmail.com)
+- Updating based on changes to composition types. ([PR #20891](https://github.com/microsoft/fluentui/pull/20891) by Humberto.Morimoto@microsoft.com)
+- Updating based on removal of functions from makeStyles. ([PR #21239](https://github.com/microsoft/fluentui/pull/21239) by Humberto.Morimoto@microsoft.com)
+- Replacing use of functions in makeStyles with direct use of tokens. ([PR #21048](https://github.com/microsoft/fluentui/pull/21048) by Humberto.Morimoto@microsoft.com)
+- use Griffel packages ([PR #21391](https://github.com/microsoft/fluentui/pull/21391) by olfedias@microsoft.com)
+- Apply fontSize styling to icon slot ([PR #21222](https://github.com/microsoft/fluentui/pull/21222) by behowell@microsoft.com)
+- Update react-icons usage to resizable icons ([PR #21074](https://github.com/microsoft/fluentui/pull/21074) by ololubek@microsoft.com)
+- feat: implement `MenuSplitGroup` component for split menu items ([PR #21095](https://github.com/microsoft/fluentui/pull/21095) by lingfangao@hotmail.com)
+- Updating use of tokens.fontWeight now that we don't need to use casting. ([PR #21217](https://github.com/microsoft/fluentui/pull/21217) by Humberto.Morimoto@microsoft.com)
 - (fix): Update react-icons dependency to latest version ([PR #20943](https://github.com/microsoft/fluentui/pull/20943) by ololubek@microsoft.com)
-- Bump @fluentui/keyboard-keys to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-context-selector to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-make-styles to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-portal to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-positioning to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-shared-contexts to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-tabster to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-utilities to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/babel-make-styles to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/jest-serializer-make-styles to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
-- Bump @fluentui/react-conformance-make-styles to v0.0.0-nightlycc44f3625c20211220.1 ([commit](https://github.com/microsoft/fluentui/commit/0839b0d96424e04706bd895d731d371acd3baaf5) by beachball)
+- breaking: MenuTrigger must be the first child of the `Menu` ([PR #21096](https://github.com/microsoft/fluentui/pull/21096) by lingfangao@hotmail.com)
+- Bump @fluentui/keyboard-keys to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
+- Bump @fluentui/react-context-selector to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
+- Bump @fluentui/react-portal to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
+- Bump @fluentui/react-positioning to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
+- Bump @fluentui/react-shared-contexts to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
+- Bump @fluentui/react-tabster to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
+- Bump @fluentui/react-utilities to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
+- Bump @fluentui/react-conformance-griffel to v0.0.0-nightlye0b8e1fa6920220128.1 ([commit](https://github.com/microsoft/fluentui/commit/90d10ec8c2d159575962c4d3d913317633b44a7a) by beachball)
 
 ## [9.0.0-beta.5](https://github.com/microsoft/fluentui/tree/@fluentui/react-menu_v9.0.0-beta.5)
 

package/Spec.md

@@ -619,7 +619,7 @@ const menu = (
 
 ```html
 <!-- expected DOM output  -->
-<button aria-haspopup="true" aria-expanded="true" id="trigger">Open menu</button>
+<button aria-haspopup="menu" aria-expanded="true" id="trigger">Open menu</button>
 <div role="menu" aria-labelledby="trigger">
   <div role="menuitem" tabindex="0">Option 1</div>
   <div role="menuitem" tabindex="-1">Option 2</div>
@@ -644,7 +644,7 @@ const menu = (
 
 ```html
 <!-- expected DOM output  -->
-<button aria-haspopup="true" aria-expanded="true" id="trigger">Open menu</button>
+<button aria-haspopup="menu" aria-expanded="true" id="trigger">Open menu</button>
 <div role="menu" aria-labelledby="trigger">
   <div role="menuitem" tabindex="0">
     <span role="presentation"><svg>FileIcon</svg></span>
@@ -682,7 +682,7 @@ const menu = (
 
 ```html
 <!-- expected DOM output  -->
-<button aria-haspopup="true" aria-expanded="true" id="trigger">Open menu</button>
+<button aria-haspopup="menu" aria-expanded="true" id="trigger">Open menu</button>
 <div role="menu" aria-labelledby="trigger">
   <div role="menuitem" tabindex="0">Option 1</div>
   <div role="separator" aria-hidden="true"></div>
@@ -719,7 +719,7 @@ const menu = (
 
 ```html
 <!-- expected DOM output  -->
-<button aria-haspopup="true" aria-expanded="true" id="trigger">Open menu</button>
+<button aria-haspopup="menu" aria-expanded="true" id="trigger">Open menu</button>
 <div role="menu" aria-labelledby="trigger">
   <div role="menuitem" tabindex="0">Option 1</div>
   <div role="separator" aria-hidden="true"></div>
@@ -758,10 +758,10 @@ const menu = (
 
 ```html
 <!-- expected DOM output  -->
-<button aria-haspopup="true" aria-expanded="true" id="trigger">Open menu</button>
+<button aria-haspopup="menu" aria-expanded="true" id="trigger">Open menu</button>
 <div role="menu" aria-labelledby="trigger">
   <div role="menuitem" tabindex="0">Option 1</div>
-  <div role="menuitem" tabindex="-1" aria-haspopup="true" aria-expanded="false" id="submenu-trigger">Open submenu</div>
+  <div role="menuitem" tabindex="-1" aria-haspopup="menu" aria-expanded="false" id="submenu-trigger">Open submenu</div>
 </div>
 
 <!-- expected DOM output for submenu  -->
@@ -843,7 +843,7 @@ const menuSelectableSections = (
 ```
 
 ```html
-<button aria-haspopup="true" aria-expanded="true" id="trigger">Open menu</button>
+<button aria-haspopup="menu" aria-expanded="true" id="trigger">Open menu</button>
 
 <!-- expected DOM output for basic checkbox  -->
 <div role="menu" aria-labelledby="trigger">
@@ -882,9 +882,12 @@ const menuSplitbutton= (
     <MenuList>
       <MenuItem>Option 1</MenuItem>
       <Menu>
-        <MenuTrigger>
-          <MenuItemSplit></MenuItemSplit>
-        </MenuTrigger>
+        <MenuSplitGroup>
+          <MenuItem>Main action</MenuItem>
+          <MenuTrigger>
+            <MenuItem />
+          </MenuTrigger>
+        </MenuSplitGroup>
         <MenuItem>Option 1</MenuItem>
         <MenuItem>Option 2</MenuItem>
         <MenuItem>Option 3</MenuItem>
@@ -897,7 +900,7 @@ const menuSplitbutton= (
 ```html
 <div role="menu" aria-labelledby="trigger">
   <div role="menuitem" tabindex="0">Option 1</div>
-  <div role="menuitem" tabindex="-1" aria-haspopup="true" aria-expanded="false" id="submenu-trigger">Open submenu</div>
+  <div role="menuitem" tabindex="-1" aria-haspopup="menu" aria-expanded="false" id="submenu-trigger">Open submenu</div>
 </div>
 
 <!-- expected DOM output  -->
@@ -905,7 +908,7 @@ const menuSplitbutton= (
   <div role="menuitem" tabindex="0">Option 1</div>
   <div role="group">
     <div role="menuitem" tabindex="-1">content slot</div>
-    <div role="menuitem" tabindex="-1" aria-haspopup="true" aria-expanded="false" id="submenu-trgger">
+    <div role="menuitem" tabindex="-1" aria-haspopup="menu" aria-expanded="false" id="submenu-trgger">
       <svg>indicator icon</svg>
     </div>
   </div>
@@ -958,11 +961,13 @@ Below is a set of diagrams that tries to illustrates all the interactions menus
 
 All of the above Mouse events seen previously should apply to the part of the split button that is intended to open a submenu.
 
-Once the submenu is open, the same behavior as in the [previous section](#submenu-trigger/navigation) applies with the exception of returning focus to the splitbutton, which is shown in the images below.
-
-![Using up/down arrow key](./etc/images/splitbutton-up-down.jpg)
+> TODO convert these diagrams to excalidraw or smth that is text format
+> TODO add extra descriptions to diagrams
 
-![Using left/right arrow key](./etc/images/splitbutton-left-right.jpg)
+<img src="./etc/images/menu-interactions/Slide19.PNG" width="700" />
+<img src="./etc/images/menu-interactions/Slide20.PNG" width="700" />
+<img src="./etc/images/menu-interactions/Slide21.PNG" width="700" />
+<img src="./etc/images/menu-interactions/Slide22.PNG" width="700" />
 
 ### MenuItem selection