@flowdrop/flowdrop 2.0.0-beta.3 → 2.0.0-beta.4

package/dist/utils/connections.js

@@ -253,8 +253,17 @@ export function getConnectionSuggestions(checker, nodeId, nodes, nodeTypes) {
  * @returns True if any cycle exists in the workflow
  */
 export function hasCycles(nodes, edges) {
-    // Build adjacency map once (O(E)) so the DFS inner loop is O(1) per lookup
-    // instead of scanning all edges on every recursive call (which was O(V*E)).
+    return detectCycles(nodes, edges);
+}
+/**
+ * Detect whether a directed graph contains a cycle, using DFS over a pre-built
+ * adjacency map (O(E) build, O(1) per neighbour lookup — avoids the O(V*E) of
+ * re-scanning every edge on each recursive call).
+ *
+ * Shared by `hasCycles` (all edges) and `hasInvalidCycles` (loopback edges
+ * pre-filtered out by the caller).
+ */
+function detectCycles(nodes, edges) {
     const adjacencyMap = new Map();
     for (const node of nodes) {
         adjacencyMap.set(node.id, []);
@@ -274,7 +283,6 @@ export function hasCycles(nodes, edges) {
             return false;
         visited.add(nodeId);
         recursionStack.add(nodeId);
-        // Use pre-built adjacency map instead of filtering all edges each call
         const neighbors = adjacencyMap.get(nodeId) || [];
         for (const target of neighbors) {
             if (hasCycleUtil(target))
@@ -283,7 +291,6 @@ export function hasCycles(nodes, edges) {
         recursionStack.delete(nodeId);
         return false;
     }
-    // Check each node
     for (const node of nodes) {
         if (!visited.has(node.id)) {
             if (hasCycleUtil(node.id))
@@ -309,53 +316,10 @@ export function hasCycles(nodes, edges) {
  * ```
  */
 export function hasInvalidCycles(nodes, edges) {
-    // Filter out loopback edges - these create valid cycles for loop iteration
+    // Filter out loopback edges - these create valid cycles for loop iteration,
+    // then reuse the shared detector over the remaining edges.
     const nonLoopbackEdges = edges.filter((edge) => !isLoopbackEdge(edge));
-    // Build adjacency map from non-loopback edges once (O(E)) so the DFS inner
-    // loop is O(1) per lookup instead of scanning all edges on every recursive
-    // call (which was O(V*E)).
-    const adjacencyMap = new Map();
-    for (const node of nodes) {
-        adjacencyMap.set(node.id, []);
-    }
-    for (const edge of nonLoopbackEdges) {
-        const neighbors = adjacencyMap.get(edge.source);
-        if (neighbors) {
-            neighbors.push(edge.target);
-        }
-    }
-    // Check for cycles using only non-loopback edges
-    const visited = new Set();
-    const recursionStack = new Set();
-    /**
-     * DFS utility to detect cycles in the graph
-     * @param nodeId - Current node being visited
-     * @returns True if a cycle is found from this node
-     */
-    function hasCycleUtil(nodeId) {
-        if (recursionStack.has(nodeId))
-            return true;
-        if (visited.has(nodeId))
-            return false;
-        visited.add(nodeId);
-        recursionStack.add(nodeId);
-        // Use pre-built adjacency map instead of filtering all edges each call
-        const neighbors = adjacencyMap.get(nodeId) || [];
-        for (const target of neighbors) {
-            if (hasCycleUtil(target))
-                return true;
-        }
-        recursionStack.delete(nodeId);
-        return false;
-    }
-    // Check each node for cycles
-    for (const node of nodes) {
-        if (!visited.has(node.id)) {
-            if (hasCycleUtil(node.id))
-                return true;
-        }
-    }
-    return false;
+    return detectCycles(nodes, nonLoopbackEdges);
 }
 /**
  * Get the execution order for a workflow (topological sort)

package/package.json

@@ -3,7 +3,7 @@
   "description": "A drop-in visual workflow editor for any web application. You own the backend. You own the data. You own the orchestration.",
   "license": "MIT",
   "private": false,
-  "version": "2.0.0-beta.3",
+  "version": "2.0.0-beta.4",
   "author": "Shibin Das (D34dMan)",
   "bugs": {
     "url": "https://github.com/flowdrop-io/flowdrop/issues"