@flow-scanner/lightning-flow-scanner-core 6.17.1 → 6.17.3

package/{out/main → main}/models/FlowGraph.js

@@ -110,6 +110,15 @@ let FlowGraph = class FlowGraph {
         }, this.nodeMap, this.allConnectors);
     }
     /**
+   * Compute which elements are reachable from start using ONLY normal connectors (not fault connectors).
+   * Elements that are reachable overall but NOT reachable via normal connectors are part of fault handling.
+   */ computeNormalReachability(startReference) {
+        const compiler = new _Compiler.Compiler();
+        compiler.traverseFlow(startReference, (element)=>{
+            this.normalReachableFromStart.add(element.name);
+        }, this.nodeMap, this.normalConnectors);
+    }
+    /**
    * Use Compiler to compute which elements are inside loops.
    * Calls Compiler.traverseFlow() for each loop with endElementName.
    */ computeLoopBoundaries() {
@@ -167,13 +176,13 @@ let FlowGraph = class FlowGraph {
     getNode(elementName) {
         return this.nodeMap.get(elementName);
     }
-    isPartOfFaultHandling(elementName) {
-        const previous = this.getPreviousElements(elementName);
-        return previous.some((prev)=>{
-            const faultTargets = this.faultConnectors.get(prev);
-            var _faultTargets_has;
-            return (_faultTargets_has = faultTargets === null || faultTargets === void 0 ? void 0 : faultTargets.has(elementName)) !== null && _faultTargets_has !== void 0 ? _faultTargets_has : false;
-        });
+    /**
+   * Check if an element is part of fault handling flow.
+   * An element is part of fault handling if it's only reachable through fault paths
+   * (i.e., reachable overall but NOT reachable via normal connectors from START).
+   */ isPartOfFaultHandling(elementName) {
+        // Element is part of fault handling if it's reachable but NOT reachable via normal paths
+        return this.reachableFromStart.has(elementName) && !this.normalReachableFromStart.has(elementName);
     }
     getLoopNodes() {
         return Array.from(this.nodeMap.values()).filter((n)=>n.subtype === "loops");
@@ -508,6 +517,7 @@ let FlowGraph = class FlowGraph {
         _define_property(this, "nodeMap", new Map());
         // Pre-computed sets for common queries (built using Compiler)
         _define_property(this, "reachableFromStart", new Set());
+        _define_property(this, "normalReachableFromStart", new Set()); // Elements reachable via normal (non-fault) connectors only
         _define_property(this, "elementsInLoop", new Map()); // element -> loop name
         // Connector metadata (extracted during node processing)
         _define_property(this, "faultConnectors", new Map());
@@ -527,6 +537,7 @@ let FlowGraph = class FlowGraph {
         this.computeLoopBoundaries();
         if (startReference) {
             this.computeReachability(startReference);
+            this.computeNormalReachability(startReference);
         }
     }
 };

package/{out/main → main}/rules/MissingRecordTriggerFilter.js

@@ -66,11 +66,13 @@ let MissingRecordTriggerFilter = class MissingRecordTriggerFilter extends _RuleC
         }
         // Check if the flow has filters or entry conditions at the flow level
         const filters = this.getStartProperty(flow, 'filters');
+        const filterFormula = this.getStartProperty(flow, 'filterFormula');
         const hasFilters = !!filters;
+        const hasFilterFormula = !!filterFormula;
         const scheduledPaths = (_flow_xmldata = flow.xmldata) === null || _flow_xmldata === void 0 ? void 0 : (_flow_xmldata_start = _flow_xmldata.start) === null || _flow_xmldata_start === void 0 ? void 0 : _flow_xmldata_start.scheduledPaths;
         const hasScheduledPaths = !!scheduledPaths;
-        // If no filters or scheduled paths (which have their own conditions), flag as violation
-        if (!hasFilters && !hasScheduledPaths) {
+        // If no filters, formula conditions, or scheduled paths (which have their own conditions), flag as violation
+        if (!hasFilters && !hasFilterFormula && !hasScheduledPaths) {
             violations.push(new _internals.Violation(new _internals.FlowAttribute(triggerType, "triggerType", "autolaunched && triggerType")));
         }
         return violations;

package/package.json

@@ -1,14 +1,13 @@
 {
   "name": "@flow-scanner/lightning-flow-scanner-core",
   "description": "A lightweight engine for Flow metadata in Node.js, and browser environments. Assess and enhance Salesforce Flow automations for best practices, security, governor limits, and performance issues.",
-  "version": "6.17.1",
-  "main": "out/index.js",
+  "version": "6.17.3",
+  "main": "index.js",
   "exports": {
     ".": {
-      "types": "./out/index.d.ts",
-      "import": "./out/index.js",
-      "require": "./out/index.js",
-      "default": "./out/index.js"
+      "import": "./index.js",
+      "require": "./index.js",
+      "types": "./index.d.ts"
     }
   },
   "engines": {
@@ -21,35 +20,8 @@
     "directory": "packages/core"
   },
   "dependencies": {
-    "fast-xml-parser": "^5.3.0",
-    "@flow-scanner/regex-scanner": "1.0.0"
-  },
-  "devDependencies": {
-    "@jest/types": "30.0.1",
-    "@swc-node/jest": "1.9.1",
-    "@swc/cli": "0.7.7",
-    "@swc/core": "1.13.5",
-    "@swc/helpers": "0.5.17",
-    "@types/jest": "29.5.14",
-    "@types/node": "22.15.30",
-    "@types/semantic-release": "20.0.6",
-    "cross-env": "^10.1.0",
-    "eslint": "9.30.0",
-    "eslint-plugin-de-morgan": "1.3.0",
-    "eslint-plugin-github": "6.0.0",
-    "eslint-plugin-jest": "29.0.1",
-    "eslint-plugin-perfectionist": "4.15.0",
-    "eslint-plugin-sonarjs": "3.0.4",
-    "husky": "9.1.7",
-    "jest": "30.0.3",
-    "lint-staged": "^16.1.2",
-    "prettier": "3.6.2",
-    "rimraf": "^6.1.0",
-    "ts-node": "10.9.2",
-    "typescript": "5.8.3",
-    "typescript-eslint": "8.35.0",
-    "vite": "6.4.1",
-    "vite-plugin-node-polyfills": "0.23.0"
+    "@flow-scanner/regex-scanner": "1.0.0",
+    "fast-xml-parser": "^5.3.0"
   },
   "homepage": "https://flow-scanner.github.io/lightning-flow-scanner/",
   "author": {
@@ -68,26 +40,5 @@
     "security-scanner",
     "static-analysis"
   ],
-  "scripts": {
-    "clean": "rimraf out dist",
-    "build:js": "swc src --out-dir out --copy-files --strip-leading-paths --config-file .swcrc",
-    "build:types": "tsc -p tsconfig.types.json --declaration --emitDeclarationOnly --outDir out",
-    "prepare:publish": "node ../../.github/scripts/prepare-publish.js",
-    "copy:root-files:dist": "node -e \"['../../LICENSE.md'].forEach(f => { const n = f.split('/').pop(); if (require('fs').existsSync(f)) require('fs').copyFileSync(f, 'dist/'+n) })\"",
-    "____main____": "__DEVELOPER COMMANDS__",
-    "build": "npm run clean && npm run build:js && npm run build:types",
-    "test": "npm run test:umd",
-    "test:node": "jest",
-    "test:umd": "npm run build:js && vite build && npm run copy:root-files:dist && cross-env UMD_PATH=dist/lightning-flow-scanner-core.umd.js jest",
-    "link": "npm run build && npm link ./out",
-    "____pack____": "PACKAGING COMMANDS__",
-    "swc:sim:pack": "npm run build",
-    "vite:dist": "npm run build:js && vite build && npm run copy:root-files:dist",
-    "stryker": "npm i -g @stryker-mutator/core @stryker-mutator/jest-runner && stryker run",
-    "version:patch": "pnpm version patch --no-git-tag-version",
-    "version:minor": "pnpm version minor --no-git-tag-version",
-    "version:major": "pnpm version major --no-git-tag-version",
-    "publish:npm": "npm run build && npm run prepare:publish && cd out && npm publish",
-    "tag": "node ../../scripts/publish-core-tag.js"
-  }
-}
+  "types": "index.d.ts"
+}

package/.husky/pre-commit

@@ -1 +0,0 @@
-npm run precommit

package/.husky/pre-push

@@ -1 +0,0 @@
-npm run prepush

package/.prettierignore

@@ -1,5 +0,0 @@
-example-flows/**
-out/**
-tests/**/*.test.ts
-jest.config.ts
-vite.config.ts

package/.swcrc

@@ -1,26 +0,0 @@
-{
-  "$schema": "https://swc.rs/schema.json",
-  "sourceMaps": false,
-  "module": {
-    "type": "commonjs",
-    "strictMode": true,
-    "noInterop": false,
-    "resolveFully": true
-  },
-  "jsc": {
-    "externalHelpers": false,
-    "target": "es2015",
-    "parser": {
-      "syntax": "typescript",
-      "tsx": true,
-      "decorators": true,
-      "dynamicImport": true
-    },
-    "transform": {
-      "legacyDecorator": true,
-      "decoratorMetadata": false
-    },
-    "keepClassNames": true
-  },
-  "minify": false  // Disable for now; re-enable post-debug if needed for smaller JS
-}

package/.turbo/turbo-build.log

@@ -1,17 +0,0 @@
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.1 build C:\Users\Ruben\Documents\GitHub\lightning-flow-scanner-fresh\packages\core
-> npm run clean && npm run build:js && npm run build:types
-
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.1 clean
-> rimraf out dist
-
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.1 build:js
-> swc src --out-dir out --copy-files --strip-leading-paths --config-file .swcrc
-
-Successfully compiled: 68 files with swc (250.78ms)
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.1 build:types
-> tsc -p tsconfig.types.json --declaration --emitDeclarationOnly --outDir out
-

package/.turbo/turbo-test.log

@@ -1,144 +0,0 @@
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.0 test C:\Users\Ruben\Documents\GitHub\lightning-flow-scanner-fresh\packages\core
-> npm run test:umd
-
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.0 test:umd
-> npm run build:js && vite build && npm run copy:root-files:dist && cross-env UMD_PATH=dist/lightning-flow-scanner-core.umd.js jest
-
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.0 build:js
-> swc src --out-dir out --copy-files --strip-leading-paths --config-file .swcrc
-
-Successfully compiled: 68 files with swc (151.24ms)
-vite v6.4.1 building for production...
-transforming...
-✓ 78 modules transformed.
-rendering chunks...
-computing gzip size...
-dist/lightning-flow-scanner-core.umd.js  79.73 kB │ gzip: 23.47 kB
-dist/lightning-flow-scanner-core.js  79.63 kB │ gzip: 23.36 kB
-✓ built in 762ms
-
-> @flow-scanner/lightning-flow-scanner-core@6.17.0 copy:root-files:dist
-> node -e "['../../LICENSE.md'].forEach(f => { const n = f.split('/').pop(); if (require('fs').existsSync(f)) require('fs').copyFileSync(f, 'dist/'+n) })"
-
-PASS tests/HardcodedUrl.test.ts (6.032 s)
-PASS tests/MissingMetadataDescription.test.ts (6.066 s)
-PASS tests/MissingNullHandler.test.ts (6.103 s)
-PASS tests/HardcodedSecret.test.ts (6.1 s)
-PASS tests/AutoLayout.test.ts (6.106 s)
-PASS tests/FlowDocumentation.test.ts (6.121 s)
-PASS tests/FlowDescription.test.ts (6.131 s)
-PASS tests/UnusedVariable.test.ts (6.131 s)
-PASS tests/RecordIdAsString.test.ts (6.141 s)
-PASS tests/UnusedVariableExceptions.test.ts (6.152 s)
-PASS tests/CyclomaticComplexity.test.ts (6.156 s)
-PASS tests/APIVersion.test.ts
-PASS tests/DuplicateDMLOperation.test.ts
-PASS tests/Config.test.ts
-PASS tests/EnabledFalse.test.ts
-PASS tests/RecursiveAfterUpdate.test.ts
-PASS tests/CopyAPIName.test.ts
-PASS tests/SanityTest.test.ts
-PASS tests/TransformInsteadOfLoop.test.ts
-PASS tests/UnconnectedElement.test.ts
-PASS tests/SameRecordFieldUpdates.test.ts
-PASS tests/GetRecordElementAllFields.test.ts
-PASS tests/ConfigBetaMode.test.ts
-PASS tests/models/Flow.test.ts
-PASS tests/HardcodedId.test.ts
-PASS tests/Exceptions.test.ts
-PASS tests/SOQLQueryInLoop.test.ts
-PASS tests/FlowName.test.ts
-PASS tests/ExportSarif.test.ts
-PASS tests/MissingFaultPath.test.ts
-PASS tests/InactiveFlow.test.ts
-PASS tests/TriggerOrder.test.ts
-PASS tests/MissingRecordTriggerFilter.test.ts
-PASS tests/models/LoopRuleCommon.test.ts
-PASS tests/UnsafeRunningContext.test.ts
-PASS tests/models/RuleCommon.test.ts
-PASS tests/DMLStatementInLoop.test.ts
---------------------------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------
-File                            | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                                                                                 
---------------------------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------
-All files                       |   89.03 |     81.7 |   79.23 |   89.03 |                                                                                                                                                                   
- src                            |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  index.ts                      |     100 |      100 |     100 |     100 |                                                                                                                                                                   
- src/main/adapters              |   91.83 |    85.71 |      80 |   91.83 |                                                                                                                                                                   
-  RegexAdapter.ts               |   91.83 |    85.71 |      80 |   91.83 | 84-91                                                                                                                                                             
- src/main/config                |   80.46 |       90 |   44.44 |   80.46 |                                                                                                                                                                   
-  NodeIcons.ts                  |   97.95 |      100 |       0 |   97.95 | 97-98                                                                                                                                                             
-  RuleRegistry.ts               |   66.48 |       90 |   57.14 |   66.48 | 81-82,87-88,93-137,140-153                                                                                                                                        
-  VariableIcons.ts              |   96.49 |      100 |       0 |   96.49 | 56-57                                                                                                                                                             
- src/main/enums                 |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  MetadataTypes.ts              |     100 |      100 |     100 |     100 |                                                                                                                                                                   
- src/main/interfaces            |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  IRulesConfig.ts               |     100 |      100 |     100 |     100 |                                                                                                                                                                   
- src/main/internals             |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  internals.ts                  |     100 |      100 |     100 |     100 |                                                                                                                                                                   
- src/main/libs                  |   87.73 |    84.52 |    90.9 |   87.73 |                                                                                                                                                                   
-  BuildFlow.ts                  |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  Compiler.ts                   |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  ExportDetails.ts              |    6.89 |      100 |       0 |    6.89 | 5-58                                                                                                                                                              
-  ExportDiagram.ts              |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  ExportSarif.ts                |   86.95 |    43.47 |     100 |   86.95 | 63-74                                                                                                                                                             
-  FixFlows.ts                   |   98.36 |    81.81 |     100 |   98.36 | 55                                                                                                                                                                
-  GetRuleDefinitions.ts         |   92.18 |      100 |      50 |   92.18 | 60-64                                                                                                                                                             
-  ParseFlows.ts                 |     100 |       80 |     100 |     100 | 29                                                                                                                                                                
-  RuleDocumentation.ts          |   94.28 |    66.66 |     100 |   94.28 | 30-31                                                                                                                                                             
-  ScanFlows.ts                  |   97.18 |    88.88 |     100 |   97.18 | 44-45,95,103                                                                                                                                                      
- src/main/models                |   84.19 |    75.82 |   67.44 |   84.19 |                                                                                                                                                                   
-  Flow.ts                       |   93.84 |    79.66 |      90 |   93.84 | 137,147-148,152-153,159-160,185,200-201,233-236,262-263,295-298                                                                                                   
-  FlowAttribute.ts              |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  FlowElement.ts                |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  FlowElementConnector.ts       |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  FlowGraph.ts                  |   80.75 |    67.41 |   73.52 |   80.75 | 33-35,75-90,159-160,167-168,171-172,185-187,190-191,198-199,247-248,284-285,292-301,343-344,350-351,363-364,375-383,452-458,462-463,472-476,503-529               
-  FlowMetadata.ts               |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  FlowNode.ts                   |   78.71 |    70.11 |      60 |   78.71 | 64-65,71-72,78-79,116-118,121-122,152-154,160-161,164-165,168-169,172-173,176-177,193-196,203-204,233-237,246-255,324-343,353-359,370-371,373-374,377-379,385-388 
-  FlowResource.ts               |      75 |      100 |       0 |      75 | 6-7                                                                                                                                                               
-  FlowType.ts                   |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  FlowVariable.ts               |   57.96 |    33.33 |      10 |   57.96 | 38-39,45-46,52-53,68,70-71,78-79,85-91,97-105,111-121,127-149,152-156                                                                                             
-  LoopRuleCommon.ts             |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  ParsedFlow.ts                 |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  RuleCommon.ts                 |   86.66 |    85.71 |   42.85 |   86.66 | 33-34,50-51,66-67,77-78,88-89,100-105                                                                                                                             
-  RuleResult.ts                 |     100 |       75 |     100 |     100 | 19                                                                                                                                                                
-  ScanResult.ts                 |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  Violation.ts                  |     100 |    94.11 |     100 |     100 | 46                                                                                                                                                                
- src/main/rules                 |   96.11 |    86.27 |   96.72 |   96.11 |                                                                                                                                                                   
-  APIVersion.ts                 |   81.72 |    66.66 |     100 |   81.72 | 33-38,43-53                                                                                                                                                       
-  ActionCallsInLoop.ts          |      92 |      100 |      50 |      92 | 23-24                                                                                                                                                             
-  AutoLayout.ts                 |     100 |       90 |     100 |     100 | 38                                                                                                                                                                
-  CopyAPIName.ts                |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  CyclomaticComplexity.ts       |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  DMLStatementInLoop.ts         |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  DuplicateDMLOperation.ts      |     100 |    84.21 |     100 |     100 | 27,40-44                                                                                                                                                          
-  FlowDescription.ts            |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  FlowName.ts                   |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  GetRecordAllFields.ts         |     100 |    91.66 |     100 |     100 | 54                                                                                                                                                                
-  HardcodedId.ts                |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  HardcodedSecret.ts            |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  HardcodedUrl.ts               |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  InactiveFlow.ts               |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  MissingFaultPath.ts           |   96.19 |       96 |     100 |   96.19 | 41-44                                                                                                                                                             
-  MissingMetadataDescription.ts |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  MissingNullHandler.ts         |   84.12 |    52.94 |     100 |   84.12 | 42,52,56-60,74-77,96-97,101-102,106-107,110-112                                                                                                                   
-  MissingRecordTriggerFilter.ts |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  ProcessBuilder.ts             |   71.42 |      100 |      50 |   71.42 | 25-34                                                                                                                                                             
-  RecordIdAsString.ts           |   96.87 |     87.5 |     100 |   96.87 | 42-43                                                                                                                                                             
-  RecursiveAfterUpdate.ts       |   95.74 |       90 |     100 |   95.74 | 50-51,79-80                                                                                                                                                       
-  SOQLQueryInLoop.ts            |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  SameRecordFieldUpdates.ts     |     100 |    88.88 |     100 |     100 | 52                                                                                                                                                                
-  TransformInsteadOfLoop.ts     |   96.42 |       75 |     100 |   96.42 | 34-35                                                                                                                                                             
-  TriggerOrder.ts               |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  UnconnectedElement.ts         |     100 |     87.5 |     100 |     100 | 22                                                                                                                                                                
-  UnsafeRunningContext.ts       |     100 |      100 |     100 |     100 |                                                                                                                                                                   
-  UnusedVariable.ts             |     100 |    93.33 |     100 |     100 | 47                                                                                                                                                                
---------------------------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------
-
-Test Suites: 37 passed, 37 total
-Tests:       3 skipped, 129 passed, 132 total
-Snapshots:   0 total
-Time:        17.425 s
-Ran all test suites.

package/.turbo/turbo-vite$colon$dist.log

@@ -1,21 +0,0 @@
-
-> @flow-scanner/lightning-flow-scanner-core@6.11.1 vite:dist C:\Users\Ruben\Documents\GitHub\lightning-flow-scanner-fresh\packages\core
-> npm run build:js && vite build && npm run copy:root-files:dist
-
-
-> @flow-scanner/lightning-flow-scanner-core@6.11.1 build:js
-> swc src --out-dir out --copy-files --strip-leading-paths --config-file .swcrc
-
-Successfully compiled: 67 files with swc (146.69ms)
-vite v6.4.1 building for production...
-transforming...
-✓ 67 modules transformed.
-rendering chunks...
-computing gzip size...
-dist/lightning-flow-scanner-core.umd.js  62.13 kB │ gzip: 19.59 kB
-dist/lightning-flow-scanner-core.js  62.01 kB │ gzip: 19.48 kB
-✓ built in 610ms
-
-> @flow-scanner/lightning-flow-scanner-core@6.11.1 copy:root-files:dist
-> node -e "['../../LICENSE.md'].forEach(f => { const n = f.split('/').pop(); if (require('fs').existsSync(f)) require('fs').copyFileSync(f, 'dist/'+n) })"
-