@flow-scanner/lightning-flow-scanner-core 6.1.6 → 6.2.0

package/README.md

@@ -289,7 +289,7 @@ _Get SARIF output including exact line numbers of violations._
 
 ## Installation
 
-`lightning-flow-scanner-core` is published to **npm** and **scanned with Snyk during release**.
+`lightning-flow-scanner-core` is [scanned with Snyk](https://github.com/Flow-Scanner/lightning-flow-scanner-core?tab=security-ov-file) prior to publication on **npm**.
 
 [![npm version](https://img.shields.io/npm/v/@flow-scanner/lightning-flow-scanner-core?label=npm)](https://www.npmjs.com/package/@flow-scanner/lightning-flow-scanner-core) [![Known Vulnerabilities](https://snyk.io/test/github/Flow-Scanner/lightning-flow-scanner-core/badge.svg)](https://snyk.io/test/github/Flow-Scanner/lightning-flow-scanner-core)
 

package/SECURITY.md

@@ -3,9 +3,10 @@
 ## Security Practices
 
 - Code is open-source and peer-reviewed by the community.
-- Vulnerabilities can be reported privately via GitHub security features.
-- Changes to the repository are scanned and reviewed before merging.
-- Tokenless Publishing with scoped npm packages and releases via GitHub Actions Trusted Publishing (OIDC).
+- Vulnerabilities can be reported privately via [GitHub security reporting](https://github.com/Flow-Scanner/lightning-flow-scanner-core/security).
+- All changes are **scanned with Snyk** and reviewed before merging.
+- Releases are published to npm using **GitHub Actions Trusted Publishing (OIDC)**.
+- Tags (`v*`) trigger automated `npm publish`, providing a full audit trail.
 
 ## Reporting a Vulnerability
 

package/main/libs/FixFlows.js

@@ -16,8 +16,8 @@ _export(exports, {
         return fix;
     }
 });
-const _BuildFlow = require("./BuildFlow");
 const _internals = /*#__PURE__*/ _interop_require_wildcard(require("../internals/internals"));
+const _BuildFlow = require("./BuildFlow");
 function _getRequireWildcardCache(nodeInterop) {
     if (typeof WeakMap !== "function") return null;
     var cacheBabelInterop = new WeakMap();
@@ -62,49 +62,46 @@ function _interop_require_wildcard(obj, nodeInterop) {
 function fix(results) {
     const newResults = [];
     for (const result of results){
-        if (result.ruleResults && result.ruleResults.length > 0) {
-            const fixables = result.ruleResults.filter((r)=>r.ruleName === "UnusedVariable" && r.occurs || r.ruleName === "UnconnectedElement" && r.occurs // TODO: this should be rule.occurs && rule.ruleDefinition.fixable
-            );
-            if ((fixables === null || fixables === void 0 ? void 0 : fixables.length) > 0) {
-                const newFlow = FixFlows(result.flow, fixables);
-                result.flow = newFlow;
-                newResults.push(result);
-            }
+        if (!result.ruleResults || result.ruleResults.length === 0) continue;
+        const fixables = result.ruleResults.filter((r)=>r.ruleName === "UnusedVariable" && r.occurs || r.ruleName === "UnconnectedElement" && r.occurs);
+        if (fixables.length === 0) continue;
+        const newFlow = FixFlows(result.flow, fixables);
+        const hasRemainingElements = newFlow.elements && newFlow.elements.length > 0;
+        if (hasRemainingElements) {
+            result.flow = newFlow;
+            newResults.push(result);
         }
     }
     return newResults;
 }
 function FixFlows(flow, ruleResults) {
-    var _flow_elements;
-    // TODO: this should be defined on the rule
+    var _unusedVariableRes_details, _unconnectedElementsRes_details, _flow_elements;
     const unusedVariableRes = ruleResults.find((r)=>r.ruleName === "UnusedVariable");
-    const unusedVariableReferences = unusedVariableRes && unusedVariableRes.details && unusedVariableRes.details.length > 0 ? unusedVariableRes.details.map((d)=>d.name) : [];
+    var _unusedVariableRes_details_map;
+    const unusedVariableNames = new Set((_unusedVariableRes_details_map = unusedVariableRes === null || unusedVariableRes === void 0 ? void 0 : (_unusedVariableRes_details = unusedVariableRes.details) === null || _unusedVariableRes_details === void 0 ? void 0 : _unusedVariableRes_details.map((d)=>d.name)) !== null && _unusedVariableRes_details_map !== void 0 ? _unusedVariableRes_details_map : []);
     const unconnectedElementsRes = ruleResults.find((r)=>r.ruleName === "UnconnectedElement");
-    const unconnectedElementsReferences = unconnectedElementsRes && unconnectedElementsRes.details && unconnectedElementsRes.details.length > 0 ? unconnectedElementsRes.details.map((d)=>d.name) : [];
-    const nodesToBuild = (_flow_elements = flow.elements) === null || _flow_elements === void 0 ? void 0 : _flow_elements.filter((node)=>{
+    var _unconnectedElementsRes_details_map;
+    const unconnectedElementNames = new Set((_unconnectedElementsRes_details_map = unconnectedElementsRes === null || unconnectedElementsRes === void 0 ? void 0 : (_unconnectedElementsRes_details = unconnectedElementsRes.details) === null || _unconnectedElementsRes_details === void 0 ? void 0 : _unconnectedElementsRes_details.map((d)=>d.name)) !== null && _unconnectedElementsRes_details_map !== void 0 ? _unconnectedElementsRes_details_map : []);
+    var _flow_elements_filter;
+    const nodesToKeep = (_flow_elements_filter = (_flow_elements = flow.elements) === null || _flow_elements === void 0 ? void 0 : _flow_elements.filter((node)=>{
         switch(node.metaType){
-            case "variable":
-                {
-                    const nodeVar = node;
-                    if (!unusedVariableReferences.includes(nodeVar.name)) {
-                        return node;
-                    }
-                    break;
-                }
+            case "metadata":
+            case "resource":
+                return true;
             case "node":
                 {
                     const nodeElement = node;
-                    if (!unconnectedElementsReferences.includes(nodeElement.name)) {
-                        return node;
-                    }
-                    break;
+                    return !unconnectedElementNames.has(nodeElement.name);
                 }
-            case "metadata":
-            case "resource":
-                return node;
+            case "variable":
+                {
+                    const nodeVar = node;
+                    return !unusedVariableNames.has(nodeVar.name);
+                }
+            default:
+                return false;
         }
-    });
-    const xmldata = (0, _BuildFlow.BuildFlow)(nodesToBuild);
-    const newFlow = new _internals.Flow(flow.fsPath, xmldata);
-    return newFlow;
+    })) !== null && _flow_elements_filter !== void 0 ? _flow_elements_filter : [];
+    const xmldata = (0, _BuildFlow.BuildFlow)(nodesToKeep);
+    return new _internals.Flow(flow.fsPath, xmldata);
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@flow-scanner/lightning-flow-scanner-core",
   "description": "A lightweight, purpose-built engine for parsing and analyzing Salesforce Flow metadata in Node.js or browser environments. Scan, validate, and optimize Flow automations for security risks, best practices, governor limits, and performance bottlenecks.",
-  "version": "6.1.6",
+  "version": "6.2.0",
   "main": "index.js",
   "types": "index.d.ts",
   "engines": {