@floomhq/signaldash 0.13.0 → 0.27.0

package/lib/cli.js

@@ -1,7 +1,8 @@
 import { createInterface } from "node:readline/promises";
-import { chmod, mkdir, readFile, rename, writeFile } from "node:fs/promises";
+import { chmod, mkdir, readFile } from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
+import { updateConfigFile } from "./config-file.js";
 import { readSecrets, writeSecrets } from "./secrets.js";
 import { runMcp } from "./mcp.js";
 import { UnipileClient, accountIsReady } from "./unipile.js";
@@ -49,16 +50,6 @@ async function ensureWorkspace(workspace) {
   await chmod(workspace, 0o700);
 }
 
-async function writeJsonPrivate(target, value) {
-  const temporary = `${target}.${process.pid}.tmp`;
-  await writeFile(temporary, `${JSON.stringify(value, null, 2)}\n`, {
-    mode: 0o600,
-  });
-  await chmod(temporary, 0o600);
-  await rename(temporary, target);
-  await chmod(target, 0o600);
-}
-
 export async function readConfig(workspace, { optional = false } = {}) {
   try {
     return JSON.parse(
@@ -276,18 +267,21 @@ export async function connectCommand(channel, options, dependencies = {}) {
     return { connected: false, hostedUrl };
   }
 
-  const nextConfig = {
-    version: 1,
-    channels: {
-      ...(config.channels || {}),
-      [channel]: {
-        accountId: selected.id,
-        name: selected.name || null,
-        connectedAt: new Date().toISOString(),
+  updateConfigFile(
+    path.join(workspace, "config.json"),
+    latest => ({
+      ...latest,
+      version: 1,
+      channels: {
+        ...(latest.channels || {}),
+        [channel]: {
+          accountId: selected.id,
+          name: selected.name || null,
+          connectedAt: new Date().toISOString(),
+        },
       },
-    },
-  };
-  await writeJsonPrivate(path.join(workspace, "config.json"), nextConfig);
+    }),
+  );
   io.stdout.write(
     `${definition.label} connected: ${selected.name || selected.id} (${selected.id})\n`,
   );

package/lib/config-file.js

@@ -0,0 +1,114 @@
+import {
+  chmodSync,
+  closeSync,
+  fsyncSync,
+  mkdirSync,
+  openSync,
+  readFileSync,
+  renameSync,
+  unlinkSync,
+  writeFileSync,
+} from "node:fs";
+import path from "node:path";
+import { randomBytes } from "node:crypto";
+
+
+const WAIT_ARRAY = new Int32Array(new SharedArrayBuffer(4));
+const LOCK_TIMEOUT_MS = 5_000;
+
+
+function wait(milliseconds) {
+  Atomics.wait(WAIT_ARRAY, 0, 0, milliseconds);
+}
+
+
+function acquireLock(lockFile) {
+  const deadline = Date.now() + LOCK_TIMEOUT_MS;
+  for (;;) {
+    try {
+      return openSync(lockFile, "wx", 0o600);
+    } catch (error) {
+      if (error.code !== "EEXIST") throw error;
+      if (Date.now() >= deadline) {
+        throw new Error(
+          `timed out waiting for SignalDash config lock: ${lockFile}; ` +
+          "the lock is never stolen automatically because that could corrupt the session",
+        );
+      }
+      wait(25);
+    }
+  }
+}
+
+
+function releaseLock(lockFile, descriptor) {
+  try {
+    closeSync(descriptor);
+  } finally {
+    try {
+      unlinkSync(lockFile);
+    } catch (error) {
+      if (error.code !== "ENOENT") throw error;
+    }
+  }
+}
+
+
+export function readConfigFile(file, { optional = false } = {}) {
+  try {
+    return JSON.parse(readFileSync(file, "utf8"));
+  } catch (error) {
+    if (error.code === "ENOENT" && optional) return {};
+    throw error;
+  }
+}
+
+
+export function updateConfigFile(file, update) {
+  const directory = path.dirname(file);
+  mkdirSync(directory, { recursive: true, mode: 0o700 });
+  chmodSync(directory, 0o700);
+  const lockFile = `${file}.lock`;
+  const descriptor = acquireLock(lockFile);
+  let temporary;
+  try {
+    const current = readConfigFile(file, { optional: true });
+    const next = update({ ...current });
+    if (!next || typeof next !== "object" || Array.isArray(next)) {
+      throw new TypeError("SignalDash config update must return an object");
+    }
+    temporary = `${file}.${process.pid}.${randomBytes(6).toString("hex")}.tmp`;
+    writeFileSync(temporary, `${JSON.stringify(next, null, 2)}\n`, {
+      mode: 0o600,
+      flag: "wx",
+    });
+    const temporaryDescriptor = openSync(temporary, "r");
+    try {
+      fsyncSync(temporaryDescriptor);
+    } finally {
+      closeSync(temporaryDescriptor);
+    }
+    renameSync(temporary, file);
+    temporary = undefined;
+    chmodSync(file, 0o600);
+    const directoryDescriptor = openSync(directory, "r");
+    try {
+      fsyncSync(directoryDescriptor);
+    } finally {
+      closeSync(directoryDescriptor);
+    }
+    return next;
+  } finally {
+    try {
+      if (temporary) {
+        try {
+          unlinkSync(temporary);
+        } catch (error) {
+          if (error.code !== "ENOENT") throw error;
+        }
+      }
+    } finally {
+      releaseLock(lockFile, descriptor);
+    }
+  }
+}

package/lib/mcp.js

@@ -127,7 +127,7 @@ function cleanMessage(message) {
     id: message.id ?? message.provider_id ?? null,
     text: message.text ?? null,
     timestamp: message.timestamp ?? null,
-    is_sender: Boolean(message.is_sender),
+    is_sender: providerIsOwn(message.is_sender),
     sender_id: message.sender_id ?? null,
     attachments: (message.attachments || []).map((attachment) => ({
       id: attachment.id ?? null,
@@ -140,6 +140,16 @@ function cleanMessage(message) {
   };
 }
 
+function providerIsOwn(value) {
+  if (typeof value === "boolean") return value;
+  if (typeof value === "number") return value !== 0;
+  if (typeof value === "string") {
+    const normalized = value.trim().toLowerCase();
+    return ["1", "true", "yes", "y"].includes(normalized);
+  }
+  return false;
+}
+
 function itemList(payload) {
   return Array.isArray(payload?.items)
     ? payload.items
@@ -207,7 +217,7 @@ async function executeTool({ name, args, config, client, guard }) {
         const recent = itemList(await client.listMessages(chatId, 20));
         const duplicate = recent.find(
           (message) =>
-            message.is_sender &&
+            providerIsOwn(message.is_sender) &&
             typeof message.text === "string" &&
             message.text.trim() === text,
         );

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@floomhq/signaldash",
-  "version": "0.13.0",
+  "version": "0.27.0",
   "description": "Secure LinkedIn, WhatsApp, and email access for AI agents",
   "type": "module",
   "bin": {
@@ -18,7 +18,7 @@
   },
   "scripts": {
     "test": "node --test",
-    "check": "node --check bin/sd.mjs && node --check server/server.cjs && node --check bin/signaldash.js && node --check lib/cli.js && node --check lib/mcp.js && node --check lib/rate-guard.js && node --check lib/secrets.js && node --check lib/unipile.js"
+    "check": "node --check bin/sd.mjs && node --check server/server.cjs && node --check server/attachments.cjs && node --check server/write-control.cjs && node --check server/voice-profile.cjs && node --check server/campaign-store.cjs && node --check server/campaign-runner.cjs && node --check server/withdrawal-store.cjs && node --check server/post-scheduler.cjs && node --check bin/signaldash.js && node --check lib/cli.js && node --check lib/config-file.js && node --check lib/mcp.js && node --check lib/rate-guard.js && node --check lib/secrets.js && node --check lib/unipile.js"
   },
   "keywords": [
     "mcp",
@@ -34,4 +34,4 @@
     "ora": "8.0.1",
     "open": "10.1.0"
   }
-}
+}