@flint.fyi/ts 0.22.0 → 0.23.1

package/dist/index.d.mts

@@ -958,13 +958,6 @@ declare const ts: import("@flint.fyi/core").Plugin<import("@flint.fyi/core").Rul
   readonly pluginId: string;
   readonly url: string;
 }, "implicitExports", undefined>, import("@flint.fyi/core").Rule<{
-  readonly description: "Reports using `module` keyword instead of `namespace` for TypeScript namespaces.";
-  readonly id: "namespaceKeywords";
-  readonly presets: readonly ["stylistic", "stylisticStrict"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "preferNamespace", undefined>, import("@flint.fyi/core").Rule<{
   readonly description: "Reports extending the prototype of native JavaScript objects.";
   readonly id: "nativeObjectExtensions";
   readonly presets: readonly ["javascript"];
@@ -1203,13 +1196,6 @@ declare const ts: import("@flint.fyi/core").Plugin<import("@flint.fyi/core").Rul
   readonly pluginId: string;
   readonly url: string;
 }, "noOctalEscape", undefined>, import("@flint.fyi/core").Rule<{
-  readonly description: "Reports using legacy octal numeric literals.";
-  readonly id: "octalNumbers";
-  readonly presets: readonly ["javascript"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "noOctalNumber", undefined>, import("@flint.fyi/core").Rule<{
   readonly description: "Prefer assignment operator shorthand where possible.";
   readonly id: "operatorAssignmentShorthand";
   readonly presets: readonly ["stylistic", "stylisticStrict"];

package/dist/index.mjs

@@ -1,6 +1,6 @@
 import { RuleCreator, createPlugin } from "@flint.fyi/core";
 import { declarationIncludesGlobal, forEachChild, getModifyingReferences, getScopeManager, getStaticNumberValue, getStaticStringValue, getStaticValue, getTSNodeRange, hasSameTokens, isBuiltinArrayMethod, isFunction, isGlobalDeclaration, isGlobalDeclarationOfName, isGlobalVariable, isInlineArrayCreation, typescriptLanguage, unwrapParentParenthesizedExpressions, unwrapParenthesizedNode } from "@flint.fyi/typescript-language";
-import ts$1, { NodeFlags, SignatureKind, SymbolFlags, SyntaxKind, TypeFlags, getLeadingCommentRanges, getTrailingCommentRanges, isArrayLiteralExpression, isBigIntLiteral, isElementAccessExpression, isFunctionLike, isIdentifier, isInterfaceDeclaration, isLiteralExpression, isNewExpression, isNumericLiteral, isParenthesizedExpression, isPrefixUnaryExpression, isPropertyAccessExpression, isSpreadElement, isStringLiteral, isVariableDeclaration } from "typescript";
+import ts$1, { NodeFlags, SignatureKind, SymbolFlags, SyntaxKind, TypeFlags, getLeadingCommentRanges, getTrailingCommentRanges, isArrayLiteralExpression, isBigIntLiteral, isElementAccessExpression, isExpressionWithTypeArguments, isFunctionLike, isIdentifier, isInterfaceDeclaration, isLiteralExpression, isNewExpression, isNumericLiteral, isParenthesizedExpression, isPrefixUnaryExpression, isPropertyAccessExpression, isShorthandPropertyAssignment, isSpreadElement, isStringLiteral, isTypeNode, isTypeParameterDeclaration, isVariableDeclaration } from "typescript";
 import * as tsutils from "ts-api-utils";
 import { isNodeFlagSet, isNullKeyword } from "ts-api-utils";
 import { nullThrows, pathKey } from "@flint.fyi/utils";
@@ -1690,13 +1690,14 @@ function isDirectEqualityCheck(node, operators, parameterName) {
 			body = getDirectReturnExpression(node.body);
 			break;
 	}
-	if (body?.kind !== SyntaxKind.BinaryExpression) return;
+	if (body?.kind !== SyntaxKind.BinaryExpression) return false;
 	const { left, operatorToken, right } = body;
-	if (!operators.includes(operatorToken.kind)) return;
+	if (!operators.includes(operatorToken.kind)) return false;
 	const isLeftParam = left.kind === SyntaxKind.Identifier && left.text === parameterName;
 	const isRightParam = right.kind === SyntaxKind.Identifier && right.text === parameterName;
-	if (isLeftParam && !isRightParam) return right;
-	if (isRightParam && !isLeftParam) return left;
+	if (isLeftParam && !isRightParam) return true;
+	if (isRightParam && !isLeftParam) return true;
+	return false;
 }
 function getDirectReturnExpression(body) {
 	if (body.statements.length !== 1) return;
@@ -7743,40 +7744,6 @@ var namespaceImplicitAmbientImports_default = ruleCreator.createRule(typescriptL
 	}
 });
 //#endregion
-//#region src/rules/namespaceKeywords.ts
-var namespaceKeywords_default = ruleCreator.createRule(typescriptLanguage, {
-	about: {
-		description: "Reports using `module` keyword instead of `namespace` for TypeScript namespaces.",
-		id: "namespaceKeywords",
-		presets: ["stylistic", "stylisticStrict"]
-	},
-	messages: { preferNamespace: {
-		primary: "The `namespace` keyword is preferred over `module` for TypeScript namespaces.",
-		secondary: [
-			"TypeScript originally used the `module` keyword to declare internal modules (namespaces).",
-			"The `namespace` keyword was later introduced to avoid confusion with ES6 modules.",
-			"Using `namespace` makes it clear you are defining a TypeScript namespace, not an ES6 module."
-		],
-		suggestions: ["Replace `module` with `namespace`."]
-	} },
-	setup(context) {
-		return { visitors: { ModuleDeclaration: (node, { sourceFile }) => {
-			if (node.name.kind === SyntaxKind.StringLiteral) return;
-			const moduleKeywordToken = node.getChildren(sourceFile).find((child) => child.kind === SyntaxKind.ModuleKeyword);
-			if (!moduleKeywordToken) return;
-			const range = getTSNodeRange(moduleKeywordToken, sourceFile);
-			context.report({
-				fix: {
-					range,
-					text: "namespace"
-				},
-				message: "preferNamespace",
-				range
-			});
-		} } };
-	}
-});
-//#endregion
 //#region src/rules/nativeObjectExtensions.ts
 const nativeConstructors = /* @__PURE__ */ new Set([
 	"AggregateError",
@@ -10082,55 +10049,6 @@ var octalEscapes_default = ruleCreator.createRule(typescriptLanguage, {
 	}
 });
 //#endregion
-//#region src/rules/octalNumbers.ts
-var octalNumbers_default = ruleCreator.createRule(typescriptLanguage, {
-	about: {
-		description: "Reports using legacy octal numeric literals.",
-		id: "octalNumbers",
-		presets: ["javascript"]
-	},
-	messages: { noOctalNumber: {
-		primary: "This legacy octal numeric literal evaluates to {{ raw }}. Did you mean that value, or to use a modern octal syntax such as {{ equivalent }}?",
-		secondary: [
-			"Legacy octal numeric literals (e.g., `077`, `0123`) are a deprecated feature in JavaScript that can lead to confusion and errors.",
-			"They are forbidden in strict mode and are less readable than their modern alternatives.",
-			"The digit `0` by itself is allowed as it represents zero, not an octal literal."
-		],
-		suggestions: ["Use the explicit octal syntax (e.g., `0o77`) introduced in ES6, which is clearer and works in both strict and non-strict modes.", "Remove the leading `0` if you intended to use the decimal value."]
-	} },
-	setup(context) {
-		return { visitors: { NumericLiteral: (node, { sourceFile }) => {
-			const text = node.getText(sourceFile);
-			if (text.length > 1 && text.startsWith("0") && nullThrows(text[1], "Second character is expected to be present by prior length check") >= "0" && nullThrows(text[1], "Second character is expected to be present by prior length check") <= "7" && !/^0[xobi]/i.test(text)) {
-				const range = {
-					begin: node.getStart(sourceFile),
-					end: node.getEnd()
-				};
-				const octalValue = parseInt(text, 8);
-				const modernOctalSyntax = `0o${text.slice(1)}`;
-				const decimalWithoutLeadingZero = text.slice(1);
-				context.report({
-					data: {
-						equivalent: modernOctalSyntax,
-						raw: octalValue.toString()
-					},
-					message: "noOctalNumber",
-					range,
-					suggestions: [{
-						id: "useModernOctalSyntax",
-						range,
-						text: modernOctalSyntax
-					}, {
-						id: "removeLeadingZero",
-						range,
-						text: decimalWithoutLeadingZero
-					}]
-				});
-			}
-		} } };
-	}
-});
-//#endregion
 //#region src/rules/operatorAssignmentShorthand.ts
 const operatorTexts = /* @__PURE__ */ new Map([
 	[SyntaxKind.AmpersandToken, "&"],
@@ -20562,8 +20480,11 @@ function getImportSpecifiers(node) {
 	return specifiers;
 }
 function getReferencedSymbol(typeChecker, node) {
-	const symbol = typeChecker.getSymbolAtLocation(node);
-	return symbol?.flags && (symbol.flags & ts$1.SymbolFlags.Alias) !== 0 ? typeChecker.getAliasedSymbol(symbol) : symbol;
+	let symbol;
+	const parent = node.parent;
+	if (isShorthandPropertyAssignment(parent)) symbol = typeChecker.getShorthandAssignmentValueSymbol(parent);
+	else symbol = typeChecker.getSymbolAtLocation(node);
+	return symbol?.flags && (symbol.flags & SymbolFlags.Alias) !== 0 ? typeChecker.getAliasedSymbol(symbol) : symbol;
 }
 function getSpecifierLocal(specifier) {
 	return specifier.kind === SyntaxKind.Identifier ? specifier : specifier.name;
@@ -20628,8 +20549,8 @@ function isOnlyTypeReference(node) {
 	let parent = node.parent;
 	while (parent) {
 		if (parent.kind === SyntaxKind.HeritageClause) return parent.token === SyntaxKind.ImplementsKeyword;
-		if (parent.kind === SyntaxKind.TypeAliasDeclaration || parent.kind === SyntaxKind.InterfaceDeclaration || ts$1.isTypeParameterDeclaration(parent)) return true;
-		if (ts$1.isTypeNode(parent) && !ts$1.isExpressionWithTypeArguments(parent)) return true;
+		if (parent.kind === SyntaxKind.TypeAliasDeclaration || parent.kind === SyntaxKind.InterfaceDeclaration || isTypeParameterDeclaration(parent)) return true;
+		if (isTypeNode(parent) && !isExpressionWithTypeArguments(parent)) return true;
 		current = parent;
 		parent = current.parent;
 	}
@@ -22291,7 +22212,6 @@ const ts = createPlugin({
 		namedDefaultExports_default,
 		namespaceDeclarations_default,
 		namespaceImplicitAmbientImports_default,
-		namespaceKeywords_default,
 		nativeObjectExtensions_default,
 		negativeIndexLengthMethods_default,
 		negativeZeroComparisons_default,
@@ -22323,7 +22243,6 @@ const ts = createPlugin({
 		objectSpreadUnnecessaryFallbacks_default,
 		objectTypeDefinitions_default,
 		octalEscapes_default,
-		octalNumbers_default,
 		operatorAssignmentShorthand_default,
 		overloadSignaturesAdjacent_default,
 		parameterReassignments_default,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@flint.fyi/ts",
-  "version": "0.22.0",
+  "version": "0.23.1",
   "description": "[Experimental] TypeScript language plugin for Flint.",
   "homepage": "https://flint.fyi/rules/ts",
   "repository": {
@@ -28,18 +28,18 @@
     "ts-api-utils": "^2.4.0",
     "typescript": "^6.0.0",
     "zod": "^4.3.6",
-    "@flint.fyi/typescript-language": "^0.19.0",
-    "@flint.fyi/core": "^0.24.0",
-    "@flint.fyi/utils": "^0.15.0"
+    "@flint.fyi/core": "^0.25.0",
+    "@flint.fyi/utils": "^0.16.0",
+    "@flint.fyi/typescript-language": "^0.20.0"
   },
   "devDependencies": {
     "tsdown": "0.22.3",
     "vitest": "4.1.0",
-    "@flint.fyi/build": "^0.1.0",
-    "@flint.fyi/rule-tester": "^0.17.0"
+    "@flint.fyi/rule-tester": "^0.19.0",
+    "@flint.fyi/build": "^0.1.0"
   },
   "engines": {
-    "node": ">=24.0.0"
+    "node": ">=26.1.0"
   },
   "publishConfig": {
     "access": "public"