@flint.fyi/ts 0.19.0 → 0.19.1

package/lib/plugin.d.ts

@@ -2015,6 +2015,22 @@ declare const ts: _flint_fyi_core0.Plugin<_flint_fyi_core0.RuleAbout<string>, "j
   readonly pluginId: string;
   readonly url: string;
 }, "preferAs", undefined>, _flint_fyi_core0.Rule<{
+  readonly description: "Reports imports that do not match the configured type import style.";
+  readonly id: "typeImports";
+  readonly presets: readonly ["stylistic"];
+} & {
+  readonly pluginId: string;
+  readonly url: string;
+}, "avoidImportType" | "someImportsAreOnlyTypes" | "typeOverValue", {
+  fixStyle: zod_v40.ZodDefault<zod_v40.ZodEnum<{
+    "inline-type-imports": "inline-type-imports";
+    "separate-type-imports": "separate-type-imports";
+  }>>;
+  prefer: zod_v40.ZodDefault<zod_v40.ZodEnum<{
+    "no-type-imports": "no-type-imports";
+    "type-imports": "type-imports";
+  }>>;
+}>, _flint_fyi_core0.Rule<{
   readonly description: "Reports typeof expressions that compare impossible string literals.";
   readonly id: "typeofComparisons";
   readonly presets: readonly ["javascript"];

package/lib/plugin.js

@@ -274,6 +274,7 @@ import tripleSlashReferenceValidity_default from "./rules/tripleSlashReferenceVa
 import tsComments_default from "./rules/tsComments.js";
 import tslintComments_default from "./rules/tslintComments.js";
 import typeAssertionStyles_default from "./rules/typeAssertionStyles.js";
+import typeImports_default from "./rules/typeImports.js";
 import typeofComparisons_default from "./rules/typeofComparisons.js";
 import unassignedVariables_default from "./rules/unassignedVariables.js";
 import undefinedTypeofChecks_default from "./rules/undefinedTypeofChecks.js";
@@ -585,6 +586,7 @@ const ts = createPlugin({
 		tsComments_default,
 		tslintComments_default,
 		typeAssertionStyles_default,
+		typeImports_default,
 		typeofComparisons_default,
 		unassignedVariables_default,
 		undefinedTypeofChecks_default,

package/lib/rules/typeImports.d.ts

@@ -0,0 +1,20 @@
+import { z } from "zod/v4";
+declare const _default: import("@flint.fyi/core").Rule<{
+    readonly description: "Reports imports that do not match the configured type import style.";
+    readonly id: "typeImports";
+    readonly presets: readonly ["stylistic"];
+} & {
+    readonly pluginId: string;
+    readonly url: string;
+}, "avoidImportType" | "someImportsAreOnlyTypes" | "typeOverValue", {
+    fixStyle: z.ZodDefault<z.ZodEnum<{
+        "inline-type-imports": "inline-type-imports";
+        "separate-type-imports": "separate-type-imports";
+    }>>;
+    prefer: z.ZodDefault<z.ZodEnum<{
+        "no-type-imports": "no-type-imports";
+        "type-imports": "type-imports";
+    }>>;
+}>;
+export default _default;
+//# sourceMappingURL=typeImports.d.ts.map

package/lib/rules/typeImports.js

@@ -0,0 +1,284 @@
+import { ruleCreator } from "./ruleCreator.js";
+import { forEachChild } from "./utils/forEachChild.js";
+import { getTSNodeRange, typescriptLanguage } from "@flint.fyi/typescript-language";
+import ts, { SyntaxKind } from "typescript";
+import { z } from "zod/v4";
+//#region src/rules/typeImports.ts
+function containsDecorator(node) {
+	if (node.kind === SyntaxKind.Decorator) return true;
+	return forEachChild(node, containsDecorator) ?? false;
+}
+function formatWordList(words) {
+	if (words.length < 2) return words[0] ?? "";
+	const last = words.at(-1);
+	return `${words.slice(0, -1).join(", ")} and ${last}`;
+}
+function getImportSource(node, sourceFile) {
+	return ts.isStringLiteral(node.moduleSpecifier) ? node.moduleSpecifier.text : node.moduleSpecifier.getText(sourceFile);
+}
+function getImportSpecifiers(node) {
+	const importClause = node.importClause;
+	if (!importClause) return [];
+	const specifiers = [];
+	if (importClause.name) specifiers.push(importClause.name);
+	const namedBindings = importClause.namedBindings;
+	if (namedBindings) if (namedBindings.kind === ts.SyntaxKind.NamespaceImport) specifiers.push(namedBindings);
+	else specifiers.push(...namedBindings.elements);
+	return specifiers;
+}
+function getReferencedSymbol(typeChecker, node) {
+	const symbol = typeChecker.getSymbolAtLocation(node);
+	return symbol?.flags && (symbol.flags & ts.SymbolFlags.Alias) !== 0 ? typeChecker.getAliasedSymbol(symbol) : symbol;
+}
+function getSpecifierLocal(specifier) {
+	return specifier.kind === SyntaxKind.Identifier ? specifier : specifier.name;
+}
+function getTypeImportFix(report, sourceFile, fixStyle) {
+	const node = report.node;
+	const importText = node.getText(sourceFile);
+	const importClause = node.importClause;
+	const namedBindings = importClause?.namedBindings;
+	const range = getTSNodeRange(node, sourceFile);
+	if (report.valueSpecifiers.length || report.unusedSpecifiers.length) {
+		if (!importClause || importClause.name || namedBindings?.kind !== ts.SyntaxKind.NamedImports) return;
+		const typeSpecifiers = new Set(report.typeSpecifiers);
+		const remainingSpecifiers = namedBindings.elements.filter((specifier) => !typeSpecifiers.has(specifier));
+		const typeText = report.typeSpecifiers.map((specifier) => specifier.getText(sourceFile)).join(", ");
+		const remainingText = remainingSpecifiers.map((specifier) => specifier.getText(sourceFile)).join(", ");
+		const moduleText = node.moduleSpecifier.getText(sourceFile);
+		return {
+			range,
+			text: `import type { ${typeText}} from ${moduleText};\nimport { ${remainingText} } from ${moduleText};`
+		};
+	}
+	if (fixStyle === "inline-type-imports" && importClause && !importClause.name && namedBindings?.kind === ts.SyntaxKind.NamedImports) {
+		const moduleText = node.moduleSpecifier.getText(sourceFile);
+		return {
+			range,
+			text: `import { ${namedBindings.elements.map((specifier) => specifier.isTypeOnly ? specifier.getText(sourceFile) : `type ${specifier.getText(sourceFile)}`).join(", ")} } from ${moduleText};`
+		};
+	}
+	return {
+		range,
+		text: importText.replace(/^import\b/, "import type")
+	};
+}
+function getTypeKeywordFixRange(node, sourceFile) {
+	const range = getTypeKeywordRange(node, sourceFile);
+	if (sourceFile.text[range.end] === " ") range.end += 1;
+	return range;
+}
+function getTypeKeywordRange(node, sourceFile) {
+	for (const child of node.getChildren(sourceFile)) if (child.kind === SyntaxKind.TypeKeyword) {
+		const range = getTSNodeRange(child, sourceFile);
+		if (node.kind === SyntaxKind.ImportSpecifier && sourceFile.text[range.end] === " ") range.end += 1;
+		return range;
+	}
+	return getTSNodeRange(node, sourceFile);
+}
+function isInImportDeclaration(node) {
+	let current = node;
+	while (current) {
+		if (current.kind === SyntaxKind.ImportDeclaration) return true;
+		current = current.parent;
+	}
+	return false;
+}
+function isInlineTypeSpecifier(specifier) {
+	return specifier.kind === SyntaxKind.ImportSpecifier && specifier.isTypeOnly;
+}
+function isOnlyTypeReference(node) {
+	if (isTypeQueryReference(node) || isTypeOnlyExportReference(node) || isPropertySignatureComputedReference(node)) return true;
+	let current;
+	let parent = node.parent;
+	while (parent) {
+		if (parent.kind === ts.SyntaxKind.HeritageClause) return parent.token === SyntaxKind.ImplementsKeyword;
+		if (ts.isTypeAliasDeclaration(parent) || ts.isInterfaceDeclaration(parent) || ts.isTypeParameterDeclaration(parent)) return true;
+		if (ts.isTypeNode(parent) && !ts.isExpressionWithTypeArguments(parent)) return true;
+		current = parent;
+		parent = current.parent;
+	}
+	return false;
+}
+function isPropertySignatureComputedReference(node) {
+	let child = node;
+	let parent = node.parent;
+	while (parent) switch (parent.kind) {
+		case SyntaxKind.PropertySignature: return parent.name === child;
+		case SyntaxKind.ComputedPropertyName:
+			if (parent.expression !== child) return false;
+			child = parent;
+			parent = parent.parent;
+			continue;
+		case SyntaxKind.PropertyAccessExpression:
+			if (parent.expression !== child) return false;
+			child = parent;
+			parent = parent.parent;
+			continue;
+		default: return false;
+	}
+	return false;
+}
+function isTypeImportDeclaration(node) {
+	return node.importClause?.phaseModifier === SyntaxKind.TypeKeyword;
+}
+function isTypeOnlyExportReference(node) {
+	const parent = node.parent;
+	if (parent.kind !== SyntaxKind.ExportSpecifier) return false;
+	const exportDeclaration = parent.parent.parent;
+	return parent.name === node && exportDeclaration.isTypeOnly;
+}
+function isTypeQueryReference(node) {
+	let child = node;
+	let parent = node.parent;
+	while (parent) switch (parent.kind) {
+		case SyntaxKind.TypeQuery: return true;
+		case SyntaxKind.QualifiedName:
+			if (parent.left !== child) return false;
+			child = parent;
+			parent = parent.parent;
+			continue;
+		default: return false;
+	}
+	return false;
+}
+var typeImports_default = ruleCreator.createRule(typescriptLanguage, {
+	about: {
+		description: "Reports imports that do not match the configured type import style.",
+		id: "typeImports",
+		presets: ["stylistic"]
+	},
+	messages: {
+		avoidImportType: {
+			primary: "Use a regular import instead of a type-only import.",
+			secondary: ["This configuration prefers regular imports over `import type` syntax."],
+			suggestions: ["Change this type-only import to a regular import."]
+		},
+		someImportsAreOnlyTypes: {
+			primary: "Imports {{ typeImports }} are only used as types.",
+			secondary: ["These imports are only used in type positions.", "Using 'import type' improves tree-shaking and makes intent clear."],
+			suggestions: ["Change these imports to use 'import type'."]
+		},
+		typeOverValue: {
+			primary: "All imports in this declaration are only used as types. Use 'import type'.",
+			secondary: ["This import is only used in type positions.", "Using 'import type' improves tree-shaking and makes intent clear."],
+			suggestions: ["Change this declaration to use 'import type'."]
+		}
+	},
+	options: {
+		fixStyle: z.enum(["inline-type-imports", "separate-type-imports"]).default("inline-type-imports"),
+		prefer: z.enum(["no-type-imports", "type-imports"]).default("type-imports")
+	},
+	setup(context) {
+		return { visitors: { SourceFile(node, { options, program, sourceFile, typeChecker }) {
+			if (options.prefer === "no-type-imports") {
+				for (const statement of node.statements) {
+					if (!ts.isImportDeclaration(statement) || !statement.importClause) continue;
+					if (isTypeImportDeclaration(statement)) {
+						context.report({
+							fix: {
+								range: getTypeKeywordFixRange(statement.importClause, sourceFile),
+								text: ""
+							},
+							message: "avoidImportType",
+							range: getTypeKeywordRange(statement.importClause, sourceFile)
+						});
+						continue;
+					}
+					for (const specifier of getImportSpecifiers(statement)) {
+						if (!isInlineTypeSpecifier(specifier)) continue;
+						context.report({
+							fix: {
+								range: getTypeKeywordFixRange(specifier, sourceFile),
+								text: ""
+							},
+							message: "avoidImportType",
+							range: getTypeKeywordRange(specifier, sourceFile)
+						});
+					}
+				}
+				return;
+			}
+			const compilerOptions = program.getCompilerOptions();
+			if (compilerOptions.experimentalDecorators && compilerOptions.emitDecoratorMetadata && containsDecorator(node)) return;
+			const sourceImportsMap = {};
+			const importedSpecifiers = [];
+			const references = /* @__PURE__ */ new Map();
+			for (const statement of node.statements) {
+				if (!ts.isImportDeclaration(statement) || !statement.importClause) continue;
+				const source = getImportSource(statement, sourceFile);
+				sourceImportsMap[source] ??= { reportValueImports: [] };
+				if (isTypeImportDeclaration(statement)) continue;
+				for (const specifier of getImportSpecifiers(statement)) {
+					if (isInlineTypeSpecifier(specifier)) continue;
+					const local = getSpecifierLocal(specifier);
+					const importedSpecifier = {
+						local,
+						specifier,
+						symbol: getReferencedSymbol(typeChecker, local)
+					};
+					importedSpecifiers.push(importedSpecifier);
+					references.set(importedSpecifier, []);
+				}
+			}
+			function collectReferences(node) {
+				if (ts.isIdentifier(node) && !isInImportDeclaration(node)) {
+					const symbol = getReferencedSymbol(typeChecker, node);
+					const importedSpecifier = importedSpecifiers.find((specifier) => specifier.local.text === node.text && (!specifier.symbol || specifier.symbol === symbol));
+					if (importedSpecifier) references.get(importedSpecifier)?.push(node);
+				}
+				forEachChild(node, collectReferences);
+			}
+			collectReferences(node);
+			for (const statement of node.statements) {
+				if (!ts.isImportDeclaration(statement) || !statement.importClause || isTypeImportDeclaration(statement)) continue;
+				const typeSpecifiers = [];
+				const valueSpecifiers = [];
+				const unusedSpecifiers = [];
+				for (const specifier of getImportSpecifiers(statement)) {
+					if (isInlineTypeSpecifier(specifier)) continue;
+					const importedSpecifier = importedSpecifiers.find(({ specifier: found }) => found === specifier);
+					const specifierReferences = importedSpecifier ? references.get(importedSpecifier) : void 0;
+					if (!specifierReferences?.length) unusedSpecifiers.push(specifier);
+					else if (specifierReferences.every(isOnlyTypeReference)) typeSpecifiers.push(specifier);
+					else valueSpecifiers.push(specifier);
+				}
+				if (typeSpecifiers.length) {
+					const sourceImports = sourceImportsMap[getImportSource(statement, sourceFile)];
+					if (!sourceImports) continue;
+					sourceImports.reportValueImports.push({
+						node: statement,
+						typeSpecifiers,
+						unusedSpecifiers,
+						valueSpecifiers
+					});
+				}
+			}
+			for (const sourceImports of Object.values(sourceImportsMap)) {
+				if (!sourceImports.reportValueImports.length) continue;
+				for (const report of sourceImports.reportValueImports) {
+					const fix = getTypeImportFix(report, sourceFile, options.fixStyle);
+					if (!report.valueSpecifiers.length && !report.unusedSpecifiers.length && !report.node.attributes?.elements.length) {
+						context.report({
+							fix,
+							message: "typeOverValue",
+							range: getTSNodeRange(report.node, sourceFile)
+						});
+						continue;
+					}
+					const importNames = report.typeSpecifiers.map((specifier) => `"${getSpecifierLocal(specifier).text}"`);
+					context.report({
+						data: { typeImports: formatWordList(importNames) },
+						fix,
+						message: "someImportsAreOnlyTypes",
+						range: getTSNodeRange(report.node, sourceFile)
+					});
+				}
+			}
+		} } };
+	}
+});
+//#endregion
+export { typeImports_default as default };
+
+//# sourceMappingURL=typeImports.js.map

package/lib/rules/utils/forEachChild.d.ts

@@ -0,0 +1,4 @@
+import type { AST } from "@flint.fyi/typescript-language";
+import ts from "typescript";
+export declare const forEachChild: <T>(node: AST.AnyNode, cbNode: (node: AST.AnyNode) => T | undefined, cbNodes?: (nodes: ts.NodeArray<AST.AnyNode>) => T | undefined) => T | undefined;
+//# sourceMappingURL=forEachChild.d.ts.map

package/lib/rules/utils/forEachChild.js

@@ -0,0 +1,7 @@
+import ts from "typescript";
+//#region src/rules/utils/forEachChild.ts
+const forEachChild = ts.forEachChild;
+//#endregion
+export { forEachChild };
+
+//# sourceMappingURL=forEachChild.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@flint.fyi/ts",
-  "version": "0.19.0",
+  "version": "0.19.1",
   "description": "[Experimental] TypeScript language plugin for Flint.",
   "homepage": "https://flint.fyi/rules/ts",
   "repository": {
@@ -29,14 +29,14 @@
     "ts-api-utils": "^2.4.0",
     "typescript": "^5.9.3 || ^6.0.0",
     "zod": "^4.3.6",
-    "@flint.fyi/core": "^0.21.2",
-    "@flint.fyi/typescript-language": "^0.18.1",
-    "@flint.fyi/utils": "^0.14.1"
+    "@flint.fyi/core": "^0.22.0",
+    "@flint.fyi/utils": "^0.14.1",
+    "@flint.fyi/typescript-language": "^0.18.2"
   },
   "devDependencies": {
     "tsdown": "0.21.0",
     "vitest": "4.1.0",
-    "@flint.fyi/rule-tester": "^0.16.2"
+    "@flint.fyi/rule-tester": "^0.16.3"
   },
   "engines": {
     "node": ">=24.0.0"