@flint.fyi/ts 0.14.2 → 0.14.4

package/lib/rules/defaultCaseLast.test.js

@@ -0,0 +1,195 @@
+import rule from "./defaultCaseLast.js";
+import { ruleTester } from "./ruleTester.js";
+ruleTester.describe(rule, {
+    invalid: [
+        {
+            code: `
+switch (value) {
+    default:
+        break;
+    case 1:
+        break;
+}
+`,
+            snapshot: `
+switch (value) {
+    default:
+    ~~~~~~~
+    Default clauses in switch statements should be last.
+        break;
+    case 1:
+        break;
+}
+`,
+        },
+        {
+            code: `
+switch (value) {
+    case 1:
+        break;
+    default:
+        break;
+    case 2:
+        break;
+}
+`,
+            snapshot: `
+switch (value) {
+    case 1:
+        break;
+    default:
+    ~~~~~~~
+    Default clauses in switch statements should be last.
+        break;
+    case 2:
+        break;
+}
+`,
+        },
+        {
+            code: `
+switch (value) {
+    case 1:
+    case 2:
+        break;
+    default:
+        break;
+    case 3:
+        break;
+}
+`,
+            snapshot: `
+switch (value) {
+    case 1:
+    case 2:
+        break;
+    default:
+    ~~~~~~~
+    Default clauses in switch statements should be last.
+        break;
+    case 3:
+        break;
+}
+`,
+        },
+        {
+            code: `
+switch (value) {
+    default:
+        console.log("default");
+        break;
+    case 1:
+        console.log("one");
+        break;
+}
+`,
+            snapshot: `
+switch (value) {
+    default:
+    ~~~~~~~
+    Default clauses in switch statements should be last.
+        console.log("default");
+        break;
+    case 1:
+        console.log("one");
+        break;
+}
+`,
+        },
+        {
+            code: `
+const result = (value: number) => {
+    switch (value) {
+        case 1:
+            return "one";
+        default:
+            return "default";
+        case 2:
+            return "two";
+    }
+};
+`,
+            snapshot: `
+const result = (value: number) => {
+    switch (value) {
+        case 1:
+            return "one";
+        default:
+        ~~~~~~~
+        Default clauses in switch statements should be last.
+            return "default";
+        case 2:
+            return "two";
+    }
+};
+`,
+        },
+        {
+            code: `
+switch (value) {
+    default:
+    case 1:
+        break;
+}
+`,
+            snapshot: `
+switch (value) {
+    default:
+    ~~~~~~~
+    Default clauses in switch statements should be last.
+    case 1:
+        break;
+}
+`,
+        },
+    ],
+    valid: [
+        `switch (value) { case 1: break; default: break; }`,
+        `switch (value) { case 1: break; case 2: break; default: break; }`,
+        `switch (value) { case 1: break; case 2: break; }`,
+        `switch (value) { default: break; }`,
+        `switch (value) { case 1: case 2: break; default: break; }`,
+        `
+switch (value) {
+    case 1:
+        break;
+    default:
+        break;
+}
+`,
+        `
+switch (value) {
+    case 1:
+        console.log("one");
+        break;
+    case 2:
+        console.log("two");
+        break;
+    default:
+        console.log("default");
+        break;
+}
+`,
+        `
+const result = (value: number) => {
+    switch (value) {
+        case 1:
+            return "one";
+        case 2:
+            return "two";
+        default:
+            return "default";
+    }
+};
+`,
+        `
+switch (value) {
+    case 1:
+    case 2:
+        break;
+    default:
+        break;
+}
+`,
+    ],
+});

package/lib/rules/duplicateArguments.d.ts

@@ -0,0 +1,6 @@
+declare const _default: import("@flint.fyi/core").Rule<{
+    readonly description: "Reports functions with duplicate parameter names in their signatures.";
+    readonly id: "duplicateArguments";
+    readonly preset: "untyped";
+}, import("../nodes.js").TSNodesByName, import("../language.js").TypeScriptServices, "duplicateParam", undefined>;
+export default _default;

package/lib/rules/duplicateArguments.js

@@ -0,0 +1,51 @@
+import * as ts from "typescript";
+import { getTSNodeRange } from "../getTSNodeRange.js";
+import { typescriptLanguage } from "../language.js";
+export default typescriptLanguage.createRule({
+    about: {
+        description: "Reports functions with duplicate parameter names in their signatures.",
+        id: "duplicateArguments",
+        preset: "untyped",
+    },
+    messages: {
+        duplicateParam: {
+            primary: "This parameter overrides the previous parameter of the same name.",
+            secondary: [
+                "Duplicate parameter names in functions can lead to unexpected behavior and make code harder to understand.",
+                "In strict mode, duplicate parameter names are a syntax error.",
+                "Even in non-strict mode, only the last parameter with a given name is accessible.",
+            ],
+            suggestions: ["Rename one of the duplicate parameters to a unique name."],
+        },
+    },
+    setup(context) {
+        function checkNode({ parameters }) {
+            const seenNames = new Set();
+            for (const parameter of parameters) {
+                if (!ts.isIdentifier(parameter.name)) {
+                    continue;
+                }
+                const parameterName = parameter.name.text;
+                const existingParameter = seenNames.has(parameterName);
+                if (existingParameter) {
+                    context.report({
+                        message: "duplicateParam",
+                        range: getTSNodeRange(parameter.name, context.sourceFile),
+                    });
+                }
+                else {
+                    seenNames.add(parameterName);
+                }
+            }
+        }
+        return {
+            visitors: {
+                ArrowFunction: checkNode,
+                Constructor: checkNode,
+                FunctionDeclaration: checkNode,
+                FunctionExpression: checkNode,
+                MethodDeclaration: checkNode,
+            },
+        };
+    },
+});

package/lib/rules/duplicateArguments.test.d.ts

@@ -0,0 +1 @@
+export {};

package/lib/rules/duplicateArguments.test.js

@@ -0,0 +1,139 @@
+import rule from "./duplicateArguments.js";
+import { ruleTester } from "./ruleTester.js";
+ruleTester.describe(rule, {
+    invalid: [
+        {
+            code: `
+function test(value, value) {
+    return value;
+}
+`,
+            snapshot: `
+function test(value, value) {
+                     ~~~~~
+                     This parameter overrides the previous parameter of the same name.
+    return value;
+}
+`,
+        },
+        {
+            code: `
+function test(first, second, first) {
+    return first + second;
+}
+`,
+            snapshot: `
+function test(first, second, first) {
+                             ~~~~~
+                             This parameter overrides the previous parameter of the same name.
+    return first + second;
+}
+`,
+        },
+        {
+            code: `
+const arrow = (value, value) => value;
+`,
+            snapshot: `
+const arrow = (value, value) => value;
+                      ~~~~~
+                      This parameter overrides the previous parameter of the same name.
+`,
+        },
+        {
+            code: `
+const func = function (value, value) {
+    return value;
+};
+`,
+            snapshot: `
+const func = function (value, value) {
+                              ~~~~~
+                              This parameter overrides the previous parameter of the same name.
+    return value;
+};
+`,
+        },
+        {
+            code: `
+class Example {
+    method(value, value) {
+        return value;
+    }
+}
+`,
+            snapshot: `
+class Example {
+    method(value, value) {
+                  ~~~~~
+                  This parameter overrides the previous parameter of the same name.
+        return value;
+    }
+}
+`,
+        },
+        {
+            code: `
+class Example {
+    constructor(value, value) {
+        this.value = value;
+    }
+}
+`,
+            snapshot: `
+class Example {
+    constructor(value, value) {
+                       ~~~~~
+                       This parameter overrides the previous parameter of the same name.
+        this.value = value;
+    }
+}
+`,
+        },
+        {
+            code: `
+function test(first, second, third, second) {
+    return first + second + third;
+}
+`,
+            snapshot: `
+function test(first, second, third, second) {
+                                    ~~~~~~
+                                    This parameter overrides the previous parameter of the same name.
+    return first + second + third;
+}
+`,
+        },
+        {
+            code: `
+function test(value, value, value) {
+    return value;
+}
+`,
+            snapshot: `
+function test(value, value, value) {
+                     ~~~~~
+                     This parameter overrides the previous parameter of the same name.
+                            ~~~~~
+                            This parameter overrides the previous parameter of the same name.
+    return value;
+}
+`,
+        },
+    ],
+    valid: [
+        `function test(value) { return value; }`,
+        `function test(first, second) { return first + second; }`,
+        `const arrow = (value) => value;`,
+        `const arrow = (first, second) => first + second;`,
+        `const func = function (value) { return value; };`,
+        `const func = function (first, second) { return first + second; };`,
+        `class Example { method(value) { return value; } }`,
+        `class Example { method(first, second) { return first + second; } }`,
+        `class Example { constructor(value) { this.value = value; } }`,
+        `class Example { constructor(first, second) { this.first = first; this.second = second; } }`,
+        `function test({ value }) { return value; }`,
+        `function test({ first, second }) { return first + second; }`,
+        `function test([first, second]) { return first + second; }`,
+    ],
+});

package/lib/rules/elseIfDuplicates.d.ts

@@ -0,0 +1,6 @@
+declare const _default: import("@flint.fyi/core").Rule<{
+    readonly description: "Reports duplicate conditions in if-else-if chains that make code unreachable.";
+    readonly id: "elseIfDuplicates";
+    readonly preset: "logical";
+}, import("../nodes.js").TSNodesByName, import("../language.js").TypeScriptServices, "duplicateCondition", undefined>;
+export default _default;

package/lib/rules/elseIfDuplicates.js

@@ -0,0 +1,53 @@
+import * as ts from "typescript";
+import { getTSNodeRange } from "../getTSNodeRange.js";
+import { typescriptLanguage } from "../language.js";
+import { hasSameTokens } from "../utils/hasSameTokens.js";
+export default typescriptLanguage.createRule({
+    about: {
+        description: "Reports duplicate conditions in if-else-if chains that make code unreachable.",
+        id: "elseIfDuplicates",
+        preset: "logical",
+    },
+    messages: {
+        duplicateCondition: {
+            primary: "This condition is identical to a previous condition in the if-else-if chain.",
+            secondary: [
+                "When an if-else-if chain has duplicate conditions, the duplicate branch will never execute because the earlier identical condition will always be evaluated first.",
+                "This typically indicates a copy-paste error or logic mistake.",
+            ],
+            suggestions: [
+                "Verify the condition logic is correct and update to check for the intended condition.",
+            ],
+        },
+    },
+    setup(context) {
+        function checkIfStatement(node) {
+            const seen = [];
+            let current = node;
+            while (true) {
+                if (seen.some((previous) => hasSameTokens(previous, current.expression, context.sourceFile))) {
+                    context.report({
+                        message: "duplicateCondition",
+                        range: getTSNodeRange(current.expression, context.sourceFile),
+                    });
+                }
+                if (!current.elseStatement ||
+                    !ts.isIfStatement(current.elseStatement)) {
+                    break;
+                }
+                seen.push(current.expression);
+                current = current.elseStatement;
+            }
+        }
+        return {
+            visitors: {
+                IfStatement: (node) => {
+                    if (!ts.isIfStatement(node.parent) ||
+                        node.parent.elseStatement !== node) {
+                        checkIfStatement(node);
+                    }
+                },
+            },
+        };
+    },
+});

package/lib/rules/elseIfDuplicates.test.d.ts

@@ -0,0 +1 @@
+export {};

package/lib/rules/elseIfDuplicates.test.js

@@ -0,0 +1,176 @@
+import rule from "./elseIfDuplicates.js";
+import { ruleTester } from "./ruleTester.js";
+ruleTester.describe(rule, {
+    invalid: [
+        {
+            code: `
+if (isSomething(value)) {
+    doFirst();
+} else if (isSomething(value)) {
+    doSecond();
+}
+`,
+            snapshot: `
+if (isSomething(value)) {
+    doFirst();
+} else if (isSomething(value)) {
+           ~~~~~~~~~~~~~~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    doSecond();
+}
+`,
+        },
+        {
+            code: `
+if (isSomething /* ... */ (value)) {
+    doFirst();
+} else if (isSomething(value /* ... */)) {
+    doSecond();
+}
+`,
+            snapshot: `
+if (isSomething /* ... */ (value)) {
+    doFirst();
+} else if (isSomething(value /* ... */)) {
+           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    doSecond();
+}
+`,
+        },
+        {
+            code: `
+if (first) {
+    handleFirst();
+} else if (second) {
+    handleSecond();
+} else if (third && fourth) {
+    handleThird();
+} else if (third && fourth) {
+    handleFourth();
+}
+`,
+            snapshot: `
+if (first) {
+    handleFirst();
+} else if (second) {
+    handleSecond();
+} else if (third && fourth) {
+    handleThird();
+} else if (third && fourth) {
+           ~~~~~~~~~~~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    handleFourth();
+}
+`,
+        },
+        {
+            code: `
+if (count === 1) {
+    handleOne();
+} else if (count === 2) {
+    handleTwo();
+} else if (count === 3) {
+    handleThree();
+} else if (count === 2) {
+    handleFour();
+} else if (count === 5) {
+    handleFive();
+}
+`,
+            snapshot: `
+if (count === 1) {
+    handleOne();
+} else if (count === 2) {
+    handleTwo();
+} else if (count === 3) {
+    handleThree();
+} else if (count === 2) {
+           ~~~~~~~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    handleFour();
+} else if (count === 5) {
+    handleFive();
+}
+`,
+        },
+        {
+            code: `
+if (value === "first") {
+    process();
+} else if (value === "second") {
+    process();
+} else if (value === "first") {
+    process();
+}
+`,
+            snapshot: `
+if (value === "first") {
+    process();
+} else if (value === "second") {
+    process();
+} else if (value === "first") {
+           ~~~~~~~~~~~~~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    process();
+}
+`,
+        },
+        {
+            code: `
+if (isValid && isActive) {
+    execute();
+} else if (isPending) {
+    wait();
+} else if (isValid && isActive) {
+    execute();
+}
+`,
+            snapshot: `
+if (isValid && isActive) {
+    execute();
+} else if (isPending) {
+    wait();
+} else if (isValid && isActive) {
+           ~~~~~~~~~~~~~~~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    execute();
+}
+`,
+        },
+        {
+            code: `
+if (value) {
+    first();
+} else if (value) {
+    second();
+} else if (value) {
+    third();
+}
+`,
+            snapshot: `
+if (value) {
+    first();
+} else if (value) {
+           ~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    second();
+} else if (value) {
+           ~~~~~
+           This condition is identical to a previous condition in the if-else-if chain.
+    third();
+}
+`,
+        },
+    ],
+    valid: [
+        `if (isSomething(value)) { doFirst(); } else if (isSomethingElse(value)) { doSecond(); }`,
+        `if (first) { handleFirst(); } else if (second) { handleSecond(); } else if (third && fourth) { handleThird(); } else if (third && fifth) { handleFourth(); }`,
+        `if (count === 1) { handleOne(); } else if (count === 2) { handleTwo(); } else if (count === 3) { handleThree(); } else if (count === 4) { handleFour(); }`,
+        `if (value === "first") { process(); } else if (value === "second") { process(); } else if (value === "third") { process(); }`,
+        `if (isValid) { execute(); } else if (isPending) { wait(); } else if (isInvalid) { reject(); }`,
+        `if (value) { process(); }`,
+        `if (first) { doFirst(); } else { doSecond(); }`,
+        `if (first) { doFirst(); } else if (second) { doSecond(); } else { doDefault(); }`,
+    ],
+});

package/lib/rules/emptyDestructures.d.ts

@@ -0,0 +1,6 @@
+declare const _default: import("@flint.fyi/core").Rule<{
+    readonly description: "Reports using empty destructuring patterns that destructure no values.";
+    readonly id: "emptyDestructures";
+    readonly preset: "logical";
+}, import("../nodes.js").TSNodesByName, import("../language.js").TypeScriptServices, "emptyPattern", undefined>;
+export default _default;

package/lib/rules/emptyDestructures.js

@@ -0,0 +1,40 @@
+import { typescriptLanguage } from "../language.js";
+export default typescriptLanguage.createRule({
+    about: {
+        description: "Reports using empty destructuring patterns that destructure no values.",
+        id: "emptyDestructures",
+        preset: "logical",
+    },
+    messages: {
+        emptyPattern: {
+            primary: "Destructuring patterns that don't extract at least one value are unnecessary.",
+            secondary: [
+                "Empty destructuring patterns like `{}` or `[]` don't extract any values and serve no practical purpose.",
+                "These patterns are likely mistakes or leftover code from refactoring.",
+            ],
+            suggestions: [
+                "Remove the empty destructuring pattern if it's not needed.",
+                "Add bindings to extract values if you intended to destructure specific properties.",
+            ],
+        },
+    },
+    setup(context) {
+        function checkBindingPattern(node) {
+            if (node.elements.length === 0) {
+                context.report({
+                    message: "emptyPattern",
+                    range: {
+                        begin: node.getStart(context.sourceFile),
+                        end: node.getEnd(),
+                    },
+                });
+            }
+        }
+        return {
+            visitors: {
+                ArrayBindingPattern: checkBindingPattern,
+                ObjectBindingPattern: checkBindingPattern,
+            },
+        };
+    },
+});

package/lib/rules/emptyDestructures.test.d.ts

@@ -0,0 +1 @@
+export {};