@flint.fyi/plugin-flint 0.8.0 → 0.8.2

package/dist/index.d.mts

@@ -1,95 +1,55 @@
 //#region src/plugin.d.ts
-declare const flint: import("@flint.fyi/core").Plugin<import("@flint.fyi/core").RuleAbout<string>, string | undefined, [import("@flint.fyi/core").Rule<{
+export declare const flint: import("@flint.fyi/core").Plugin<import("@flint.fyi/core").RuleAbout<string>, string | undefined, [import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Requires passing `sourceFile` to `getStart()` for better performance.";
   readonly id: "getStartSourceFile";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "missingSourceFile", undefined>, import("@flint.fyi/core").Rule<{
+}, "missingSourceFile", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports cases for invalid code that isn't formatted across lines.";
   readonly id: "invalidCodeLines";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "singleLineTest", undefined>, import("@flint.fyi/core").Rule<{
+}, "singleLineTest", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports `context.report()` calls missing data for message placeholders.";
   readonly id: "missingPlaceholders";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "missingPlaceholders", undefined>, import("@flint.fyi/core").Rule<{
+}, "missingPlaceholders", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Disallows using the `in` operator to check properties on TypeScript nodes.";
   readonly id: "nodePropertyInChecks";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "nodePropertyInChecks", undefined>, import("@flint.fyi/core").Rule<{
+}, "nodePropertyInChecks", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports and auto-fixes message placeholders that are not formatted as `{{ placeholder }}`.";
   readonly id: "placeholderFormats";
   readonly presets: readonly ["stylistic", "stylisticStrict"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "placeholderFormats", undefined>, import("@flint.fyi/core").Rule<{
+}, "placeholderFormats", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports Flint plugin `rules` arrays that are not sorted alphabetically.";
   readonly id: "pluginRuleOrdering";
   readonly presets: readonly ["stylisticStrict"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "pluginRuleOrdering", undefined>, import("@flint.fyi/core").Rule<{
+}, "pluginRuleOrdering", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports plugin rules created directly with language instead of through RuleCreator.";
   readonly id: "ruleCreationMethods";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "ruleCreationMethods", undefined>, import("@flint.fyi/core").Rule<{
+}, "ruleCreationMethods", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports test cases that are identical to previous test cases.";
   readonly id: "testCaseDuplicates";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "duplicateTest", undefined>, import("@flint.fyi/core").Rule<{
+}, "duplicateTest", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports test cases that have the same name as a previous test case.";
   readonly id: "testCaseNameDuplicates";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "duplicateTestName", undefined>, import("@flint.fyi/core").Rule<{
+}, "duplicateTestName", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Test case code should be a static string literal.";
   readonly id: "testCaseNonStaticCode";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "nonStaticTestCaseCode", undefined>, import("@flint.fyi/core").Rule<{
+}, "nonStaticTestCaseCode", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports test cases that are marked `only: true`.";
   readonly id: "testCaseOnlyFlags";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "testCaseOnly", undefined>, import("@flint.fyi/core").Rule<{
+}, "testCaseOnly", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Test cases with only a code property can use string shorthand syntax instead of object literal syntax.";
   readonly id: "testShorthands";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
-}, "testShorthands", undefined>, import("@flint.fyi/core").Rule<{
+}, "testShorthands", undefined>, import("@flint.fyi/core").Rule<import("@flint.fyi/core").PluginRuleAbout<string> & {
   readonly description: "Reports message IDs defined in the messages object that are never used in recognized report calls.";
   readonly id: "unusedMessageIds";
   readonly presets: readonly ["logical"];
-} & {
-  readonly pluginId: string;
-  readonly url: string;
 }, "unusedMessageIds", undefined>]>;
-//#endregion
-export { flint };
+//#endregion

package/dist/index.mjs

@@ -87,10 +87,10 @@ function tsAstToLiteral(node) {
 		case SyntaxKind.NullKeyword: return null;
 		case SyntaxKind.TrueKeyword: return true;
 	}
-	if (ts.isArrayLiteralExpression(node)) return node.elements.filter((element) => element.kind !== SyntaxKind.SpreadElement).map((element) => tsAstToLiteral(element));
-	if (ts.isNumericLiteral(node)) return parseFloat(node.text);
-	if (ts.isObjectLiteralExpression(node)) return Object.fromEntries(node.properties.filter((property) => ts.isPropertyAssignment(property) && (property.name.kind === SyntaxKind.Identifier || property.name.kind === SyntaxKind.StringLiteral)).map((property) => [property.name.escapedText || property.name.text, tsAstToLiteral(property.initializer)]));
-	if (ts.isStringLiteral(node)) return node.text;
+	if (node.kind === SyntaxKind.ArrayLiteralExpression) return node.elements.filter((element) => element.kind !== SyntaxKind.SpreadElement).map((element) => tsAstToLiteral(element));
+	if (node.kind === SyntaxKind.NumericLiteral) return parseFloat(node.text);
+	if (node.kind === SyntaxKind.ObjectLiteralExpression) return Object.fromEntries(node.properties.filter((property) => property.kind === SyntaxKind.PropertyAssignment && (property.name.kind === SyntaxKind.Identifier || property.name.kind === SyntaxKind.StringLiteral)).map((property) => [property.name.text, tsAstToLiteral(property.initializer)]));
+	if (node.kind === SyntaxKind.StringLiteral) return node.text;
 }
 //#endregion
 //#region src/utils/parseTestCases.ts
@@ -133,7 +133,7 @@ function parseTestCaseInvalid(node) {
 	const files = findProperty(node.properties, "files", (node) => node.kind === SyntaxKind.ObjectLiteralExpression);
 	const name = findProperty(node.properties, "name", isStaticString);
 	const options = findProperty(node.properties, "options", (node) => node.kind === SyntaxKind.ObjectLiteralExpression);
-	const snapshot = findProperty(node.properties, "snapshot", isStaticString);
+	const snapshot = findProperty(node.properties, "snapshot", isTestCaseCode);
 	if (!snapshot) return;
 	return {
 		code: getTestCaseCode(code),
@@ -150,7 +150,7 @@ function parseTestCaseInvalid(node) {
 			snapshot
 		},
 		options: options && tsAstToLiteral(options),
-		snapshot: snapshot.text
+		snapshot: getTestCaseCode(snapshot)
 	};
 }
 function getTestCaseCode(node) {
@@ -363,7 +363,7 @@ var nodePropertyInChecks_default = ruleCreator.createRule(typescriptLanguage, {
 	messages: { nodePropertyInChecks: {
 		primary: "Avoid using the `in` operator to check properties on TypeScript nodes.",
 		secondary: ["The `in` operator checks inherited properties and may not work reliably with TypeScript AST nodes.", "TypeScript AST nodes have complex prototype chains that can lead to unexpected results with `in` checks."],
-		suggestions: ["Access the property directly or use a type guard function like `ts.isXXX()` instead."]
+		suggestions: ["Access the property directly or compare `node.kind` to the matching `SyntaxKind` instead."]
 	} },
 	setup(context) {
 		return { visitors: { BinaryExpression(node, { sourceFile, typeChecker }) {
@@ -755,6 +755,71 @@ function isVolarReportSourceCodeCall(node, typeChecker) {
 	if (node.expression.kind === SyntaxKind.PropertyAccessExpression && node.expression.expression.kind === SyntaxKind.Identifier && node.expression.name.text === "reportSourceCode") return typeChecker.getSymbolAtLocation(node.expression.expression)?.getDeclarations()?.some((declaration) => declaration.kind === SyntaxKind.NamespaceImport && isImportedBindingFromModule(declaration, volarLanguagePackageName)) ?? false;
 	return false;
 }
+var unusedMessageIds_default = ruleCreator.createRule(typescriptLanguage, {
+	about: {
+		description: "Reports message IDs defined in the messages object that are never used in recognized report calls.",
+		id: "unusedMessageIds",
+		presets: ["logical"]
+	},
+	messages: { unusedMessageIds: {
+		primary: "Message ID '{{ messageId }}' is defined but never used.",
+		secondary: ["This message ID is declared in the messages object but is not referenced in any `context.report()` or built-in Flint report helper call.", "Remove unused message IDs to keep the rule configuration clean and maintainable."],
+		suggestions: ["Remove the unused message ID from the messages object."]
+	} },
+	setup(context) {
+		const unusedMessageIds = /* @__PURE__ */ new Map();
+		function collectMessageIds(node, sourceFile) {
+			const args = node.arguments[1];
+			if (args?.kind !== SyntaxKind.ObjectLiteralExpression) return;
+			const messagesProperty = findProperty(args.properties, "messages", (node) => node.kind === SyntaxKind.ObjectLiteralExpression);
+			if (!messagesProperty) return;
+			for (const prop of messagesProperty.properties) {
+				if (prop.kind !== SyntaxKind.PropertyAssignment || prop.name.kind !== SyntaxKind.Identifier) continue;
+				const messageId = prop.name.text;
+				if (!unusedMessageIds.has(messageId)) unusedMessageIds.set(messageId, getTSNodeRange(prop.name, sourceFile));
+			}
+		}
+		function detectMessageIdUsage(node, reportArgumentIndex) {
+			if (!unusedMessageIds.size) return;
+			const args = node.arguments[reportArgumentIndex];
+			if (args?.kind !== SyntaxKind.ObjectLiteralExpression) {
+				unusedMessageIds.clear();
+				return;
+			}
+			const messageProperty = findProperty(args.properties, "message", (node) => node.kind === SyntaxKind.StringLiteral);
+			if (!messageProperty) {
+				unusedMessageIds.clear();
+				return;
+			}
+			unusedMessageIds.delete(messageProperty.text);
+		}
+		return { visitors: {
+			CallExpression(node, { sourceFile, typeChecker }) {
+				if (isRuleCreatorCreateRule(node, typeChecker)) {
+					collectMessageIds(node, sourceFile);
+					return;
+				}
+				if (isRuleContextReport(node, typeChecker)) {
+					detectMessageIdUsage(node, 0);
+					return;
+				}
+				if (isVolarReportSourceCodeCall(node, typeChecker)) {
+					detectMessageIdUsage(node, 1);
+					return;
+				}
+			},
+			"SourceFile:exit"() {
+				if (!unusedMessageIds.size) return;
+				for (const [messageId, range] of unusedMessageIds) context.report({
+					data: { messageId },
+					message: "unusedMessageIds",
+					range
+				});
+				unusedMessageIds.clear();
+			}
+		} };
+	}
+});
 //#endregion
 //#region src/plugin.ts
 const flint = createPlugin({
@@ -772,71 +837,7 @@ const flint = createPlugin({
 		testCaseNonStaticCode_default,
 		testCaseOnlyFlags_default,
 		testShorthands_default,
-		ruleCreator.createRule(typescriptLanguage, {
-			about: {
-				description: "Reports message IDs defined in the messages object that are never used in recognized report calls.",
-				id: "unusedMessageIds",
-				presets: ["logical"]
-			},
-			messages: { unusedMessageIds: {
-				primary: "Message ID '{{ messageId }}' is defined but never used.",
-				secondary: ["This message ID is declared in the messages object but is not referenced in any `context.report()` or built-in Flint report helper call.", "Remove unused message IDs to keep the rule configuration clean and maintainable."],
-				suggestions: ["Remove the unused message ID from the messages object."]
-			} },
-			setup(context) {
-				const unusedMessageIds = /* @__PURE__ */ new Map();
-				function collectMessageIds(node, sourceFile) {
-					const args = node.arguments[1];
-					if (args?.kind !== SyntaxKind.ObjectLiteralExpression) return;
-					const messagesProperty = findProperty(args.properties, "messages", (node) => node.kind === SyntaxKind.ObjectLiteralExpression);
-					if (!messagesProperty) return;
-					for (const prop of messagesProperty.properties) {
-						if (prop.kind !== SyntaxKind.PropertyAssignment || prop.name.kind !== SyntaxKind.Identifier) continue;
-						const messageId = prop.name.text;
-						if (!unusedMessageIds.has(messageId)) unusedMessageIds.set(messageId, getTSNodeRange(prop.name, sourceFile));
-					}
-				}
-				function detectMessageIdUsage(node, reportArgumentIndex) {
-					if (!unusedMessageIds.size) return;
-					const args = node.arguments[reportArgumentIndex];
-					if (args?.kind !== SyntaxKind.ObjectLiteralExpression) {
-						unusedMessageIds.clear();
-						return;
-					}
-					const messageProperty = findProperty(args.properties, "message", (node) => node.kind === SyntaxKind.StringLiteral);
-					if (!messageProperty) {
-						unusedMessageIds.clear();
-						return;
-					}
-					unusedMessageIds.delete(messageProperty.text);
-				}
-				return { visitors: {
-					CallExpression(node, { sourceFile, typeChecker }) {
-						if (isRuleCreatorCreateRule(node, typeChecker)) {
-							collectMessageIds(node, sourceFile);
-							return;
-						}
-						if (isRuleContextReport(node, typeChecker)) {
-							detectMessageIdUsage(node, 0);
-							return;
-						}
-						if (isVolarReportSourceCodeCall(node, typeChecker)) {
-							detectMessageIdUsage(node, 1);
-							return;
-						}
-					},
-					"SourceFile:exit"() {
-						if (!unusedMessageIds.size) return;
-						for (const [messageId, range] of unusedMessageIds) context.report({
-							data: { messageId },
-							message: "unusedMessageIds",
-							range
-						});
-						unusedMessageIds.clear();
-					}
-				} };
-			}
-		})
+		unusedMessageIds_default
 	]
 });
 //#endregion

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@flint.fyi/plugin-flint",
-  "version": "0.8.0",
+  "version": "0.8.2",
   "description": "[Experimental] A Flint plugin for linting Flint plugins.",
   "homepage": "https://flint.fyi/rules/flint",
   "repository": {
@@ -22,16 +22,17 @@
     "dist/"
   ],
   "dependencies": {
-    "typescript": "^6.0.0",
-    "@flint.fyi/typescript-language": "^0.20.0",
+    "@flint.fyi/core": "^0.27.0",
+    "@flint.fyi/typescript-language": "^0.21.0",
     "@flint.fyi/utils": "^0.16.0",
-    "@flint.fyi/core": "^0.25.0"
+    "typescript": "^6.0.3"
   },
   "devDependencies": {
-    "tsdown": "0.22.3",
-    "vitest": "4.1.0",
-    "@flint.fyi/rule-tester": "^0.18.0",
-    "@flint.fyi/build": "^0.1.0"
+    "@flint.fyi/build": "^0.1.0",
+    "@flint.fyi/rule-tester": "^0.20.0",
+    "@flint.fyi/volar-language": "^0.4.0",
+    "tsdown": "0.23.0",
+    "vitest": "5.0.1"
   },
   "engines": {
     "node": ">=26.1.0"