@flink-app/flink 2.0.0-alpha.95 → 2.0.0-alpha.96

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @flink-app/flink
 
+## 2.0.0-alpha.96
+
+### Patch Changes
+
+-   Fix double-JSON-encoding of tool results on conversation reload.
+
+    `ConversationAgent.convertToAgentMessages` was re-stringifying tool result payloads that `ToolExecutor.formatResultForAI` had already serialized to a JSON string. Each reload escaped the value one more level, corrupting tool history on every continuation turn (visible through any LLM adapter, including Anthropic). Strings are now passed through untouched; non-string values are still stringified for backward compatibility with older storage rows.
+
 ## 2.0.0-alpha.95
 
 ## 2.0.0-alpha.94

package/dist/src/ai/ConversationAgent.js

@@ -297,7 +297,9 @@ var ConversationAgent = /** @class */ (function (_super) {
                     role: "tool",
                     toolCallId: toolResult.id,
                     toolName: "", // Not stored, but required by type
-                    result: JSON.stringify(toolResult.result),
+                    // Tool results are persisted as already-stringified payloads (see formatResultForAI).
+                    // JSON.stringify-ing again would double-encode strings into escaped JSON literals.
+                    result: typeof toolResult.result === "string" ? toolResult.result : JSON.stringify(toolResult.result),
                 }); });
             }
             else if (msg.role === "user") {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@flink-app/flink",
-  "version": "2.0.0-alpha.95",
+  "version": "2.0.0-alpha.96",
   "description": "Typescript only framework for creating REST-like APIs on top of Express and mongodb",
   "types": "dist/src/index.d.ts",
   "main": "dist/src/index.js",

package/spec/ai/ConversationAgent.spec.ts

@@ -324,6 +324,35 @@ describe("ConversationAgent", () => {
             });
         });
 
+        it("should not double-encode string tool results on reload", async () => {
+            // Real production flow: ToolExecutor.formatResultForAI returns a JSON string,
+            // which is what AgentRunner stores on tool_result content blocks. On the
+            // round-trip back from storage, that string must NOT be JSON.stringified
+            // again — otherwise the model sees escaped JSON literals on every reload.
+            const alreadyStringified = JSON.stringify({ temp: "22C", condition: "sunny" });
+
+            const conversationData: ConversationData = {
+                messages: [
+                    {
+                        role: "user",
+                        toolResults: [{ id: "call_1", result: alreadyStringified }],
+                    },
+                ],
+            };
+
+            agent.loadConversationSpy.and.returnValue(Promise.resolve(conversationData));
+
+            const input: any = { conversationId: "conv-123" };
+            await agent.testBeforeRun(input, {});
+
+            expect(input.history[0]).toEqual({
+                role: "tool",
+                toolCallId: "call_1",
+                toolName: "",
+                result: alreadyStringified, // not JSON.stringify(alreadyStringified)
+            });
+        });
+
         it("should preserve assistant messages with toolCalls", async () => {
             const conversationData: ConversationData = {
                 messages: [

package/src/ai/ConversationAgent.ts

@@ -308,7 +308,9 @@ export abstract class ConversationAgent<Context extends FlinkContext = FlinkCont
                         role: "tool",
                         toolCallId: toolResult.id,
                         toolName: "", // Not stored, but required by type
-                        result: JSON.stringify(toolResult.result),
+                        // Tool results are persisted as already-stringified payloads (see formatResultForAI).
+                        // JSON.stringify-ing again would double-encode strings into escaped JSON literals.
+                        result: typeof toolResult.result === "string" ? toolResult.result : JSON.stringify(toolResult.result),
                     })
                 );
             } else if (msg.role === "user") {