@flighthq/render 0.3.0-next.906.07cea63 → 0.3.0

package/src/sceneRender.test.ts

@@ -25,7 +25,15 @@ import {
   setNodeLocalMatrix4,
 } from '@flighthq/node/contract';
 import { createMesh, createNode3D, Node3DKind, getNode3DWorldAlpha } from '@flighthq/scene3d/contract';
-import type { Camera3D, Material, MeshGeometry, Scene3DLightBlock, Scene3DLightsLike } from '@flighthq/types/contract';
+import type {
+  Mesh,
+  Skin,
+  Camera3D,
+  Material,
+  MeshGeometry,
+  Scene3DLightBlock,
+  Scene3DLightsLike,
+} from '@flighthq/types/contract';
 import {
   SCENE_LIGHT_BLOCK_FLOATS,
   SCENE_LIGHT_HEMISPHERE_OFFSET,
@@ -35,7 +43,7 @@ import {
 import { describe, expect, it } from 'vitest';
 
 import { createRenderState } from './renderState';
-import { packScene3DLightBlock, prepareScene3DRender } from './sceneRender';
+import { packScene3DLightBlock, prepareScene3DRender, setSkinnedMeshBoundsGuard } from './sceneRender';
 
 function boundedBox(): MeshGeometry {
   const geometry = createBoxMeshGeometry(2, 2, 2);
@@ -244,6 +252,31 @@ describe('prepareScene3DRender', () => {
     expect(list.viewProjection.m[15]).not.toBe(1);
   });
 
+  it('uses a draw-time viewport aspect without mutating the camera projection', () => {
+    const state = createRenderState();
+    const scene = createNode3D(Node3DKind);
+    const camera = frontCamera();
+
+    const tallXScale = prepareScene3DRender(state, scene, camera, emptyLights(), 0.5).viewProjection.m[0];
+    const wideXScale = prepareScene3DRender(state, scene, camera, emptyLights(), 2).viewProjection.m[0];
+
+    expect(tallXScale).toBeCloseTo(wideXScale * 4);
+    expect(camera.projection.kind).toBe('perspective');
+    if (camera.projection.kind === 'perspective') expect(camera.projection.aspect).toBe(1);
+  });
+
+  it('consumes camera jitter in the prepared view-projection', () => {
+    const state = createRenderState();
+    const scene = createNode3D(Node3DKind);
+    const camera = frontCamera();
+    const baseXOffset = prepareScene3DRender(state, scene, camera, emptyLights()).viewProjection.m[8];
+
+    camera.jitter.x = 0.125;
+    const jitteredXOffset = prepareScene3DRender(state, scene, camera, emptyLights()).viewProjection.m[8];
+
+    expect(jitteredXOffset).toBeCloseTo(baseXOffset - 0.125);
+  });
+
   it('culls a mesh placed far behind the camera', () => {
     const state = createRenderState();
     const scene = createNode3D(Node3DKind);
@@ -402,3 +435,43 @@ describe('prepareScene3DRender', () => {
     expect(getNodeWorldMatrix4(mesh).m[12]).toBeCloseTo(3);
   });
 });
+
+describe('setSkinnedMeshBoundsGuard', () => {
+  afterEach(() => setSkinnedMeshBoundsGuard(null));
+
+  // The seam keeps the message and the @flighthq/log dependency in the separately-importable guard
+  // module; the cull path only calls whatever is installed.
+  it('reports the skinned mesh that reached culling without posed bounds', () => {
+    const seen: Mesh[] = [];
+    setSkinnedMeshBoundsGuard((mesh) => seen.push(mesh as Mesh));
+    const state = createRenderState();
+    const scene = createNode3D(Node3DKind);
+    const mesh = createMesh(boundedBox(), [null]);
+    mesh.skin = {} as Skin;
+    addNodeChild(scene, mesh);
+
+    prepareScene3DRender(state, scene, frontCamera(), {
+      ambient: createAmbientLight(),
+      directional: createDirectionalLight(),
+    });
+
+    expect(seen).toEqual([mesh]);
+  });
+
+  it('stops reporting once cleared with null', () => {
+    let calls = 0;
+    setSkinnedMeshBoundsGuard(() => (calls += 1));
+    const state = createRenderState();
+    const scene = createNode3D(Node3DKind);
+    const mesh = createMesh(boundedBox(), [null]);
+    mesh.skin = {} as Skin;
+    addNodeChild(scene, mesh);
+    const lights = { ambient: createAmbientLight(), directional: createDirectionalLight() };
+
+    prepareScene3DRender(state, scene, frontCamera(), lights);
+    setSkinnedMeshBoundsGuard(null);
+    prepareScene3DRender(state, scene, frontCamera(), lights);
+
+    expect(calls).toBe(1);
+  });
+});

package/dist/renderColorScaleBias.d.ts

@@ -1,3 +0,0 @@
-import type { RenderProxy, RenderState } from '@flighthq/types/contract';
-export declare function updateRenderProxyColorScaleBias(state: RenderState, data: RenderProxy, _parentData?: RenderProxy): void;
-//# sourceMappingURL=renderColorScaleBias.d.ts.map

package/dist/renderColorScaleBias.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"renderColorScaleBias.d.ts","sourceRoot":"","sources":["../src/renderColorScaleBias.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAA4C,WAAW,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AAcnH,wBAAgB,+BAA+B,CAC7C,KAAK,EAAE,WAAW,EAClB,IAAI,EAAE,WAAW,EACjB,WAAW,CAAC,EAAE,WAAW,GACxB,IAAI,CAON"}

package/dist/renderColorScaleBias.js

@@ -1,21 +0,0 @@
-import { getNodeRuntime } from '@flighthq/node/contract';
-import { getRenderStateRuntime } from './renderState';
-// Hands the node's resolved color adjustment to the render node. A node's color-adjustment stack
-// (NodeRuntime.colorAdjustments) is fused once into the affine `resolvedColorScaleBias` cache by the
-// set-accessors on change — never per frame — so this hot-path visitor is a single field read, identical
-// in cost to reading the old `.colorScaleBias`. Non-inheriting: a node uses its own resolved value (or
-// none → null). The value is the Adjustment-tier fold input; it is not a material and does not key the
-// batch.
-//
-// Matrix-tier channel mixing travels through `resolvedColorMatrix`. A non-matrix operation that cannot
-// be represented by either path leaves `colorAdjustmentsUnsupported` set, invoking the shakeable guard
-// so unsupported adjustment data is reported rather than silently discarded.
-export function updateRenderProxyColorScaleBias(state, data, _parentData) {
-    const runtime = getNodeRuntime(data.source);
-    data.colorScaleBias = runtime.resolvedColorScaleBias ?? null;
-    data.colorMatrix = runtime.resolvedColorMatrix ?? null;
-    if (runtime.colorAdjustmentsUnsupported) {
-        getRenderStateRuntime(state).colorAdjustmentUnsupportedGuard?.(state, data.source);
-    }
-}
-//# sourceMappingURL=renderColorScaleBias.js.map

package/dist/renderColorScaleBias.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"renderColorScaleBias.js","sourceRoot":"","sources":["../src/renderColorScaleBias.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,cAAc,EAAE,MAAM,yBAAyB,CAAC;AAGzD,OAAO,EAAE,qBAAqB,EAAE,MAAM,eAAe,CAAC;AAEtD,iGAAiG;AACjG,qGAAqG;AACrG,yGAAyG;AACzG,uGAAuG;AACvG,uGAAuG;AACvG,SAAS;AACT,EAAE;AACF,uGAAuG;AACvG,uGAAuG;AACvG,6EAA6E;AAC7E,MAAM,UAAU,+BAA+B,CAC7C,KAAkB,EAClB,IAAiB,EACjB,WAAyB;IAEzB,MAAM,OAAO,GAAG,cAAc,CAAC,IAAI,CAAC,MAAc,CAA8C,CAAC;IACjG,IAAI,CAAC,cAAc,GAAG,OAAO,CAAC,sBAAsB,IAAI,IAAI,CAAC;IAC7D,IAAI,CAAC,WAAW,GAAG,OAAO,CAAC,mBAAmB,IAAI,IAAI,CAAC;IACvD,IAAI,OAAO,CAAC,2BAA2B,EAAE,CAAC;QACxC,qBAAqB,CAAC,KAAK,CAAC,CAAC,+BAA+B,EAAE,CAAC,KAAK,EAAE,IAAI,CAAC,MAAoB,CAAC,CAAC;IACnG,CAAC;AACH,CAAC"}

package/src/renderColorScaleBias.test.ts

@@ -1,53 +0,0 @@
-import { createColorMatrixAdjustment, createTintAdjustment } from '@flighthq/adjustments/contract';
-import { setNodeColorAdjustments } from '@flighthq/node/contract';
-import { createDisplayObject, getNode2DRuntime } from '@flighthq/scene2d/contract';
-import type { Renderable } from '@flighthq/types/contract';
-
-import { updateRenderProxyColorScaleBias } from './renderColorScaleBias';
-import { createRenderProxy } from './renderProxy';
-import { createRenderState } from './renderState';
-
-describe('updateRenderProxyColorScaleBias', () => {
-  it('resolves a node color-adjustment stack onto the render node as an affine ColorScaleBias', () => {
-    const state = createRenderState();
-    const node = createDisplayObject();
-    setNodeColorAdjustments(node, [createTintAdjustment(0x7f0000ff)]);
-    const data = createRenderProxy(state, node as unknown as Renderable);
-    updateRenderProxyColorScaleBias(state, data);
-    expect(data.colorScaleBias).not.toBeNull();
-    expect(data.colorScaleBias!.redScale).toBeCloseTo(0x7f / 255);
-    expect(data.colorScaleBias!.greenScale).toBe(0);
-  });
-
-  it('resolves channel mixing onto the render node as a complete matrix', () => {
-    const state = createRenderState();
-    const node = createDisplayObject();
-    const matrix = [1, 0.5, 0, 0, 0.1, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0];
-    setNodeColorAdjustments(node, [createColorMatrixAdjustment(matrix)]);
-    const data = createRenderProxy(state, node as unknown as Renderable);
-    updateRenderProxyColorScaleBias(state, data);
-    expect(data.colorMatrix).toEqual(matrix);
-  });
-
-  it('resolves to null when the node carries no adjustments', () => {
-    const state = createRenderState();
-    const node = createDisplayObject();
-    const data = createRenderProxy(state, node as unknown as Renderable);
-    updateRenderProxyColorScaleBias(state, data);
-    expect(data.colorScaleBias).toBeNull();
-  });
-
-  it('reads the cache the accessor fused once (the walk never re-fuses)', () => {
-    const state = createRenderState();
-    const node = createDisplayObject();
-    setNodeColorAdjustments(node, [createTintAdjustment(0x3fffffff)]);
-    // The set-accessor fused the stack once; the runtime already holds the cached resolved value.
-    const cached = getNode2DRuntime(node).resolvedColorScaleBias;
-    expect(cached).not.toBeNull();
-    const data = createRenderProxy(state, node as unknown as Renderable);
-    updateRenderProxyColorScaleBias(state, data);
-    expect(data.colorScaleBias).toBe(cached);
-    updateRenderProxyColorScaleBias(state, data);
-    expect(data.colorScaleBias).toBe(cached);
-  });
-});