@fleetbase/fleetops-engine 0.6.65 → 0.6.67

package/server/tests/Feature/Http/Api/DeviceEventUuidIndexMigrationTest.php

@@ -0,0 +1,106 @@
+<?php
+
+use Illuminate\Database\SQLiteConnection;
+use Illuminate\Support\Facades\Schema;
+
+function fleetopsDeviceEventIndexMigrationDatabase(bool $createTable = true): SQLiteConnection
+{
+    $connection = new SQLiteConnection(new PDO('sqlite::memory:'), ':memory:', '', ['driver' => 'sqlite']);
+    Schema::swap($connection->getSchemaBuilder());
+
+    if ($createTable) {
+        Schema::create('device_events', function ($table) {
+            $table->increments('id');
+            $table->uuid('uuid')->nullable();
+            $table->string('_key')->nullable()->index();
+            $table->uuid('company_uuid')->nullable();
+            $table->text('payload')->nullable();
+        });
+    }
+
+    return $connection;
+}
+
+function fleetopsDeviceEventIndexMigration()
+{
+    return require dirname(__DIR__, 4) . '/migrations/2026_09_17_000001_add_device_event_uuid_lookup_index.php';
+}
+
+function fleetopsDeviceEventIndexNames(SQLiteConnection $connection): array
+{
+    return array_column($connection->select('PRAGMA index_list("device_events")'), 'name');
+}
+
+test('device event UUID migration indexes legacy lookups without changing data', function () {
+    $connection = fleetopsDeviceEventIndexMigrationDatabase();
+    $connection->table('device_events')->insert([
+        ['uuid' => 'event-1', 'payload' => 'first'],
+        ['uuid' => 'event-1', 'payload' => 'legacy duplicate'],
+        ['uuid' => null, 'payload' => 'legacy null'],
+    ]);
+    $before    = $connection->table('device_events')->orderBy('id')->get()->all();
+    $migration = fleetopsDeviceEventIndexMigration();
+
+    $migration->up();
+    $migration->up();
+
+    expect(fleetopsDeviceEventIndexNames($connection))->toContain('device_events_uuid_lookup_index', 'device_events__key_index')
+        ->and($connection->table('device_events')->orderBy('id')->get()->all())->toEqual($before);
+    $plan = $connection->select('EXPLAIN QUERY PLAN SELECT * FROM device_events WHERE uuid = ? LIMIT 1', ['event-1']);
+    expect($plan[0]->detail)->toContain('USING INDEX device_events_uuid_lookup_index');
+
+    // Rollback is performed by a newly loaded migration, as in artisan migrate:rollback.
+    fleetopsDeviceEventIndexMigration()->down();
+    expect(fleetopsDeviceEventIndexNames($connection))->not->toContain('device_events_uuid_lookup_index')
+        ->toContain('device_events__key_index')
+        ->and($connection->table('device_events')->orderBy('id')->get()->all())->toEqual($before);
+});
+
+test('device event UUID migration preserves equivalent existing indexes', function (array $columns, bool $unique) {
+    $connection = fleetopsDeviceEventIndexMigrationDatabase();
+    Schema::table('device_events', function ($table) use ($columns, $unique) {
+        $unique ? $table->unique($columns, 'existing_event_identity') : $table->index($columns, 'existing_event_identity');
+    });
+    $before = fleetopsDeviceEventIndexNames($connection);
+
+    fleetopsDeviceEventIndexMigration()->up();
+    fleetopsDeviceEventIndexMigration()->down();
+
+    expect(fleetopsDeviceEventIndexNames($connection))->toBe($before);
+})->with([
+    'unique UUID'            => [['uuid'], true],
+    'UUID leading composite' => [['uuid', 'company_uuid'], false],
+]);
+
+test('device event UUID migration recognizes a UUID primary key', function () {
+    $connection = fleetopsDeviceEventIndexMigrationDatabase(false);
+    Schema::create('device_events', function ($table) {
+        $table->uuid('uuid')->primary();
+    });
+    $before = fleetopsDeviceEventIndexNames($connection);
+
+    fleetopsDeviceEventIndexMigration()->up();
+    fleetopsDeviceEventIndexMigration()->down();
+
+    expect(fleetopsDeviceEventIndexNames($connection))->toBe($before);
+});
+
+test('device event UUID migration adds an index when UUID is not the leading column', function () {
+    $connection = fleetopsDeviceEventIndexMigrationDatabase();
+    Schema::table('device_events', fn ($table) => $table->index(['company_uuid', 'uuid'], 'existing_company_event'));
+
+    fleetopsDeviceEventIndexMigration()->up();
+    expect(fleetopsDeviceEventIndexNames($connection))->toContain('device_events_uuid_lookup_index', 'existing_company_event');
+
+    fleetopsDeviceEventIndexMigration()->down();
+    expect(fleetopsDeviceEventIndexNames($connection))->not->toContain('device_events_uuid_lookup_index')
+        ->toContain('existing_company_event');
+});
+
+test('device event UUID migration tolerates an absent legacy table', function () {
+    fleetopsDeviceEventIndexMigrationDatabase(false);
+    fleetopsDeviceEventIndexMigration()->up();
+    fleetopsDeviceEventIndexMigration()->down();
+
+    expect(Schema::hasTable('device_events'))->toBeFalse();
+});

package/server/tests/Feature/Http/Api/GeofenceControllerContractsTest.php

@@ -184,10 +184,10 @@ class FleetOpsGeofenceControllerFake extends GeofenceController
     public ?FleetOpsGeofenceQueryFake $nextEventQuery = null;
     public array $serializedEvents                    = [];
 
-    public ?Fleetbase\FleetOps\Models\Driver $historyDriver = null;
+    public ?Driver $historyDriver                           = null;
     public array $historyDriverLookups                      = [];
 
-    protected function findDriverForHistory(string $driverId): ?Fleetbase\FleetOps\Models\Driver
+    protected function findDriverForHistory(string $driverId): ?Driver
     {
         $this->historyDriverLookups[] = $driverId;
 
@@ -364,7 +364,7 @@ test('api geofence driver history applies driver filter and caps pagination', fu
 
     // The endpoint is addressed by public_id and resolves the driver itself; the query
     // still filters on the driver's uuid.
-    $historyDriver = new Fleetbase\FleetOps\Models\Driver();
+    $historyDriver = new Driver();
     $historyDriver->setRawAttributes(['uuid' => 'driver-9', 'public_id' => 'driver_public9'], true);
     $controller->historyDriver = $historyDriver;
 
@@ -384,7 +384,7 @@ test('api geofence driver history applies driver filter and caps pagination', fu
 test('driver history answers 404 when the driver does not resolve', function () {
     // The endpoint's own not-found branch: findDriverForHistory returns null and the
     // request must not proceed to a query keyed on nothing.
-    $controller = new FleetOpsGeofenceControllerFake();
+    $controller                = new FleetOpsGeofenceControllerFake();
     $controller->historyDriver = null;
 
     $response = $controller->driverHistory(Request::create('/geofences/driver/driver_missing/history', 'GET'), 'driver_missing');

package/server/tests/Feature/Http/Api/TrailerControllerLifecycleTest.php

@@ -238,7 +238,7 @@ function fleetOpsTrailerControllerDatabase(): SQLiteConnection
     });
     $schema->create('custom_fields', function ($table) {
         $table->increments('id');
-        foreach (['uuid', 'company_uuid', 'label', 'name', 'type'] as $column) {
+        foreach (['uuid', 'public_id', 'company_uuid', 'label', 'name', 'type'] as $column) {
             $table->string($column)->nullable();
         }
         $table->timestamps();

package/server/tests/Feature/Http/Internal/DriverControllerCreateRecordTest.php

@@ -109,7 +109,7 @@ function fleetopsInternalDriverCreateBoot(): SQLiteConnection
         'companies'       => ['uuid', 'public_id', 'name', 'owner_uuid', 'timezone', 'options'],
         'company_users'   => ['uuid', 'company_uuid', 'user_uuid', 'status'],
         'vehicles'        => ['uuid', 'public_id', 'company_uuid', 'driver_uuid'],
-        'custom_fields'   => ['uuid', 'company_uuid', 'subject_uuid', 'subject_type', 'name', 'label'],
+        'custom_fields'   => ['uuid', 'public_id', 'company_uuid', 'subject_uuid', 'subject_type', 'name', 'label'],
         'roles'           => ['name', 'guard_name', 'company_uuid'],
         'model_has_roles' => ['role_id', 'model_type', 'model_uuid'],
     ];

package/server/tests/Feature/Http/Internal/DriverControllerExistingUserAdoptionTest.php

@@ -220,7 +220,7 @@ function fleetopsDriverAdoptionBoot(array $validatorErrors): SQLiteConnection
         'companies'             => ['uuid', 'public_id', 'name', 'owner_uuid', 'timezone', 'options', 'status', '_key'],
         'company_users'         => ['uuid', 'public_id', 'company_uuid', 'user_uuid', 'status', '_key'],
         'vehicles'              => ['uuid', 'public_id', 'company_uuid', 'driver_uuid'],
-        'custom_fields'         => ['uuid', 'company_uuid', 'subject_uuid', 'subject_type', 'name', 'label'],
+        'custom_fields'         => ['uuid', 'public_id', 'company_uuid', 'subject_uuid', 'subject_type', 'name', 'label'],
         'custom_field_values'   => ['uuid', 'public_id', 'company_uuid', 'custom_field_uuid', 'subject_uuid', 'subject_type', 'value', 'value_type', '_key'],
         'settings'              => ['key', 'value'],
         'permissions'           => ['name', 'guard_name', 'service', 'description'],

package/server/tests/Feature/Http/Internal/HubControllerTest.php

@@ -163,6 +163,9 @@ test('internal hub maintenance builds kpis sections docs and service actions', f
         5, // overdue work orders
         6, // open maintenance
         7, // high priority maintenance
+        1, // published inspection forms
+        2, // failed inspections awaiting review
+        3, // unresolved failed inspections
         8, // low stock parts
         9, // equipment
     ], 'company-maintenance');
@@ -175,32 +178,55 @@ test('internal hub maintenance builds kpis sections docs and service actions', f
             'value' => 2,
             'tone'  => 'rose',
         ])
+        // Failed inspections take the third tile: a failed DVIR is a truck that
+        // should not be on the road, which outranks the parts shelf.
         ->and($payload['kpis'][2])->toMatchArray([
+            'key'   => 'failed_inspections',
+            'value' => 2,
+            'tone'  => 'rose',
+            'route' => 'maintenance.inspection-submissions',
+        ])
+        ->and($payload['kpis'][3])->toMatchArray([
             'key'   => 'open_work_orders',
             'value' => 4,
             'tone'  => 'amber',
         ])
         ->and(array_column($payload['actions'], 'key'))->toBe([
+            'failed_inspections',
             'overdue_schedules',
             'overdue_work_orders',
             'high_priority_maintenance',
             'upcoming_service',
-            'low_stock_parts',
+        ])
+        ->and($payload['actions'][0])->toMatchArray([
+            'description' => '2 failed inspections need issue or work order follow-up.',
+            'tone'        => 'warning',
+            'route'       => 'maintenance.inspection-submissions',
         ])
         ->and(array_column($payload['sections'], 'key'))->toBe([
+            'inspections',
             'planning',
             'records',
         ])
         ->and($payload['sections'][0]['links'][0])->toMatchArray([
+            'label' => 'Inspection Forms',
+            'count' => 1,
+        ])
+        ->and($payload['sections'][0]['links'][1])->toMatchArray([
+            'label' => 'Inspections',
+            'count' => 3,
+        ])
+        ->and($payload['sections'][1]['links'][0])->toMatchArray([
             'label' => 'Schedules',
             'count' => 5,
         ])
         ->and(array_column($payload['docs'], 'label'))->toBe([
             'Schedules',
+            'Inspections',
             'Work Orders',
             'Equipment',
             'Parts',
         ])
-        ->and($controller->countCalls)->toHaveCount(8)
+        ->and($controller->countCalls)->toHaveCount(11)
         ->and(array_unique($controller->countCalls))->toBe(['company-maintenance']);
 });

package/server/tests/Feature/Http/Internal/OrderControllerCreateRecordTest.php

@@ -201,7 +201,7 @@ function fleetopsInternalOrderCreateBoot(array $validatorErrors = []): SQLiteCon
         'tracking_statuses'   => ['uuid', 'public_id', 'company_uuid', 'tracking_number_uuid', 'code', 'status', 'details', 'location', 'city', 'province', 'country', '_key'],
         'contacts'            => ['uuid', 'public_id', 'company_uuid', 'name'],
         'vendors'             => ['uuid', 'public_id', 'company_uuid', 'name'],
-        'custom_fields'       => ['uuid', 'company_uuid', 'subject_uuid', 'subject_type', 'name', 'label'],
+        'custom_fields'       => ['uuid', 'public_id', 'company_uuid', 'subject_uuid', 'subject_type', 'name', 'label'],
         'custom_field_values' => ['uuid', 'company_uuid', 'custom_field_uuid', 'subject_uuid', 'subject_type', 'value'],
         'companies'           => ['uuid', 'public_id', 'name', 'options'],
     ];